Re: [lguest build regression fix] Re: 2.6.24-rc8-git1: Reported regressions from 2.6.23
On Sunday 20 January 2008 10:49:45 Adrian Bunk wrote: > On Sun, Jan 20, 2008 at 10:24:47AM +1100, Rusty Russell wrote: > > On Sunday 20 January 2008 05:06:04 Ingo Molnar wrote: > > > # CONFIG_PARAVIRT_GUEST is not set > > > CONFIG_LGUEST_GUEST=y > > > > This looks like a "randconfig" bug, to be honest. > > According to GNU grep we have two CONFIG_LGUEST_GUEST variables (sic), > one in arch/x86/lguest/Kconfig and one in drivers/lguest/Kconfig. > > Rusty, don't blame randconfig for finding bugs in this mess you > created... My apologies, it is my mess. The one in drivers/lguest/Kconfig is the old (bogus) one: looks like I lost the removal part in a patch merge back in September. I've tested this patch. It correctly handles Ingo's config (removes lguest guest support). Both lguest and lguest guest support can be turned on independently, and it still compiles. How embarrassing, Rusty. --- Remove bogus duplicate CONFIG_LGUEST_GUEST entry. It was moved to arch/x86/lguest/Kconfig, but I lost the deletion part in a patch suffle. My confused one-liner "fix" to turn it on is also reverted: 84f7466ee20cc094aa38617abfa2f3834871f054 Signed-off-by: Rusty Russell <[EMAIL PROTECTED]> diff -r 3db2cadc1a30 drivers/lguest/Kconfig --- a/drivers/lguest/KconfigSun Jan 20 11:25:15 2008 +1100 +++ b/drivers/lguest/KconfigSun Jan 20 11:47:57 2008 +1100 @@ -2,7 +2,6 @@ config LGUEST tristate "Linux hypervisor example code" depends on X86_32 && EXPERIMENTAL && !X86_PAE && FUTEX && !(X86_VISWS || X86_VOYAGER) select HVC_DRIVER - select LGUEST_GUEST ---help--- This is a very simple module which allows you to run multiple instances of the same Linux kernel, using the @@ -11,9 +10,3 @@ config LGUEST not "rustyvisor". See Documentation/lguest/lguest.txt. If unsure, say N. If curious, say M. If masochistic, say Y. - -config LGUEST_GUEST - bool - help - The guest needs code built-in, even if the host has lguest - support as a module. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [lguest build regression fix] Re: 2.6.24-rc8-git1: Reported regressions from 2.6.23
On Sun, Jan 20, 2008 at 10:24:47AM +1100, Rusty Russell wrote: > On Sunday 20 January 2008 05:06:04 Ingo Molnar wrote: > > x86 randconfig testing found the following build failure: > > > > arch/x86/lguest/boot.c: In function 'lazy_hcall': > > arch/x86/lguest/boot.c:151: error: implicit declaration of function > > 'paravirt_get_lazy_mode' arch/x86/lguest/boot.c:151: error: > > 'PARAVIRT_LAZY_NONE' undeclared (first use in this function) > > > > which i bisected down to this very fresh commit: > > > > commit 84f7466ee20cc094aa38617abfa2f3834871f054 > > Author: Rusty Russell <[EMAIL PROTECTED]> > > Date: Sat Jan 19 07:02:29 2008 +1100 > > > > Selecting LGUEST should turn on Guest support, as in 2.6.23. > > > > which allows the following .config variation: > > > > # CONFIG_PARAVIRT_GUEST is not set > > CONFIG_LGUEST_GUEST=y > > This looks like a "randconfig" bug, to be honest. > > CONFIG_LGUEST_GUEST and CONFIG_LGUEST are within "if PARAVIRT_GUEST" (include > is in arch/x86/Kconfig). According to GNU grep we have two CONFIG_LGUEST_GUEST variables (sic), one in arch/x86/lguest/Kconfig and one in drivers/lguest/Kconfig. And CONFIG_LGUEST (which selects CONFIG_LGUEST_GUEST) is in drivers/lguest/Kconfig which gets included from drivers/kvm/Kconfig (sic) which in turn gets included from drivers/Kconfig which in turn is not within the "if PARAVIRT_GUEST". Rusty, don't blame randconfig for finding bugs in this mess you created... > Rusty. cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [lguest build regression fix] Re: 2.6.24-rc8-git1: Reported regressions from 2.6.23
On Sunday 20 January 2008 05:06:04 Ingo Molnar wrote: > x86 randconfig testing found the following build failure: > > arch/x86/lguest/boot.c: In function 'lazy_hcall': > arch/x86/lguest/boot.c:151: error: implicit declaration of function > 'paravirt_get_lazy_mode' arch/x86/lguest/boot.c:151: error: > 'PARAVIRT_LAZY_NONE' undeclared (first use in this function) > > which i bisected down to this very fresh commit: > > commit 84f7466ee20cc094aa38617abfa2f3834871f054 > Author: Rusty Russell <[EMAIL PROTECTED]> > Date: Sat Jan 19 07:02:29 2008 +1100 > > Selecting LGUEST should turn on Guest support, as in 2.6.23. > > which allows the following .config variation: > > # CONFIG_PARAVIRT_GUEST is not set > CONFIG_LGUEST_GUEST=y This looks like a "randconfig" bug, to be honest. CONFIG_LGUEST_GUEST and CONFIG_LGUEST are within "if PARAVIRT_GUEST" (include is in arch/x86/Kconfig). Rusty. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[lguest build regression fix] Re: 2.6.24-rc8-git1: Reported regressions from 2.6.23
x86 randconfig testing found the following build failure: arch/x86/lguest/boot.c: In function 'lazy_hcall': arch/x86/lguest/boot.c:151: error: implicit declaration of function 'paravirt_get_lazy_mode' arch/x86/lguest/boot.c:151: error: 'PARAVIRT_LAZY_NONE' undeclared (first use in this function) which i bisected down to this very fresh commit: commit 84f7466ee20cc094aa38617abfa2f3834871f054 Author: Rusty Russell <[EMAIL PROTECTED]> Date: Sat Jan 19 07:02:29 2008 +1100 Selecting LGUEST should turn on Guest support, as in 2.6.23. which allows the following .config variation: # CONFIG_PARAVIRT_GUEST is not set CONFIG_LGUEST_GUEST=y please revert that commit, or apply the fix below. btw., i didnt even notice that patch because it is not visible on lkml, etc. NOTE: i found this problem this very minute so the patch below has not been tested through yet (it does build and boot with the attached config), but it seems obvious (to me). Ingo ---> Subject: x86: lguest fix From: Ingo Molnar <[EMAIL PROTECTED]> this commit: commit 84f7466ee20cc094aa38617abfa2f3834871f054 Author: Rusty Russell <[EMAIL PROTECTED]> Date: Sat Jan 19 07:02:29 2008 +1100 Selecting LGUEST should turn on Guest support, as in 2.6.23. caused build failures due to allowing LGUEST to be selected without paravirt support. Signed-off-by: Ingo Molnar <[EMAIL PROTECTED]> --- drivers/lguest/Kconfig |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: linux/drivers/lguest/Kconfig === --- linux.orig/drivers/lguest/Kconfig +++ linux/drivers/lguest/Kconfig @@ -1,6 +1,6 @@ config LGUEST tristate "Linux hypervisor example code" - depends on X86_32 && EXPERIMENTAL && !X86_PAE && FUTEX && !(X86_VISWS || X86_VOYAGER) + depends on X86_32 && EXPERIMENTAL && PARAVIRT_GUEST && !X86_PAE && FUTEX && !(X86_VISWS || X86_VOYAGER) select HVC_DRIVER select LGUEST_GUEST ---help--- # # Automatically generated make config: don't edit # Linux kernel version: 2.6.24-rc8 # Sat Jan 19 18:45:20 2008 # # CONFIG_64BIT is not set CONFIG_X86_32=y # CONFIG_X86_64 is not set CONFIG_X86=y CONFIG_GENERIC_TIME=y CONFIG_GENERIC_CMOS_UPDATE=y CONFIG_CLOCKSOURCE_WATCHDOG=y CONFIG_GENERIC_CLOCKEVENTS=y CONFIG_GENERIC_CLOCKEVENTS_BROADCAST=y CONFIG_LOCKDEP_SUPPORT=y CONFIG_STACKTRACE_SUPPORT=y CONFIG_SEMAPHORE_SLEEPERS=y CONFIG_MMU=y CONFIG_ZONE_DMA=y CONFIG_QUICKLIST=y CONFIG_GENERIC_ISA_DMA=y CONFIG_GENERIC_IOMAP=y CONFIG_GENERIC_BUG=y CONFIG_GENERIC_HWEIGHT=y CONFIG_ARCH_MAY_HAVE_PC_FDC=y CONFIG_DMI=y # CONFIG_RWSEM_GENERIC_SPINLOCK is not set CONFIG_RWSEM_XCHGADD_ALGORITHM=y # CONFIG_ARCH_HAS_ILOG2_U32 is not set # CONFIG_ARCH_HAS_ILOG2_U64 is not set CONFIG_GENERIC_CALIBRATE_DELAY=y # CONFIG_GENERIC_TIME_VSYSCALL is not set CONFIG_ARCH_SUPPORTS_OPROFILE=y # CONFIG_ZONE_DMA32 is not set CONFIG_ARCH_POPULATES_NODE_MAP=y # CONFIG_AUDIT_ARCH is not set CONFIG_GENERIC_HARDIRQS=y CONFIG_GENERIC_IRQ_PROBE=y CONFIG_GENERIC_PENDING_IRQ=y CONFIG_X86_SMP=y CONFIG_X86_HT=y CONFIG_X86_BIOS_REBOOT=y CONFIG_X86_TRAMPOLINE=y CONFIG_KTIME_SCALAR=y CONFIG_DEFCONFIG_LIST="/lib/modules/$UNAME_RELEASE/.config" # # General setup # CONFIG_EXPERIMENTAL=y CONFIG_LOCK_KERNEL=y CONFIG_INIT_ENV_ARG_LIMIT=32 CONFIG_LOCALVERSION="" CONFIG_LOCALVERSION_AUTO=y # CONFIG_SWAP is not set # CONFIG_SYSVIPC is not set # CONFIG_POSIX_MQUEUE is not set CONFIG_BSD_PROCESS_ACCT=y CONFIG_BSD_PROCESS_ACCT_V3=y CONFIG_TASKSTATS=y # CONFIG_TASK_DELAY_ACCT is not set CONFIG_TASK_XACCT=y CONFIG_TASK_IO_ACCOUNTING=y CONFIG_USER_NS=y # CONFIG_PID_NS is not set CONFIG_AUDIT=y CONFIG_AUDITSYSCALL=y CONFIG_IKCONFIG=y # CONFIG_IKCONFIG_PROC is not set CONFIG_LOG_BUF_SHIFT=20 CONFIG_CGROUPS=y # CONFIG_CGROUP_DEBUG is not set # CONFIG_CGROUP_NS is not set CONFIG_CPUSETS=y # CONFIG_FAIR_GROUP_SCHED is not set CONFIG_CGROUP_CPUACCT=y CONFIG_SYSFS_DEPRECATED=y CONFIG_PROC_PID_CPUSET=y # CONFIG_RELAY is not set # CONFIG_BLK_DEV_INITRD is not set # CONFIG_CC_OPTIMIZE_FOR_SIZE is not set CONFIG_SYSCTL=y # CONFIG_EMBEDDED is not set CONFIG_UID16=y CONFIG_SYSCTL_SYSCALL=y CONFIG_KALLSYMS=y # CONFIG_KALLSYMS_EXTRA_PASS is not set CONFIG_HOTPLUG=y CONFIG_PRINTK=y CONFIG_BUG=y CONFIG_ELF_CORE=y CONFIG_BASE_FULL=y CONFIG_FUTEX=y CONFIG_ANON_INODES=y CONFIG_EPOLL=y CONFIG_SIGNALFD=y CONFIG_EVENTFD=y CONFIG_SHMEM=y CONFIG_VM_EVENT_COUNTERS=y CONFIG_SLUB_DEBUG=y # CONFIG_SLAB is not set CONFIG_SLUB=y # CONFIG_SLOB is not set CONFIG_SLABINFO=y CONFIG_RT_MUTEXES=y # CONFIG_TINY_SHMEM is not set CONFIG_BASE_SMALL=0 CONFIG_MODULES=y CONFIG_MODULE_UNLOAD=y CONFIG_MODULE_FORCE_UNLOAD=y CONFIG_MODVERSIONS=y # CONFIG_MODULE_SRCVERSION_ALL is not set # CONFIG_KMOD is not set CONFIG_STOP_MACHINE=y CONFIG_BLOCK=y # CONFIG_LBD is not set # CONFIG_BLK_DEV_IO_TRACE is not set # CONFIG_LSF is not set CONFIG_BLK_DEV_BSG=y # # IO Schedulers # CONFIG_IOSCHED_NOOP=y #
[lguest build regression fix] Re: 2.6.24-rc8-git1: Reported regressions from 2.6.23
x86 randconfig testing found the following build failure: arch/x86/lguest/boot.c: In function 'lazy_hcall': arch/x86/lguest/boot.c:151: error: implicit declaration of function 'paravirt_get_lazy_mode' arch/x86/lguest/boot.c:151: error: 'PARAVIRT_LAZY_NONE' undeclared (first use in this function) which i bisected down to this very fresh commit: commit 84f7466ee20cc094aa38617abfa2f3834871f054 Author: Rusty Russell [EMAIL PROTECTED] Date: Sat Jan 19 07:02:29 2008 +1100 Selecting LGUEST should turn on Guest support, as in 2.6.23. which allows the following .config variation: # CONFIG_PARAVIRT_GUEST is not set CONFIG_LGUEST_GUEST=y please revert that commit, or apply the fix below. btw., i didnt even notice that patch because it is not visible on lkml, etc. NOTE: i found this problem this very minute so the patch below has not been tested through yet (it does build and boot with the attached config), but it seems obvious (to me). Ingo --- Subject: x86: lguest fix From: Ingo Molnar [EMAIL PROTECTED] this commit: commit 84f7466ee20cc094aa38617abfa2f3834871f054 Author: Rusty Russell [EMAIL PROTECTED] Date: Sat Jan 19 07:02:29 2008 +1100 Selecting LGUEST should turn on Guest support, as in 2.6.23. caused build failures due to allowing LGUEST to be selected without paravirt support. Signed-off-by: Ingo Molnar [EMAIL PROTECTED] --- drivers/lguest/Kconfig |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: linux/drivers/lguest/Kconfig === --- linux.orig/drivers/lguest/Kconfig +++ linux/drivers/lguest/Kconfig @@ -1,6 +1,6 @@ config LGUEST tristate Linux hypervisor example code - depends on X86_32 EXPERIMENTAL !X86_PAE FUTEX !(X86_VISWS || X86_VOYAGER) + depends on X86_32 EXPERIMENTAL PARAVIRT_GUEST !X86_PAE FUTEX !(X86_VISWS || X86_VOYAGER) select HVC_DRIVER select LGUEST_GUEST ---help--- # # Automatically generated make config: don't edit # Linux kernel version: 2.6.24-rc8 # Sat Jan 19 18:45:20 2008 # # CONFIG_64BIT is not set CONFIG_X86_32=y # CONFIG_X86_64 is not set CONFIG_X86=y CONFIG_GENERIC_TIME=y CONFIG_GENERIC_CMOS_UPDATE=y CONFIG_CLOCKSOURCE_WATCHDOG=y CONFIG_GENERIC_CLOCKEVENTS=y CONFIG_GENERIC_CLOCKEVENTS_BROADCAST=y CONFIG_LOCKDEP_SUPPORT=y CONFIG_STACKTRACE_SUPPORT=y CONFIG_SEMAPHORE_SLEEPERS=y CONFIG_MMU=y CONFIG_ZONE_DMA=y CONFIG_QUICKLIST=y CONFIG_GENERIC_ISA_DMA=y CONFIG_GENERIC_IOMAP=y CONFIG_GENERIC_BUG=y CONFIG_GENERIC_HWEIGHT=y CONFIG_ARCH_MAY_HAVE_PC_FDC=y CONFIG_DMI=y # CONFIG_RWSEM_GENERIC_SPINLOCK is not set CONFIG_RWSEM_XCHGADD_ALGORITHM=y # CONFIG_ARCH_HAS_ILOG2_U32 is not set # CONFIG_ARCH_HAS_ILOG2_U64 is not set CONFIG_GENERIC_CALIBRATE_DELAY=y # CONFIG_GENERIC_TIME_VSYSCALL is not set CONFIG_ARCH_SUPPORTS_OPROFILE=y # CONFIG_ZONE_DMA32 is not set CONFIG_ARCH_POPULATES_NODE_MAP=y # CONFIG_AUDIT_ARCH is not set CONFIG_GENERIC_HARDIRQS=y CONFIG_GENERIC_IRQ_PROBE=y CONFIG_GENERIC_PENDING_IRQ=y CONFIG_X86_SMP=y CONFIG_X86_HT=y CONFIG_X86_BIOS_REBOOT=y CONFIG_X86_TRAMPOLINE=y CONFIG_KTIME_SCALAR=y CONFIG_DEFCONFIG_LIST=/lib/modules/$UNAME_RELEASE/.config # # General setup # CONFIG_EXPERIMENTAL=y CONFIG_LOCK_KERNEL=y CONFIG_INIT_ENV_ARG_LIMIT=32 CONFIG_LOCALVERSION= CONFIG_LOCALVERSION_AUTO=y # CONFIG_SWAP is not set # CONFIG_SYSVIPC is not set # CONFIG_POSIX_MQUEUE is not set CONFIG_BSD_PROCESS_ACCT=y CONFIG_BSD_PROCESS_ACCT_V3=y CONFIG_TASKSTATS=y # CONFIG_TASK_DELAY_ACCT is not set CONFIG_TASK_XACCT=y CONFIG_TASK_IO_ACCOUNTING=y CONFIG_USER_NS=y # CONFIG_PID_NS is not set CONFIG_AUDIT=y CONFIG_AUDITSYSCALL=y CONFIG_IKCONFIG=y # CONFIG_IKCONFIG_PROC is not set CONFIG_LOG_BUF_SHIFT=20 CONFIG_CGROUPS=y # CONFIG_CGROUP_DEBUG is not set # CONFIG_CGROUP_NS is not set CONFIG_CPUSETS=y # CONFIG_FAIR_GROUP_SCHED is not set CONFIG_CGROUP_CPUACCT=y CONFIG_SYSFS_DEPRECATED=y CONFIG_PROC_PID_CPUSET=y # CONFIG_RELAY is not set # CONFIG_BLK_DEV_INITRD is not set # CONFIG_CC_OPTIMIZE_FOR_SIZE is not set CONFIG_SYSCTL=y # CONFIG_EMBEDDED is not set CONFIG_UID16=y CONFIG_SYSCTL_SYSCALL=y CONFIG_KALLSYMS=y # CONFIG_KALLSYMS_EXTRA_PASS is not set CONFIG_HOTPLUG=y CONFIG_PRINTK=y CONFIG_BUG=y CONFIG_ELF_CORE=y CONFIG_BASE_FULL=y CONFIG_FUTEX=y CONFIG_ANON_INODES=y CONFIG_EPOLL=y CONFIG_SIGNALFD=y CONFIG_EVENTFD=y CONFIG_SHMEM=y CONFIG_VM_EVENT_COUNTERS=y CONFIG_SLUB_DEBUG=y # CONFIG_SLAB is not set CONFIG_SLUB=y # CONFIG_SLOB is not set CONFIG_SLABINFO=y CONFIG_RT_MUTEXES=y # CONFIG_TINY_SHMEM is not set CONFIG_BASE_SMALL=0 CONFIG_MODULES=y CONFIG_MODULE_UNLOAD=y CONFIG_MODULE_FORCE_UNLOAD=y CONFIG_MODVERSIONS=y # CONFIG_MODULE_SRCVERSION_ALL is not set # CONFIG_KMOD is not set CONFIG_STOP_MACHINE=y CONFIG_BLOCK=y # CONFIG_LBD is not set # CONFIG_BLK_DEV_IO_TRACE is not set # CONFIG_LSF is not set CONFIG_BLK_DEV_BSG=y # # IO Schedulers # CONFIG_IOSCHED_NOOP=y # CONFIG_IOSCHED_AS is not set
Re: [lguest build regression fix] Re: 2.6.24-rc8-git1: Reported regressions from 2.6.23
On Sunday 20 January 2008 05:06:04 Ingo Molnar wrote: x86 randconfig testing found the following build failure: arch/x86/lguest/boot.c: In function 'lazy_hcall': arch/x86/lguest/boot.c:151: error: implicit declaration of function 'paravirt_get_lazy_mode' arch/x86/lguest/boot.c:151: error: 'PARAVIRT_LAZY_NONE' undeclared (first use in this function) which i bisected down to this very fresh commit: commit 84f7466ee20cc094aa38617abfa2f3834871f054 Author: Rusty Russell [EMAIL PROTECTED] Date: Sat Jan 19 07:02:29 2008 +1100 Selecting LGUEST should turn on Guest support, as in 2.6.23. which allows the following .config variation: # CONFIG_PARAVIRT_GUEST is not set CONFIG_LGUEST_GUEST=y This looks like a randconfig bug, to be honest. CONFIG_LGUEST_GUEST and CONFIG_LGUEST are within if PARAVIRT_GUEST (include is in arch/x86/Kconfig). Rusty. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [lguest build regression fix] Re: 2.6.24-rc8-git1: Reported regressions from 2.6.23
On Sun, Jan 20, 2008 at 10:24:47AM +1100, Rusty Russell wrote: On Sunday 20 January 2008 05:06:04 Ingo Molnar wrote: x86 randconfig testing found the following build failure: arch/x86/lguest/boot.c: In function 'lazy_hcall': arch/x86/lguest/boot.c:151: error: implicit declaration of function 'paravirt_get_lazy_mode' arch/x86/lguest/boot.c:151: error: 'PARAVIRT_LAZY_NONE' undeclared (first use in this function) which i bisected down to this very fresh commit: commit 84f7466ee20cc094aa38617abfa2f3834871f054 Author: Rusty Russell [EMAIL PROTECTED] Date: Sat Jan 19 07:02:29 2008 +1100 Selecting LGUEST should turn on Guest support, as in 2.6.23. which allows the following .config variation: # CONFIG_PARAVIRT_GUEST is not set CONFIG_LGUEST_GUEST=y This looks like a randconfig bug, to be honest. CONFIG_LGUEST_GUEST and CONFIG_LGUEST are within if PARAVIRT_GUEST (include is in arch/x86/Kconfig). According to GNU grep we have two CONFIG_LGUEST_GUEST variables (sic), one in arch/x86/lguest/Kconfig and one in drivers/lguest/Kconfig. And CONFIG_LGUEST (which selects CONFIG_LGUEST_GUEST) is in drivers/lguest/Kconfig which gets included from drivers/kvm/Kconfig (sic) which in turn gets included from drivers/Kconfig which in turn is not within the if PARAVIRT_GUEST. Rusty, don't blame randconfig for finding bugs in this mess you created... Rusty. cu Adrian -- Is there not promise of rain? Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. Only a promise, Lao Er said. Pearl S. Buck - Dragon Seed -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [lguest build regression fix] Re: 2.6.24-rc8-git1: Reported regressions from 2.6.23
On Sunday 20 January 2008 10:49:45 Adrian Bunk wrote: On Sun, Jan 20, 2008 at 10:24:47AM +1100, Rusty Russell wrote: On Sunday 20 January 2008 05:06:04 Ingo Molnar wrote: # CONFIG_PARAVIRT_GUEST is not set CONFIG_LGUEST_GUEST=y This looks like a randconfig bug, to be honest. According to GNU grep we have two CONFIG_LGUEST_GUEST variables (sic), one in arch/x86/lguest/Kconfig and one in drivers/lguest/Kconfig. Rusty, don't blame randconfig for finding bugs in this mess you created... My apologies, it is my mess. The one in drivers/lguest/Kconfig is the old (bogus) one: looks like I lost the removal part in a patch merge back in September. I've tested this patch. It correctly handles Ingo's config (removes lguest guest support). Both lguest and lguest guest support can be turned on independently, and it still compiles. How embarrassing, Rusty. --- Remove bogus duplicate CONFIG_LGUEST_GUEST entry. It was moved to arch/x86/lguest/Kconfig, but I lost the deletion part in a patch suffle. My confused one-liner fix to turn it on is also reverted: 84f7466ee20cc094aa38617abfa2f3834871f054 Signed-off-by: Rusty Russell [EMAIL PROTECTED] diff -r 3db2cadc1a30 drivers/lguest/Kconfig --- a/drivers/lguest/KconfigSun Jan 20 11:25:15 2008 +1100 +++ b/drivers/lguest/KconfigSun Jan 20 11:47:57 2008 +1100 @@ -2,7 +2,6 @@ config LGUEST tristate Linux hypervisor example code depends on X86_32 EXPERIMENTAL !X86_PAE FUTEX !(X86_VISWS || X86_VOYAGER) select HVC_DRIVER - select LGUEST_GUEST ---help--- This is a very simple module which allows you to run multiple instances of the same Linux kernel, using the @@ -11,9 +10,3 @@ config LGUEST not rustyvisor. See Documentation/lguest/lguest.txt. If unsure, say N. If curious, say M. If masochistic, say Y. - -config LGUEST_GUEST - bool - help - The guest needs code built-in, even if the host has lguest - support as a module. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
