Re: [net-next PATCH] net: fix xdp_rxq_info build issue when CONFIG_SYSFS is not set

[David Miller]

From: Jesper Dangaard Brouer 
Date: Tue, 09 Jan 2018 23:42:34 +0100

> The commit e817f85652c1 ("xdp: generic XDP handling of xdp_rxq_info")
> removed some ifdef CONFIG_SYSFS in net/core/dev.c, but forgot to
> remove the corresponding ifdef's in include/linux/netdevice.h.
> 
> Fixes: e817f85652c1 ("xdp: generic XDP handling of xdp_rxq_info")
> Reported-by: Guenter Roeck 
> Signed-off-by: Jesper Dangaard Brouer 

Applied.

Re: [net-next PATCH] net: fix xdp_rxq_info build issue when CONFIG_SYSFS is not set

[David Miller]

From: Jesper Dangaard Brouer 
Date: Tue, 09 Jan 2018 23:42:34 +0100

> The commit e817f85652c1 ("xdp: generic XDP handling of xdp_rxq_info")
> removed some ifdef CONFIG_SYSFS in net/core/dev.c, but forgot to
> remove the corresponding ifdef's in include/linux/netdevice.h.
> 
> Fixes: e817f85652c1 ("xdp: generic XDP handling of xdp_rxq_info")
> Reported-by: Guenter Roeck 
> Signed-off-by: Jesper Dangaard Brouer 

Applied.

Re: [net-next PATCH] net: fix xdp_rxq_info build issue when CONFIG_SYSFS is not set

[Guenter Roeck]

On Tue, Jan 09, 2018 at 11:42:34PM +0100, Jesper Dangaard Brouer wrote:
> The commit e817f85652c1 ("xdp: generic XDP handling of xdp_rxq_info")
> removed some ifdef CONFIG_SYSFS in net/core/dev.c, but forgot to
> remove the corresponding ifdef's in include/linux/netdevice.h.
> 
> Fixes: e817f85652c1 ("xdp: generic XDP handling of xdp_rxq_info")
> Reported-by: Guenter Roeck 
> Signed-off-by: Jesper Dangaard Brouer 

Tested-by: Guenter Roeck 

> ---
>  include/linux/netdevice.h |3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
> index 440b000f07f4..b308793c64ce 100644
> --- a/include/linux/netdevice.h
> +++ b/include/linux/netdevice.h
> @@ -1805,12 +1805,9 @@ struct net_device {
>   /* Interface address info used in eth_type_trans() */
>   unsigned char   *dev_addr;
>  
> -#ifdef CONFIG_SYSFS
>   struct netdev_rx_queue  *_rx;
> -
>   unsigned intnum_rx_queues;
>   unsigned intreal_num_rx_queues;
> -#endif
>  
>   struct bpf_prog __rcu   *xdp_prog;
>   unsigned long   gro_flush_timeout;
> 

Re: [net-next PATCH] net: fix xdp_rxq_info build issue when CONFIG_SYSFS is not set

[Guenter Roeck]

On Tue, Jan 09, 2018 at 11:42:34PM +0100, Jesper Dangaard Brouer wrote:
> The commit e817f85652c1 ("xdp: generic XDP handling of xdp_rxq_info")
> removed some ifdef CONFIG_SYSFS in net/core/dev.c, but forgot to
> remove the corresponding ifdef's in include/linux/netdevice.h.
> 
> Fixes: e817f85652c1 ("xdp: generic XDP handling of xdp_rxq_info")
> Reported-by: Guenter Roeck 
> Signed-off-by: Jesper Dangaard Brouer 

Tested-by: Guenter Roeck 

> ---
>  include/linux/netdevice.h |3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
> index 440b000f07f4..b308793c64ce 100644
> --- a/include/linux/netdevice.h
> +++ b/include/linux/netdevice.h
> @@ -1805,12 +1805,9 @@ struct net_device {
>   /* Interface address info used in eth_type_trans() */
>   unsigned char   *dev_addr;
>  
> -#ifdef CONFIG_SYSFS
>   struct netdev_rx_queue  *_rx;
> -
>   unsigned intnum_rx_queues;
>   unsigned intreal_num_rx_queues;
> -#endif
>  
>   struct bpf_prog __rcu   *xdp_prog;
>   unsigned long   gro_flush_timeout;
> 

[net-next PATCH] net: fix xdp_rxq_info build issue when CONFIG_SYSFS is not set

[Jesper Dangaard Brouer]

The commit e817f85652c1 ("xdp: generic XDP handling of xdp_rxq_info")
removed some ifdef CONFIG_SYSFS in net/core/dev.c, but forgot to
remove the corresponding ifdef's in include/linux/netdevice.h.

Fixes: e817f85652c1 ("xdp: generic XDP handling of xdp_rxq_info")
Reported-by: Guenter Roeck 
Signed-off-by: Jesper Dangaard Brouer 
---
 include/linux/netdevice.h |3 ---
 1 file changed, 3 deletions(-)

diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
index 440b000f07f4..b308793c64ce 100644
--- a/include/linux/netdevice.h
+++ b/include/linux/netdevice.h
@@ -1805,12 +1805,9 @@ struct net_device {
/* Interface address info used in eth_type_trans() */
unsigned char   *dev_addr;
 
-#ifdef CONFIG_SYSFS
struct netdev_rx_queue  *_rx;
-
unsigned intnum_rx_queues;
unsigned intreal_num_rx_queues;
-#endif
 
struct bpf_prog __rcu   *xdp_prog;
unsigned long   gro_flush_timeout;

[net-next PATCH] net: fix xdp_rxq_info build issue when CONFIG_SYSFS is not set

[Jesper Dangaard Brouer]

The commit e817f85652c1 ("xdp: generic XDP handling of xdp_rxq_info")
removed some ifdef CONFIG_SYSFS in net/core/dev.c, but forgot to
remove the corresponding ifdef's in include/linux/netdevice.h.

Fixes: e817f85652c1 ("xdp: generic XDP handling of xdp_rxq_info")
Reported-by: Guenter Roeck 
Signed-off-by: Jesper Dangaard Brouer 
---
 include/linux/netdevice.h |3 ---
 1 file changed, 3 deletions(-)

diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
index 440b000f07f4..b308793c64ce 100644
--- a/include/linux/netdevice.h
+++ b/include/linux/netdevice.h
@@ -1805,12 +1805,9 @@ struct net_device {
/* Interface address info used in eth_type_trans() */
unsigned char   *dev_addr;
 
-#ifdef CONFIG_SYSFS
struct netdev_rx_queue  *_rx;
-
unsigned intnum_rx_queues;
unsigned intreal_num_rx_queues;
-#endif
 
struct bpf_prog __rcu   *xdp_prog;
unsigned long   gro_flush_timeout;