Re: [patch] Add the device IDs for AMD/ATI SB700
Hi,
Sorry for the late reply and thanks to Jeff for stepping in. :)
Since Jeff covered both status of your patches and administrative issues
I would only like to add one small hint for people adding support for
multi-function PCI chipsets (with multiple PCI device IDs):
It makes sense to put addition of _all_ new PCI IDs into the first patch
of the series and send it to PCI Maintainer (Hi Greg). This should make
all other patches from the series independent of each other (in the usual
case I'm not talking about all crazy scenarios here). After the patch
with PCI IDs gets applied upstream you may now send all other patches to
the respective maintainers without worrying about inter-patch dependencies
and without maintainers worrying about your patches not applying cleanly.
IIRC Intely guys are using this process when adding support for their new
chipsets and it works smoothly.
[ Yep, this process is the exception from the general "patch shouldn't add
unused code" rule but the amount of _temporarily_ unused stuff is _minimal_
and doing it this way saves a lot of time for all parties involved. ]
PS Greg/Jeff If I'm totally wrong on this please correct me...
Thanks,
Bart
On Friday 25 May 2007, Jeff Garzik wrote:
> Henry Su wrote:
> > I check the latest kernel source code with git, and find out that the
> > SMBus patch has not been applied yet,
>
> Correct. When you don't see a patch in the upstream git tree
> git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git
> then the next step is consult the MAINTAINERS file, and determine to
> whom you should send a follow-up patch, or simply contact about the
> status of a patch you just sent. In this case, SMBus is in drivers/i2c
> sub-directory, which leads us to find in MAINTAINERS,
>
> I2C SUBSYSTEM
> P: Jean Delvare
> M: [EMAIL PROTECTED]
> L: [EMAIL PROTECTED]
> T: quilt http://khali.linux-fr.org/devel/linux-2.6/jdelvare-i2c/
> S: Maintained
>
> That tells us the maintainer of the subsystem, and also ("T:") an
> external reference (a tree) to where the maintainer posts accepted
> patches, prior to sending them upstream.
>
> So for SMBus, you should make sure your SMBus changes appear in Jean
> Delvare's quilt tree. If they do not, create a new patch and send it to
> Jean and CC [EMAIL PROTECTED] and [EMAIL PROTECTED]
>
>
> > and the patch for IDE has not been applied completely.one more device
> > id should be added to pata_atiixp.c,
> > l list the patch as following, or you can fetch it from the attached file,
> > could you please apply this for me?
>
> Actually it has been applied -- the part that I maintain (drivers/ata/*)
> is currently stored in a secondary tree, as described above. Your patch
> has been stored on the 'upstream' branch of
> git://git.kernel.org/pub/scm/linux/kernel/git/jgarzik/libata-dev.git
>
> Currently, the upstream Linux kernel is only accepting bug fixes. I
> merge ATA bug fixes (and sometimes simple PCI ID additions) into
> libata-dev.git#upstream-fixes during this phase of development. These
> changes are sent upstream in 24-48 hours, to ensure that they will be
> included in the next release (kernel 2.6.22).
>
> All other ATA changes are merged into libata-dev.git#upstream. When
> Linus releases kernel 2.6.22, the "merge window" opens, allowing
> non-bug-fix changes to be submitted upstream. When the merge window
> opens, I submit everything in libata-dev.git#upstream to Linus and
> Andrew Morton for inclusion in the official upstream kernel tree.
>
> That is our development process in a nutshell.
>
> The kernel development process is conducted entirely via email, so you
> see why it is so important to learn how to email patches in the proper
> format.
>
> Jeff
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [patch] Add the device IDs for AMD/ATI SB700
Henry Su wrote:
I check the latest kernel source code with git, and find out that the SMBus patch has not been applied yet,
Correct. When you don't see a patch in the upstream git tree
git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git
then the next step is consult the MAINTAINERS file, and determine to
whom you should send a follow-up patch, or simply contact about the
status of a patch you just sent. In this case, SMBus is in drivers/i2c
sub-directory, which leads us to find in MAINTAINERS,
I2C SUBSYSTEM
P: Jean Delvare
M: [EMAIL PROTECTED]
L: [EMAIL PROTECTED]
T: quilt http://khali.linux-fr.org/devel/linux-2.6/jdelvare-i2c/
S: Maintained
That tells us the maintainer of the subsystem, and also ("T:") an
external reference (a tree) to where the maintainer posts accepted
patches, prior to sending them upstream.
So for SMBus, you should make sure your SMBus changes appear in Jean
Delvare's quilt tree. If they do not, create a new patch and send it to
Jean and CC [EMAIL PROTECTED] and [EMAIL PROTECTED]
and the patch for IDE has not been applied completely.one more device id
should be added to pata_atiixp.c,
l list the patch as following, or you can fetch it from the attached file, could you please apply this for me?
Actually it has been applied -- the part that I maintain (drivers/ata/*)
is currently stored in a secondary tree, as described above. Your patch
has been stored on the 'upstream' branch of
git://git.kernel.org/pub/scm/linux/kernel/git/jgarzik/libata-dev.git
Currently, the upstream Linux kernel is only accepting bug fixes. I
merge ATA bug fixes (and sometimes simple PCI ID additions) into
libata-dev.git#upstream-fixes during this phase of development. These
changes are sent upstream in 24-48 hours, to ensure that they will be
included in the next release (kernel 2.6.22).
All other ATA changes are merged into libata-dev.git#upstream. When
Linus releases kernel 2.6.22, the "merge window" opens, allowing
non-bug-fix changes to be submitted upstream. When the merge window
opens, I submit everything in libata-dev.git#upstream to Linus and
Andrew Morton for inclusion in the official upstream kernel tree.
That is our development process in a nutshell.
The kernel development process is conducted entirely via email, so you
see why it is so important to learn how to email patches in the proper
format.
Jeff
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [patch] Add the device IDs for AMD/ATI SB700
Henry Su wrote: > Hi Jeff, > Thanks for your kindly help, I will fix the email next time. > Do you mean all the device IDs for ATI SB700 are added to the corresponding > files? > because I split this patch and resent four patches according to your last > suggestion, > if this patch is applied, another patches are not necessary now. Splitting up the patches helped us all. The AHCI, drivers/ide, and now pata_atiixp patches were applied by the respective maintainers. Let me know if you need a quick introduction to git, which is the main tool to watch the latest Linux kernel source code (it's like CVS, but better :)) I don't know about the SMBus patch, though. That may or may not have been applied. Jeff - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [patch] Add the device IDs for AMD/ATI SB700
Henry Su wrote:
> --- linux-2.6.21.1.orig/drivers/ata/pata_atiixp.c 2007-05-10
> 06:30:14.0 폍
> linux-2.6.21.1/drivers/ata/pata_atiixp.c 2007-05-10 07:17:07.0 폍
> @@ -283,6 ,7 @@ static const struct pci_device_id atiixp
> { PCI_VDEVICE(ATI, PCI_DEVICE_ID_ATI_IXP300_IDE), },
> { PCI_VDEVICE(ATI, PCI_DEVICE_ID_ATI_IXP400_IDE), },
> { PCI_VDEVICE(ATI, PCI_DEVICE_ID_ATI_IXP600_IDE), },
> + { PCI_VDEVICE(ATI, PCI_DEVICE_ID_ATI_IXP700_IDE), },
Patch applied manually.
Your patches are all technically correct -- but you really need to fix
your email so that we can receive and apply your patches via scripts.
This is a basic step that every kernel contributor needs to take.
Jeff
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [patch] Add the device IDs for AMD/ATI SB700
On Wed, May 09, 2007 at 08:36:54AM -0400, Jeff Garzik wrote: > Henry Su wrote: > > From: [EMAIL PROTECTED] > > Adding the device ID for AMD/ATI SB700. > > Signed-off-by:henry su <[EMAIL PROTECTED]> > > Time to train new people... > > You need to split up your patches: > * send I2C and PCI quirk patches to GregKH > * send drivers/ide/* stuff to Bart > * send drivers/ata/* patches to me Additionally, these patches seem to be hurrendously MIME damaged. patch(1) sees this.. diff -Nur linux-2.6.21.1.orig/include/linux/pci+AF8-ids.h linux-2.6.21.1/include/linux/pci+AF8-ids.h --- linux-2.6.21.1.orig/include/linux/pci+AF8-ids.h 2007-05-16 13:28:54.405386000 +-0800 +-+-+- linux-2.6.21.1/include/linux/pci+AF8-ids.h 2007-05-16 13:45:29.936636000 +-0800 +AEAAQA- -371,6 +-371,9 +AEAAQA- +ACM-define PCI+AF8-DEVICE+AF8-ID+AF8-ATI+AF8-IXP600+AF8-SRAID 0x4381 +ACM-define PCI+AF8-DEVICE+AF8-ID+AF8-ATI+AF8-IXP600+AF8-SMBUS 0x4385 +ACM-define PCI+AF8-DEVICE+AF8-ID+AF8-ATI+AF8-IXP600+AF8-IDE 0x438c +-+ACM-define PCI+AF8-DEVICE+AF8-ID+AF8-ATI+AF8-IXP700+AF8-SATA 0x4390 +-+ACM-define PCI+AF8-DEVICE+AF8-ID+AF8-ATI+AF8-IXP700+AF8-SMBUS 0x4395 +-+ACM-define PCI+AF8-DEVICE+AF8-ID+AF8-ATI+AF8-IXP700+AF8-IDE 0x439c Dave -- http://www.codemonkey.org.uk - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [patch] Add the device IDs for AMD/ATI SB700
Am Mittwoch 09 Mai 2007 16:21 schrieb Greg KH: > On Wed, May 09, 2007 at 08:36:54AM -0400, Jeff Garzik wrote: > > Henry Su wrote: > > > From: [EMAIL PROTECTED] > > > Adding the device ID for AMD/ATI SB700. > > > Signed-off-by:henry su <[EMAIL PROTECTED]> > > > > Time to train new people... > > > > You need to split up your patches: > > * send I2C and PCI quirk patches to GregKH > > Nope, I2C is not me anymore, I think it's already on it's third > maintainer AFAICT, Jean Delvare only dropped lm-sensors maintainership. He is still maintainer (and hopefully stays) of the i2c subsystem. Anyway, whoever maintains it, patches for i2c should be sent to the i2c mailing list, [EMAIL PROTECTED] Hans - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [patch] Add the device IDs for AMD/ATI SB700
On Wed, May 09, 2007 at 08:36:54AM -0400, Jeff Garzik wrote: > Henry Su wrote: > > From: [EMAIL PROTECTED] > > Adding the device ID for AMD/ATI SB700. > > Signed-off-by:henry su <[EMAIL PROTECTED]> > > Time to train new people... > > You need to split up your patches: > * send I2C and PCI quirk patches to GregKH Nope, I2C is not me anymore, I think it's already on it's third maintainer, check the MAINTAINERS file for details. thanks, greg k-h - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [patch] Add the device IDs for AMD/ATI SB700
Henry Su wrote:
> --- linux-2.6.21.1.orig/drivers/ide/pci/atiixp.c 2007-05-10
> 06:30:17.0 +0800
> +++ linux-2.6.21.1/drivers/ide/pci/atiixp.c 2007-05-10 07:18:39.0
> +0800
> @@ -353,6 +353,7 @@ static struct pci_device_id atiixp_pci_t
> { PCI_VENDOR_ID_ATI, PCI_DEVICE_ID_ATI_IXP300_IDE, PCI_ANY_ID,
> PCI_ANY_ID, 0, 0, 0},
> { PCI_VENDOR_ID_ATI, PCI_DEVICE_ID_ATI_IXP400_IDE, PCI_ANY_ID,
> PCI_ANY_ID, 0, 0, 0},
> { PCI_VENDOR_ID_ATI, PCI_DEVICE_ID_ATI_IXP600_IDE, PCI_ANY_ID,
> PCI_ANY_ID, 0, 0, 1},
> + { PCI_VENDOR_ID_ATI, PCI_DEVICE_ID_ATI_IXP700_IDE, PCI_ANY_ID,
> +PCI_ANY_ID, 0, 0, 1},
> { 0, },
> };
> MODULE_DEVICE_TABLE(pci, atiixp_pci_tbl);
>
> --- linux-2.6.21.1.orig/drivers/ata/ahci.c2007-05-10 06:30:14.0
> +0800
> +++ linux-2.6.21.1/drivers/ata/ahci.c 2007-05-10 07:41:41.0 +0800
> @@ -415,6 +415,7 @@ static const struct pci_device_id ahci_p
> /* ATI */
> { PCI_VDEVICE(ATI, 0x4380), board_ahci_sb600 }, /* ATI SB600 non-raid */
> { PCI_VDEVICE(ATI, 0x4381), board_ahci }, /* ATI SB600 raid */
Wasn't there a patch which dropped SB600 raid entry? I think I heard
there's no device which has 0x4381 as its DID.
--
tejun
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [patch] Add the device IDs for AMD/ATI SB700
Henry Su wrote:
> From: [EMAIL PROTECTED]
> Adding the device ID for AMD/ATI SB700.
> Signed-off-by:henry su <[EMAIL PROTECTED]>
Time to train new people...
You need to split up your patches:
* send I2C and PCI quirk patches to GregKH
* send drivers/ide/* stuff to Bart
* send drivers/ata/* patches to me
> --- linux-2.6.21.1.orig/drivers/ide/pci/atiixp.c 2007-05-10
> 06:30:17.0 +0800
> +++ linux-2.6.21.1/drivers/ide/pci/atiixp.c 2007-05-10 07:18:39.0
> +0800
> @@ -353,6 +353,7 @@ static struct pci_device_id atiixp_pci_t
> { PCI_VENDOR_ID_ATI, PCI_DEVICE_ID_ATI_IXP300_IDE, PCI_ANY_ID,
> PCI_ANY_ID, 0, 0, 0},
> { PCI_VENDOR_ID_ATI, PCI_DEVICE_ID_ATI_IXP400_IDE, PCI_ANY_ID,
> PCI_ANY_ID, 0, 0, 0},
> { PCI_VENDOR_ID_ATI, PCI_DEVICE_ID_ATI_IXP600_IDE, PCI_ANY_ID,
> PCI_ANY_ID, 0, 0, 1},
> + { PCI_VENDOR_ID_ATI, PCI_DEVICE_ID_ATI_IXP700_IDE, PCI_ANY_ID,
> +PCI_ANY_ID, 0, 0, 1},
> { 0, },
> };
> MODULE_DEVICE_TABLE(pci, atiixp_pci_tbl);
fix word wrap
> --- linux-2.6.21.1.orig/drivers/ata/ahci.c2007-05-10 06:30:14.0
> +0800
> +++ linux-2.6.21.1/drivers/ata/ahci.c 2007-05-10 07:41:41.0 +0800
> @@ -415,6 +415,7 @@ static const struct pci_device_id ahci_p
> /* ATI */
> { PCI_VDEVICE(ATI, 0x4380), board_ahci_sb600 }, /* ATI SB600 non-raid */
> { PCI_VDEVICE(ATI, 0x4381), board_ahci }, /* ATI SB600 raid */
> + { PCI_VDEVICE(ATI, 0x4390), board_ahci_sb600 }, /* ATI SB700 */
>
> /* VIA */
> { PCI_VDEVICE(VIA, 0x3349), board_ahci_vt8251 }, /* VIA VT8251 */
>
> --- linux-2.6.21.1.orig/drivers/pci/quirks.c 2007-05-10 06:30:17.0
> +0800
> +++ linux-2.6.21.1/drivers/pci/quirks.c 2007-05-10 07:49:33.0
> +0800
> @@ -875,6 +875,7 @@ static void __devinit quirk_sb600_sata(s
> }
> }
> DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_ATI, PCI_DEVICE_ID_ATI_IXP600_SATA,
> quirk_sb600_sata);
> +DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_ATI,
> +PCI_DEVICE_ID_ATI_IXP700_SATA, quirk_sb600_sata);
fix word wrap
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
