[PATCH] Re: [patch] Re: 2.4.3-pre8: IPX not building
The improved patch below should fix it. This additional problem only showed up when IPX was built into the kernel (non modular). If you don't want to revert the previous patch and apply this one you can simply change net/ipx/af_ipx line 126 from: static int sysctl_ipx_pprop_broadcasting = 1; to: int sysctl_ipx_pprop_broadcasting = 1; and then make bzImage again. Robert-Velisav MICIOVICI <[EMAIL PROTECTED]> wrote: > > Sorry to bother but it seems that the patchlet is still not good > enough... problems at linkage or something: > > net/network.o(.data+0x5f04): undefined reference to > `sysctl_ipx_pprop_broadcasting' > make: *** [vmlinux] Error 1 > [root@bigfoot linux-2.4.3-pre8]# --- linux-2.4.3pre8.orig/net/ipx/af_ipx.c Thu Mar 29 10:27:29 2001 +++ linux-2.4.3pre8/net/ipx/af_ipx.cThu Mar 29 10:22:59 2001 @@ -123,7 +123,7 @@ static unsigned char ipxcfg_max_hops = 16; static char ipxcfg_auto_select_primary; static char ipxcfg_auto_create_interfaces; -static int sysctl_ipx_pprop_broadcasting = 1; +int sysctl_ipx_pprop_broadcasting = 1; /* Global Variables */ static struct datalink_proto *p8022_datalink; @@ -1542,7 +1542,7 @@ ipx_offset = intrfc->if_ipx_offset; size = sizeof(struct ipxhdr) + len + ipx_offset; - skb = sock_alloc_send_skb(sk, size, noblock, ); + skb = sock_alloc_send_skb(sk, size, 0, noblock, ); if (!skb) goto out_put; @@ -2531,7 +2531,6 @@ sendmsg:ipx_sendmsg, recvmsg:ipx_recvmsg, mmap: sock_no_mmap, - sendpage: sock_no_sendpage, }; #include - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH] Re: [patch] Re: 2.4.3-pre8: IPX not building
The improved patch below should fix it. This additional problem only showed up when IPX was built into the kernel (non modular). If you don't want to revert the previous patch and apply this one you can simply change net/ipx/af_ipx line 126 from: static int sysctl_ipx_pprop_broadcasting = 1; to: int sysctl_ipx_pprop_broadcasting = 1; and then make bzImage again. Robert-Velisav MICIOVICI [EMAIL PROTECTED] wrote: Sorry to bother but it seems that the patchlet is still not good enough... problems at linkage or something: SNIP net/network.o(.data+0x5f04): undefined reference to `sysctl_ipx_pprop_broadcasting' make: *** [vmlinux] Error 1 [root@bigfoot linux-2.4.3-pre8]# --- linux-2.4.3pre8.orig/net/ipx/af_ipx.c Thu Mar 29 10:27:29 2001 +++ linux-2.4.3pre8/net/ipx/af_ipx.cThu Mar 29 10:22:59 2001 @@ -123,7 +123,7 @@ static unsigned char ipxcfg_max_hops = 16; static char ipxcfg_auto_select_primary; static char ipxcfg_auto_create_interfaces; -static int sysctl_ipx_pprop_broadcasting = 1; +int sysctl_ipx_pprop_broadcasting = 1; /* Global Variables */ static struct datalink_proto *p8022_datalink; @@ -1542,7 +1542,7 @@ ipx_offset = intrfc-if_ipx_offset; size = sizeof(struct ipxhdr) + len + ipx_offset; - skb = sock_alloc_send_skb(sk, size, noblock, err); + skb = sock_alloc_send_skb(sk, size, 0, noblock, err); if (!skb) goto out_put; @@ -2531,7 +2531,6 @@ sendmsg:ipx_sendmsg, recvmsg:ipx_recvmsg, mmap: sock_no_mmap, - sendpage: sock_no_sendpage, }; #include linux/smp_lock.h - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [patch] Re: 2.4.3-pre8: IPX not building
Sorry to bother but it seems that the patchlet is still not good enough... problems at linkage or something: O2 -fomit-frame-pointer -fno-strict-aliasing -pipe -mpreferred-stack-boundary=2 -march=athlon -c -o iodebug.o iodebug.c gcc -D__KERNEL__ -I/usr/src/linux-2.4.3-pre8/include -Wall -Wstrict-prototypes -O2 -fomit-frame-pointer -fno-strict-aliasing -pipe -mpreferred-stack-boundary=2 -march=athlon -c -o memcpy.o memcpy.c gcc -D__KERNEL__ -I/usr/src/linux-2.4.3-pre8/include -Wall -Wstrict-prototypes -O2 -fomit-frame-pointer -fno-strict-aliasing -pipe -mpreferred-stack-boundary=2 -march=athlon -c -o mmx.o mmx.c rm -f lib.a ar rcs lib.a checksum.o old-checksum.o delay.o usercopy.o getuser.o putuser.o iodebug.o memcpy.o mmx.o make[2]: Leaving directory `/usr/src/linux-2.4.3-pre8/arch/i386/lib' make[1]: Leaving directory `/usr/src/linux-2.4.3-pre8/arch/i386/lib' ld -m elf_i386 -T /usr/src/linux-2.4.3-pre8/arch/i386/vmlinux.lds -e stext arch/i386/kernel/head.o arch/i386/kernel/init_task.o init/main.o init/version.o \ --start-group \ arch/i386/kernel/kernel.o arch/i386/mm/mm.o kernel/kernel.o mm/mm.o fs/fs.o ipc/ipc.o \ drivers/block/block.o drivers/char/char.o drivers/misc/misc.o drivers/net/net.o drivers/media/media.o drivers/parport/driver.o drivers/char/agp/agp.o drivers/char/drm/drm.o drivers/net/fc/fc.o drivers/net/appletalk/appletalk.o drivers/net/tokenring/tr.o drivers/atm/atm.o drivers/ide/idedriver.o drivers/scsi/scsidrv.o drivers/ieee1394/ieee1394drv.o drivers/cdrom/driver.o drivers/sound/sounddrivers.o drivers/pci/driver.o drivers/pnp/pnp.o drivers/video/video.o drivers/net/hamradio/hamradio.o drivers/i2o/i2o.o drivers/i2c/i2c.o drivers/md/mddev.o \net/network.o \ /usr/src/linux-2.4.3-pre8/arch/i386/lib/lib.a /usr/src/linux-2.4.3-pre8/lib/lib.a /usr/src/linux-2.4.3-pre8/arch/i386/lib/lib.a \ --end-group \ -o vmlinux net/network.o(.data+0x5f04): undefined reference to `sysctl_ipx_pprop_broadcasting' make: *** [vmlinux] Error 1 [root@bigfoot linux-2.4.3-pre8]# On Tue, 27 Mar 2001, Eran Man wrote: > Date: Tue, 27 Mar 2001 21:43:28 +0200 > From: Eran Man <[EMAIL PROTECTED]> > To: Robert-Velisav MICIOVICI <[EMAIL PROTECTED]> > Cc: [EMAIL PROTECTED] > Subject: [patch] Re: 2.4.3-pre8: IPX not building > > The following patchlet solves it: > > --- linux-2.4.3pre8.orig/net/ipx/af_ipx.c Mon Mar 26 13:17:08 2001 > +++ linux/net/ipx/af_ipx.c Mon Mar 26 13:14:52 2001 > @@ -1542,7 +1542,7 @@ > ipx_offset = intrfc->if_ipx_offset; > size = sizeof(struct ipxhdr) + len + ipx_offset; > > - skb = sock_alloc_send_skb(sk, size, noblock, ); > + skb = sock_alloc_send_skb(sk, size, 0, noblock, ); > if (!skb) > goto out_put; > > @@ -2531,7 +2531,6 @@ > sendmsg:ipx_sendmsg, > recvmsg:ipx_recvmsg, > mmap: sock_no_mmap, > - sendpage: sock_no_sendpage, > }; > > #include > > > Robert-Velisav MICIOVICI wrote: > > > > Hi, > > > > Just a build problem report. > > > > gcc -D__KERNEL__ -I/usr/src/linux-2.4.3-pre8/include -Wall > > -Wstrict-prototypes -O2 -fomit-frame-pointer > > -fno-strict-aliasing -pipe -mpreferred-stack-boundary=2 > > -march=athlon -DMODULE -DMODVERSIONS -include > > /usr/src/linux-2.4.3-pre8/include/linux/modversions.h -c -o > > ip6table_mangle.o ip6table_mangle.c > > gcc -D__KERNEL__ -I/usr/src/linux-2.4.3-pre8/include -Wall > > -Wstrict-prototypes -O2 -fomit-frame-pointer > > -fno-strict-aliasing -pipe -mpreferred-stack-boundary=2 > > -march=athlon -DMODULE -DMODVERSIONS -include > > /usr/src/linux-2.4.3-pre8/include/linux/modversions.h -c -o > > ip6t_MARK.o ip6t_MARK.c > > make[2]: Leaving directory /usr/src/linux-2.4.3-pre8/net/ipv6/netfilter' > > make -C ipx modules > > make[2]: Entering directory /usr/src/linux-2.4.3-pre8/net/ipx' > > gcc -D__KERNEL__ -I/usr/src/linux-2.4.3-pre8/include -Wall > > -Wstrict-prototypes -O2 -fomit-frame-pointer > > -fno-strict-aliasing -pipe -mpreferred-stack-boundary=2 > > -march=athlon -DMODULE -DMODVERSIONS -include > > /usr/src/linux-2.4.3-pre8/include/linux/modversions.h -DEXPORT_SYMTAB > > -c af_ipx.c > > af_ipx.c: In function pxrtr_route_packet': > > af_ipx.c:1545: warning: passing arg 4 of `sock_alloc_send_skb_R7094cf19' > > makes integer from pointer without a cast > > af_ipx.c:1545: too few arguments to function > > `sock_alloc_send_skb_R7094cf19' > > af_ipx.c: At top level: > > af_ipx.c:2534: unknown
Re: [patch] Re: 2.4.3-pre8: IPX not building
Sorry to bother but it seems that the patchlet is still not good enough... problems at linkage or something: O2 -fomit-frame-pointer -fno-strict-aliasing -pipe -mpreferred-stack-boundary=2 -march=athlon -c -o iodebug.o iodebug.c gcc -D__KERNEL__ -I/usr/src/linux-2.4.3-pre8/include -Wall -Wstrict-prototypes -O2 -fomit-frame-pointer -fno-strict-aliasing -pipe -mpreferred-stack-boundary=2 -march=athlon -c -o memcpy.o memcpy.c gcc -D__KERNEL__ -I/usr/src/linux-2.4.3-pre8/include -Wall -Wstrict-prototypes -O2 -fomit-frame-pointer -fno-strict-aliasing -pipe -mpreferred-stack-boundary=2 -march=athlon -c -o mmx.o mmx.c rm -f lib.a ar rcs lib.a checksum.o old-checksum.o delay.o usercopy.o getuser.o putuser.o iodebug.o memcpy.o mmx.o make[2]: Leaving directory `/usr/src/linux-2.4.3-pre8/arch/i386/lib' make[1]: Leaving directory `/usr/src/linux-2.4.3-pre8/arch/i386/lib' ld -m elf_i386 -T /usr/src/linux-2.4.3-pre8/arch/i386/vmlinux.lds -e stext arch/i386/kernel/head.o arch/i386/kernel/init_task.o init/main.o init/version.o \ --start-group \ arch/i386/kernel/kernel.o arch/i386/mm/mm.o kernel/kernel.o mm/mm.o fs/fs.o ipc/ipc.o \ drivers/block/block.o drivers/char/char.o drivers/misc/misc.o drivers/net/net.o drivers/media/media.o drivers/parport/driver.o drivers/char/agp/agp.o drivers/char/drm/drm.o drivers/net/fc/fc.o drivers/net/appletalk/appletalk.o drivers/net/tokenring/tr.o drivers/atm/atm.o drivers/ide/idedriver.o drivers/scsi/scsidrv.o drivers/ieee1394/ieee1394drv.o drivers/cdrom/driver.o drivers/sound/sounddrivers.o drivers/pci/driver.o drivers/pnp/pnp.o drivers/video/video.o drivers/net/hamradio/hamradio.o drivers/i2o/i2o.o drivers/i2c/i2c.o drivers/md/mddev.o \net/network.o \ /usr/src/linux-2.4.3-pre8/arch/i386/lib/lib.a /usr/src/linux-2.4.3-pre8/lib/lib.a /usr/src/linux-2.4.3-pre8/arch/i386/lib/lib.a \ --end-group \ -o vmlinux net/network.o(.data+0x5f04): undefined reference to `sysctl_ipx_pprop_broadcasting' make: *** [vmlinux] Error 1 [root@bigfoot linux-2.4.3-pre8]# On Tue, 27 Mar 2001, Eran Man wrote: Date: Tue, 27 Mar 2001 21:43:28 +0200 From: Eran Man [EMAIL PROTECTED] To: Robert-Velisav MICIOVICI [EMAIL PROTECTED] Cc: [EMAIL PROTECTED] Subject: [patch] Re: 2.4.3-pre8: IPX not building The following patchlet solves it: --- linux-2.4.3pre8.orig/net/ipx/af_ipx.c Mon Mar 26 13:17:08 2001 +++ linux/net/ipx/af_ipx.c Mon Mar 26 13:14:52 2001 @@ -1542,7 +1542,7 @@ ipx_offset = intrfc-if_ipx_offset; size = sizeof(struct ipxhdr) + len + ipx_offset; - skb = sock_alloc_send_skb(sk, size, noblock, err); + skb = sock_alloc_send_skb(sk, size, 0, noblock, err); if (!skb) goto out_put; @@ -2531,7 +2531,6 @@ sendmsg:ipx_sendmsg, recvmsg:ipx_recvmsg, mmap: sock_no_mmap, - sendpage: sock_no_sendpage, }; #include linux/smp_lock.h Robert-Velisav MICIOVICI wrote: Hi, Just a build problem report. gcc -D__KERNEL__ -I/usr/src/linux-2.4.3-pre8/include -Wall -Wstrict-prototypes -O2 -fomit-frame-pointer -fno-strict-aliasing -pipe -mpreferred-stack-boundary=2 -march=athlon -DMODULE -DMODVERSIONS -include /usr/src/linux-2.4.3-pre8/include/linux/modversions.h -c -o ip6table_mangle.o ip6table_mangle.c gcc -D__KERNEL__ -I/usr/src/linux-2.4.3-pre8/include -Wall -Wstrict-prototypes -O2 -fomit-frame-pointer -fno-strict-aliasing -pipe -mpreferred-stack-boundary=2 -march=athlon -DMODULE -DMODVERSIONS -include /usr/src/linux-2.4.3-pre8/include/linux/modversions.h -c -o ip6t_MARK.o ip6t_MARK.c make[2]: Leaving directory /usr/src/linux-2.4.3-pre8/net/ipv6/netfilter' make -C ipx modules make[2]: Entering directory /usr/src/linux-2.4.3-pre8/net/ipx' gcc -D__KERNEL__ -I/usr/src/linux-2.4.3-pre8/include -Wall -Wstrict-prototypes -O2 -fomit-frame-pointer -fno-strict-aliasing -pipe -mpreferred-stack-boundary=2 -march=athlon -DMODULE -DMODVERSIONS -include /usr/src/linux-2.4.3-pre8/include/linux/modversions.h -DEXPORT_SYMTAB -c af_ipx.c af_ipx.c: In function pxrtr_route_packet': af_ipx.c:1545: warning: passing arg 4 of `sock_alloc_send_skb_R7094cf19' makes integer from pointer without a cast af_ipx.c:1545: too few arguments to function `sock_alloc_send_skb_R7094cf19' af_ipx.c: At top level: af_ipx.c:2534: unknown field `sendpage' specified in initializer af_ipx.c:2534: `sock_no_sendpage' undeclared here (not in a function) af_ipx.c:2534: warning: excess elements in struct initializer af_ipx.c:2534: warning: (near initialization forpx_dgram_ops') make[2]: *** [af_ipx.o] Error 1 make[2]: Leaving directory /usr/src/linux-2.4.3-pre8/net/ipx' make[1]: *** [_modsubdir_ipx] Error 2
[patch] Re: 2.4.3-pre8: IPX not building
The following patchlet solves it: --- linux-2.4.3pre8.orig/net/ipx/af_ipx.c Mon Mar 26 13:17:08 2001 +++ linux/net/ipx/af_ipx.c Mon Mar 26 13:14:52 2001 @@ -1542,7 +1542,7 @@ ipx_offset = intrfc->if_ipx_offset; size = sizeof(struct ipxhdr) + len + ipx_offset; - skb = sock_alloc_send_skb(sk, size, noblock, ); + skb = sock_alloc_send_skb(sk, size, 0, noblock, ); if (!skb) goto out_put; @@ -2531,7 +2531,6 @@ sendmsg:ipx_sendmsg, recvmsg:ipx_recvmsg, mmap: sock_no_mmap, - sendpage: sock_no_sendpage, }; #include Robert-Velisav MICIOVICI wrote: > > Hi, > > Just a build problem report. > > gcc -D__KERNEL__ -I/usr/src/linux-2.4.3-pre8/include -Wall > -Wstrict-prototypes -O2 -fomit-frame-pointer > -fno-strict-aliasing -pipe -mpreferred-stack-boundary=2 > -march=athlon -DMODULE -DMODVERSIONS -include > /usr/src/linux-2.4.3-pre8/include/linux/modversions.h -c -o > ip6table_mangle.o ip6table_mangle.c > gcc -D__KERNEL__ -I/usr/src/linux-2.4.3-pre8/include -Wall > -Wstrict-prototypes -O2 -fomit-frame-pointer > -fno-strict-aliasing -pipe -mpreferred-stack-boundary=2 > -march=athlon -DMODULE -DMODVERSIONS -include > /usr/src/linux-2.4.3-pre8/include/linux/modversions.h -c -o > ip6t_MARK.o ip6t_MARK.c > make[2]: Leaving directory /usr/src/linux-2.4.3-pre8/net/ipv6/netfilter' > make -C ipx modules > make[2]: Entering directory /usr/src/linux-2.4.3-pre8/net/ipx' > gcc -D__KERNEL__ -I/usr/src/linux-2.4.3-pre8/include -Wall > -Wstrict-prototypes -O2 -fomit-frame-pointer > -fno-strict-aliasing -pipe -mpreferred-stack-boundary=2 > -march=athlon -DMODULE -DMODVERSIONS -include > /usr/src/linux-2.4.3-pre8/include/linux/modversions.h -DEXPORT_SYMTAB > -c af_ipx.c > af_ipx.c: In function pxrtr_route_packet': > af_ipx.c:1545: warning: passing arg 4 of `sock_alloc_send_skb_R7094cf19' > makes integer from pointer without a cast > af_ipx.c:1545: too few arguments to function > `sock_alloc_send_skb_R7094cf19' > af_ipx.c: At top level: > af_ipx.c:2534: unknown field `sendpage' specified in initializer > af_ipx.c:2534: `sock_no_sendpage' undeclared here (not in a function) > af_ipx.c:2534: warning: excess elements in struct initializer > af_ipx.c:2534: warning: (near initialization forpx_dgram_ops') > make[2]: *** [af_ipx.o] Error 1 > make[2]: Leaving directory /usr/src/linux-2.4.3-pre8/net/ipx' > make[1]: *** [_modsubdir_ipx] Error 2 > make[1]: Leaving directory /usr/src/linux-2.4.3-pre8/net' > make: *** [_mod_net] Error 2 > [root@bigfoot linux-2.4.3-pre8]# > > Best regards to you kernel-wizzards! > > - > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to [EMAIL PROTECTED] > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[patch] Re: 2.4.3-pre8: IPX not building
The following patchlet solves it: --- linux-2.4.3pre8.orig/net/ipx/af_ipx.c Mon Mar 26 13:17:08 2001 +++ linux/net/ipx/af_ipx.c Mon Mar 26 13:14:52 2001 @@ -1542,7 +1542,7 @@ ipx_offset = intrfc-if_ipx_offset; size = sizeof(struct ipxhdr) + len + ipx_offset; - skb = sock_alloc_send_skb(sk, size, noblock, err); + skb = sock_alloc_send_skb(sk, size, 0, noblock, err); if (!skb) goto out_put; @@ -2531,7 +2531,6 @@ sendmsg:ipx_sendmsg, recvmsg:ipx_recvmsg, mmap: sock_no_mmap, - sendpage: sock_no_sendpage, }; #include linux/smp_lock.h Robert-Velisav MICIOVICI wrote: Hi, Just a build problem report. gcc -D__KERNEL__ -I/usr/src/linux-2.4.3-pre8/include -Wall -Wstrict-prototypes -O2 -fomit-frame-pointer -fno-strict-aliasing -pipe -mpreferred-stack-boundary=2 -march=athlon -DMODULE -DMODVERSIONS -include /usr/src/linux-2.4.3-pre8/include/linux/modversions.h -c -o ip6table_mangle.o ip6table_mangle.c gcc -D__KERNEL__ -I/usr/src/linux-2.4.3-pre8/include -Wall -Wstrict-prototypes -O2 -fomit-frame-pointer -fno-strict-aliasing -pipe -mpreferred-stack-boundary=2 -march=athlon -DMODULE -DMODVERSIONS -include /usr/src/linux-2.4.3-pre8/include/linux/modversions.h -c -o ip6t_MARK.o ip6t_MARK.c make[2]: Leaving directory /usr/src/linux-2.4.3-pre8/net/ipv6/netfilter' make -C ipx modules make[2]: Entering directory /usr/src/linux-2.4.3-pre8/net/ipx' gcc -D__KERNEL__ -I/usr/src/linux-2.4.3-pre8/include -Wall -Wstrict-prototypes -O2 -fomit-frame-pointer -fno-strict-aliasing -pipe -mpreferred-stack-boundary=2 -march=athlon -DMODULE -DMODVERSIONS -include /usr/src/linux-2.4.3-pre8/include/linux/modversions.h -DEXPORT_SYMTAB -c af_ipx.c af_ipx.c: In function pxrtr_route_packet': af_ipx.c:1545: warning: passing arg 4 of `sock_alloc_send_skb_R7094cf19' makes integer from pointer without a cast af_ipx.c:1545: too few arguments to function `sock_alloc_send_skb_R7094cf19' af_ipx.c: At top level: af_ipx.c:2534: unknown field `sendpage' specified in initializer af_ipx.c:2534: `sock_no_sendpage' undeclared here (not in a function) af_ipx.c:2534: warning: excess elements in struct initializer af_ipx.c:2534: warning: (near initialization forpx_dgram_ops') make[2]: *** [af_ipx.o] Error 1 make[2]: Leaving directory /usr/src/linux-2.4.3-pre8/net/ipx' make[1]: *** [_modsubdir_ipx] Error 2 make[1]: Leaving directory /usr/src/linux-2.4.3-pre8/net' make: *** [_mod_net] Error 2 [root@bigfoot linux-2.4.3-pre8]# Best regards to you kernel-wizzards! - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
