Re: [patch] dac960: return success instead of -ENOTTY
On 2013-01-11 07:52, Dan Carpenter wrote: > There is a missing break statement here. This used to return directly > but we re-worked it in 2008 to add locking as part of the BKL push down. Thanks Dan, applied. Must have a big user base... -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [patch] dac960: return success instead of -ENOTTY
On 2013-01-11 07:52, Dan Carpenter wrote: There is a missing break statement here. This used to return directly but we re-worked it in 2008 to add locking as part of the BKL push down. Thanks Dan, applied. Must have a big user base... -- Jens Axboe -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[patch] dac960: return success instead of -ENOTTY
There is a missing break statement here. This used to return directly but we re-worked it in 2008 to add locking as part of the BKL push down. Signed-off-by: Dan Carpenter diff --git a/drivers/block/DAC960.c b/drivers/block/DAC960.c index 9a13e88..0d3ffc5 100644 --- a/drivers/block/DAC960.c +++ b/drivers/block/DAC960.c @@ -7054,6 +7054,7 @@ static long DAC960_gam_ioctl(struct file *file, unsigned int Request, else ErrorCode = 0; } + break; default: ErrorCode = -ENOTTY; } -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[patch] dac960: return success instead of -ENOTTY
There is a missing break statement here. This used to return directly but we re-worked it in 2008 to add locking as part of the BKL push down. Signed-off-by: Dan Carpenter dan.carpen...@oracle.com diff --git a/drivers/block/DAC960.c b/drivers/block/DAC960.c index 9a13e88..0d3ffc5 100644 --- a/drivers/block/DAC960.c +++ b/drivers/block/DAC960.c @@ -7054,6 +7054,7 @@ static long DAC960_gam_ioctl(struct file *file, unsigned int Request, else ErrorCode = 0; } + break; default: ErrorCode = -ENOTTY; } -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
