Re: [patch] ibft: add a missing break statement
On Fri, Jan 11, 2013 at 09:48:07AM +0300, Dan Carpenter wrote: > The code works the same with or without the break. It just looks a bit > cleaner to not fall through. Yeah, you're clearly right. For those reading this, so you don't have to go check yourselves, the line after the end of this diff is also a break; there's no further code in that case. > Signed-off-by: Dan Carpenter Acked-by: Peter Jones > > diff --git a/drivers/firmware/iscsi_ibft.c b/drivers/firmware/iscsi_ibft.c > index 3ee852c..c4b187c 100644 > --- a/drivers/firmware/iscsi_ibft.c > +++ b/drivers/firmware/iscsi_ibft.c > @@ -503,6 +503,7 @@ static umode_t __init ibft_check_tgt_for(void *data, int > type) > case ISCSI_BOOT_TGT_NIC_ASSOC: > case ISCSI_BOOT_TGT_CHAP_TYPE: > rc = S_IRUGO; > + break; > case ISCSI_BOOT_TGT_NAME: > if (tgt->tgt_name_len) > rc = S_IRUGO; -- Peter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [patch] ibft: add a missing break statement
On Fri, Jan 11, 2013 at 09:48:07AM +0300, Dan Carpenter wrote: The code works the same with or without the break. It just looks a bit cleaner to not fall through. Yeah, you're clearly right. For those reading this, so you don't have to go check yourselves, the line after the end of this diff is also a break; there's no further code in that case. Signed-off-by: Dan Carpenter dan.carpen...@oracle.com Acked-by: Peter Jones pjo...@redhat.com diff --git a/drivers/firmware/iscsi_ibft.c b/drivers/firmware/iscsi_ibft.c index 3ee852c..c4b187c 100644 --- a/drivers/firmware/iscsi_ibft.c +++ b/drivers/firmware/iscsi_ibft.c @@ -503,6 +503,7 @@ static umode_t __init ibft_check_tgt_for(void *data, int type) case ISCSI_BOOT_TGT_NIC_ASSOC: case ISCSI_BOOT_TGT_CHAP_TYPE: rc = S_IRUGO; + break; case ISCSI_BOOT_TGT_NAME: if (tgt-tgt_name_len) rc = S_IRUGO; -- Peter -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[patch] ibft: add a missing break statement
The code works the same with or without the break. It just looks a bit cleaner to not fall through. Signed-off-by: Dan Carpenter diff --git a/drivers/firmware/iscsi_ibft.c b/drivers/firmware/iscsi_ibft.c index 3ee852c..c4b187c 100644 --- a/drivers/firmware/iscsi_ibft.c +++ b/drivers/firmware/iscsi_ibft.c @@ -503,6 +503,7 @@ static umode_t __init ibft_check_tgt_for(void *data, int type) case ISCSI_BOOT_TGT_NIC_ASSOC: case ISCSI_BOOT_TGT_CHAP_TYPE: rc = S_IRUGO; + break; case ISCSI_BOOT_TGT_NAME: if (tgt->tgt_name_len) rc = S_IRUGO; -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[patch] ibft: add a missing break statement
The code works the same with or without the break. It just looks a bit cleaner to not fall through. Signed-off-by: Dan Carpenter dan.carpen...@oracle.com diff --git a/drivers/firmware/iscsi_ibft.c b/drivers/firmware/iscsi_ibft.c index 3ee852c..c4b187c 100644 --- a/drivers/firmware/iscsi_ibft.c +++ b/drivers/firmware/iscsi_ibft.c @@ -503,6 +503,7 @@ static umode_t __init ibft_check_tgt_for(void *data, int type) case ISCSI_BOOT_TGT_NIC_ASSOC: case ISCSI_BOOT_TGT_CHAP_TYPE: rc = S_IRUGO; + break; case ISCSI_BOOT_TGT_NAME: if (tgt-tgt_name_len) rc = S_IRUGO; -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
