Re: [patch] opt the sky2 driver into using extended config space

[Stephen Hemminger]

On Sat, 22 Dec 2007 04:35:59 -0800
Arjan van de Ven <[EMAIL PROTECTED]> wrote:

> From: Arjan van de Ven <[EMAIL PROTECTED]>
> Subject: opt the sky2 driver into using extended config space
> 
> So far, the sky2 driver is the only one I've identified (with a quick grep)
> that actually would be using extended configuration space; the patch below
> adds the enablement of this to the driver.
> 
> Signed-off-by: Arjan van de Ven <[EMAIL PROTECTED]>
> CC: [EMAIL PROTECTED]

Current driver uses the drivers memory map access to PCI config space
to avoid all the extra config space access issues. So this patch is not needed.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[patch] opt the sky2 driver into using extended config space

[Arjan van de Ven]

From: Arjan van de Ven <[EMAIL PROTECTED]>
Subject: opt the sky2 driver into using extended config space

So far, the sky2 driver is the only one I've identified (with a quick grep)
that actually would be using extended configuration space; the patch below
adds the enablement of this to the driver.

Signed-off-by: Arjan van de Ven <[EMAIL PROTECTED]>
CC: [EMAIL PROTECTED]


Index: linux-2.6.24-rc5/drivers/net/sky2.c
===
--- linux-2.6.24-rc5.orig/drivers/net/sky2.c
+++ linux-2.6.24-rc5/drivers/net/sky2.c
@@ -4111,6 +4111,11 @@ static int __devinit sky2_probe(struct p
goto err_out;
}
 
+   /*
+* enable extended config space to enable AER
+*/
+   pci_enable_ext_config(pdev);
+
err = pci_request_regions(pdev, DRV_NAME);
if (err) {
dev_err(&pdev->dev, "cannot obtain PCI resources\n");
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/