Re: [patch] pinctrl: abx500: fix some more bitwise AND tests

2013-11-18 Thread Linus Walleij
On Sun, Nov 10, 2013 at 12:35 AM, Dan Carpenter
 wrote:

> I sent a patch to fix some bitwise AND tests but I guess I missed some.
> Sorry about that.
>
> Signed-off-by: Dan Carpenter 

Patch applied for fixes, thanks!

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [patch] pinctrl: abx500: fix some more bitwise AND tests

2013-11-18 Thread Linus Walleij
On Sun, Nov 10, 2013 at 12:35 AM, Dan Carpenter
dan.carpen...@oracle.com wrote:

 I sent a patch to fix some bitwise AND tests but I guess I missed some.
 Sorry about that.

 Signed-off-by: Dan Carpenter dan.carpen...@oracle.com

Patch applied for fixes, thanks!

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


[patch] pinctrl: abx500: fix some more bitwise AND tests

2013-11-09 Thread Dan Carpenter
I sent a patch to fix some bitwise AND tests but I guess I missed some.
Sorry about that.

Signed-off-by: Dan Carpenter 

diff --git a/drivers/pinctrl/pinctrl-abx500.c b/drivers/pinctrl/pinctrl-abx500.c
index 4780959..5183e7bb 100644
--- a/drivers/pinctrl/pinctrl-abx500.c
+++ b/drivers/pinctrl/pinctrl-abx500.c
@@ -418,7 +418,7 @@ static int abx500_set_mode(struct pinctrl_dev *pctldev, 
struct gpio_chip *chip,
ret = abx500_gpio_set_bits(chip,
AB8500_GPIO_ALTFUN_REG,
af.alt_bit1,
-   !!(af.alta_val && BIT(0)));
+   !!(af.alta_val & BIT(0)));
if (ret < 0)
goto out;
 
@@ -439,7 +439,7 @@ static int abx500_set_mode(struct pinctrl_dev *pctldev, 
struct gpio_chip *chip,
goto out;
 
ret = abx500_gpio_set_bits(chip, AB8500_GPIO_ALTFUN_REG,
-   af.alt_bit1, !!(af.altb_val && BIT(0)));
+   af.alt_bit1, !!(af.altb_val & BIT(0)));
if (ret < 0)
goto out;
 
@@ -462,7 +462,7 @@ static int abx500_set_mode(struct pinctrl_dev *pctldev, 
struct gpio_chip *chip,
goto out;
 
ret = abx500_gpio_set_bits(chip, AB8500_GPIO_ALTFUN_REG,
-   af.alt_bit2, !!(af.altc_val && BIT(1)));
+   af.alt_bit2, !!(af.altc_val & BIT(1)));
break;
 
default:
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


[patch] pinctrl: abx500: fix some more bitwise AND tests

2013-11-09 Thread Dan Carpenter
I sent a patch to fix some bitwise AND tests but I guess I missed some.
Sorry about that.

Signed-off-by: Dan Carpenter dan.carpen...@oracle.com

diff --git a/drivers/pinctrl/pinctrl-abx500.c b/drivers/pinctrl/pinctrl-abx500.c
index 4780959..5183e7bb 100644
--- a/drivers/pinctrl/pinctrl-abx500.c
+++ b/drivers/pinctrl/pinctrl-abx500.c
@@ -418,7 +418,7 @@ static int abx500_set_mode(struct pinctrl_dev *pctldev, 
struct gpio_chip *chip,
ret = abx500_gpio_set_bits(chip,
AB8500_GPIO_ALTFUN_REG,
af.alt_bit1,
-   !!(af.alta_val  BIT(0)));
+   !!(af.alta_val  BIT(0)));
if (ret  0)
goto out;
 
@@ -439,7 +439,7 @@ static int abx500_set_mode(struct pinctrl_dev *pctldev, 
struct gpio_chip *chip,
goto out;
 
ret = abx500_gpio_set_bits(chip, AB8500_GPIO_ALTFUN_REG,
-   af.alt_bit1, !!(af.altb_val  BIT(0)));
+   af.alt_bit1, !!(af.altb_val  BIT(0)));
if (ret  0)
goto out;
 
@@ -462,7 +462,7 @@ static int abx500_set_mode(struct pinctrl_dev *pctldev, 
struct gpio_chip *chip,
goto out;
 
ret = abx500_gpio_set_bits(chip, AB8500_GPIO_ALTFUN_REG,
-   af.alt_bit2, !!(af.altc_val  BIT(1)));
+   af.alt_bit2, !!(af.altc_val  BIT(1)));
break;
 
default:
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/