Re: [patch] w1: silence an uninitialized variable warning
Hi Dan 14.04.2016, 12:36, "Dan Carpenter": > If kstrtoint() returns -ERANGE then "tmp" is uninitialized. Looks good to me, please pull it into janitors tree > Signed-off-by: Dan Carpenter Acked-by: Evgeniy Polaykov > diff --git a/drivers/w1/w1.c b/drivers/w1/w1.c > index 89a7847..bb34362 100644 > --- a/drivers/w1/w1.c > +++ b/drivers/w1/w1.c > @@ -335,7 +335,7 @@ static ssize_t > w1_master_attribute_store_max_slave_count(struct device *dev, > int tmp; > struct w1_master *md = dev_to_w1_master(dev); > > - if (kstrtoint(buf, 0, ) == -EINVAL || tmp < 1) > + if (kstrtoint(buf, 0, ) || tmp < 1) > return -EINVAL; > > mutex_lock(>mutex);
Re: [patch] w1: silence an uninitialized variable warning
Hi Dan 14.04.2016, 12:36, "Dan Carpenter" : > If kstrtoint() returns -ERANGE then "tmp" is uninitialized. Looks good to me, please pull it into janitors tree > Signed-off-by: Dan Carpenter Acked-by: Evgeniy Polaykov > diff --git a/drivers/w1/w1.c b/drivers/w1/w1.c > index 89a7847..bb34362 100644 > --- a/drivers/w1/w1.c > +++ b/drivers/w1/w1.c > @@ -335,7 +335,7 @@ static ssize_t > w1_master_attribute_store_max_slave_count(struct device *dev, > int tmp; > struct w1_master *md = dev_to_w1_master(dev); > > - if (kstrtoint(buf, 0, ) == -EINVAL || tmp < 1) > + if (kstrtoint(buf, 0, ) || tmp < 1) > return -EINVAL; > > mutex_lock(>mutex);
[patch] w1: silence an uninitialized variable warning
If kstrtoint() returns -ERANGE then "tmp" is uninitialized. Signed-off-by: Dan Carpenterdiff --git a/drivers/w1/w1.c b/drivers/w1/w1.c index 89a7847..bb34362 100644 --- a/drivers/w1/w1.c +++ b/drivers/w1/w1.c @@ -335,7 +335,7 @@ static ssize_t w1_master_attribute_store_max_slave_count(struct device *dev, int tmp; struct w1_master *md = dev_to_w1_master(dev); - if (kstrtoint(buf, 0, ) == -EINVAL || tmp < 1) + if (kstrtoint(buf, 0, ) || tmp < 1) return -EINVAL; mutex_lock(>mutex);
[patch] w1: silence an uninitialized variable warning
If kstrtoint() returns -ERANGE then "tmp" is uninitialized. Signed-off-by: Dan Carpenter diff --git a/drivers/w1/w1.c b/drivers/w1/w1.c index 89a7847..bb34362 100644 --- a/drivers/w1/w1.c +++ b/drivers/w1/w1.c @@ -335,7 +335,7 @@ static ssize_t w1_master_attribute_store_max_slave_count(struct device *dev, int tmp; struct w1_master *md = dev_to_w1_master(dev); - if (kstrtoint(buf, 0, ) == -EINVAL || tmp < 1) + if (kstrtoint(buf, 0, ) || tmp < 1) return -EINVAL; mutex_lock(>mutex);