Re: [patch 03/54] NOHZ: Rate limit the local softirq pending warning output
On Fri, 2007-06-08 at 12:34 +0200, Daniel Thaler wrote: > Chris Wright wrote: > > -stable review patch. If anyone has any objections, please let us know. > > - > > > > From: Thomas Gleixner <[EMAIL PROTECTED]> > > > > The warning in the NOHZ code, which triggers when a CPU goes idle with > > softirqs pending can fill up the logs quite quickly. Rate limit the output > > until we found the root cause of that problem. > > Isn't the root cause found and fixed with "[patch 09/54] Prevent going > idle with softirq pending"? Yes, still we want the printk there to find places, which go into idle with softirqs pending. There is at least one problem in the SLIP code, which triggers this. OTOH we do not want those messages to flood the syslog. tglx - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [patch 03/54] NOHZ: Rate limit the local softirq pending warning output
Chris Wright wrote: > -stable review patch. If anyone has any objections, please let us know. > - > > From: Thomas Gleixner <[EMAIL PROTECTED]> > > The warning in the NOHZ code, which triggers when a CPU goes idle with > softirqs pending can fill up the logs quite quickly. Rate limit the output > until we found the root cause of that problem. Isn't the root cause found and fixed with "[patch 09/54] Prevent going idle with softirq pending"? - Daniel - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[patch 03/54] NOHZ: Rate limit the local softirq pending warning output
-stable review patch. If anyone has any objections, please let us know.
-
From: Thomas Gleixner <[EMAIL PROTECTED]>
The warning in the NOHZ code, which triggers when a CPU goes idle with
softirqs pending can fill up the logs quite quickly. Rate limit the output
until we found the root cause of that problem.
Signed-off-by: Thomas Gleixner <[EMAIL PROTECTED]>
Signed-off-by: Andrew Morton <[EMAIL PROTECTED]>
Signed-off-by: Chris Wright <[EMAIL PROTECTED]>
Signed-off-by: Greg Kroah-Hartman <[EMAIL PROTECTED]>
---
kernel/time/tick-sched.c | 12 +---
1 file changed, 9 insertions(+), 3 deletions(-)
--- linux-2.6.21.4.orig/kernel/time/tick-sched.c
+++ linux-2.6.21.4/kernel/time/tick-sched.c
@@ -167,9 +167,15 @@ void tick_nohz_stop_sched_tick(void)
goto end;
cpu = smp_processor_id();
- if (unlikely(local_softirq_pending()))
- printk(KERN_ERR "NOHZ: local_softirq_pending %02x\n",
- local_softirq_pending());
+ if (unlikely(local_softirq_pending())) {
+ static int ratelimit;
+
+ if (ratelimit < 10) {
+ printk(KERN_ERR "NOHZ: local_softirq_pending %02x\n",
+ local_softirq_pending());
+ ratelimit++;
+ }
+ }
now = ktime_get();
/*
--
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[patch 03/54] NOHZ: Rate limit the local softirq pending warning output
-stable review patch. If anyone has any objections, please let us know.
-
From: Thomas Gleixner [EMAIL PROTECTED]
The warning in the NOHZ code, which triggers when a CPU goes idle with
softirqs pending can fill up the logs quite quickly. Rate limit the output
until we found the root cause of that problem.
Signed-off-by: Thomas Gleixner [EMAIL PROTECTED]
Signed-off-by: Andrew Morton [EMAIL PROTECTED]
Signed-off-by: Chris Wright [EMAIL PROTECTED]
Signed-off-by: Greg Kroah-Hartman [EMAIL PROTECTED]
---
kernel/time/tick-sched.c | 12 +---
1 file changed, 9 insertions(+), 3 deletions(-)
--- linux-2.6.21.4.orig/kernel/time/tick-sched.c
+++ linux-2.6.21.4/kernel/time/tick-sched.c
@@ -167,9 +167,15 @@ void tick_nohz_stop_sched_tick(void)
goto end;
cpu = smp_processor_id();
- if (unlikely(local_softirq_pending()))
- printk(KERN_ERR NOHZ: local_softirq_pending %02x\n,
- local_softirq_pending());
+ if (unlikely(local_softirq_pending())) {
+ static int ratelimit;
+
+ if (ratelimit 10) {
+ printk(KERN_ERR NOHZ: local_softirq_pending %02x\n,
+ local_softirq_pending());
+ ratelimit++;
+ }
+ }
now = ktime_get();
/*
--
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [patch 03/54] NOHZ: Rate limit the local softirq pending warning output
Chris Wright wrote: -stable review patch. If anyone has any objections, please let us know. - From: Thomas Gleixner [EMAIL PROTECTED] The warning in the NOHZ code, which triggers when a CPU goes idle with softirqs pending can fill up the logs quite quickly. Rate limit the output until we found the root cause of that problem. Isn't the root cause found and fixed with [patch 09/54] Prevent going idle with softirq pending? - Daniel - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [patch 03/54] NOHZ: Rate limit the local softirq pending warning output
On Fri, 2007-06-08 at 12:34 +0200, Daniel Thaler wrote: Chris Wright wrote: -stable review patch. If anyone has any objections, please let us know. - From: Thomas Gleixner [EMAIL PROTECTED] The warning in the NOHZ code, which triggers when a CPU goes idle with softirqs pending can fill up the logs quite quickly. Rate limit the output until we found the root cause of that problem. Isn't the root cause found and fixed with [patch 09/54] Prevent going idle with softirq pending? Yes, still we want the printk there to find places, which go into idle with softirqs pending. There is at least one problem in the SLIP code, which triggers this. OTOH we do not want those messages to flood the syslog. tglx - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
