Re: [patch 1/1] Audit return code of create_proc_*
Hi Domen,
On Friday 15 July 2005 00:19, you wrote:
> Audit return of create_proc_* functions.
This (and related changes) spam the log, if
kernel is compiled without /proc-support.
Kernels without /proc-support are quite common in the embedded world.
Just provide a function in a suitable header
(include/linux/proc_fs.h looks promising)
file, which contains the following:
#ifdef CONFIG_PROC_FS
#define procfs_failure(msg) do { printk(msg); } while(0)
#else
#define procfs_failure(msg) do {} while(0)
#endif
and use it instead of the direct printk call.
That way you get both: Your GCC or checking tool warning is silenced
and the log is not spammed for the embedded people.
For code, which is broken without procfs, the code
should be fixed or it should select PROC_FS in its Kconfig file.
Regards
Ingo Oeser
pgp4s9qFpX6R1.pgp
Description: PGP signature
Re: [patch 1/1] Audit return code of create_proc_*
Hi Domen,
On Friday 15 July 2005 00:19, you wrote:
Audit return of create_proc_* functions.
This (and related changes) spam the log, if
kernel is compiled without /proc-support.
Kernels without /proc-support are quite common in the embedded world.
Just provide a function in a suitable header
(include/linux/proc_fs.h looks promising)
file, which contains the following:
#ifdef CONFIG_PROC_FS
#define procfs_failure(msg) do { printk(msg); } while(0)
#else
#define procfs_failure(msg) do {} while(0)
#endif
and use it instead of the direct printk call.
That way you get both: Your GCC or checking tool warning is silenced
and the log is not spammed for the embedded people.
For code, which is broken without procfs, the code
should be fixed or it should select PROC_FS in its Kconfig file.
Regards
Ingo Oeser
pgp4s9qFpX6R1.pgp
Description: PGP signature
[patch 1/1] Audit return code of create_proc_*
From: Christophe Lucas <[EMAIL PROTECTED]>
Audit return of create_proc_* functions.
Signed-off-by: Christophe Lucas <[EMAIL PROTECTED]>
Signed-off-by: Domen Puncer <[EMAIL PROTECTED]>
---
ecard.c | 11 +--
1 files changed, 9 insertions(+), 2 deletions(-)
Index: quilt/arch/arm26/kernel/ecard.c
===
--- quilt.orig/arch/arm26/kernel/ecard.c
+++ quilt/arch/arm26/kernel/ecard.c
@@ -522,9 +522,16 @@ static struct proc_dir_entry *proc_bus_e
static void ecard_proc_init(void)
{
+ struct proc_dir_entry *proc_entry;
proc_bus_ecard_dir = proc_mkdir("ecard", proc_bus);
- create_proc_info_entry("devices", 0, proc_bus_ecard_dir,
- get_ecard_dev_info);
+ if (!proc_bus_ecard_dir)
+ printk(KERN_WARNING "Unable to create proc dir entry.\n");
+ else {
+ proc_entry = create_proc_info_entry("devices", 0,
+ proc_bus_ecard_dir, get_ecard_dev_info);
+ if (!proc_entry)
+ printk(KERN_WARNING "ecard: Unable to create proc
entry\n");
+ }
}
#define ec_set_resource(ec,nr,st,sz,flg) \
--
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[patch 1/1] Audit return code of create_proc_*
From: Christophe Lucas [EMAIL PROTECTED]
Audit return of create_proc_* functions.
Signed-off-by: Christophe Lucas [EMAIL PROTECTED]
Signed-off-by: Domen Puncer [EMAIL PROTECTED]
---
ecard.c | 11 +--
1 files changed, 9 insertions(+), 2 deletions(-)
Index: quilt/arch/arm26/kernel/ecard.c
===
--- quilt.orig/arch/arm26/kernel/ecard.c
+++ quilt/arch/arm26/kernel/ecard.c
@@ -522,9 +522,16 @@ static struct proc_dir_entry *proc_bus_e
static void ecard_proc_init(void)
{
+ struct proc_dir_entry *proc_entry;
proc_bus_ecard_dir = proc_mkdir(ecard, proc_bus);
- create_proc_info_entry(devices, 0, proc_bus_ecard_dir,
- get_ecard_dev_info);
+ if (!proc_bus_ecard_dir)
+ printk(KERN_WARNING Unable to create proc dir entry.\n);
+ else {
+ proc_entry = create_proc_info_entry(devices, 0,
+ proc_bus_ecard_dir, get_ecard_dev_info);
+ if (!proc_entry)
+ printk(KERN_WARNING ecard: Unable to create proc
entry\n);
+ }
}
#define ec_set_resource(ec,nr,st,sz,flg) \
--
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
