[patch 22/23] mac80211: only honor IW_SCAN_THIS_ESSID in STA, IBSS, and AP modes

2007-11-14 Thread Greg KH
-stable review patch.  If anyone has any objections, please let us know.

--


From: John W. Linville <[EMAIL PROTECTED]>

patch d114f399b4da6fa7f9da3bbf1fb841370c11e788 in mainline.

The previous IW_SCAN_THIS_ESSID patch left a hole allowing scan
requests on interfaces in inappropriate modes.

Signed-off-by: John W. Linville <[EMAIL PROTECTED]>
Signed-off-by: David S. Miller <[EMAIL PROTECTED]>
Signed-off-by: Greg Kroah-Hartman <[EMAIL PROTECTED]>

---
 net/mac80211/ieee80211_ioctl.c |   37 +++--
 1 file changed, 19 insertions(+), 18 deletions(-)

--- a/net/mac80211/ieee80211_ioctl.c
+++ b/net/mac80211/ieee80211_ioctl.c
@@ -698,29 +698,30 @@ static int ieee80211_ioctl_siwscan(struc
if (!netif_running(dev))
return -ENETDOWN;
 
+   switch (sdata->type) {
+   case IEEE80211_IF_TYPE_STA:
+   case IEEE80211_IF_TYPE_IBSS:
+   if (local->scan_flags & IEEE80211_SCAN_MATCH_SSID) {
+   ssid = sdata->u.sta.ssid;
+   ssid_len = sdata->u.sta.ssid_len;
+   }
+   break;
+   case IEEE80211_IF_TYPE_AP:
+   if (local->scan_flags & IEEE80211_SCAN_MATCH_SSID) {
+   ssid = sdata->u.ap.ssid;
+   ssid_len = sdata->u.ap.ssid_len;
+   }
+   break;
+   default:
+   return -EOPNOTSUPP;
+   }
+
+   /* if SSID was specified explicitly then use that */
if (wrqu->data.length == sizeof(struct iw_scan_req) &&
wrqu->data.flags & IW_SCAN_THIS_ESSID) {
req = (struct iw_scan_req *)extra;
ssid = req->essid;
ssid_len = req->essid_len;
-   } else {
-   switch (sdata->type) {
-   case IEEE80211_IF_TYPE_STA:
-   case IEEE80211_IF_TYPE_IBSS:
-   if (local->scan_flags & IEEE80211_SCAN_MATCH_SSID) {
-   ssid = sdata->u.sta.ssid;
-   ssid_len = sdata->u.sta.ssid_len;
-   }
-   break;
-   case IEEE80211_IF_TYPE_AP:
-   if (local->scan_flags & IEEE80211_SCAN_MATCH_SSID) {
-   ssid = sdata->u.ap.ssid;
-   ssid_len = sdata->u.ap.ssid_len;
-   }
-   break;
-   default:
-   return -EOPNOTSUPP;
-   }
}
 
return ieee80211_sta_req_scan(dev, ssid, ssid_len);

-- 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


[patch 22/23] mac80211: only honor IW_SCAN_THIS_ESSID in STA, IBSS, and AP modes

2007-11-14 Thread Greg KH
-stable review patch.  If anyone has any objections, please let us know.

--


From: John W. Linville [EMAIL PROTECTED]

patch d114f399b4da6fa7f9da3bbf1fb841370c11e788 in mainline.

The previous IW_SCAN_THIS_ESSID patch left a hole allowing scan
requests on interfaces in inappropriate modes.

Signed-off-by: John W. Linville [EMAIL PROTECTED]
Signed-off-by: David S. Miller [EMAIL PROTECTED]
Signed-off-by: Greg Kroah-Hartman [EMAIL PROTECTED]

---
 net/mac80211/ieee80211_ioctl.c |   37 +++--
 1 file changed, 19 insertions(+), 18 deletions(-)

--- a/net/mac80211/ieee80211_ioctl.c
+++ b/net/mac80211/ieee80211_ioctl.c
@@ -698,29 +698,30 @@ static int ieee80211_ioctl_siwscan(struc
if (!netif_running(dev))
return -ENETDOWN;
 
+   switch (sdata-type) {
+   case IEEE80211_IF_TYPE_STA:
+   case IEEE80211_IF_TYPE_IBSS:
+   if (local-scan_flags  IEEE80211_SCAN_MATCH_SSID) {
+   ssid = sdata-u.sta.ssid;
+   ssid_len = sdata-u.sta.ssid_len;
+   }
+   break;
+   case IEEE80211_IF_TYPE_AP:
+   if (local-scan_flags  IEEE80211_SCAN_MATCH_SSID) {
+   ssid = sdata-u.ap.ssid;
+   ssid_len = sdata-u.ap.ssid_len;
+   }
+   break;
+   default:
+   return -EOPNOTSUPP;
+   }
+
+   /* if SSID was specified explicitly then use that */
if (wrqu-data.length == sizeof(struct iw_scan_req) 
wrqu-data.flags  IW_SCAN_THIS_ESSID) {
req = (struct iw_scan_req *)extra;
ssid = req-essid;
ssid_len = req-essid_len;
-   } else {
-   switch (sdata-type) {
-   case IEEE80211_IF_TYPE_STA:
-   case IEEE80211_IF_TYPE_IBSS:
-   if (local-scan_flags  IEEE80211_SCAN_MATCH_SSID) {
-   ssid = sdata-u.sta.ssid;
-   ssid_len = sdata-u.sta.ssid_len;
-   }
-   break;
-   case IEEE80211_IF_TYPE_AP:
-   if (local-scan_flags  IEEE80211_SCAN_MATCH_SSID) {
-   ssid = sdata-u.ap.ssid;
-   ssid_len = sdata-u.ap.ssid_len;
-   }
-   break;
-   default:
-   return -EOPNOTSUPP;
-   }
}
 
return ieee80211_sta_req_scan(dev, ssid, ssid_len);

-- 
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/