Re: [tcp] 9d9b1ee0b2: packetdrill.packetdrill/gtests/net/tcp/user_timeout/user-timeout-probe_ipv4-mapped-v6.fail
On Thu, Feb 25, 2021 at 9:06 AM Oliver Sang wrote:
>
> Hi, Neal,
>
> On Wed, Feb 24, 2021 at 10:13:02PM +0800, Oliver Sang wrote:
> > Hi, Neal,
> >
> > On Fri, Feb 19, 2021 at 09:52:04AM -0500, Neal Cardwell wrote:
> > > On Thu, Feb 18, 2021 at 8:33 PM kernel test robot
> > > wrote:
> > > >
> > > >
> > > > Greeting,
> > > >
> > > > FYI, we noticed the following commit (built with gcc-9):
> > > >
> > > > commit: 9d9b1ee0b2d1c9e02b2338c4a4b0a062d2d3edac ("tcp: fix
> > > > TCP_USER_TIMEOUT with zero window")
> > > > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git master
> > >
> > > I have pushed to the packetdrill repo a commit that should fix this test:
> > >
> > > 094da3bc77e5 (HEAD, packetdrill/master) net-test: update TCP tests for
> > > USER_TIMEOUT ZWP fix
> > > https://github.com/google/packetdrill/commit/094da3bc77e518d820ebc0ef8b94a5b4cf707a39
> > >
> > > Can someone please pull that commit into the repo used by the test
> > > bot, if needed? (Or does it automatically use the latest packetdrill
> > > master branch?)
> >
> > We updated our tool to use this latest packetdrill. seems improved, but not
> > totally fix.
> >
> > before upgrading, we have:
> > b889c7c8c02ebb0b 9d9b1ee0b2d1c9e02b2338c4a4b
> > ---
> >fail:runs %reproductionfail:runs
> >| | |
> >:6 100% 6:6
> > packetdrill.packetdrill/gtests/net/tcp/user_timeout/user-timeout-probe_ipv4-mapped-v6.fail
> >:6 100% 6:6
> > packetdrill.packetdrill/gtests/net/tcp/user_timeout/user-timeout-probe_ipv4.fail
> >
> > after upgrading, we have:
> > b889c7c8c02ebb0b 9d9b1ee0b2d1c9e02b2338c4a4b
> > ---
> >fail:runs %reproductionfail:runs
> >| | |
> >:6 100% 5:6
> > packetdrill.packetdrill/gtests/net/tcp/user_timeout/user-timeout-probe_ipv4-mapped-v6.fail
> >:6 100% 3:6
> > packetdrill.packetdrill/gtests/net/tcp/user_timeout/user-timeout-probe_ipv4.fail
> >
> >
> > attached kmsg.xz and packetdrill from one run where both tests failed.
>
> here is an update. we did't re-test parent with latest packetdrill yesterday,
> so above results about b889c7c8c02ebb0b are still from old version
> packetdrill.
>
> today, we did further tests based on latest packetdrill, and found the tests
> always failed upon b889c7c8c02ebb0b. not sure if a kernel before your commit
> (9d9b1ee0b2d1c9e02b2338c4a4b) is still valid to run latest packetdrill?)
Well, the packetdrill test was relying on old kernel behavior (not
very precise USER_TIMEOUT implementation),
and the test had comments explaining this (
https://github.com/google/packetdrill/commit/094da3bc77e518d820ebc0ef8b94a5b4cf707a39
So old packetdrill test only pass on old kernels.
Really the new packetdrill test is now checking the behavior of recent kernels
and making sure future kernels won't regress.
>
> attached kmsg and test log from latest packetdrill upon parent commit FYI.
>
>
> >
> >
> > >
> > > thanks,
> > > neal
>
>
> > Running packetdrill/tests/bsd/fast_retransmit/fr-4pkt-sack-bsd.pkt ...
> > 2021-02-24 08:46:09 packetdrill/packetdrill --tolerance_usecs=4
> > packetdrill/tests/bsd/fast_retransmit/fr-4pkt-sack-bsd.pkt
> > packetdrill/tests/bsd/fast_retransmit/fr-4pkt-sack-bsd.pkt:25: error
> > handling packet: live packet payload: expected 1000 bytes vs actual 2000
> > bytes
> > packetdrill/tests/bsd/fast_retransmit/fr-4pkt-sack-bsd.pkt failed
> > Running packetdrill/tests/linux/fast_retransmit/fr-4pkt-sack-linux.pkt ...
> > 2021-02-24 08:46:10 packetdrill/packetdrill --tolerance_usecs=4
> > packetdrill/tests/linux/fast_retransmit/fr-4pkt-sack-linux.pkt
> > packetdrill/tests/linux/fast_retransmit/fr-4pkt-sack-linux.pkt pass
> > Running packetdrill/tests/linux/packetdrill/socket_err.pkt ...
> > 2021-02-24 08:46:10 packetdrill/packetdrill --tolerance_usecs=4
> > packetdrill/tests/linux/packetdrill/socket_err.pkt
> > packetdrill/tests/linux/packetdrill/socket_err.pkt:6: runtime error in
> > socket call: Expected non-negative result but got -1 with errno 93
> > (Protocol not supported)
> > packetdrill/tests/linux/packetdrill/socket_err.pkt failed
> > Running packetdrill/tests/linux/packetdrill/socket_wrong_err.pkt ...
> > 2021-02-24 08:46:10 packetdrill/packetdrill --tolerance_usecs=4
> > packetdrill/tests/linux/packetdrill/socket_wrong_err.pkt
> > packetdrill/tests/linux/packetdrill/socket_wrong_err.pkt:4: runtime error
> > in socket call: Expected result -99 but got -1 with errno 93 (Protocol not
> > supported)
> > packetdrill/tests/linux/packetdrill/socket_wrong_err.pkt failed
> > OK
> > [/lkp/benchmarks/packetdrill/gtests/net/tcp/blocking/blocking-accept.pkt
> > (ipv4)]
> > stdout:
> > stderr:
> > OK
> >
Re: [tcp] 9d9b1ee0b2: packetdrill.packetdrill/gtests/net/tcp/user_timeout/user-timeout-probe_ipv4-mapped-v6.fail
Hi, Neal,
On Wed, Feb 24, 2021 at 10:13:02PM +0800, Oliver Sang wrote:
> Hi, Neal,
>
> On Fri, Feb 19, 2021 at 09:52:04AM -0500, Neal Cardwell wrote:
> > On Thu, Feb 18, 2021 at 8:33 PM kernel test robot
> > wrote:
> > >
> > >
> > > Greeting,
> > >
> > > FYI, we noticed the following commit (built with gcc-9):
> > >
> > > commit: 9d9b1ee0b2d1c9e02b2338c4a4b0a062d2d3edac ("tcp: fix
> > > TCP_USER_TIMEOUT with zero window")
> > > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git master
> >
> > I have pushed to the packetdrill repo a commit that should fix this test:
> >
> > 094da3bc77e5 (HEAD, packetdrill/master) net-test: update TCP tests for
> > USER_TIMEOUT ZWP fix
> > https://github.com/google/packetdrill/commit/094da3bc77e518d820ebc0ef8b94a5b4cf707a39
> >
> > Can someone please pull that commit into the repo used by the test
> > bot, if needed? (Or does it automatically use the latest packetdrill
> > master branch?)
>
> We updated our tool to use this latest packetdrill. seems improved, but not
> totally fix.
>
> before upgrading, we have:
> b889c7c8c02ebb0b 9d9b1ee0b2d1c9e02b2338c4a4b
> ---
>fail:runs %reproductionfail:runs
>| | |
>:6 100% 6:6
> packetdrill.packetdrill/gtests/net/tcp/user_timeout/user-timeout-probe_ipv4-mapped-v6.fail
>:6 100% 6:6
> packetdrill.packetdrill/gtests/net/tcp/user_timeout/user-timeout-probe_ipv4.fail
>
> after upgrading, we have:
> b889c7c8c02ebb0b 9d9b1ee0b2d1c9e02b2338c4a4b
> ---
>fail:runs %reproductionfail:runs
>| | |
>:6 100% 5:6
> packetdrill.packetdrill/gtests/net/tcp/user_timeout/user-timeout-probe_ipv4-mapped-v6.fail
>:6 100% 3:6
> packetdrill.packetdrill/gtests/net/tcp/user_timeout/user-timeout-probe_ipv4.fail
>
>
> attached kmsg.xz and packetdrill from one run where both tests failed.
here is an update. we did't re-test parent with latest packetdrill yesterday,
so above results about b889c7c8c02ebb0b are still from old version packetdrill.
today, we did further tests based on latest packetdrill, and found the tests
always failed upon b889c7c8c02ebb0b. not sure if a kernel before your commit
(9d9b1ee0b2d1c9e02b2338c4a4b) is still valid to run latest packetdrill?
attached kmsg and test log from latest packetdrill upon parent commit FYI.
>
>
> >
> > thanks,
> > neal
> Running packetdrill/tests/bsd/fast_retransmit/fr-4pkt-sack-bsd.pkt ...
> 2021-02-24 08:46:09 packetdrill/packetdrill --tolerance_usecs=4
> packetdrill/tests/bsd/fast_retransmit/fr-4pkt-sack-bsd.pkt
> packetdrill/tests/bsd/fast_retransmit/fr-4pkt-sack-bsd.pkt:25: error handling
> packet: live packet payload: expected 1000 bytes vs actual 2000 bytes
> packetdrill/tests/bsd/fast_retransmit/fr-4pkt-sack-bsd.pkt failed
> Running packetdrill/tests/linux/fast_retransmit/fr-4pkt-sack-linux.pkt ...
> 2021-02-24 08:46:10 packetdrill/packetdrill --tolerance_usecs=4
> packetdrill/tests/linux/fast_retransmit/fr-4pkt-sack-linux.pkt
> packetdrill/tests/linux/fast_retransmit/fr-4pkt-sack-linux.pkt pass
> Running packetdrill/tests/linux/packetdrill/socket_err.pkt ...
> 2021-02-24 08:46:10 packetdrill/packetdrill --tolerance_usecs=4
> packetdrill/tests/linux/packetdrill/socket_err.pkt
> packetdrill/tests/linux/packetdrill/socket_err.pkt:6: runtime error in socket
> call: Expected non-negative result but got -1 with errno 93 (Protocol not
> supported)
> packetdrill/tests/linux/packetdrill/socket_err.pkt failed
> Running packetdrill/tests/linux/packetdrill/socket_wrong_err.pkt ...
> 2021-02-24 08:46:10 packetdrill/packetdrill --tolerance_usecs=4
> packetdrill/tests/linux/packetdrill/socket_wrong_err.pkt
> packetdrill/tests/linux/packetdrill/socket_wrong_err.pkt:4: runtime error in
> socket call: Expected result -99 but got -1 with errno 93 (Protocol not
> supported)
> packetdrill/tests/linux/packetdrill/socket_wrong_err.pkt failed
> OK [/lkp/benchmarks/packetdrill/gtests/net/tcp/blocking/blocking-accept.pkt
> (ipv4)]
> stdout:
> stderr:
> OK [/lkp/benchmarks/packetdrill/gtests/net/tcp/blocking/blocking-accept.pkt
> (ipv6)]
> stdout:
> stderr:
> OK
> [/lkp/benchmarks/packetdrill/gtests/net/tcp/blocking/blocking-connect.pkt
> (ipv4-mapped-v6)]
> stdout:
> stderr:
> OK [/lkp/benchmarks/packetdrill/gtests/net/tcp/blocking/blocking-read.pkt
> (ipv4)]
> stdout:
> stderr:
> OK [/lkp/benchmarks/packetdrill/gtests/net/tcp/blocking/blocking-read.pkt
> (ipv6)]
> stdout:
> stderr:
> OK [/lkp/benchmarks/packetdrill/gtests/net/tcp/blocking/blocking-write.pkt
> (ipv4-mapped-v6)]
> stdout:
> stderr:
> OK
> [/lkp/benchmarks/packetdrill/gtests/net/tcp/close/close-local-close-then-remote-fin.pkt
> (ipv4)]
> stdout:
> stderr:
Re: [tcp] 9d9b1ee0b2: packetdrill.packetdrill/gtests/net/tcp/user_timeout/user-timeout-probe_ipv4-mapped-v6.fail
Hi, Neal,
On Fri, Feb 19, 2021 at 09:52:04AM -0500, Neal Cardwell wrote:
> On Thu, Feb 18, 2021 at 8:33 PM kernel test robot
> wrote:
> >
> >
> > Greeting,
> >
> > FYI, we noticed the following commit (built with gcc-9):
> >
> > commit: 9d9b1ee0b2d1c9e02b2338c4a4b0a062d2d3edac ("tcp: fix
> > TCP_USER_TIMEOUT with zero window")
> > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git master
>
> I have pushed to the packetdrill repo a commit that should fix this test:
>
> 094da3bc77e5 (HEAD, packetdrill/master) net-test: update TCP tests for
> USER_TIMEOUT ZWP fix
> https://github.com/google/packetdrill/commit/094da3bc77e518d820ebc0ef8b94a5b4cf707a39
>
> Can someone please pull that commit into the repo used by the test
> bot, if needed? (Or does it automatically use the latest packetdrill
> master branch?)
We updated our tool to use this latest packetdrill. seems improved, but not
totally fix.
before upgrading, we have:
b889c7c8c02ebb0b 9d9b1ee0b2d1c9e02b2338c4a4b
---
fail:runs %reproductionfail:runs
| | |
:6 100% 6:6
packetdrill.packetdrill/gtests/net/tcp/user_timeout/user-timeout-probe_ipv4-mapped-v6.fail
:6 100% 6:6
packetdrill.packetdrill/gtests/net/tcp/user_timeout/user-timeout-probe_ipv4.fail
after upgrading, we have:
b889c7c8c02ebb0b 9d9b1ee0b2d1c9e02b2338c4a4b
---
fail:runs %reproductionfail:runs
| | |
:6 100% 5:6
packetdrill.packetdrill/gtests/net/tcp/user_timeout/user-timeout-probe_ipv4-mapped-v6.fail
:6 100% 3:6
packetdrill.packetdrill/gtests/net/tcp/user_timeout/user-timeout-probe_ipv4.fail
attached kmsg.xz and packetdrill from one run where both tests failed.
>
> thanks,
> neal
kmsg.xz
Description: application/xz
Running packetdrill/tests/bsd/fast_retransmit/fr-4pkt-sack-bsd.pkt ...
2021-02-24 08:46:09 packetdrill/packetdrill --tolerance_usecs=4
packetdrill/tests/bsd/fast_retransmit/fr-4pkt-sack-bsd.pkt
packetdrill/tests/bsd/fast_retransmit/fr-4pkt-sack-bsd.pkt:25: error handling
packet: live packet payload: expected 1000 bytes vs actual 2000 bytes
packetdrill/tests/bsd/fast_retransmit/fr-4pkt-sack-bsd.pkt failed
Running packetdrill/tests/linux/fast_retransmit/fr-4pkt-sack-linux.pkt ...
2021-02-24 08:46:10 packetdrill/packetdrill --tolerance_usecs=4
packetdrill/tests/linux/fast_retransmit/fr-4pkt-sack-linux.pkt
packetdrill/tests/linux/fast_retransmit/fr-4pkt-sack-linux.pkt pass
Running packetdrill/tests/linux/packetdrill/socket_err.pkt ...
2021-02-24 08:46:10 packetdrill/packetdrill --tolerance_usecs=4
packetdrill/tests/linux/packetdrill/socket_err.pkt
packetdrill/tests/linux/packetdrill/socket_err.pkt:6: runtime error in socket
call: Expected non-negative result but got -1 with errno 93 (Protocol not
supported)
packetdrill/tests/linux/packetdrill/socket_err.pkt failed
Running packetdrill/tests/linux/packetdrill/socket_wrong_err.pkt ...
2021-02-24 08:46:10 packetdrill/packetdrill --tolerance_usecs=4
packetdrill/tests/linux/packetdrill/socket_wrong_err.pkt
packetdrill/tests/linux/packetdrill/socket_wrong_err.pkt:4: runtime error in
socket call: Expected result -99 but got -1 with errno 93 (Protocol not
supported)
packetdrill/tests/linux/packetdrill/socket_wrong_err.pkt failed
OK [/lkp/benchmarks/packetdrill/gtests/net/tcp/blocking/blocking-accept.pkt
(ipv4)]
stdout:
stderr:
OK [/lkp/benchmarks/packetdrill/gtests/net/tcp/blocking/blocking-accept.pkt
(ipv6)]
stdout:
stderr:
OK [/lkp/benchmarks/packetdrill/gtests/net/tcp/blocking/blocking-connect.pkt
(ipv4-mapped-v6)]
stdout:
stderr:
OK [/lkp/benchmarks/packetdrill/gtests/net/tcp/blocking/blocking-read.pkt
(ipv4)]
stdout:
stderr:
OK [/lkp/benchmarks/packetdrill/gtests/net/tcp/blocking/blocking-read.pkt
(ipv6)]
stdout:
stderr:
OK [/lkp/benchmarks/packetdrill/gtests/net/tcp/blocking/blocking-write.pkt
(ipv4-mapped-v6)]
stdout:
stderr:
OK
[/lkp/benchmarks/packetdrill/gtests/net/tcp/close/close-local-close-then-remote-fin.pkt
(ipv4)]
stdout:
stderr:
OK
[/lkp/benchmarks/packetdrill/gtests/net/tcp/close/close-local-close-then-remote-fin.pkt
(ipv6)]
stdout:
stderr:
OK [/lkp/benchmarks/packetdrill/gtests/net/tcp/close/close-on-syn-sent.pkt
(ipv4-mapped-v6)]
stdout:
stderr:
OK
[/lkp/benchmarks/packetdrill/gtests/net/tcp/close/close-remote-fin-then-close.pkt
(ipv4)]
stdout:
stderr:
OK
[/lkp/benchmarks/packetdrill/gtests/net/tcp/close/close-remote-fin-then-close.pkt
(ipv6)]
stdout:
stderr:
OK
[/lkp/benchmarks/packetdrill/gtests/net/tcp/cwnd_moderation/cwnd-moderation-disorder-no-moderation.pkt
(ipv4-mapped-v6)]
stdout:
stderr:
FAIL
Re: [tcp] 9d9b1ee0b2: packetdrill.packetdrill/gtests/net/tcp/user_timeout/user-timeout-probe_ipv4-mapped-v6.fail
On Thu, Feb 18, 2021 at 8:33 PM kernel test robot wrote:
>
>
> Greeting,
>
> FYI, we noticed the following commit (built with gcc-9):
>
> commit: 9d9b1ee0b2d1c9e02b2338c4a4b0a062d2d3edac ("tcp: fix TCP_USER_TIMEOUT
> with zero window")
> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git master
I have pushed to the packetdrill repo a commit that should fix this test:
094da3bc77e5 (HEAD, packetdrill/master) net-test: update TCP tests for
USER_TIMEOUT ZWP fix
https://github.com/google/packetdrill/commit/094da3bc77e518d820ebc0ef8b94a5b4cf707a39
Can someone please pull that commit into the repo used by the test
bot, if needed? (Or does it automatically use the latest packetdrill
master branch?)
thanks,
neal
