[tip:efi/urgent] efi: Fix debugobjects warning on 'efi_rts_work'
Commit-ID: ef1491e791308317bb9851a0ad380c4a68b58d54 Gitweb: https://git.kernel.org/tip/ef1491e791308317bb9851a0ad380c4a68b58d54 Author: Waiman Long AuthorDate: Wed, 14 Nov 2018 09:55:40 -0800 Committer: Ingo Molnar CommitDate: Thu, 15 Nov 2018 10:04:45 +0100 efi: Fix debugobjects warning on 'efi_rts_work' The following commit: 9dbbedaa6171 ("efi: Make efi_rts_work accessible to efi page fault handler") converted 'efi_rts_work' from an auto variable to a global variable. However, when submitting the work, INIT_WORK_ONSTACK() was still used, causing the following complaint from debugobjects: ODEBUG: object ed27b500 is NOT on stack c7d38760, but annotated. Change the macro to just INIT_WORK() to eliminate the warning. Signed-off-by: Waiman Long Signed-off-by: Ard Biesheuvel Acked-by: Sai Praneeth Prakhya Cc: Linus Torvalds Cc: Peter Zijlstra Cc: Thomas Gleixner Cc: linux-...@vger.kernel.org Fixes: 9dbbedaa6171 ("efi: Make efi_rts_work accessible to efi page fault handler") Link: http://lkml.kernel.org/r/20181114175544.12860-2-ard.biesheu...@linaro.org Signed-off-by: Ingo Molnar --- drivers/firmware/efi/runtime-wrappers.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/firmware/efi/runtime-wrappers.c b/drivers/firmware/efi/runtime-wrappers.c index a19d845bdb06..8903b9ccfc2b 100644 --- a/drivers/firmware/efi/runtime-wrappers.c +++ b/drivers/firmware/efi/runtime-wrappers.c @@ -67,7 +67,7 @@ struct efi_runtime_work efi_rts_work; } \ \ init_completion(_rts_work.efi_rts_comp);\ - INIT_WORK_ONSTACK(_rts_work.work, efi_call_rts);\ + INIT_WORK(_rts_work.work, efi_call_rts);\ efi_rts_work.arg1 = _arg1; \ efi_rts_work.arg2 = _arg2; \ efi_rts_work.arg3 = _arg3; \
[tip:efi/urgent] efi: Fix debugobjects warning on 'efi_rts_work'
Commit-ID: ef1491e791308317bb9851a0ad380c4a68b58d54 Gitweb: https://git.kernel.org/tip/ef1491e791308317bb9851a0ad380c4a68b58d54 Author: Waiman Long AuthorDate: Wed, 14 Nov 2018 09:55:40 -0800 Committer: Ingo Molnar CommitDate: Thu, 15 Nov 2018 10:04:45 +0100 efi: Fix debugobjects warning on 'efi_rts_work' The following commit: 9dbbedaa6171 ("efi: Make efi_rts_work accessible to efi page fault handler") converted 'efi_rts_work' from an auto variable to a global variable. However, when submitting the work, INIT_WORK_ONSTACK() was still used, causing the following complaint from debugobjects: ODEBUG: object ed27b500 is NOT on stack c7d38760, but annotated. Change the macro to just INIT_WORK() to eliminate the warning. Signed-off-by: Waiman Long Signed-off-by: Ard Biesheuvel Acked-by: Sai Praneeth Prakhya Cc: Linus Torvalds Cc: Peter Zijlstra Cc: Thomas Gleixner Cc: linux-...@vger.kernel.org Fixes: 9dbbedaa6171 ("efi: Make efi_rts_work accessible to efi page fault handler") Link: http://lkml.kernel.org/r/20181114175544.12860-2-ard.biesheu...@linaro.org Signed-off-by: Ingo Molnar --- drivers/firmware/efi/runtime-wrappers.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/firmware/efi/runtime-wrappers.c b/drivers/firmware/efi/runtime-wrappers.c index a19d845bdb06..8903b9ccfc2b 100644 --- a/drivers/firmware/efi/runtime-wrappers.c +++ b/drivers/firmware/efi/runtime-wrappers.c @@ -67,7 +67,7 @@ struct efi_runtime_work efi_rts_work; } \ \ init_completion(_rts_work.efi_rts_comp);\ - INIT_WORK_ONSTACK(_rts_work.work, efi_call_rts);\ + INIT_WORK(_rts_work.work, efi_call_rts);\ efi_rts_work.arg1 = _arg1; \ efi_rts_work.arg2 = _arg2; \ efi_rts_work.arg3 = _arg3; \