[tip:irq/core] x86/irq: Fix kbuild warning in smp_irq_move_cleanup_interrupt()
Commit-ID: c7a730fa4624092e2d1c0cb7b750816e87c32364
Gitweb: http://git.kernel.org/tip/c7a730fa4624092e2d1c0cb7b750816e87c32364
Author: Prarit Bhargava
AuthorDate: Mon, 13 Jan 2014 08:40:20 -0500
Committer: Ingo Molnar
CommitDate: Mon, 13 Jan 2014 15:08:37 +0100
x86/irq: Fix kbuild warning in smp_irq_move_cleanup_interrupt()
Fengguang Wu's 0day kernel build service reported the following build warning:
arch/x86/kernel/apic/io_apic.c:2211
smp_irq_move_cleanup_interrupt() warn: always true condition '(irq <= -1) =>
(0-u32max <= (-1))'
because irq is defined as an unsigned int instead of an int.
Fix this trivial error by redefining irq as a signed int. The
remaining consumers of the int are okay.
Signed-off-by: Prarit Bhargava
Cc: Konrad Rzeszutek Wilk
Cc: Sebastian Andrzej Siewior
Cc: Joerg Roedel
Cc: Fengguang Wu
Link:
http://lkml.kernel.org/r/1389620420-7110-1-git-send-email-pra...@redhat.com
Signed-off-by: Ingo Molnar
---
arch/x86/kernel/apic/io_apic.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/kernel/apic/io_apic.c b/arch/x86/kernel/apic/io_apic.c
index 6df0b66..a43f068 100644
--- a/arch/x86/kernel/apic/io_apic.c
+++ b/arch/x86/kernel/apic/io_apic.c
@@ -2202,7 +2202,7 @@ asmlinkage void smp_irq_move_cleanup_interrupt(void)
me = smp_processor_id();
for (vector = FIRST_EXTERNAL_VECTOR; vector < NR_VECTORS; vector++) {
- unsigned int irq;
+ int irq;
unsigned int irr;
struct irq_desc *desc;
struct irq_cfg *cfg;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[tip:irq/core] x86/irq: Fix kbuild warning in smp_irq_move_cleanup_interrupt()
Commit-ID: c7a730fa4624092e2d1c0cb7b750816e87c32364
Gitweb: http://git.kernel.org/tip/c7a730fa4624092e2d1c0cb7b750816e87c32364
Author: Prarit Bhargava pra...@redhat.com
AuthorDate: Mon, 13 Jan 2014 08:40:20 -0500
Committer: Ingo Molnar mi...@kernel.org
CommitDate: Mon, 13 Jan 2014 15:08:37 +0100
x86/irq: Fix kbuild warning in smp_irq_move_cleanup_interrupt()
Fengguang Wu's 0day kernel build service reported the following build warning:
arch/x86/kernel/apic/io_apic.c:2211
smp_irq_move_cleanup_interrupt() warn: always true condition '(irq = -1) =
(0-u32max = (-1))'
because irq is defined as an unsigned int instead of an int.
Fix this trivial error by redefining irq as a signed int. The
remaining consumers of the int are okay.
Signed-off-by: Prarit Bhargava pra...@redhat.com
Cc: Konrad Rzeszutek Wilk konrad.w...@oracle.com
Cc: Sebastian Andrzej Siewior sebast...@breakpoint.cc
Cc: Joerg Roedel j...@8bytes.org
Cc: Fengguang Wu fengguang...@intel.com
Link:
http://lkml.kernel.org/r/1389620420-7110-1-git-send-email-pra...@redhat.com
Signed-off-by: Ingo Molnar mi...@kernel.org
---
arch/x86/kernel/apic/io_apic.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/kernel/apic/io_apic.c b/arch/x86/kernel/apic/io_apic.c
index 6df0b66..a43f068 100644
--- a/arch/x86/kernel/apic/io_apic.c
+++ b/arch/x86/kernel/apic/io_apic.c
@@ -2202,7 +2202,7 @@ asmlinkage void smp_irq_move_cleanup_interrupt(void)
me = smp_processor_id();
for (vector = FIRST_EXTERNAL_VECTOR; vector NR_VECTORS; vector++) {
- unsigned int irq;
+ int irq;
unsigned int irr;
struct irq_desc *desc;
struct irq_cfg *cfg;
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
