[tip:perf/urgent] perf hists browser: Fix off-by-two bug on the first column
Commit-ID: 63a1a3d820c619a4dab1781cc16c110a284efded
Gitweb: http://git.kernel.org/tip/63a1a3d820c619a4dab1781cc16c110a284efded
Author: Namhyung Kim
AuthorDate: Mon, 15 Oct 2012 18:14:35 -0300
Committer: Arnaldo Carvalho de Melo
CommitDate: Tue, 16 Oct 2012 13:06:05 -0300
perf hists browser: Fix off-by-two bug on the first column
The commit 5395a04841fc ("perf hists: Separate overhead and baseline
columns") makes the "Overhead" column no more the first one. So it
resulted in the mis-aligned column in the normal (non-diff) output.
Signed-off-by: Namhyung Kim
Reported-by: Markus Trippelsdorf
Acked-by: Jiri Olsa
Cc: Ingo Molnar
Cc: Jiri Olsa
Cc: Paul Mackerras
Cc: Peter Zijlstra
Link: http://lkml.kernel.org/r/None
Signed-off-by: Arnaldo Carvalho de Melo
---
tools/perf/ui/browsers/hists.c |4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/tools/perf/ui/browsers/hists.c b/tools/perf/ui/browsers/hists.c
index 0568536..fe4430a 100644
--- a/tools/perf/ui/browsers/hists.c
+++ b/tools/perf/ui/browsers/hists.c
@@ -610,6 +610,7 @@ static int hist_browser__show_entry(struct hist_browser
*browser,
char folded_sign = ' ';
bool current_entry = ui_browser__is_current_entry(>b, row);
off_t row_offset = entry->row_offset;
+ bool first = true;
if (current_entry) {
browser->he_selection = entry;
@@ -633,10 +634,11 @@ static int hist_browser__show_entry(struct hist_browser
*browser,
if (!perf_hpp__format[i].cond)
continue;
- if (i) {
+ if (!first) {
slsmg_printf(" ");
width -= 2;
}
+ first = false;
if (perf_hpp__format[i].color) {
hpp.ptr =
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[tip:perf/urgent] perf hists browser: Fix off-by-two bug on the first column
Commit-ID: 63a1a3d820c619a4dab1781cc16c110a284efded
Gitweb: http://git.kernel.org/tip/63a1a3d820c619a4dab1781cc16c110a284efded
Author: Namhyung Kim namhyung@lge.com
AuthorDate: Mon, 15 Oct 2012 18:14:35 -0300
Committer: Arnaldo Carvalho de Melo a...@redhat.com
CommitDate: Tue, 16 Oct 2012 13:06:05 -0300
perf hists browser: Fix off-by-two bug on the first column
The commit 5395a04841fc (perf hists: Separate overhead and baseline
columns) makes the Overhead column no more the first one. So it
resulted in the mis-aligned column in the normal (non-diff) output.
Signed-off-by: Namhyung Kim namhy...@kernel.org
Reported-by: Markus Trippelsdorf mar...@trippelsdorf.de
Acked-by: Jiri Olsa jo...@redhat.com
Cc: Ingo Molnar mi...@kernel.org
Cc: Jiri Olsa jo...@redhat.com
Cc: Paul Mackerras pau...@samba.org
Cc: Peter Zijlstra a.p.zijls...@chello.nl
Link: http://lkml.kernel.org/r/None
Signed-off-by: Arnaldo Carvalho de Melo a...@redhat.com
---
tools/perf/ui/browsers/hists.c |4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/tools/perf/ui/browsers/hists.c b/tools/perf/ui/browsers/hists.c
index 0568536..fe4430a 100644
--- a/tools/perf/ui/browsers/hists.c
+++ b/tools/perf/ui/browsers/hists.c
@@ -610,6 +610,7 @@ static int hist_browser__show_entry(struct hist_browser
*browser,
char folded_sign = ' ';
bool current_entry = ui_browser__is_current_entry(browser-b, row);
off_t row_offset = entry-row_offset;
+ bool first = true;
if (current_entry) {
browser-he_selection = entry;
@@ -633,10 +634,11 @@ static int hist_browser__show_entry(struct hist_browser
*browser,
if (!perf_hpp__format[i].cond)
continue;
- if (i) {
+ if (!first) {
slsmg_printf( );
width -= 2;
}
+ first = false;
if (perf_hpp__format[i].color) {
hpp.ptr = percent;
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
