[tip:x86/asm] x86/entry: Inline enter_from_user_mode()

[tip-bot for Paolo Bonzini]

Commit-ID:  be8a18e2e98e04a5def5887d913b267865562448
Gitweb: http://git.kernel.org/tip/be8a18e2e98e04a5def5887d913b267865562448
Author: Paolo Bonzini 
AuthorDate: Mon, 20 Jun 2016 16:58:30 +0200
Committer:  Ingo Molnar 
CommitDate: Sun, 10 Jul 2016 13:33:02 +0200

x86/entry: Inline enter_from_user_mode()

This matches what is already done for prepare_exit_to_usermode(),
and saves about 60 clock cycles (4% speedup) with the benchmark
in the previous commit message.

Signed-off-by: Paolo Bonzini 
Reviewed-by: Rik van Riel 
Reviewed-by: Andy Lutomirski 
Acked-by: Paolo Bonzini 
Cc: Borislav Petkov 
Cc: Brian Gerst 
Cc: Denys Vlasenko 
Cc: H. Peter Anvin 
Cc: Josh Poimboeuf 
Cc: Linus Torvalds 
Cc: Peter Zijlstra 
Cc: Thomas Gleixner 
Cc: k...@vger.kernel.org
Link: 
http://lkml.kernel.org/r/1466434712-31440-3-git-send-email-pbonz...@redhat.com
Signed-off-by: Ingo Molnar 
---
 arch/x86/entry/common.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/entry/common.c b/arch/x86/entry/common.c
index 618bc61..9e1e27d 100644
--- a/arch/x86/entry/common.c
+++ b/arch/x86/entry/common.c
@@ -40,7 +40,7 @@ static struct thread_info *pt_regs_to_thread_info(struct 
pt_regs *regs)
 
 #ifdef CONFIG_CONTEXT_TRACKING
 /* Called on entry from user mode with IRQs off. */
-__visible void enter_from_user_mode(void)
+__visible inline void enter_from_user_mode(void)
 {
CT_WARN_ON(ct_state() != CONTEXT_USER);
user_exit_irqoff();

[tip:x86/asm] x86/entry: Inline enter_from_user_mode()

[tip-bot for Paolo Bonzini]

Commit-ID:  be8a18e2e98e04a5def5887d913b267865562448
Gitweb: http://git.kernel.org/tip/be8a18e2e98e04a5def5887d913b267865562448
Author: Paolo Bonzini 
AuthorDate: Mon, 20 Jun 2016 16:58:30 +0200
Committer:  Ingo Molnar 
CommitDate: Sun, 10 Jul 2016 13:33:02 +0200

x86/entry: Inline enter_from_user_mode()

This matches what is already done for prepare_exit_to_usermode(),
and saves about 60 clock cycles (4% speedup) with the benchmark
in the previous commit message.

Signed-off-by: Paolo Bonzini 
Reviewed-by: Rik van Riel 
Reviewed-by: Andy Lutomirski 
Acked-by: Paolo Bonzini 
Cc: Borislav Petkov 
Cc: Brian Gerst 
Cc: Denys Vlasenko 
Cc: H. Peter Anvin 
Cc: Josh Poimboeuf 
Cc: Linus Torvalds 
Cc: Peter Zijlstra 
Cc: Thomas Gleixner 
Cc: k...@vger.kernel.org
Link: 
http://lkml.kernel.org/r/1466434712-31440-3-git-send-email-pbonz...@redhat.com
Signed-off-by: Ingo Molnar 
---
 arch/x86/entry/common.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/entry/common.c b/arch/x86/entry/common.c
index 618bc61..9e1e27d 100644
--- a/arch/x86/entry/common.c
+++ b/arch/x86/entry/common.c
@@ -40,7 +40,7 @@ static struct thread_info *pt_regs_to_thread_info(struct 
pt_regs *regs)
 
 #ifdef CONFIG_CONTEXT_TRACKING
 /* Called on entry from user mode with IRQs off. */
-__visible void enter_from_user_mode(void)
+__visible inline void enter_from_user_mode(void)
 {
CT_WARN_ON(ct_state() != CONTEXT_USER);
user_exit_irqoff();

Re: [tip:x86/asm] x86/entry: Inline enter_from_user_mode()

[Ingo Molnar]

* Borislav Petkov  wrote:

> tip-bot for Paolo Bonzini  wrote:
> 
> >Commit-ID:  eec4b1227db153ca16f8f5f285d01fefdce05438
> >Gitweb:
> >http://git.kernel.org/tip/eec4b1227db153ca16f8f5f285d01fefdce05438
> >Author: Paolo Bonzini 
> >AuthorDate: Mon, 20 Jun 2016 16:58:30 +0200
> >Committer:  Ingo Molnar 
> >CommitDate: Sat, 9 Jul 2016 10:44:02 +0200
> >
> >x86/entry: Inline enter_from_user_mode()
> >
> >This matches what is already done for prepare_exit_to_usermode(),
> >and saves about 60 clock cycles (4% speedup) with the benchmark
> >in the previous commit message.
> >
> >Signed-off-by: Paolo Bonzini 
> >Reviewed-by: Rik van Riel 
> >Reviewed-by: Andy Lutomirski 
> >Reviewed-by: Rik van Riel 
> >Reviewed-by: Andy Lutomirski 
> >Reviewed-by: Rik van Riel 
> >Reviewed-by: Andy Lutomirski 
> >Reviewed-by: Rik van Riel 
> >Reviewed-by: Andy Lutomirski 
> >Acked-by: Paolo Bonzini 
> 
> Woohaa, if that amount of review doesn't get this patch upstream I don't know 
> what will ;-)

Gah, that's a script gone bad - fixed!

Thanks,

Ingo

Re: [tip:x86/asm] x86/entry: Inline enter_from_user_mode()

[Ingo Molnar]

* Borislav Petkov  wrote:

> tip-bot for Paolo Bonzini  wrote:
> 
> >Commit-ID:  eec4b1227db153ca16f8f5f285d01fefdce05438
> >Gitweb:
> >http://git.kernel.org/tip/eec4b1227db153ca16f8f5f285d01fefdce05438
> >Author: Paolo Bonzini 
> >AuthorDate: Mon, 20 Jun 2016 16:58:30 +0200
> >Committer:  Ingo Molnar 
> >CommitDate: Sat, 9 Jul 2016 10:44:02 +0200
> >
> >x86/entry: Inline enter_from_user_mode()
> >
> >This matches what is already done for prepare_exit_to_usermode(),
> >and saves about 60 clock cycles (4% speedup) with the benchmark
> >in the previous commit message.
> >
> >Signed-off-by: Paolo Bonzini 
> >Reviewed-by: Rik van Riel 
> >Reviewed-by: Andy Lutomirski 
> >Reviewed-by: Rik van Riel 
> >Reviewed-by: Andy Lutomirski 
> >Reviewed-by: Rik van Riel 
> >Reviewed-by: Andy Lutomirski 
> >Reviewed-by: Rik van Riel 
> >Reviewed-by: Andy Lutomirski 
> >Acked-by: Paolo Bonzini 
> 
> Woohaa, if that amount of review doesn't get this patch upstream I don't know 
> what will ;-)

Gah, that's a script gone bad - fixed!

Thanks,

Ingo

Re: [tip:x86/asm] x86/entry: Inline enter_from_user_mode()

[Borislav Petkov]

tip-bot for Paolo Bonzini  wrote:

>Commit-ID:  eec4b1227db153ca16f8f5f285d01fefdce05438
>Gitweb:
>http://git.kernel.org/tip/eec4b1227db153ca16f8f5f285d01fefdce05438
>Author: Paolo Bonzini 
>AuthorDate: Mon, 20 Jun 2016 16:58:30 +0200
>Committer:  Ingo Molnar 
>CommitDate: Sat, 9 Jul 2016 10:44:02 +0200
>
>x86/entry: Inline enter_from_user_mode()
>
>This matches what is already done for prepare_exit_to_usermode(),
>and saves about 60 clock cycles (4% speedup) with the benchmark
>in the previous commit message.
>
>Signed-off-by: Paolo Bonzini 
>Reviewed-by: Rik van Riel 
>Reviewed-by: Andy Lutomirski 
>Reviewed-by: Rik van Riel 
>Reviewed-by: Andy Lutomirski 
>Reviewed-by: Rik van Riel 
>Reviewed-by: Andy Lutomirski 
>Reviewed-by: Rik van Riel 
>Reviewed-by: Andy Lutomirski 
>Acked-by: Paolo Bonzini 

Woohaa, if that amount of review doesn't get this patch upstream I don't know 
what will ;-)

-- 
Sent from a small device: formatting sucks and brevity is inevitable. 

Re: [tip:x86/asm] x86/entry: Inline enter_from_user_mode()

[Borislav Petkov]

tip-bot for Paolo Bonzini  wrote:

>Commit-ID:  eec4b1227db153ca16f8f5f285d01fefdce05438
>Gitweb:
>http://git.kernel.org/tip/eec4b1227db153ca16f8f5f285d01fefdce05438
>Author: Paolo Bonzini 
>AuthorDate: Mon, 20 Jun 2016 16:58:30 +0200
>Committer:  Ingo Molnar 
>CommitDate: Sat, 9 Jul 2016 10:44:02 +0200
>
>x86/entry: Inline enter_from_user_mode()
>
>This matches what is already done for prepare_exit_to_usermode(),
>and saves about 60 clock cycles (4% speedup) with the benchmark
>in the previous commit message.
>
>Signed-off-by: Paolo Bonzini 
>Reviewed-by: Rik van Riel 
>Reviewed-by: Andy Lutomirski 
>Reviewed-by: Rik van Riel 
>Reviewed-by: Andy Lutomirski 
>Reviewed-by: Rik van Riel 
>Reviewed-by: Andy Lutomirski 
>Reviewed-by: Rik van Riel 
>Reviewed-by: Andy Lutomirski 
>Acked-by: Paolo Bonzini 

Woohaa, if that amount of review doesn't get this patch upstream I don't know 
what will ;-)

-- 
Sent from a small device: formatting sucks and brevity is inevitable. 

[tip:x86/asm] x86/entry: Inline enter_from_user_mode()

[tip-bot for Paolo Bonzini]

Commit-ID:  eec4b1227db153ca16f8f5f285d01fefdce05438
Gitweb: http://git.kernel.org/tip/eec4b1227db153ca16f8f5f285d01fefdce05438
Author: Paolo Bonzini 
AuthorDate: Mon, 20 Jun 2016 16:58:30 +0200
Committer:  Ingo Molnar 
CommitDate: Sat, 9 Jul 2016 10:44:02 +0200

x86/entry: Inline enter_from_user_mode()

This matches what is already done for prepare_exit_to_usermode(),
and saves about 60 clock cycles (4% speedup) with the benchmark
in the previous commit message.

Signed-off-by: Paolo Bonzini 
Reviewed-by: Rik van Riel 
Reviewed-by: Andy Lutomirski 
Reviewed-by: Rik van Riel 
Reviewed-by: Andy Lutomirski 
Reviewed-by: Rik van Riel 
Reviewed-by: Andy Lutomirski 
Reviewed-by: Rik van Riel 
Reviewed-by: Andy Lutomirski 
Acked-by: Paolo Bonzini 
Cc: Borislav Petkov 
Cc: Brian Gerst 
Cc: Denys Vlasenko 
Cc: H. Peter Anvin 
Cc: Josh Poimboeuf 
Cc: Linus Torvalds 
Cc: Peter Zijlstra 
Cc: Thomas Gleixner 
Cc: k...@vger.kernel.org
Link: 
http://lkml.kernel.org/r/1466434712-31440-3-git-send-email-pbonz...@redhat.com
Signed-off-by: Ingo Molnar 
---
 arch/x86/entry/common.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/entry/common.c b/arch/x86/entry/common.c
index 618bc61..9e1e27d 100644
--- a/arch/x86/entry/common.c
+++ b/arch/x86/entry/common.c
@@ -40,7 +40,7 @@ static struct thread_info *pt_regs_to_thread_info(struct 
pt_regs *regs)
 
 #ifdef CONFIG_CONTEXT_TRACKING
 /* Called on entry from user mode with IRQs off. */
-__visible void enter_from_user_mode(void)
+__visible inline void enter_from_user_mode(void)
 {
CT_WARN_ON(ct_state() != CONTEXT_USER);
user_exit_irqoff();

[tip:x86/asm] x86/entry: Inline enter_from_user_mode()

[tip-bot for Paolo Bonzini]

Commit-ID:  eec4b1227db153ca16f8f5f285d01fefdce05438
Gitweb: http://git.kernel.org/tip/eec4b1227db153ca16f8f5f285d01fefdce05438
Author: Paolo Bonzini 
AuthorDate: Mon, 20 Jun 2016 16:58:30 +0200
Committer:  Ingo Molnar 
CommitDate: Sat, 9 Jul 2016 10:44:02 +0200

x86/entry: Inline enter_from_user_mode()

This matches what is already done for prepare_exit_to_usermode(),
and saves about 60 clock cycles (4% speedup) with the benchmark
in the previous commit message.

Signed-off-by: Paolo Bonzini 
Reviewed-by: Rik van Riel 
Reviewed-by: Andy Lutomirski 
Reviewed-by: Rik van Riel 
Reviewed-by: Andy Lutomirski 
Reviewed-by: Rik van Riel 
Reviewed-by: Andy Lutomirski 
Reviewed-by: Rik van Riel 
Reviewed-by: Andy Lutomirski 
Acked-by: Paolo Bonzini 
Cc: Borislav Petkov 
Cc: Brian Gerst 
Cc: Denys Vlasenko 
Cc: H. Peter Anvin 
Cc: Josh Poimboeuf 
Cc: Linus Torvalds 
Cc: Peter Zijlstra 
Cc: Thomas Gleixner 
Cc: k...@vger.kernel.org
Link: 
http://lkml.kernel.org/r/1466434712-31440-3-git-send-email-pbonz...@redhat.com
Signed-off-by: Ingo Molnar 
---
 arch/x86/entry/common.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/entry/common.c b/arch/x86/entry/common.c
index 618bc61..9e1e27d 100644
--- a/arch/x86/entry/common.c
+++ b/arch/x86/entry/common.c
@@ -40,7 +40,7 @@ static struct thread_info *pt_regs_to_thread_info(struct 
pt_regs *regs)
 
 #ifdef CONFIG_CONTEXT_TRACKING
 /* Called on entry from user mode with IRQs off. */
-__visible void enter_from_user_mode(void)
+__visible inline void enter_from_user_mode(void)
 {
CT_WARN_ON(ct_state() != CONTEXT_USER);
user_exit_irqoff();