Re: [v4] dt-bindings: msm: disp: add yaml schemas for DPU and DSI bindings

2020-06-03 Thread Rob Herring
On Tue, May 19, 2020 at 11:37:01AM +0530, Krishna Manikandan wrote:
> MSM Mobile Display Subsytem (MDSS) encapsulates sub-blocks
> like DPU display controller, DSI etc. Add YAML schema
> for the device tree bindings for the same.
> 
> Signed-off-by: Krishna Manikandan 
> 
> Changes in v2:
>   - Changed dpu to DPU (Sam Ravnborg)
>   - Fixed indentation issues (Sam Ravnborg)
>   - Added empty line between different properties (Sam Ravnborg)
>   - Replaced reference txt files with  their corresponding
> yaml files (Sam Ravnborg)
>   - Modified the file to use "|" only when it is
> necessary (Sam Ravnborg)
> 
> Changes in v3:
>   - Corrected the license used (Rob Herring)
>   - Added maxItems for properties (Rob Herring)
>   - Dropped generic descriptions (Rob Herring)
>   - Added ranges property (Rob Herring)
>   - Corrected the indendation (Rob Herring)
>   - Added additionalProperties (Rob Herring)
>   - Split dsi file into two, one for dsi controller
> and another one for dsi phy per target (Rob Herring)
>   - Corrected description for pinctrl-names (Rob Herring)
>   - Corrected the examples used in yaml file (Rob Herring)
>   - Delete dsi.txt and dpu.txt (Rob Herring)
> 
> Changes in v4:
>   - Move schema up by one level (Rob Herring)
>   - Add patternProperties for mdp node (Rob Herring)
>   - Corrected description of some properties (Rob Herring)
> ---
>  .../bindings/display/msm/dpu-sc7180.yaml   | 243 
>  .../bindings/display/msm/dpu-sdm845.yaml   | 220 ++
>  .../devicetree/bindings/display/msm/dpu.txt| 141 
>  .../display/msm/dsi-controller-sc7180.yaml | 123 +++
>  .../display/msm/dsi-controller-sdm845.yaml | 120 ++
>  .../bindings/display/msm/dsi-controller.yaml   | 151 +
>  .../bindings/display/msm/dsi-phy-sc7180.yaml   |  75 +++
>  .../bindings/display/msm/dsi-phy-sdm845.yaml   |  76 +++
>  .../devicetree/bindings/display/msm/dsi-phy.yaml   |  82 +++
>  .../devicetree/bindings/display/msm/dsi.txt| 246 
> -
>  10 files changed, 1090 insertions(+), 387 deletions(-)
>  create mode 100644 
> Documentation/devicetree/bindings/display/msm/dpu-sc7180.yaml
>  create mode 100644 
> Documentation/devicetree/bindings/display/msm/dpu-sdm845.yaml
>  delete mode 100644 Documentation/devicetree/bindings/display/msm/dpu.txt
>  create mode 100644 
> Documentation/devicetree/bindings/display/msm/dsi-controller-sc7180.yaml
>  create mode 100644 
> Documentation/devicetree/bindings/display/msm/dsi-controller-sdm845.yaml
>  create mode 100644 
> Documentation/devicetree/bindings/display/msm/dsi-controller.yaml
>  create mode 100644 
> Documentation/devicetree/bindings/display/msm/dsi-phy-sc7180.yaml
>  create mode 100644 
> Documentation/devicetree/bindings/display/msm/dsi-phy-sdm845.yaml
>  create mode 100644 Documentation/devicetree/bindings/display/msm/dsi-phy.yaml
>  delete mode 100644 Documentation/devicetree/bindings/display/msm/dsi.txt
> 
> diff --git a/Documentation/devicetree/bindings/display/msm/dpu-sc7180.yaml 
> b/Documentation/devicetree/bindings/display/msm/dpu-sc7180.yaml
> new file mode 100644
> index 000..b5607f9
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/msm/dpu-sc7180.yaml
> @@ -0,0 +1,243 @@
> +# SPDX-License-Identifier: GPL-2.0-only or BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/display/msm/dpu-sc7180.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Description of Qualcomm Display DPU dt properties.
> +
> +maintainers:
> +  - Krishna Manikandan 
> +
> +description: |
> +  Device tree bindings for MSM Mobile Display Subsytem(MDSS) that 
> encapsulates
> +  sub-blocks like DPU display controller, DSI and DP interfaces etc. Device 
> tree
> +  bindings of MDSS and DPU are mentioned for SC7180 target.
> +
> +properties:
> +  compatible:
> +items:
> +  - const: qcom,sc7180-mdss

blank line between properties.

> +  reg:
> +maxItems: 1
> +
> +  reg-names:
> +const: mdss
> +
> +  power-domains:
> +maxItems: 1
> +
> +  clocks:
> +maxItems: 3
> +
> +  clock-names:
> +description: |
> +  Device clock names in the same order as mentioned in clocks property.
> +  The required clocks are mentioned below.

Not a useful description. Unless you have something specific about 
*this* device, drop it.

> +items:
> +  - const: iface
> +  - const: ahb
> +  - const: core
> +
> +  interrupts:
> +maxItems: 1
> +
> +  interrupt-controller: true
> +
> +  "#interrupt-cells":
> +const: 1
> +
> +  iommus:
> +maxItems: 1
> +
> +  "#address-cells":
> +const: 2
> +
> +  "#size-cells":
> +const: 2
> +
> +  ranges: true
> +
> +  interconnects:
> +description: |
> +  Interconnect path specifier for MDSS 

[v4] dt-bindings: msm: disp: add yaml schemas for DPU and DSI bindings

2020-05-19 Thread Krishna Manikandan
MSM Mobile Display Subsytem (MDSS) encapsulates sub-blocks
like DPU display controller, DSI etc. Add YAML schema
for the device tree bindings for the same.

Signed-off-by: Krishna Manikandan 

Changes in v2:
- Changed dpu to DPU (Sam Ravnborg)
- Fixed indentation issues (Sam Ravnborg)
- Added empty line between different properties (Sam Ravnborg)
- Replaced reference txt files with  their corresponding
  yaml files (Sam Ravnborg)
- Modified the file to use "|" only when it is
  necessary (Sam Ravnborg)

Changes in v3:
- Corrected the license used (Rob Herring)
- Added maxItems for properties (Rob Herring)
- Dropped generic descriptions (Rob Herring)
- Added ranges property (Rob Herring)
- Corrected the indendation (Rob Herring)
- Added additionalProperties (Rob Herring)
- Split dsi file into two, one for dsi controller
  and another one for dsi phy per target (Rob Herring)
- Corrected description for pinctrl-names (Rob Herring)
- Corrected the examples used in yaml file (Rob Herring)
- Delete dsi.txt and dpu.txt (Rob Herring)

Changes in v4:
- Move schema up by one level (Rob Herring)
- Add patternProperties for mdp node (Rob Herring)
- Corrected description of some properties (Rob Herring)
---
 .../bindings/display/msm/dpu-sc7180.yaml   | 243 
 .../bindings/display/msm/dpu-sdm845.yaml   | 220 ++
 .../devicetree/bindings/display/msm/dpu.txt| 141 
 .../display/msm/dsi-controller-sc7180.yaml | 123 +++
 .../display/msm/dsi-controller-sdm845.yaml | 120 ++
 .../bindings/display/msm/dsi-controller.yaml   | 151 +
 .../bindings/display/msm/dsi-phy-sc7180.yaml   |  75 +++
 .../bindings/display/msm/dsi-phy-sdm845.yaml   |  76 +++
 .../devicetree/bindings/display/msm/dsi-phy.yaml   |  82 +++
 .../devicetree/bindings/display/msm/dsi.txt| 246 -
 10 files changed, 1090 insertions(+), 387 deletions(-)
 create mode 100644 
Documentation/devicetree/bindings/display/msm/dpu-sc7180.yaml
 create mode 100644 
Documentation/devicetree/bindings/display/msm/dpu-sdm845.yaml
 delete mode 100644 Documentation/devicetree/bindings/display/msm/dpu.txt
 create mode 100644 
Documentation/devicetree/bindings/display/msm/dsi-controller-sc7180.yaml
 create mode 100644 
Documentation/devicetree/bindings/display/msm/dsi-controller-sdm845.yaml
 create mode 100644 
Documentation/devicetree/bindings/display/msm/dsi-controller.yaml
 create mode 100644 
Documentation/devicetree/bindings/display/msm/dsi-phy-sc7180.yaml
 create mode 100644 
Documentation/devicetree/bindings/display/msm/dsi-phy-sdm845.yaml
 create mode 100644 Documentation/devicetree/bindings/display/msm/dsi-phy.yaml
 delete mode 100644 Documentation/devicetree/bindings/display/msm/dsi.txt

diff --git a/Documentation/devicetree/bindings/display/msm/dpu-sc7180.yaml 
b/Documentation/devicetree/bindings/display/msm/dpu-sc7180.yaml
new file mode 100644
index 000..b5607f9
--- /dev/null
+++ b/Documentation/devicetree/bindings/display/msm/dpu-sc7180.yaml
@@ -0,0 +1,243 @@
+# SPDX-License-Identifier: GPL-2.0-only or BSD-2-Clause
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/display/msm/dpu-sc7180.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Description of Qualcomm Display DPU dt properties.
+
+maintainers:
+  - Krishna Manikandan 
+
+description: |
+  Device tree bindings for MSM Mobile Display Subsytem(MDSS) that encapsulates
+  sub-blocks like DPU display controller, DSI and DP interfaces etc. Device 
tree
+  bindings of MDSS and DPU are mentioned for SC7180 target.
+
+properties:
+  compatible:
+items:
+  - const: qcom,sc7180-mdss
+  reg:
+maxItems: 1
+
+  reg-names:
+const: mdss
+
+  power-domains:
+maxItems: 1
+
+  clocks:
+maxItems: 3
+
+  clock-names:
+description: |
+  Device clock names in the same order as mentioned in clocks property.
+  The required clocks are mentioned below.
+items:
+  - const: iface
+  - const: ahb
+  - const: core
+
+  interrupts:
+maxItems: 1
+
+  interrupt-controller: true
+
+  "#interrupt-cells":
+const: 1
+
+  iommus:
+maxItems: 1
+
+  "#address-cells":
+const: 2
+
+  "#size-cells":
+const: 2
+
+  ranges: true
+
+  interconnects:
+description: |
+  Interconnect path specifier for MDSS according to
+  Documentation/devicetree/bindings/interconnect/interconnect.txt.
+  An entry should contain 2 paths corresponding to 2 AXI ports representing
+  source and destination ports.
+maxItems: 1
+
+  interconnect-names:
+description: |
+  MDSS will have 2 port names to differentiate between the
+  2 interconnect paths defined with interconnect specifier.
+maxItems: 1
+
+  assigned-clocks: