Re: [v4l-dvb-maintainer] Re: [GIT PATCHES] V4L/DVB updates
On Mon, 16 Apr 2007, Dmitry Torokhov wrote: > Hi Mauro, > > On 4/15/07, Mauro Carvalho Chehab <[EMAIL PROTECTED]> wrote: > > - Fix Kernel Bugzilla #8301: spinlock fix for flexcop-pci > > While move of spin_lock_init before request_irq is obviously correct I > wonder what is the reason behind changing spin_lock_irq() into > spin_lock_irqsave() as I do not see flexcop_pci_isr being called from > anywhere but IRQ context. > > BTW, is irq_lock needed at all? There was some more discussion on the linux-dvb list http://www.linuxtv.org/pipermail/linux-dvb/2007-April/017024.html , and I think we came to the conclusion that irq_lock isn't needed at all. It does nothing but serialize the ISR and ISRs are automatically serialized by the kernel. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [v4l-dvb-maintainer] Re: [GIT PATCHES] V4L/DVB updates
On Mon, 16 Apr 2007, Dmitry Torokhov wrote: Hi Mauro, On 4/15/07, Mauro Carvalho Chehab [EMAIL PROTECTED] wrote: - Fix Kernel Bugzilla #8301: spinlock fix for flexcop-pci While move of spin_lock_init before request_irq is obviously correct I wonder what is the reason behind changing spin_lock_irq() into spin_lock_irqsave() as I do not see flexcop_pci_isr being called from anywhere but IRQ context. BTW, is irq_lock needed at all? There was some more discussion on the linux-dvb list http://www.linuxtv.org/pipermail/linux-dvb/2007-April/017024.html , and I think we came to the conclusion that irq_lock isn't needed at all. It does nothing but serialize the ISR and ISRs are automatically serialized by the kernel. - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
