Re: [v5] dt-bindings: msm: disp: add yaml schemas for DPU and DSI bindings
On Fri, Jul 10, 2020 at 07:27:49PM +0530, Krishna Manikandan wrote:
> MSM Mobile Display Subsytem (MDSS) encapsulates sub-blocks
> like DPU display controller, DSI etc. Add YAML schema
> for the device tree bindings for the same.
>
> Signed-off-by: Krishna Manikandan
>
> Changes in v2:
> - Changed dpu to DPU (Sam Ravnborg)
> - Fixed indentation issues (Sam Ravnborg)
> - Added empty line between different properties (Sam Ravnborg)
> - Replaced reference txt files with their corresponding
> yaml files (Sam Ravnborg)
> - Modified the file to use "|" only when it is
> necessary (Sam Ravnborg)
>
> Changes in v3:
> - Corrected the license used (Rob Herring)
> - Added maxItems for properties (Rob Herring)
> - Dropped generic descriptions (Rob Herring)
> - Added ranges property (Rob Herring)
> - Corrected the indendation (Rob Herring)
> - Added additionalProperties (Rob Herring)
> - Split dsi file into two, one for dsi controller
> and another one for dsi phy per target (Rob Herring)
> - Corrected description for pinctrl-names (Rob Herring)
> - Corrected the examples used in yaml file (Rob Herring)
> - Delete dsi.txt and dpu.txt (Rob Herring)
>
> Changes in v4:
> - Move schema up by one level (Rob Herring)
> - Add patternProperties for mdp node (Rob Herring)
> - Corrected description of some properties (Rob Herring)
>
> Changes in v5:
> - Correct the indentation (Rob Herring)
> - Remove unnecessary description from properties (Rob Herring)
> - Correct the number of interconnect entries (Rob Herring)
> - Add interconnect names for sc7180 (Rob Herring)
> - Add description for ports (Rob Herring)
> - Remove common properties (Rob Herring)
> - Add unevalutatedProperties (Rob Herring)
> - Reference existing dsi controller yaml in the common
> dsi controller file (Rob Herring)
> - Correct the description of clock names to include only the
> clocks that are required (Rob Herring)
> - Remove properties which are already covered under the common
> binding (Rob Herring)
> - Add dsi phy supply nodes which are required for sc7180 and
> sdm845 targets (Rob Herring)
> - Add type ref for syscon-sfpb (Rob Herring)
> ---
> .../bindings/display/dsi-controller.yaml | 4 +-
> .../bindings/display/msm/dpu-sc7180.yaml | 230 +++
> .../bindings/display/msm/dpu-sdm845.yaml | 210 ++
> .../devicetree/bindings/display/msm/dpu.txt| 141
> .../display/msm/dsi-common-controller.yaml | 178 +++
> .../display/msm/dsi-controller-sc7180.yaml | 115 ++
> .../display/msm/dsi-controller-sdm845.yaml | 115 ++
> .../bindings/display/msm/dsi-phy-sc7180.yaml | 79 +++
> .../bindings/display/msm/dsi-phy-sdm845.yaml | 81 +++
> .../devicetree/bindings/display/msm/dsi-phy.yaml | 79 +++
> .../devicetree/bindings/display/msm/dsi.txt| 246
> -
> 11 files changed, 1089 insertions(+), 389 deletions(-)
> create mode 100644
> Documentation/devicetree/bindings/display/msm/dpu-sc7180.yaml
> create mode 100644
> Documentation/devicetree/bindings/display/msm/dpu-sdm845.yaml
> delete mode 100644 Documentation/devicetree/bindings/display/msm/dpu.txt
> create mode 100644
> Documentation/devicetree/bindings/display/msm/dsi-common-controller.yaml
> create mode 100644
> Documentation/devicetree/bindings/display/msm/dsi-controller-sc7180.yaml
> create mode 100644
> Documentation/devicetree/bindings/display/msm/dsi-controller-sdm845.yaml
> create mode 100644
> Documentation/devicetree/bindings/display/msm/dsi-phy-sc7180.yaml
> create mode 100644
> Documentation/devicetree/bindings/display/msm/dsi-phy-sdm845.yaml
> create mode 100644 Documentation/devicetree/bindings/display/msm/dsi-phy.yaml
> delete mode 100644 Documentation/devicetree/bindings/display/msm/dsi.txt
>
> diff --git a/Documentation/devicetree/bindings/display/dsi-controller.yaml
> b/Documentation/devicetree/bindings/display/dsi-controller.yaml
> index fd986c3..85b71b1 100644
> --- a/Documentation/devicetree/bindings/display/dsi-controller.yaml
> +++ b/Documentation/devicetree/bindings/display/dsi-controller.yaml
> @@ -28,7 +28,7 @@ description: |
>
> properties:
>$nodename:
> -pattern: "^dsi-controller(@.*)?$"
> +pattern: "^dsi(@.*)?$"
>
>"#address-cells":
> const: 1
> @@ -76,7 +76,7 @@ patternProperties:
> examples:
>- |
> #include
> -dsi-controller@a0351000 {
> +dsi@a0351000 {
> reg = <0xa0351000 0x1000>;
> #address-cells = <1>;
> #size-cells = <0>;
> diff --git a/Documentation/devicetree/bindings/display/msm/dpu-sc7180.yaml
> b/Documentation/devicetree/bindings/display/msm/dpu-sc7180.yam
Re: [v5] dt-bindings: msm: disp: add yaml schemas for DPU and DSI bindings
On Fri, 10 Jul 2020 19:27:49 +0530, Krishna Manikandan wrote: > MSM Mobile Display Subsytem (MDSS) encapsulates sub-blocks > like DPU display controller, DSI etc. Add YAML schema > for the device tree bindings for the same. > > Signed-off-by: Krishna Manikandan > > Changes in v2: > - Changed dpu to DPU (Sam Ravnborg) > - Fixed indentation issues (Sam Ravnborg) > - Added empty line between different properties (Sam Ravnborg) > - Replaced reference txt files with their corresponding > yaml files (Sam Ravnborg) > - Modified the file to use "|" only when it is > necessary (Sam Ravnborg) > > Changes in v3: > - Corrected the license used (Rob Herring) > - Added maxItems for properties (Rob Herring) > - Dropped generic descriptions (Rob Herring) > - Added ranges property (Rob Herring) > - Corrected the indendation (Rob Herring) > - Added additionalProperties (Rob Herring) > - Split dsi file into two, one for dsi controller > and another one for dsi phy per target (Rob Herring) > - Corrected description for pinctrl-names (Rob Herring) > - Corrected the examples used in yaml file (Rob Herring) > - Delete dsi.txt and dpu.txt (Rob Herring) > > Changes in v4: > - Move schema up by one level (Rob Herring) > - Add patternProperties for mdp node (Rob Herring) > - Corrected description of some properties (Rob Herring) > > Changes in v5: > - Correct the indentation (Rob Herring) > - Remove unnecessary description from properties (Rob Herring) > - Correct the number of interconnect entries (Rob Herring) > - Add interconnect names for sc7180 (Rob Herring) > - Add description for ports (Rob Herring) > - Remove common properties (Rob Herring) > - Add unevalutatedProperties (Rob Herring) > - Reference existing dsi controller yaml in the common > dsi controller file (Rob Herring) > - Correct the description of clock names to include only the > clocks that are required (Rob Herring) > - Remove properties which are already covered under the common > binding (Rob Herring) > - Add dsi phy supply nodes which are required for sc7180 and > sdm845 targets (Rob Herring) > - Add type ref for syscon-sfpb (Rob Herring) > --- > .../bindings/display/dsi-controller.yaml | 4 +- > .../bindings/display/msm/dpu-sc7180.yaml | 230 +++ > .../bindings/display/msm/dpu-sdm845.yaml | 210 ++ > .../devicetree/bindings/display/msm/dpu.txt| 141 > .../display/msm/dsi-common-controller.yaml | 178 +++ > .../display/msm/dsi-controller-sc7180.yaml | 115 ++ > .../display/msm/dsi-controller-sdm845.yaml | 115 ++ > .../bindings/display/msm/dsi-phy-sc7180.yaml | 79 +++ > .../bindings/display/msm/dsi-phy-sdm845.yaml | 81 +++ > .../devicetree/bindings/display/msm/dsi-phy.yaml | 79 +++ > .../devicetree/bindings/display/msm/dsi.txt| 246 > - > 11 files changed, 1089 insertions(+), 389 deletions(-) > create mode 100644 > Documentation/devicetree/bindings/display/msm/dpu-sc7180.yaml > create mode 100644 > Documentation/devicetree/bindings/display/msm/dpu-sdm845.yaml > delete mode 100644 Documentation/devicetree/bindings/display/msm/dpu.txt > create mode 100644 > Documentation/devicetree/bindings/display/msm/dsi-common-controller.yaml > create mode 100644 > Documentation/devicetree/bindings/display/msm/dsi-controller-sc7180.yaml > create mode 100644 > Documentation/devicetree/bindings/display/msm/dsi-controller-sdm845.yaml > create mode 100644 > Documentation/devicetree/bindings/display/msm/dsi-phy-sc7180.yaml > create mode 100644 > Documentation/devicetree/bindings/display/msm/dsi-phy-sdm845.yaml > create mode 100644 Documentation/devicetree/bindings/display/msm/dsi-phy.yaml > delete mode 100644 Documentation/devicetree/bindings/display/msm/dsi.txt > My bot found errors running 'make dt_binding_check' on your patch: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/display/msm/dsi-controller-sc7180.example.dt.yaml: example-0: dsi@ae94000:reg:0: [0, 183058432, 0, 1024] is too long /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/display/msm/dpu-sdm845.example.dt.yaml: example-0: mdss@ae0:reg:0: [0, 182452224, 0, 4096] is too long /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/display/msm/dsi-phy-sc7180.example.dt.yaml: example-0: dsi-phy@ae94400:reg:0: [0, 183059456, 0, 512] is too long /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/display/msm/dsi-phy-sc7180.example.dt.yaml: example-0: dsi-phy@ae94400:reg:1: [0, 183059968, 0, 640] is too long /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/display/msm/d
[v5] dt-bindings: msm: disp: add yaml schemas for DPU and DSI bindings
MSM Mobile Display Subsytem (MDSS) encapsulates sub-blocks
like DPU display controller, DSI etc. Add YAML schema
for the device tree bindings for the same.
Signed-off-by: Krishna Manikandan
Changes in v2:
- Changed dpu to DPU (Sam Ravnborg)
- Fixed indentation issues (Sam Ravnborg)
- Added empty line between different properties (Sam Ravnborg)
- Replaced reference txt files with their corresponding
yaml files (Sam Ravnborg)
- Modified the file to use "|" only when it is
necessary (Sam Ravnborg)
Changes in v3:
- Corrected the license used (Rob Herring)
- Added maxItems for properties (Rob Herring)
- Dropped generic descriptions (Rob Herring)
- Added ranges property (Rob Herring)
- Corrected the indendation (Rob Herring)
- Added additionalProperties (Rob Herring)
- Split dsi file into two, one for dsi controller
and another one for dsi phy per target (Rob Herring)
- Corrected description for pinctrl-names (Rob Herring)
- Corrected the examples used in yaml file (Rob Herring)
- Delete dsi.txt and dpu.txt (Rob Herring)
Changes in v4:
- Move schema up by one level (Rob Herring)
- Add patternProperties for mdp node (Rob Herring)
- Corrected description of some properties (Rob Herring)
Changes in v5:
- Correct the indentation (Rob Herring)
- Remove unnecessary description from properties (Rob Herring)
- Correct the number of interconnect entries (Rob Herring)
- Add interconnect names for sc7180 (Rob Herring)
- Add description for ports (Rob Herring)
- Remove common properties (Rob Herring)
- Add unevalutatedProperties (Rob Herring)
- Reference existing dsi controller yaml in the common
dsi controller file (Rob Herring)
- Correct the description of clock names to include only the
clocks that are required (Rob Herring)
- Remove properties which are already covered under the common
binding (Rob Herring)
- Add dsi phy supply nodes which are required for sc7180 and
sdm845 targets (Rob Herring)
- Add type ref for syscon-sfpb (Rob Herring)
---
.../bindings/display/dsi-controller.yaml | 4 +-
.../bindings/display/msm/dpu-sc7180.yaml | 230 +++
.../bindings/display/msm/dpu-sdm845.yaml | 210 ++
.../devicetree/bindings/display/msm/dpu.txt| 141
.../display/msm/dsi-common-controller.yaml | 178 +++
.../display/msm/dsi-controller-sc7180.yaml | 115 ++
.../display/msm/dsi-controller-sdm845.yaml | 115 ++
.../bindings/display/msm/dsi-phy-sc7180.yaml | 79 +++
.../bindings/display/msm/dsi-phy-sdm845.yaml | 81 +++
.../devicetree/bindings/display/msm/dsi-phy.yaml | 79 +++
.../devicetree/bindings/display/msm/dsi.txt| 246 -
11 files changed, 1089 insertions(+), 389 deletions(-)
create mode 100644
Documentation/devicetree/bindings/display/msm/dpu-sc7180.yaml
create mode 100644
Documentation/devicetree/bindings/display/msm/dpu-sdm845.yaml
delete mode 100644 Documentation/devicetree/bindings/display/msm/dpu.txt
create mode 100644
Documentation/devicetree/bindings/display/msm/dsi-common-controller.yaml
create mode 100644
Documentation/devicetree/bindings/display/msm/dsi-controller-sc7180.yaml
create mode 100644
Documentation/devicetree/bindings/display/msm/dsi-controller-sdm845.yaml
create mode 100644
Documentation/devicetree/bindings/display/msm/dsi-phy-sc7180.yaml
create mode 100644
Documentation/devicetree/bindings/display/msm/dsi-phy-sdm845.yaml
create mode 100644 Documentation/devicetree/bindings/display/msm/dsi-phy.yaml
delete mode 100644 Documentation/devicetree/bindings/display/msm/dsi.txt
diff --git a/Documentation/devicetree/bindings/display/dsi-controller.yaml
b/Documentation/devicetree/bindings/display/dsi-controller.yaml
index fd986c3..85b71b1 100644
--- a/Documentation/devicetree/bindings/display/dsi-controller.yaml
+++ b/Documentation/devicetree/bindings/display/dsi-controller.yaml
@@ -28,7 +28,7 @@ description: |
properties:
$nodename:
-pattern: "^dsi-controller(@.*)?$"
+pattern: "^dsi(@.*)?$"
"#address-cells":
const: 1
@@ -76,7 +76,7 @@ patternProperties:
examples:
- |
#include
-dsi-controller@a0351000 {
+dsi@a0351000 {
reg = <0xa0351000 0x1000>;
#address-cells = <1>;
#size-cells = <0>;
diff --git a/Documentation/devicetree/bindings/display/msm/dpu-sc7180.yaml
b/Documentation/devicetree/bindings/display/msm/dpu-sc7180.yaml
new file mode 100644
index 000..3afa85c
--- /dev/null
+++ b/Documentation/devicetree/bindings/display/msm/dpu-sc7180.yaml
@@ -0,0 +1,230 @@
+# SPDX-License-Identifier: GPL-2.0-only or BSD-2-Clause
+%YAML
