Re: - mmconfig-validate-against-acpi-motherboard-resources.patch removed from -mm tree
On Thursday, October 25, 2007 10:27 pm Greg KH wrote: > On Thu, Oct 25, 2007 at 11:03:51PM -0600, Robert Hancock wrote: > > Greg KH wrote: > >> On Thu, Oct 25, 2007 at 04:22:35PM -0700, Jesse Barnes wrote: > >>> I think Greg doesn't like it, even though we don't have an > >>> alternative at this point... > >> > >> Yes, I didn't like it, Ivan didn't like it, and I got reports that > >> it wasn't even needed at all once you upgraded your BIOS to the > >> latest version. > >> So, is this still needed? And if so, can you try to implement > >> what Ivan suggested to do here instead? > > > > Aren't you guys referring to > > pci-disable-decode-of-io-memory-during-bar-sizing.patch? This is > > another one entirely, though related. > > I have no idea, there have been a lot of conflicting patches in this > area... Oh sorry, my confusion. I don't know what happened to the mmconfig vs. ACPI resources patch. Jesse - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: - mmconfig-validate-against-acpi-motherboard-resources.patch removed from -mm tree
On Thursday, October 25, 2007 10:27 pm Greg KH wrote: On Thu, Oct 25, 2007 at 11:03:51PM -0600, Robert Hancock wrote: Greg KH wrote: On Thu, Oct 25, 2007 at 04:22:35PM -0700, Jesse Barnes wrote: I think Greg doesn't like it, even though we don't have an alternative at this point... Yes, I didn't like it, Ivan didn't like it, and I got reports that it wasn't even needed at all once you upgraded your BIOS to the latest version. So, is this still needed? And if so, can you try to implement what Ivan suggested to do here instead? Aren't you guys referring to pci-disable-decode-of-io-memory-during-bar-sizing.patch? This is another one entirely, though related. I have no idea, there have been a lot of conflicting patches in this area... Oh sorry, my confusion. I don't know what happened to the mmconfig vs. ACPI resources patch. Jesse - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: - mmconfig-validate-against-acpi-motherboard-resources.patch removed from -mm tree
On Thu, Oct 25, 2007 at 11:03:51PM -0600, Robert Hancock wrote: > Greg KH wrote: >> On Thu, Oct 25, 2007 at 04:22:35PM -0700, Jesse Barnes wrote: >>> I think Greg doesn't like it, even though we don't have an alternative at >>> this point... >> Yes, I didn't like it, Ivan didn't like it, and I got reports that it >> wasn't even needed at all once you upgraded your BIOS to the latest >> version. >> So, is this still needed? And if so, can you try to implement what Ivan >> suggested to do here instead? > > Aren't you guys referring to > pci-disable-decode-of-io-memory-during-bar-sizing.patch? This is another > one entirely, though related. I have no idea, there have been a lot of conflicting patches in this area... - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: - mmconfig-validate-against-acpi-motherboard-resources.patch removed from -mm tree
Greg KH wrote: On Thu, Oct 25, 2007 at 04:22:35PM -0700, Jesse Barnes wrote: I think Greg doesn't like it, even though we don't have an alternative at this point... Yes, I didn't like it, Ivan didn't like it, and I got reports that it wasn't even needed at all once you upgraded your BIOS to the latest version. So, is this still needed? And if so, can you try to implement what Ivan suggested to do here instead? Aren't you guys referring to pci-disable-decode-of-io-memory-during-bar-sizing.patch? This is another one entirely, though related. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: - mmconfig-validate-against-acpi-motherboard-resources.patch removed from -mm tree
On Thu, Oct 25, 2007 at 04:22:35PM -0700, Jesse Barnes wrote: > I think Greg doesn't like it, even though we don't have an alternative > at this point... Yes, I didn't like it, Ivan didn't like it, and I got reports that it wasn't even needed at all once you upgraded your BIOS to the latest version. So, is this still needed? And if so, can you try to implement what Ivan suggested to do here instead? thanks, greg k-h - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: - mmconfig-validate-against-acpi-motherboard-resources.patch removed from -mm tree
I think Greg doesn't like it, even though we don't have an alternative
at this point...
Jesse
On Thursday, October 25, 2007 4:20 pm Robert Hancock wrote:
> Where did this patch go? I didn't get notified that anyone dropped
> it, but I don't see it in current -git..
>
> [EMAIL PROTECTED] wrote:
> > The patch titled
> > MMCONFIG: validate against ACPI motherboard resources
> > has been removed from the -mm tree. Its filename was
> > mmconfig-validate-against-acpi-motherboard-resources.patch
> >
> > This patch was dropped because it was merged into mainline or a
> > subsystem tree
> >
> > --
> > Subject: MMCONFIG: validate against ACPI motherboard resources
> > From: Robert Hancock <[EMAIL PROTECTED]>
> >
> > This path adds validation of the MMCONFIG table against the ACPI
> > reserved motherboard resources. If the MMCONFIG table is found to
> > be reserved in ACPI, we don't bother checking the E820 table. The
> > PCI Express firmware spec apparently tells BIOS developers that
> > reservation in ACPI is required and E820 reservation is optional,
> > so checking against ACPI first makes sense. Many BIOSes don't
> > reserve the MMCONFIG region in E820 even though it is perfectly
> > functional, the existing check needlessly disables MMCONFIG in
> > these cases.
> >
> > In order to do this, MMCONFIG setup has been split into two phases.
> > If PCI configuration type 1 is not available then MMCONFIG is
> > enabled early as before. Otherwise, it is enabled later after the
> > ACPI interpreter is enabled, since we need to be able to execute
> > control methods in order to check the ACPI reserved resources.
> > Presently this is just triggered off the end of ACPI interpreter
> > initialization.
> >
> > There are a few other behavioral changes here:
> >
> > - Validate all MMCONFIG configurations provided, not just the first
> > one.
> >
> > - Validate the entire required length of each configuration
> > according to the provided ending bus number is reserved, not just
> > the minimum required allocation.
> >
> > - Validate that the area is reserved even if we read it from the
> > chipset directly and not from the MCFG table. This catches the
> > case where the BIOS didn't set the location properly in the chipset
> > and has mapped it over other things it shouldn't have.
> >
> > This also cleans up the MMCONFIG initialization functions so that
> > they simply do nothing if MMCONFIG is not compiled in.
> >
> > Based on an original patch by Rajesh Shah from Intel.
> >
> > [EMAIL PROTECTED]: many fixes and cleanups]
> > Signed-off-by: Robert Hancock <[EMAIL PROTECTED]>
> > Cc: Rajesh Shah <[EMAIL PROTECTED]>
> > Cc: Jesse Barnes <[EMAIL PROTECTED]>
> > Acked-by: Linus Torvalds <[EMAIL PROTECTED]>
> > Cc: Andi Kleen <[EMAIL PROTECTED]>
> > Cc: Greg KH <[EMAIL PROTECTED]>
> > Signed-off-by: Andrew Morton <[EMAIL PROTECTED]>
> > ---
> >
> > arch/i386/pci/init.c|4
> > arch/i386/pci/mmconfig-shared.c | 151
> > ++ arch/i386/pci/pci.h |
> > 1
> > drivers/acpi/bus.c |2
> > include/linux/pci.h |8 +
> > 5 files changed, 144 insertions(+), 22 deletions(-)
> >
> > diff -puN
> > arch/i386/pci/init.c~mmconfig-validate-against-acpi-motherboard-res
> >ources arch/i386/pci/init.c ---
> > a/arch/i386/pci/init.c~mmconfig-validate-against-acpi-motherboard-r
> >esources +++ a/arch/i386/pci/init.c
> > @@ -11,9 +11,7 @@ static __init int pci_access_init(void)
> > #ifdef CONFIG_PCI_DIRECT
> > type = pci_direct_probe();
> > #endif
> > -#ifdef CONFIG_PCI_MMCONFIG
> > - pci_mmcfg_init(type);
> > -#endif
> > + pci_mmcfg_early_init(type);
> > if (raw_pci_ops)
> > return 0;
> > #ifdef CONFIG_PCI_BIOS
> > diff -puN
> > arch/i386/pci/mmconfig-shared.c~mmconfig-validate-against-acpi-moth
> >erboard-resources arch/i386/pci/mmconfig-shared.c ---
> > a/arch/i386/pci/mmconfig-shared.c~mmconfig-validate-against-acpi-mo
> >therboard-resources +++ a/arch/i386/pci/mmconfig-shared.c
> > @@ -206,9 +206,78 @@ static void __init pci_mmcfg_insert_reso
> > pci_mmcfg_resources_inserted = 1;
> > }
> >
> > -static void __init pci_mmcfg_reject_broken(int type)
> > +static acpi_status __init check_mcfg_resource(struct acpi_resource
> > *res, + void *data)
> > +{
> > + struct resource *mcfg_res = data;
> > + struct acpi_resource_address64 address;
> > + acpi_status status;
> > +
> > + if (res->type == ACPI_RESOURCE_TYPE_FIXED_MEMORY32) {
> > + struct acpi_resource_fixed_memory32 *fixmem32 =
> > + >data.fixed_memory32;
> > + if (!fixmem32)
> > + return AE_OK;
> > + if ((mcfg_res->start >= fixmem32->address) &&
> > + (mcfg_res->end < (fixmem32->address +
> > + fixmem32->address_length))) {
> > +
Re: - mmconfig-validate-against-acpi-motherboard-resources.patch removed from -mm tree
Where did this patch go? I didn't get notified that anyone dropped it,
but I don't see it in current -git..
[EMAIL PROTECTED] wrote:
The patch titled
MMCONFIG: validate against ACPI motherboard resources
has been removed from the -mm tree. Its filename was
mmconfig-validate-against-acpi-motherboard-resources.patch
This patch was dropped because it was merged into mainline or a subsystem tree
--
Subject: MMCONFIG: validate against ACPI motherboard resources
From: Robert Hancock <[EMAIL PROTECTED]>
This path adds validation of the MMCONFIG table against the ACPI reserved
motherboard resources. If the MMCONFIG table is found to be reserved in
ACPI, we don't bother checking the E820 table. The PCI Express firmware
spec apparently tells BIOS developers that reservation in ACPI is required
and E820 reservation is optional, so checking against ACPI first makes
sense. Many BIOSes don't reserve the MMCONFIG region in E820 even though
it is perfectly functional, the existing check needlessly disables MMCONFIG
in these cases.
In order to do this, MMCONFIG setup has been split into two phases. If PCI
configuration type 1 is not available then MMCONFIG is enabled early as
before. Otherwise, it is enabled later after the ACPI interpreter is
enabled, since we need to be able to execute control methods in order to
check the ACPI reserved resources. Presently this is just triggered off
the end of ACPI interpreter initialization.
There are a few other behavioral changes here:
- Validate all MMCONFIG configurations provided, not just the first one.
- Validate the entire required length of each configuration according to
the provided ending bus number is reserved, not just the minimum required
allocation.
- Validate that the area is reserved even if we read it from the chipset
directly and not from the MCFG table. This catches the case where the
BIOS didn't set the location properly in the chipset and has mapped it
over other things it shouldn't have.
This also cleans up the MMCONFIG initialization functions so that they
simply do nothing if MMCONFIG is not compiled in.
Based on an original patch by Rajesh Shah from Intel.
[EMAIL PROTECTED]: many fixes and cleanups]
Signed-off-by: Robert Hancock <[EMAIL PROTECTED]>
Cc: Rajesh Shah <[EMAIL PROTECTED]>
Cc: Jesse Barnes <[EMAIL PROTECTED]>
Acked-by: Linus Torvalds <[EMAIL PROTECTED]>
Cc: Andi Kleen <[EMAIL PROTECTED]>
Cc: Greg KH <[EMAIL PROTECTED]>
Signed-off-by: Andrew Morton <[EMAIL PROTECTED]>
---
arch/i386/pci/init.c|4
arch/i386/pci/mmconfig-shared.c | 151 ++
arch/i386/pci/pci.h |1
drivers/acpi/bus.c |2
include/linux/pci.h |8 +
5 files changed, 144 insertions(+), 22 deletions(-)
diff -puN
arch/i386/pci/init.c~mmconfig-validate-against-acpi-motherboard-resources
arch/i386/pci/init.c
--- a/arch/i386/pci/init.c~mmconfig-validate-against-acpi-motherboard-resources
+++ a/arch/i386/pci/init.c
@@ -11,9 +11,7 @@ static __init int pci_access_init(void)
#ifdef CONFIG_PCI_DIRECT
type = pci_direct_probe();
#endif
-#ifdef CONFIG_PCI_MMCONFIG
- pci_mmcfg_init(type);
-#endif
+ pci_mmcfg_early_init(type);
if (raw_pci_ops)
return 0;
#ifdef CONFIG_PCI_BIOS
diff -puN
arch/i386/pci/mmconfig-shared.c~mmconfig-validate-against-acpi-motherboard-resources
arch/i386/pci/mmconfig-shared.c
---
a/arch/i386/pci/mmconfig-shared.c~mmconfig-validate-against-acpi-motherboard-resources
+++ a/arch/i386/pci/mmconfig-shared.c
@@ -206,9 +206,78 @@ static void __init pci_mmcfg_insert_reso
pci_mmcfg_resources_inserted = 1;
}
-static void __init pci_mmcfg_reject_broken(int type)
+static acpi_status __init check_mcfg_resource(struct acpi_resource *res,
+ void *data)
+{
+ struct resource *mcfg_res = data;
+ struct acpi_resource_address64 address;
+ acpi_status status;
+
+ if (res->type == ACPI_RESOURCE_TYPE_FIXED_MEMORY32) {
+ struct acpi_resource_fixed_memory32 *fixmem32 =
+ >data.fixed_memory32;
+ if (!fixmem32)
+ return AE_OK;
+ if ((mcfg_res->start >= fixmem32->address) &&
+ (mcfg_res->end < (fixmem32->address +
+ fixmem32->address_length))) {
+ mcfg_res->flags = 1;
+ return AE_CTRL_TERMINATE;
+ }
+ }
+ if ((res->type != ACPI_RESOURCE_TYPE_ADDRESS32) &&
+ (res->type != ACPI_RESOURCE_TYPE_ADDRESS64))
+ return AE_OK;
+
+ status = acpi_resource_to_address64(res, );
+ if (ACPI_FAILURE(status) ||
+ (address.address_length <= 0) ||
+ (address.resource_type != ACPI_MEMORY_RANGE))
+ return AE_OK;
+
+ if
Re: - mmconfig-validate-against-acpi-motherboard-resources.patch removed from -mm tree
Where did this patch go? I didn't get notified that anyone dropped it,
but I don't see it in current -git..
[EMAIL PROTECTED] wrote:
The patch titled
MMCONFIG: validate against ACPI motherboard resources
has been removed from the -mm tree. Its filename was
mmconfig-validate-against-acpi-motherboard-resources.patch
This patch was dropped because it was merged into mainline or a subsystem tree
--
Subject: MMCONFIG: validate against ACPI motherboard resources
From: Robert Hancock [EMAIL PROTECTED]
This path adds validation of the MMCONFIG table against the ACPI reserved
motherboard resources. If the MMCONFIG table is found to be reserved in
ACPI, we don't bother checking the E820 table. The PCI Express firmware
spec apparently tells BIOS developers that reservation in ACPI is required
and E820 reservation is optional, so checking against ACPI first makes
sense. Many BIOSes don't reserve the MMCONFIG region in E820 even though
it is perfectly functional, the existing check needlessly disables MMCONFIG
in these cases.
In order to do this, MMCONFIG setup has been split into two phases. If PCI
configuration type 1 is not available then MMCONFIG is enabled early as
before. Otherwise, it is enabled later after the ACPI interpreter is
enabled, since we need to be able to execute control methods in order to
check the ACPI reserved resources. Presently this is just triggered off
the end of ACPI interpreter initialization.
There are a few other behavioral changes here:
- Validate all MMCONFIG configurations provided, not just the first one.
- Validate the entire required length of each configuration according to
the provided ending bus number is reserved, not just the minimum required
allocation.
- Validate that the area is reserved even if we read it from the chipset
directly and not from the MCFG table. This catches the case where the
BIOS didn't set the location properly in the chipset and has mapped it
over other things it shouldn't have.
This also cleans up the MMCONFIG initialization functions so that they
simply do nothing if MMCONFIG is not compiled in.
Based on an original patch by Rajesh Shah from Intel.
[EMAIL PROTECTED]: many fixes and cleanups]
Signed-off-by: Robert Hancock [EMAIL PROTECTED]
Cc: Rajesh Shah [EMAIL PROTECTED]
Cc: Jesse Barnes [EMAIL PROTECTED]
Acked-by: Linus Torvalds [EMAIL PROTECTED]
Cc: Andi Kleen [EMAIL PROTECTED]
Cc: Greg KH [EMAIL PROTECTED]
Signed-off-by: Andrew Morton [EMAIL PROTECTED]
---
arch/i386/pci/init.c|4
arch/i386/pci/mmconfig-shared.c | 151 ++
arch/i386/pci/pci.h |1
drivers/acpi/bus.c |2
include/linux/pci.h |8 +
5 files changed, 144 insertions(+), 22 deletions(-)
diff -puN
arch/i386/pci/init.c~mmconfig-validate-against-acpi-motherboard-resources
arch/i386/pci/init.c
--- a/arch/i386/pci/init.c~mmconfig-validate-against-acpi-motherboard-resources
+++ a/arch/i386/pci/init.c
@@ -11,9 +11,7 @@ static __init int pci_access_init(void)
#ifdef CONFIG_PCI_DIRECT
type = pci_direct_probe();
#endif
-#ifdef CONFIG_PCI_MMCONFIG
- pci_mmcfg_init(type);
-#endif
+ pci_mmcfg_early_init(type);
if (raw_pci_ops)
return 0;
#ifdef CONFIG_PCI_BIOS
diff -puN
arch/i386/pci/mmconfig-shared.c~mmconfig-validate-against-acpi-motherboard-resources
arch/i386/pci/mmconfig-shared.c
---
a/arch/i386/pci/mmconfig-shared.c~mmconfig-validate-against-acpi-motherboard-resources
+++ a/arch/i386/pci/mmconfig-shared.c
@@ -206,9 +206,78 @@ static void __init pci_mmcfg_insert_reso
pci_mmcfg_resources_inserted = 1;
}
-static void __init pci_mmcfg_reject_broken(int type)
+static acpi_status __init check_mcfg_resource(struct acpi_resource *res,
+ void *data)
+{
+ struct resource *mcfg_res = data;
+ struct acpi_resource_address64 address;
+ acpi_status status;
+
+ if (res-type == ACPI_RESOURCE_TYPE_FIXED_MEMORY32) {
+ struct acpi_resource_fixed_memory32 *fixmem32 =
+ res-data.fixed_memory32;
+ if (!fixmem32)
+ return AE_OK;
+ if ((mcfg_res-start = fixmem32-address)
+ (mcfg_res-end (fixmem32-address +
+ fixmem32-address_length))) {
+ mcfg_res-flags = 1;
+ return AE_CTRL_TERMINATE;
+ }
+ }
+ if ((res-type != ACPI_RESOURCE_TYPE_ADDRESS32)
+ (res-type != ACPI_RESOURCE_TYPE_ADDRESS64))
+ return AE_OK;
+
+ status = acpi_resource_to_address64(res, address);
+ if (ACPI_FAILURE(status) ||
+ (address.address_length = 0) ||
+ (address.resource_type != ACPI_MEMORY_RANGE))
+ return AE_OK;
+
+ if ((mcfg_res-start =
Re: - mmconfig-validate-against-acpi-motherboard-resources.patch removed from -mm tree
I think Greg doesn't like it, even though we don't have an alternative
at this point...
Jesse
On Thursday, October 25, 2007 4:20 pm Robert Hancock wrote:
Where did this patch go? I didn't get notified that anyone dropped
it, but I don't see it in current -git..
[EMAIL PROTECTED] wrote:
The patch titled
MMCONFIG: validate against ACPI motherboard resources
has been removed from the -mm tree. Its filename was
mmconfig-validate-against-acpi-motherboard-resources.patch
This patch was dropped because it was merged into mainline or a
subsystem tree
--
Subject: MMCONFIG: validate against ACPI motherboard resources
From: Robert Hancock [EMAIL PROTECTED]
This path adds validation of the MMCONFIG table against the ACPI
reserved motherboard resources. If the MMCONFIG table is found to
be reserved in ACPI, we don't bother checking the E820 table. The
PCI Express firmware spec apparently tells BIOS developers that
reservation in ACPI is required and E820 reservation is optional,
so checking against ACPI first makes sense. Many BIOSes don't
reserve the MMCONFIG region in E820 even though it is perfectly
functional, the existing check needlessly disables MMCONFIG in
these cases.
In order to do this, MMCONFIG setup has been split into two phases.
If PCI configuration type 1 is not available then MMCONFIG is
enabled early as before. Otherwise, it is enabled later after the
ACPI interpreter is enabled, since we need to be able to execute
control methods in order to check the ACPI reserved resources.
Presently this is just triggered off the end of ACPI interpreter
initialization.
There are a few other behavioral changes here:
- Validate all MMCONFIG configurations provided, not just the first
one.
- Validate the entire required length of each configuration
according to the provided ending bus number is reserved, not just
the minimum required allocation.
- Validate that the area is reserved even if we read it from the
chipset directly and not from the MCFG table. This catches the
case where the BIOS didn't set the location properly in the chipset
and has mapped it over other things it shouldn't have.
This also cleans up the MMCONFIG initialization functions so that
they simply do nothing if MMCONFIG is not compiled in.
Based on an original patch by Rajesh Shah from Intel.
[EMAIL PROTECTED]: many fixes and cleanups]
Signed-off-by: Robert Hancock [EMAIL PROTECTED]
Cc: Rajesh Shah [EMAIL PROTECTED]
Cc: Jesse Barnes [EMAIL PROTECTED]
Acked-by: Linus Torvalds [EMAIL PROTECTED]
Cc: Andi Kleen [EMAIL PROTECTED]
Cc: Greg KH [EMAIL PROTECTED]
Signed-off-by: Andrew Morton [EMAIL PROTECTED]
---
arch/i386/pci/init.c|4
arch/i386/pci/mmconfig-shared.c | 151
++ arch/i386/pci/pci.h |
1
drivers/acpi/bus.c |2
include/linux/pci.h |8 +
5 files changed, 144 insertions(+), 22 deletions(-)
diff -puN
arch/i386/pci/init.c~mmconfig-validate-against-acpi-motherboard-res
ources arch/i386/pci/init.c ---
a/arch/i386/pci/init.c~mmconfig-validate-against-acpi-motherboard-r
esources +++ a/arch/i386/pci/init.c
@@ -11,9 +11,7 @@ static __init int pci_access_init(void)
#ifdef CONFIG_PCI_DIRECT
type = pci_direct_probe();
#endif
-#ifdef CONFIG_PCI_MMCONFIG
- pci_mmcfg_init(type);
-#endif
+ pci_mmcfg_early_init(type);
if (raw_pci_ops)
return 0;
#ifdef CONFIG_PCI_BIOS
diff -puN
arch/i386/pci/mmconfig-shared.c~mmconfig-validate-against-acpi-moth
erboard-resources arch/i386/pci/mmconfig-shared.c ---
a/arch/i386/pci/mmconfig-shared.c~mmconfig-validate-against-acpi-mo
therboard-resources +++ a/arch/i386/pci/mmconfig-shared.c
@@ -206,9 +206,78 @@ static void __init pci_mmcfg_insert_reso
pci_mmcfg_resources_inserted = 1;
}
-static void __init pci_mmcfg_reject_broken(int type)
+static acpi_status __init check_mcfg_resource(struct acpi_resource
*res, + void *data)
+{
+ struct resource *mcfg_res = data;
+ struct acpi_resource_address64 address;
+ acpi_status status;
+
+ if (res-type == ACPI_RESOURCE_TYPE_FIXED_MEMORY32) {
+ struct acpi_resource_fixed_memory32 *fixmem32 =
+ res-data.fixed_memory32;
+ if (!fixmem32)
+ return AE_OK;
+ if ((mcfg_res-start = fixmem32-address)
+ (mcfg_res-end (fixmem32-address +
+ fixmem32-address_length))) {
+ mcfg_res-flags = 1;
+ return AE_CTRL_TERMINATE;
+ }
+ }
+ if ((res-type != ACPI_RESOURCE_TYPE_ADDRESS32)
+ (res-type != ACPI_RESOURCE_TYPE_ADDRESS64))
+ return AE_OK;
+
+ status =
Re: - mmconfig-validate-against-acpi-motherboard-resources.patch removed from -mm tree
On Thu, Oct 25, 2007 at 04:22:35PM -0700, Jesse Barnes wrote: I think Greg doesn't like it, even though we don't have an alternative at this point... Yes, I didn't like it, Ivan didn't like it, and I got reports that it wasn't even needed at all once you upgraded your BIOS to the latest version. So, is this still needed? And if so, can you try to implement what Ivan suggested to do here instead? thanks, greg k-h - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: - mmconfig-validate-against-acpi-motherboard-resources.patch removed from -mm tree
Greg KH wrote: On Thu, Oct 25, 2007 at 04:22:35PM -0700, Jesse Barnes wrote: I think Greg doesn't like it, even though we don't have an alternative at this point... Yes, I didn't like it, Ivan didn't like it, and I got reports that it wasn't even needed at all once you upgraded your BIOS to the latest version. So, is this still needed? And if so, can you try to implement what Ivan suggested to do here instead? Aren't you guys referring to pci-disable-decode-of-io-memory-during-bar-sizing.patch? This is another one entirely, though related. - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: - mmconfig-validate-against-acpi-motherboard-resources.patch removed from -mm tree
On Thu, Oct 25, 2007 at 11:03:51PM -0600, Robert Hancock wrote: Greg KH wrote: On Thu, Oct 25, 2007 at 04:22:35PM -0700, Jesse Barnes wrote: I think Greg doesn't like it, even though we don't have an alternative at this point... Yes, I didn't like it, Ivan didn't like it, and I got reports that it wasn't even needed at all once you upgraded your BIOS to the latest version. So, is this still needed? And if so, can you try to implement what Ivan suggested to do here instead? Aren't you guys referring to pci-disable-decode-of-io-memory-during-bar-sizing.patch? This is another one entirely, though related. I have no idea, there have been a lot of conflicting patches in this area... - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
