Re: 2.6.12-rc1-mm2 (patch to fix build error In function `zft_init')
Greg KH <[EMAIL PROTECTED]> wrote: > > > I glanced at the code, and this little patch fixes the problem: > > Ick, sorry, that was my fault. I've applied this patch to my trees, > thanks. > > Hm, I wonder how I missed this, I did do a 'make allmodconfig' build to > try to catch this kind of stuff... allmodconfig doesn't catch BROKEN_ON_SMP code. I've been caught out by that a few times. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: 2.6.12-rc1-mm2 (patch to fix build error In function `zft_init')
On Thu, Mar 24, 2005 at 08:55:13AM -0700, Steven Cole wrote: > Steven Cole wrote: > >I'm getting the following build error with 2.6.12-rc1-mm2: > > > > CC init/version.o > > LD init/built-in.o > > LD .tmp_vmlinux1 > >drivers/built-in.o(.init.text+0x4323): In function `zft_init': > >: undefined reference to `class_device_creat' > >make: *** [.tmp_vmlinux1] Error 1 > > > > I glanced at the code, and this little patch fixes the problem: Ick, sorry, that was my fault. I've applied this patch to my trees, thanks. Hm, I wonder how I missed this, I did do a 'make allmodconfig' build to try to catch this kind of stuff... thanks, greg k-h - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: 2.6.12-rc1-mm2 (patch to fix build error In function `zft_init')
Steven Cole wrote:
I'm getting the following build error with 2.6.12-rc1-mm2:
CC init/version.o
LD init/built-in.o
LD .tmp_vmlinux1
drivers/built-in.o(.init.text+0x4323): In function `zft_init':
: undefined reference to `class_device_creat'
make: *** [.tmp_vmlinux1] Error 1
I glanced at the code, and this little patch fixes the problem:
Steven
Signed-off by: Steven Cole <[EMAIL PROTECTED]>
--- linux-2.6.12-rc1-mm2/drivers/char/ftape/zftape/zftape-init.c.orig
2005-03-24 08:43:30.0 -0700
+++ linux-2.6.12-rc1-mm2/drivers/char/ftape/zftape/zftape-init.c
2005-03-24 08:43:56.0 -0700
@@ -331,7 +331,7 @@
zft_class = class_create(THIS_MODULE, "zft");
for (i = 0; i < 4; i++) {
- class_device_creat(zft_class, MKDEV(QIC117_TAPE_MAJOR, i),
NULL, "qft%i", i);
+ class_device_create(zft_class, MKDEV(QIC117_TAPE_MAJOR, i),
NULL, "qft%i", i);
devfs_mk_cdev(MKDEV(QIC117_TAPE_MAJOR, i),
S_IFCHR | S_IRUSR | S_IWUSR,
"qft%i", i);
Re: 2.6.12-rc1-mm2 (patch to fix build error In function `zft_init')
Steven Cole wrote:
I'm getting the following build error with 2.6.12-rc1-mm2:
CC init/version.o
LD init/built-in.o
LD .tmp_vmlinux1
drivers/built-in.o(.init.text+0x4323): In function `zft_init':
: undefined reference to `class_device_creat'
make: *** [.tmp_vmlinux1] Error 1
I glanced at the code, and this little patch fixes the problem:
Steven
Signed-off by: Steven Cole [EMAIL PROTECTED]
--- linux-2.6.12-rc1-mm2/drivers/char/ftape/zftape/zftape-init.c.orig
2005-03-24 08:43:30.0 -0700
+++ linux-2.6.12-rc1-mm2/drivers/char/ftape/zftape/zftape-init.c
2005-03-24 08:43:56.0 -0700
@@ -331,7 +331,7 @@
zft_class = class_create(THIS_MODULE, zft);
for (i = 0; i 4; i++) {
- class_device_creat(zft_class, MKDEV(QIC117_TAPE_MAJOR, i),
NULL, qft%i, i);
+ class_device_create(zft_class, MKDEV(QIC117_TAPE_MAJOR, i),
NULL, qft%i, i);
devfs_mk_cdev(MKDEV(QIC117_TAPE_MAJOR, i),
S_IFCHR | S_IRUSR | S_IWUSR,
qft%i, i);
Re: 2.6.12-rc1-mm2 (patch to fix build error In function `zft_init')
On Thu, Mar 24, 2005 at 08:55:13AM -0700, Steven Cole wrote: Steven Cole wrote: I'm getting the following build error with 2.6.12-rc1-mm2: CC init/version.o LD init/built-in.o LD .tmp_vmlinux1 drivers/built-in.o(.init.text+0x4323): In function `zft_init': : undefined reference to `class_device_creat' make: *** [.tmp_vmlinux1] Error 1 I glanced at the code, and this little patch fixes the problem: Ick, sorry, that was my fault. I've applied this patch to my trees, thanks. Hm, I wonder how I missed this, I did do a 'make allmodconfig' build to try to catch this kind of stuff... thanks, greg k-h - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: 2.6.12-rc1-mm2 (patch to fix build error In function `zft_init')
Greg KH [EMAIL PROTECTED] wrote: I glanced at the code, and this little patch fixes the problem: Ick, sorry, that was my fault. I've applied this patch to my trees, thanks. Hm, I wonder how I missed this, I did do a 'make allmodconfig' build to try to catch this kind of stuff... allmodconfig doesn't catch BROKEN_ON_SMP code. I've been caught out by that a few times. - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
