Re: 2.6.13-rc3-mm1: horribly drivers/scsi/qla2xxx/Makefile
Andrew Vasquez wrote: > Yes, quite. How about the following to correct the intention. > > > > Add correct Kconfig option for ISP24xx support. > > Signed-off-by: Andrew Vasquez <[EMAIL PROTECTED]> > --- > > diff --git a/drivers/scsi/qla2xxx/Kconfig b/drivers/scsi/qla2xxx/Kconfig > --- a/drivers/scsi/qla2xxx/Kconfig > +++ b/drivers/scsi/qla2xxx/Kconfig > @@ -39,3 +39,11 @@ config SCSI_QLA6312 > ---help--- > This driver supports the QLogic 63xx (ISP6312 and ISP6322) host > adapter family. > + > +config SCSI_QLA24XX > + tristate "QLogic ISP24xx host adapter family support" > + depends on SCSI_QLA2XXX > +select SCSI_FC_ATTRS there should be also "select FW_LOADER", as it uses request_firmware & release_firmware > + ---help--- > + This driver supports the QLogic 24xx (ISP2422 and ISP2432) host > + adapter family. -- Jindrich Makovicka - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: 2.6.13-rc3-mm1: horribly drivers/scsi/qla2xxx/Makefile
Andrew Vasquez wrote: Yes, quite. How about the following to correct the intention. Add correct Kconfig option for ISP24xx support. Signed-off-by: Andrew Vasquez [EMAIL PROTECTED] --- diff --git a/drivers/scsi/qla2xxx/Kconfig b/drivers/scsi/qla2xxx/Kconfig --- a/drivers/scsi/qla2xxx/Kconfig +++ b/drivers/scsi/qla2xxx/Kconfig @@ -39,3 +39,11 @@ config SCSI_QLA6312 ---help--- This driver supports the QLogic 63xx (ISP6312 and ISP6322) host adapter family. + +config SCSI_QLA24XX + tristate QLogic ISP24xx host adapter family support + depends on SCSI_QLA2XXX +select SCSI_FC_ATTRS there should be also select FW_LOADER, as it uses request_firmware release_firmware + ---help--- + This driver supports the QLogic 24xx (ISP2422 and ISP2432) host + adapter family. -- Jindrich Makovicka - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: 2.6.13-rc3-mm1: horribly drivers/scsi/qla2xxx/Makefile
On Fri, 15 Jul 2005, Adrian Bunk wrote: > On Fri, Jul 15, 2005 at 01:36:53AM -0700, Andrew Morton wrote: > >... > > Changes since 2.6.13-rc2-mm2: > >... > > git-scsi-misc.patch > >... > > Subsystem trees > >... > ... > +obj-$(CONFIG_SCSI_QLA24XX) += qla2xxx.o > > > I don't know what exactly you want to achieve, but this is so horribly > wrong. Yes, quite. How about the following to correct the intention. Add correct Kconfig option for ISP24xx support. Signed-off-by: Andrew Vasquez <[EMAIL PROTECTED]> --- diff --git a/drivers/scsi/qla2xxx/Kconfig b/drivers/scsi/qla2xxx/Kconfig --- a/drivers/scsi/qla2xxx/Kconfig +++ b/drivers/scsi/qla2xxx/Kconfig @@ -39,3 +39,11 @@ config SCSI_QLA6312 ---help--- This driver supports the QLogic 63xx (ISP6312 and ISP6322) host adapter family. + +config SCSI_QLA24XX + tristate "QLogic ISP24xx host adapter family support" + depends on SCSI_QLA2XXX +select SCSI_FC_ATTRS + ---help--- + This driver supports the QLogic 24xx (ISP2422 and ISP2432) host + adapter family. diff --git a/drivers/scsi/qla2xxx/Makefile b/drivers/scsi/qla2xxx/Makefile --- a/drivers/scsi/qla2xxx/Makefile +++ b/drivers/scsi/qla2xxx/Makefile @@ -1,6 +1,4 @@ EXTRA_CFLAGS += -DUNIQUE_FW_NAME -CONFIG_SCSI_QLA24XX=m -EXTRA_CFLAGS += -DCONFIG_SCSI_QLA24XX -DCONFIG_SCSI_QLA24XX_MODULE qla2xxx-y := qla_os.o qla_init.o qla_mbx.o qla_iocb.o qla_isr.o qla_gs.o \ qla_dbg.o qla_sup.o qla_rscn.o qla_attr.o - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
2.6.13-rc3-mm1: horribly drivers/scsi/qla2xxx/Makefile
On Fri, Jul 15, 2005 at 01:36:53AM -0700, Andrew Morton wrote: >... > Changes since 2.6.13-rc2-mm2: >... > git-scsi-misc.patch >... > Subsystem trees >... --- linux-2.6.13-rc3/drivers/scsi/qla2xxx/Makefile 2005-06-17 16:04:01.0 -0700 +++ devel/drivers/scsi/qla2xxx/Makefile 2005-07-15 00:46:18.0 -0700 @@ -1,4 +1,6 @@ EXTRA_CFLAGS += -DUNIQUE_FW_NAME +CONFIG_SCSI_QLA24XX=m +EXTRA_CFLAGS += -DCONFIG_SCSI_QLA24XX -DCONFIG_SCSI_QLA24XX_MODULE qla2xxx-y := qla_os.o qla_init.o qla_mbx.o qla_iocb.o qla_isr.o qla_gs.o \ qla_dbg.o qla_sup.o qla_rscn.o qla_attr.o @@ -14,3 +16,4 @@ obj-$(CONFIG_SCSI_QLA22XX) += qla2xxx.o obj-$(CONFIG_SCSI_QLA2300) += qla2xxx.o qla2300.o obj-$(CONFIG_SCSI_QLA2322) += qla2xxx.o qla2322.o obj-$(CONFIG_SCSI_QLA6312) += qla2xxx.o qla6312.o +obj-$(CONFIG_SCSI_QLA24XX) += qla2xxx.o I don't know what exactly you want to achieve, but this is so horribly wrong. cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
2.6.13-rc3-mm1: horribly drivers/scsi/qla2xxx/Makefile
On Fri, Jul 15, 2005 at 01:36:53AM -0700, Andrew Morton wrote: ... Changes since 2.6.13-rc2-mm2: ... git-scsi-misc.patch ... Subsystem trees ... --- linux-2.6.13-rc3/drivers/scsi/qla2xxx/Makefile 2005-06-17 16:04:01.0 -0700 +++ devel/drivers/scsi/qla2xxx/Makefile 2005-07-15 00:46:18.0 -0700 @@ -1,4 +1,6 @@ EXTRA_CFLAGS += -DUNIQUE_FW_NAME +CONFIG_SCSI_QLA24XX=m +EXTRA_CFLAGS += -DCONFIG_SCSI_QLA24XX -DCONFIG_SCSI_QLA24XX_MODULE qla2xxx-y := qla_os.o qla_init.o qla_mbx.o qla_iocb.o qla_isr.o qla_gs.o \ qla_dbg.o qla_sup.o qla_rscn.o qla_attr.o @@ -14,3 +16,4 @@ obj-$(CONFIG_SCSI_QLA22XX) += qla2xxx.o obj-$(CONFIG_SCSI_QLA2300) += qla2xxx.o qla2300.o obj-$(CONFIG_SCSI_QLA2322) += qla2xxx.o qla2322.o obj-$(CONFIG_SCSI_QLA6312) += qla2xxx.o qla6312.o +obj-$(CONFIG_SCSI_QLA24XX) += qla2xxx.o I don't know what exactly you want to achieve, but this is so horribly wrong. cu Adrian -- Is there not promise of rain? Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. Only a promise, Lao Er said. Pearl S. Buck - Dragon Seed - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: 2.6.13-rc3-mm1: horribly drivers/scsi/qla2xxx/Makefile
On Fri, 15 Jul 2005, Adrian Bunk wrote: On Fri, Jul 15, 2005 at 01:36:53AM -0700, Andrew Morton wrote: ... Changes since 2.6.13-rc2-mm2: ... git-scsi-misc.patch ... Subsystem trees ... ... +obj-$(CONFIG_SCSI_QLA24XX) += qla2xxx.o I don't know what exactly you want to achieve, but this is so horribly wrong. Yes, quite. How about the following to correct the intention. Add correct Kconfig option for ISP24xx support. Signed-off-by: Andrew Vasquez [EMAIL PROTECTED] --- diff --git a/drivers/scsi/qla2xxx/Kconfig b/drivers/scsi/qla2xxx/Kconfig --- a/drivers/scsi/qla2xxx/Kconfig +++ b/drivers/scsi/qla2xxx/Kconfig @@ -39,3 +39,11 @@ config SCSI_QLA6312 ---help--- This driver supports the QLogic 63xx (ISP6312 and ISP6322) host adapter family. + +config SCSI_QLA24XX + tristate QLogic ISP24xx host adapter family support + depends on SCSI_QLA2XXX +select SCSI_FC_ATTRS + ---help--- + This driver supports the QLogic 24xx (ISP2422 and ISP2432) host + adapter family. diff --git a/drivers/scsi/qla2xxx/Makefile b/drivers/scsi/qla2xxx/Makefile --- a/drivers/scsi/qla2xxx/Makefile +++ b/drivers/scsi/qla2xxx/Makefile @@ -1,6 +1,4 @@ EXTRA_CFLAGS += -DUNIQUE_FW_NAME -CONFIG_SCSI_QLA24XX=m -EXTRA_CFLAGS += -DCONFIG_SCSI_QLA24XX -DCONFIG_SCSI_QLA24XX_MODULE qla2xxx-y := qla_os.o qla_init.o qla_mbx.o qla_iocb.o qla_isr.o qla_gs.o \ qla_dbg.o qla_sup.o qla_rscn.o qla_attr.o - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
