Re: BUG: scheduling while atomic - Linux 2.6.20-rc2-ga3d89517
On Tue, 26 Dec 2006 18:15:31 +0100 Pavel Machek wrote: > Hi! > > > some days and will let you know if the problem represents. Please note > > that it happened only twice and I don't have any clue on how to > > reproduce it. > > > > I added Pavel and Rafael to CC-list because for the first time in at > > least six months my laptop failed to resume after suspend-to-disk > > (userland tools) with this kernel. Guys, do you think that this > > failure could be related to this BUG? > > everything is possible, but this one does not seem too likely. Is > failure reproducible? Ingo just posted a patch for this problem. http://marc.theaimsgroup.com/?l=linux-kernel=116715139714252=2 --- ~Randy - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: BUG: scheduling while atomic - Linux 2.6.20-rc2-ga3d89517
Hi On 12/26/06, Pavel Machek <[EMAIL PROTECTED]> wrote: Hi! > some days and will let you know if the problem represents. Please note > that it happened only twice and I don't have any clue on how to > reproduce it. > > I added Pavel and Rafael to CC-list because for the first time in at > least six months my laptop failed to resume after suspend-to-disk > (userland tools) with this kernel. Guys, do you think that this > failure could be related to this BUG? everything is possible, but this one does not seem too likely. Is failure reproducible? Not at all. I applied Hirofumi's patch and the problem seems to be gone. But it was impossible to reproduce even without it: the BUG happened only twice and the resume failure only once. Pavel Fabio -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: BUG: scheduling while atomic - Linux 2.6.20-rc2-ga3d89517
Hi! > some days and will let you know if the problem represents. Please note > that it happened only twice and I don't have any clue on how to > reproduce it. > > I added Pavel and Rafael to CC-list because for the first time in at > least six months my laptop failed to resume after suspend-to-disk > (userland tools) with this kernel. Guys, do you think that this > failure could be related to this BUG? everything is possible, but this one does not seem too likely. Is failure reproducible? Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: BUG: scheduling while atomic - Linux 2.6.20-rc2-ga3d89517
Hi! some days and will let you know if the problem represents. Please note that it happened only twice and I don't have any clue on how to reproduce it. I added Pavel and Rafael to CC-list because for the first time in at least six months my laptop failed to resume after suspend-to-disk (userland tools) with this kernel. Guys, do you think that this failure could be related to this BUG? everything is possible, but this one does not seem too likely. Is failure reproducible? Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: BUG: scheduling while atomic - Linux 2.6.20-rc2-ga3d89517
Hi On 12/26/06, Pavel Machek [EMAIL PROTECTED] wrote: Hi! some days and will let you know if the problem represents. Please note that it happened only twice and I don't have any clue on how to reproduce it. I added Pavel and Rafael to CC-list because for the first time in at least six months my laptop failed to resume after suspend-to-disk (userland tools) with this kernel. Guys, do you think that this failure could be related to this BUG? everything is possible, but this one does not seem too likely. Is failure reproducible? Not at all. I applied Hirofumi's patch and the problem seems to be gone. But it was impossible to reproduce even without it: the BUG happened only twice and the resume failure only once. Pavel Fabio -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: BUG: scheduling while atomic - Linux 2.6.20-rc2-ga3d89517
On Tue, 26 Dec 2006 18:15:31 +0100 Pavel Machek wrote: Hi! some days and will let you know if the problem represents. Please note that it happened only twice and I don't have any clue on how to reproduce it. I added Pavel and Rafael to CC-list because for the first time in at least six months my laptop failed to resume after suspend-to-disk (userland tools) with this kernel. Guys, do you think that this failure could be related to this BUG? everything is possible, but this one does not seem too likely. Is failure reproducible? Ingo just posted a patch for this problem. http://marc.theaimsgroup.com/?l=linux-kernelm=116715139714252w=2 --- ~Randy - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: BUG: scheduling while atomic - Linux 2.6.20-rc2-ga3d89517
OK, I applied your patch to yesterday's Linus' GIT. I will run it for
some days and will let you know if the problem represents. Please note
that it happened only twice and I don't have any clue on how to
reproduce it.
I added Pavel and Rafael to CC-list because for the first time in at
least six months my laptop failed to resume after suspend-to-disk
(userland tools) with this kernel. Guys, do you think that this
failure could be related to this BUG?
Best regards and Happy Holidays,
Fabio
On 12/24/06, OGAWA Hirofumi <[EMAIL PROTECTED]> wrote:
"Fabio Comolli" <[EMAIL PROTECTED]> writes:
> Just found this in syslog. It was during normal activity, about 6
> minutes after resume-from-ram. I never saw this before.
It seems someone missed to check PREEMPT_ACTIVE in __resched_legal().
Could you please test the following patch?
--
OGAWA Hirofumi <[EMAIL PROTECTED]>
Signed-off-by: OGAWA Hirofumi <[EMAIL PROTECTED]>
---
kernel/sched.c |5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff -puN kernel/sched.c~__resched_legal kernel/sched.c
--- linux-2.6/kernel/sched.c~__resched_legal2006-12-24 22:40:19.0
+0900
+++ linux-2.6-hirofumi/kernel/sched.c 2006-12-24 23:54:01.0 +0900
@@ -4619,10 +4619,11 @@ asmlinkage long sys_sched_yield(void)
static inline int __resched_legal(int expected_preempt_count)
{
-#ifdef CONFIG_PREEMPT
+#ifndef CONFIG_PREEMPT
+ expected_preempt_count = 0;
+#endif
if (unlikely(preempt_count() != expected_preempt_count))
return 0;
-#endif
if (unlikely(system_state != SYSTEM_RUNNING))
return 0;
return 1;
_
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: BUG: scheduling while atomic - Linux 2.6.20-rc2-ga3d89517
OK, I applied your patch to yesterday's Linus' GIT. I will run it for
some days and will let you know if the problem represents. Please note
that it happened only twice and I don't have any clue on how to
reproduce it.
I added Pavel and Rafael to CC-list because for the first time in at
least six months my laptop failed to resume after suspend-to-disk
(userland tools) with this kernel. Guys, do you think that this
failure could be related to this BUG?
Best regards and Happy Holidays,
Fabio
On 12/24/06, OGAWA Hirofumi [EMAIL PROTECTED] wrote:
Fabio Comolli [EMAIL PROTECTED] writes:
Just found this in syslog. It was during normal activity, about 6
minutes after resume-from-ram. I never saw this before.
It seems someone missed to check PREEMPT_ACTIVE in __resched_legal().
Could you please test the following patch?
--
OGAWA Hirofumi [EMAIL PROTECTED]
Signed-off-by: OGAWA Hirofumi [EMAIL PROTECTED]
---
kernel/sched.c |5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff -puN kernel/sched.c~__resched_legal kernel/sched.c
--- linux-2.6/kernel/sched.c~__resched_legal2006-12-24 22:40:19.0
+0900
+++ linux-2.6-hirofumi/kernel/sched.c 2006-12-24 23:54:01.0 +0900
@@ -4619,10 +4619,11 @@ asmlinkage long sys_sched_yield(void)
static inline int __resched_legal(int expected_preempt_count)
{
-#ifdef CONFIG_PREEMPT
+#ifndef CONFIG_PREEMPT
+ expected_preempt_count = 0;
+#endif
if (unlikely(preempt_count() != expected_preempt_count))
return 0;
-#endif
if (unlikely(system_state != SYSTEM_RUNNING))
return 0;
return 1;
_
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: BUG: scheduling while atomic - Linux 2.6.20-rc2-ga3d89517
"Fabio Comolli" <[EMAIL PROTECTED]> writes:
> Just found this in syslog. It was during normal activity, about 6
> minutes after resume-from-ram. I never saw this before.
It seems someone missed to check PREEMPT_ACTIVE in __resched_legal().
Could you please test the following patch?
--
OGAWA Hirofumi <[EMAIL PROTECTED]>
Signed-off-by: OGAWA Hirofumi <[EMAIL PROTECTED]>
---
kernel/sched.c |5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff -puN kernel/sched.c~__resched_legal kernel/sched.c
--- linux-2.6/kernel/sched.c~__resched_legal2006-12-24 22:40:19.0
+0900
+++ linux-2.6-hirofumi/kernel/sched.c 2006-12-24 23:54:01.0 +0900
@@ -4619,10 +4619,11 @@ asmlinkage long sys_sched_yield(void)
static inline int __resched_legal(int expected_preempt_count)
{
-#ifdef CONFIG_PREEMPT
+#ifndef CONFIG_PREEMPT
+ expected_preempt_count = 0;
+#endif
if (unlikely(preempt_count() != expected_preempt_count))
return 0;
-#endif
if (unlikely(system_state != SYSTEM_RUNNING))
return 0;
return 1;
_
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: BUG: scheduling while atomic - Linux 2.6.20-rc2-ga3d89517
Fabio Comolli [EMAIL PROTECTED] writes:
Just found this in syslog. It was during normal activity, about 6
minutes after resume-from-ram. I never saw this before.
It seems someone missed to check PREEMPT_ACTIVE in __resched_legal().
Could you please test the following patch?
--
OGAWA Hirofumi [EMAIL PROTECTED]
Signed-off-by: OGAWA Hirofumi [EMAIL PROTECTED]
---
kernel/sched.c |5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff -puN kernel/sched.c~__resched_legal kernel/sched.c
--- linux-2.6/kernel/sched.c~__resched_legal2006-12-24 22:40:19.0
+0900
+++ linux-2.6-hirofumi/kernel/sched.c 2006-12-24 23:54:01.0 +0900
@@ -4619,10 +4619,11 @@ asmlinkage long sys_sched_yield(void)
static inline int __resched_legal(int expected_preempt_count)
{
-#ifdef CONFIG_PREEMPT
+#ifndef CONFIG_PREEMPT
+ expected_preempt_count = 0;
+#endif
if (unlikely(preempt_count() != expected_preempt_count))
return 0;
-#endif
if (unlikely(system_state != SYSTEM_RUNNING))
return 0;
return 1;
_
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
