GFS2: Pull request (fixes)
Hi, Please consider pulling the following fixes for GFS2, Steve. The following changes since commit 372b1dbdd1fb5697890b937228d93cfd9c734c90: Merge branch 'for-linus' of git://git.samba.org/sfrench/cifs-2.6 (2014-08-20 18:33:21 -0500) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/steve/gfs2-3.0-fixes.git tags/gfs2-fixes for you to fetch changes up to cfb2f9d5c921e38b0f12bb26fed10b87766d: GFS2: fix d_splice_alias() misuses (2014-09-12 20:58:55 +0100) Here are a number of small fixes for GFS2. There is a fix for FIEMAP on large sparse files, a negative dentry hashing fix, a fix for flock, and a bug fix relating to d_splice_alias usage. There are also (patches 1 and 5) a couple of updates which are less critical, but small and low risk. Al Viro (1): GFS2: fix d_splice_alias() misuses Benjamin Coddington (1): GFS2: Hash the negative dentry during inode lookup Bob Peterson (2): GFS2: Change maxlen variables to size_t GFS2: Request demote when a "try" flock fails Fabian Frederick (1): GFS2: fs/gfs2/super.c: replace seq_printf by seq_puts Jan Kara (1): GFS2: Don't use MAXQUOTAS value fs/gfs2/bmap.c | 9 + fs/gfs2/file.c | 15 --- fs/gfs2/incore.h | 7 +-- fs/gfs2/inode.c | 9 ++--- fs/gfs2/super.c | 20 ++-- 5 files changed, 38 insertions(+), 22 deletions(-) signature.asc Description: This is a digitally signed message part
GFS2: Pull request (fixes)
The following changes since commit 3c8fb50445833b93f69b6b703a29aae3523cad0c: Merge tag 'pm+acpi-3.16-rc2' of git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm (2014-06-19 18:58:57 -1000) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/steve/gfs2-3.0-fixes.git tags/gfs2-fixes for you to fetch changes up to 27ff6a0f7f5bf500e9d2a8760c062789b52c551f: GFS2: fs/gfs2/rgrp.c: kernel-doc warning fixes (2014-07-18 11:15:14 +0100) This patch set contains two minor docs/spelling fixes, some fixes for flock, a change to use GFP_NOFS to avoid recursion on a rarely used code path and a fix for a race relating to the glock lru. Bob Peterson (3): GFS2: Only wait for demote when last holder is dequeued GFS2: Allow flocks to use normal glock dq rather than dq_wait GFS2: Allow caching of glocks for flock Fabian Frederick (2): GFS2: replace count*size kzalloc by kcalloc GFS2: fs/gfs2/rgrp.c: kernel-doc warning fixes Geert Uytterhoeven (1): GFS2: memcontrol: Spelling s/invlidate/invalidate/ Steven Whitehouse (2): GFS2: Fix race in glock lru glock disposal GFS2: Use GFP_NOFS when allocating glocks fs/gfs2/file.c | 4 ++-- fs/gfs2/glock.c| 14 +- fs/gfs2/glops.c| 4 ++-- fs/gfs2/lock_dlm.c | 4 ++-- fs/gfs2/rgrp.c | 4 ++-- 5 files changed, 17 insertions(+), 13 deletions(-) signature.asc Description: This is a digitally signed message part
GFS2: Pull request (fixes)
Hi, Please consider pulling the following bug fixes, Steve. - The following changes since commit 7e3528c3660a2e8602abc7858b0994d611f74bc3: slab.h: remove duplicate kmalloc declaration and fix kernel-doc warnings (2013-11-24 11:01:16 -0800) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/steve/gfs2-3.0-fixes.git tags/gfs2-fixes for you to fetch changes up to 0b3a2c9968d453d5827e635a6f3d69129f70af66: GFS2: Fix unsafe dereference in dump_holder() (2014-01-02 12:18:04 +) Here is a set of small fixes for GFS2. There is a fix to drop s_umount which is copied in from the core vfs, two patches relate to a hard to hit "use after free" and memory leak. Two patches related to using DIO and buffered I/O on the same file to ensure correct operation in relation to glock state changes. The final patch adds an RCU read lock to ensure correct locking on an error path. Bob Peterson (2): GFS2: Fix use-after-free race when calling gfs2_remove_from_ail GFS2: Fix slab memory leak in gfs2_bufdata Steven Whitehouse (3): GFS2: don't hold s_umount over blkdev_put GFS2: Fix incorrect invalidation for DIO/buffered I/O GFS2: Wait for async DIO in glock state changes Tetsuo Handa (1): GFS2: Fix unsafe dereference in dump_holder() fs/gfs2/aops.c | 30 ++ fs/gfs2/glock.c | 2 ++ fs/gfs2/glops.c | 10 -- fs/gfs2/log.c| 4 ++-- fs/gfs2/meta_io.c| 5 + fs/gfs2/ops_fstype.c | 12 +++- 6 files changed, 58 insertions(+), 5 deletions(-) signature.asc Description: This is a digitally signed message part
GFS2: Pull request (fixes)
Hi, Please consider pulling the following fixes, Steve. The following changes since commit ea0341e071527d5cec350917b01ab901af09d758: GFS2: Fix ref count bug relating to atomic_open (2013-11-21 18:47:57 +) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/steve/gfs2-3.0-fixes.git tags/gfs2-fixes for you to fetch changes up to ea0341e071527d5cec350917b01ab901af09d758: GFS2: Fix ref count bug relating to atomic_open (2013-11-21 18:47:57 +) A couple of small, but important bug fixes for GFS2. The first one fixes a possible NULL pointer dereference, and the second one resolves a reference counting issue in one of the lesser used paths through atomic_open. fs/gfs2/glock.c |3 ++- fs/gfs2/inode.c |5 - 2 files changed, 6 insertions(+), 2 deletions(-) signature.asc Description: This is a digitally signed message part
Re: GFS2: Pull request (fixes)
On Mon, Aug 19, 2013 at 2:26 AM, Steven Whitehouse wrote: > Oops, forgot to sign this when I sent it first, so here is a signed copy of > it. Please sign the git tag instead of the email. There are no sane tools to check email signatures etc, but git signed tags not only check your pgp key signature, they also allow you to just write the message into the tag. Also, please don't do crap like this: > are available in the git repository at: > > https://git.kernel.org/cgit/linux/kernel/git/steve/gfs2-3.0-fixes.git master Yeah, no. The proper address is git://git.kernel.org/pub/scm/linux/kernel/git/steve/gfs2-3.0-fixes not that cgit web page. Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
GFS2: Pull request (fixes)
Oops, forgot to sign this when I sent it first, so here is a signed copy of it. Hi, Please consider pulling the following changes, Steve. - Out of these five patches, the one for ensuring that the number of revokes is not exceeded, and the one for checking the glock is not already held in gfs2_getxattr are the two most important. The latter can be triggered by selinux. The other three patches are very small and fix mostly fairly trivial issues. -- The following changes since commit 47188d39b5deeebf41f87a02af1b3935866364cf: Merge tag 'ext4_for_linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4 (2013-07-14 21:47:51 -0700) are available in the git repository at: https://git.kernel.org/cgit/linux/kernel/git/steve/gfs2-3.0-fixes.git master Benjamin Marzinski (1): GFS2: don't overrun reserved revokes Dan Carpenter (1): GFS2: alloc_workqueue() doesn't return an ERR_PTR Steven Whitehouse (2): GFS2: Fix typo in gfs2_create_inode() GFS2: Check for glock already held in gfs2_getxattr Tejun Heo (1): GFS2: WQ_NON_REENTRANT is meaningless and going away fs/gfs2/glock.c |8 fs/gfs2/glops.c | 18 +- fs/gfs2/inode.c |6 +- fs/gfs2/main.c |2 +- 4 files changed, 23 insertions(+), 11 deletions(-) signature.asc Description: This is a digitally signed message part
GFS2: Pull request (fixes)
Hi, Please consider pulling the following changes, Steve. - Out of these five patches, the one for ensuring that the number of revokes is not exceeded, and the one for checking the glock is not already held in gfs2_getxattr are the two most important. The latter can be triggered by selinux. The other three patches are very small and fix mostly fairly trivial issues. -- The following changes since commit 47188d39b5deeebf41f87a02af1b3935866364cf: Merge tag 'ext4_for_linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4 (2013-07-14 21:47:51 -0700) are available in the git repository at: https://git.kernel.org/cgit/linux/kernel/git/steve/gfs2-3.0-fixes.git master Benjamin Marzinski (1): GFS2: don't overrun reserved revokes Dan Carpenter (1): GFS2: alloc_workqueue() doesn't return an ERR_PTR Steven Whitehouse (2): GFS2: Fix typo in gfs2_create_inode() GFS2: Check for glock already held in gfs2_getxattr Tejun Heo (1): GFS2: WQ_NON_REENTRANT is meaningless and going away fs/gfs2/glock.c |8 fs/gfs2/glops.c | 18 +- fs/gfs2/inode.c |6 +- fs/gfs2/main.c |2 +- 4 files changed, 23 insertions(+), 11 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
GFS2: Pull request (fixes)
Hi, Please consider pulling the following fixes for GFS2, Steve. -- There are four patches this time. The first fixes a problem where the wrong descriptor type was being written into the log for journaled data blocks. The second fixes a race relating to the deallocation of allocator data. The third provides a fallback if kmalloc is unable to satisfy a request to allocate a directory hash table. The fourth fixes the iopen glock caching so that inodes are deleted in a more timely manner after rmdir/unlink. - The following changes since commit aa4f608478acb7ed69dfcff4f3c404100b78ac49: Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/geert/linux-m68k (2013-06-03 18:09:42 +0900) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/steve/gfs2-3.0-fixes.git master Bob Peterson (4): GFS2: Set log descriptor type for jdata blocks GFS2: Increase i_writecount during gfs2_setattr_size GFS2: Fall back to vmalloc if kmalloc fails for dir hash tables GFS2: Don't cache iopen glocks fs/gfs2/bmap.c | 17 + fs/gfs2/dir.c | 43 +-- fs/gfs2/file.c | 19 +-- fs/gfs2/inode.c |1 + fs/gfs2/lops.c |4 +++- fs/gfs2/rgrp.c |4 +++- fs/gfs2/super.c |6 +- 7 files changed, 71 insertions(+), 23 deletions(-) signature.asc Description: This is a digitally signed message part
GFS2: Pull request (fixes)
Hi, Please consider pulling the following fixes, Steve. This time there are just four fixes. There are a couple of minor updates to the quota code, a fix for KConfig to ensure that only valid combinations including GFS2 can be built, and a fix for a typo affecting end i/o processing when writing the journal. Also, there is a temporary fix for a performance regression relating to block reservations and directories. A longer fix will be applied in due course, but this deals with the most immediate problem for now. The following changes since commit c7788792a5e7b0d5d7f96d0766b4cb6112d47d75: Linux 3.10-rc2 (2013-05-20 14:37:38 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/steve/gfs2-3.0-fixes.git master Bob Peterson (2): GFS2: two minor quota fixups GFS2: Use single-block reservations for directories Randy Dunlap (1): GFS2: fix DLM depends to fix build errors Steven Whitehouse (1): GFS2: Fix typo in gfs2_log_end_write loop fs/gfs2/Kconfig |2 +- fs/gfs2/lops.c |2 +- fs/gfs2/quota.c |4 ++-- fs/gfs2/rgrp.c |9 +++-- 4 files changed, 11 insertions(+), 6 deletions(-) signature.asc Description: This is a digitally signed message part
Re: GFS2: Pull request (fixes)
Hi, I've dropped out the patch which shouldn't have made it into the previous pull request, so this set should be ok now. Apologies for not spotting that issue sooner, Steve. - There are two patches which fix up a couple of minor issues in the DLM interface code, a missing error path in gfs2_rs_alloc(), one patch which fixes a problem during "withdraw" and a fix for discards/FITRIM when using 4k sector sized devices. - The following changes since commit 66ade474237745a57b7e87da9a93c7ec69fd52bb: Merge branch 'fixes' of git://git.linaro.org/people/rmk/linux-arm (2013-04-03 16:15:17 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/steve/gfs2-3.0-fixes.git master Akinobu Mita (1): GFS2: use memchr_inv Bob Peterson (1): GFS2: Issue discards in 512b sectors David Teigland (1): GFS2: use kmalloc for lvb bitmap Steven Whitehouse (1): GFS2: Fix unlock of fcntl locks during withdrawn state Wei Yongjun (1): GFS2: return error if malloc failed in gfs2_rs_alloc() fs/gfs2/file.c |5 - fs/gfs2/incore.h |1 + fs/gfs2/lock_dlm.c | 39 --- fs/gfs2/rgrp.c | 32 ++-- 4 files changed, 39 insertions(+), 38 deletions(-) signature.asc Description: This is a digitally signed message part
Re: GFS2: Pull request (fixes)
On Fri, Apr 5, 2013 at 9:27 AM, David Teigland wrote: > On Fri, Apr 05, 2013 at 11:34:45AM +0100, Steven Whitehouse wrote: >> Please consider pulling the following changes, > > There's some mixup here that should be cleared up first. > >> David Teigland (2): >> GFS2: Fix unlock of fcntl locks during withdrawn state >> >> Steven Whitehouse (1): >> GFS2: Fix unlock of fcntl locks during withdrawn state Looks like the summary line for one got leaked through an email follow-up to the other. So now the summary of the second commit is meaningless and doesn't actually describe it. Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: GFS2: Pull request (fixes)
Hi, On Fri, 2013-04-05 at 12:27 -0400, David Teigland wrote: > On Fri, Apr 05, 2013 at 11:34:45AM +0100, Steven Whitehouse wrote: > > Please consider pulling the following changes, > > There's some mixup here that should be cleared up first. > > > David Teigland (2): > > GFS2: Fix unlock of fcntl locks during withdrawn state > > > > Steven Whitehouse (1): > > GFS2: Fix unlock of fcntl locks during withdrawn state > > Yes, sorry about that. I'll fix that up and resend the pull request in due course, Steve. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: GFS2: Pull request (fixes)
On Fri, Apr 05, 2013 at 11:34:45AM +0100, Steven Whitehouse wrote: > Please consider pulling the following changes, There's some mixup here that should be cleared up first. > David Teigland (2): > GFS2: Fix unlock of fcntl locks during withdrawn state > > Steven Whitehouse (1): > GFS2: Fix unlock of fcntl locks during withdrawn state -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
GFS2: Pull request (fixes)
Hi, Please consider pulling the following changes, Steve. There are two patches which fix up a couple of minor issues in the DLM interface code, a missing error path in gfs2_rs_alloc(), two patches which fix problems during "withdraw" and a fix for discards/FITRIM when using 4k sector sized devices. The following changes since commit 66ade474237745a57b7e87da9a93c7ec69fd52bb: Merge branch 'fixes' of git://git.linaro.org/people/rmk/linux-arm (2013-04-03 16:15:17 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/steve/gfs2-3.0-fixes.git master Akinobu Mita (1): GFS2: use memchr_inv Bob Peterson (1): GFS2: Issue discards in 512b sectors David Teigland (2): GFS2: use kmalloc for lvb bitmap GFS2: Fix unlock of fcntl locks during withdrawn state Steven Whitehouse (1): GFS2: Fix unlock of fcntl locks during withdrawn state Wei Yongjun (1): GFS2: return error if malloc failed in gfs2_rs_alloc() fs/dlm/plock.c | 18 +++--- fs/gfs2/file.c |5 - fs/gfs2/incore.h |1 + fs/gfs2/lock_dlm.c | 39 --- fs/gfs2/rgrp.c | 32 ++-- 5 files changed, 54 insertions(+), 41 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
GFS2: Pull request (fixes)
Hi,
Please consider pulling the following fix. Since there is only one patch
this time, I've attached it below rather than posting it separately,
Steve.
--
The following changes since commit 949db153b6466c6f7cad5a427ecea94985927311:
Linux 3.8-rc5 (2013-01-25 11:57:28 -0800)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/steve/gfs2-3.0-fixes.git master
David Teigland (1):
GFS2: fix skip unlock condition
fs/gfs2/lock_dlm.c |7 ++-
1 files changed, 6 insertions(+), 1 deletions(-)
--
From d4e0bfec9b6fbb9b58640b44e01bb74ae0d29b22 Mon Sep 17 00:00:00 2001
From: David Teigland
Date: Thu, 3 Jan 2013 17:52:07 -0500
Subject: [PATCH] GFS2: fix skip unlock condition
The recent commit fb6791d100d1bba20b5cdbc4912e1f7086ec60f8
included the wrong logic. The lvbptr check was incorrectly
added after the patch was tested.
Signed-off-by: David Teigland
Signed-off-by: Steven Whitehouse
diff --git a/fs/gfs2/lock_dlm.c b/fs/gfs2/lock_dlm.c
index b906ed1..9802de0 100644
--- a/fs/gfs2/lock_dlm.c
+++ b/fs/gfs2/lock_dlm.c
@@ -281,6 +281,7 @@ static void gdlm_put_lock(struct gfs2_glock *gl)
{
struct gfs2_sbd *sdp = gl->gl_sbd;
struct lm_lockstruct *ls = &sdp->sd_lockstruct;
+ int lvb_needs_unlock = 0;
int error;
if (gl->gl_lksb.sb_lkid == 0) {
@@ -294,8 +295,12 @@ static void gdlm_put_lock(struct gfs2_glock *gl)
gfs2_update_request_times(gl);
/* don't want to skip dlm_unlock writing the lvb when lock is ex */
+
+ if (gl->gl_lksb.sb_lvbptr && (gl->gl_state == LM_ST_EXCLUSIVE))
+ lvb_needs_unlock = 1;
+
if (test_bit(SDF_SKIP_DLM_UNLOCK, &sdp->sd_flags) &&
- gl->gl_lksb.sb_lvbptr && (gl->gl_state != LM_ST_EXCLUSIVE)) {
+ !lvb_needs_unlock) {
gfs2_glock_free(gl);
return;
}
--
1.7.4
signature.asc
Description: This is a digitally signed message part
GFS2: Pull request (fixes)
Hi, Please consider pulling the following GFS2 fixes, Steve. --- Here are four small bug fixes for GFS2. There is no common theme here really, just a few items that were fixed recently. The first fixes lock name generation when the glock number is 0. The second fixes a race allocating reservation structures and the final two fix a performance issue by making small changes in the allocation code. --- The following changes since commit 4a490b78cb7e0e5efa44425df72a9fedc1c36366: Merge branch 'drm-next' of git://people.freedesktop.org/~airlied/linux (2012-12-30 10:00:37 -0800) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/steve/gfs2-3.0-fixes.git master Abhijith Das (1): GFS2: Fix race in gfs2_rs_alloc Bob Peterson (2): GFS2: Stop looking for free blocks at end of rgrp GFS2: Reset rd_last_alloc when it reaches the end of the rgrp Nathan Straz (1): GFS2: Initialize hex string to '0' fs/gfs2/lock_dlm.c |1 + fs/gfs2/rgrp.c | 35 --- 2 files changed, 21 insertions(+), 15 deletions(-) signature.asc Description: This is a digitally signed message part
GFS2: Pull request (fixes)
Hi, Please consider pulling the following GFS2 fixes, Steve. --- Here are a number of GFS2 bug fixes. There are three from Andy Price which fix various issues spotted by automated code analysis. There are two from Lukas Czerner fixing my mistaken assumptions as to how FITRIM should work. Finally Ben Marzinski has fixed a bug relating to mmap and atime and also a bug relating to a locking issue in the transaction code. The following changes since commit ddffeb8c4d0331609ef2581d84de4d763607bd37: Linux 3.7-rc1 (2012-10-14 14:41:04 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/steve/gfs2-3.0-fixes.git master Andrew Price (3): GFS2: Fix an unchecked error from gfs2_rs_alloc GFS2: Fix possible null pointer deref in gfs2_rs_alloc GFS2: Clean up some unused assignments Benjamin Marzinski (2): GFS2: Don't call file_accessed() with a shared glock GFS2: Test bufdata with buffer locked and gfs2_log_lock held Lukas Czerner (2): GFS2: Require user to provide argument for FITRIM GFS2: Fix FITRIM argument handling fs/gfs2/file.c | 14 +- fs/gfs2/lops.c | 16 ++-- fs/gfs2/quota.c |7 +-- fs/gfs2/rgrp.c | 33 + fs/gfs2/super.c |3 ++- fs/gfs2/trans.c |8 6 files changed, 43 insertions(+), 38 deletions(-) signature.asc Description: This is a digitally signed message part
GFS2: Pull request (fixes)
Hi, Please consider pulling the following GFS2 fixes Steve. -- Here are three GFS2 fixes for the current kernel tree. These are all related to the block reservation code which was added at the merge window. That code will be getting an update at the forthcoming merge window too. In the mean time though there are a few smaller issues which should be fixed. The first patch resolves an issue with write sizes of greater than 32 bits with the size hinting code. The second ensures that the allocation data structure is initialised when using xattrs and the third takes into account allocations which may have been made by other nodes which affect a reservation on the local node. The following changes since commit 0d7614f09c1ebdbaa1599a5aba7593f147bf96ee: Linux 3.6-rc1 (2012-08-02 16:38:10 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/steve/gfs2-3.0-fixes.git master Steven Whitehouse (3): GFS2: Make write size hinting code common GFS2: Fix missing allocation data for set/remove xattr GFS2: Take account of blockages when using reserved blocks fs/gfs2/file.c | 31 ++--- fs/gfs2/inode.c |8 +- fs/gfs2/rgrp.c | 66 +++--- 3 files changed, 61 insertions(+), 44 deletions(-) signature.asc Description: This is a digitally signed message part
