Re: Linux 2.4.0-ac9

2001-01-14 Thread Jens Axboe

On Mon, Jan 15 2001, Bill Crawford wrote:
>  I have a problem here with loopback-mounted filesystem freezing. The
> process writing to the filesystem (ext2) gets stuck in uninterruptible
> state with WCHAN showing "lock_p" which I believe to be lock_page.

Could you try with this patch

*.kernel.org/pub/linux/kernel/people/axboe/patches/2.4.0-ac9/loop-2

and see if it helps?

-- 
* Jens Axboe <[EMAIL PROTECTED]>
* SuSE Labs
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
Please read the FAQ at http://www.tux.org/lkml/



Linux 2.4.0-ac9

2001-01-14 Thread Bill Crawford

 I have a problem here with loopback-mounted filesystem freezing. The
process writing to the filesystem (ext2) gets stuck in uninterruptible
state with WCHAN showing "lock_p" which I believe to be lock_page.

 First time I noticed this, the system froze shortly afterwards but I
do not know if this is related (because on another occasion the system
has been fine apart from this wedged process).

 Underlying system is also ext2 if that makes any difference.

 Machine is AMD K6-III 400, kernel patched also with the DRM code from
XFree86 CVS but otherwise untouched, compiler (possible suspect) is
"(gcc version 2.96 2731 (Red Hat Linux 7.0))" from gcc-2.96-69.

 However the "vanishing (PS/2) mouse and keyboard" problem seems to be
cured with this release (he says ;ยท).

 I also had a problem occasionally with -ac8 printing something like
"Undead swap entry" repeatedly during shutdown recently, not sure if
that's gone yet.

-- 
/* Bill Crawford, Unix Systems Developer, ebOne, formerly GTS Netcom */
#include "stddiscl.h"
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
Please read the FAQ at http://www.tux.org/lkml/



Re: Linux 2.4.0-ac9

2001-01-14 Thread Christoph Rohland

Steven Cole <[EMAIL PROTECTED]> writes:

> Here is a little patch which also fixes the symptoms of the build
> problem, and makes a kernel 1510 bytes smaller (without
> CONFIG_SWAPFS).  Someone more knowlegable than I will have to verify
> its correctness.

Thanks, this is correct. I did not test the symlink fixes w/o
CONFIG_SWAPFS. My bad.

Greetings
Christoph

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
Please read the FAQ at http://www.tux.org/lkml/



Re: Linux 2.4.0-ac9

2001-01-14 Thread Christoph Rohland

Steven Cole [EMAIL PROTECTED] writes:

 Here is a little patch which also fixes the symptoms of the build
 problem, and makes a kernel 1510 bytes smaller (without
 CONFIG_SWAPFS).  Someone more knowlegable than I will have to verify
 its correctness.

Thanks, this is correct. I did not test the symlink fixes w/o
CONFIG_SWAPFS. My bad.

Greetings
Christoph

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
Please read the FAQ at http://www.tux.org/lkml/



Linux 2.4.0-ac9

2001-01-14 Thread Bill Crawford

 I have a problem here with loopback-mounted filesystem freezing. The
process writing to the filesystem (ext2) gets stuck in uninterruptible
state with WCHAN showing "lock_p" which I believe to be lock_page.

 First time I noticed this, the system froze shortly afterwards but I
do not know if this is related (because on another occasion the system
has been fine apart from this wedged process).

 Underlying system is also ext2 if that makes any difference.

 Machine is AMD K6-III 400, kernel patched also with the DRM code from
XFree86 CVS but otherwise untouched, compiler (possible suspect) is
"(gcc version 2.96 2731 (Red Hat Linux 7.0))" from gcc-2.96-69.

 However the "vanishing (PS/2) mouse and keyboard" problem seems to be
cured with this release (he says ;).

 I also had a problem occasionally with -ac8 printing something like
"Undead swap entry" repeatedly during shutdown recently, not sure if
that's gone yet.

-- 
/* Bill Crawford, Unix Systems Developer, ebOne, formerly GTS Netcom */
#include "stddiscl.h"
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
Please read the FAQ at http://www.tux.org/lkml/



Re: Linux 2.4.0-ac9

2001-01-14 Thread Jens Axboe

On Mon, Jan 15 2001, Bill Crawford wrote:
  I have a problem here with loopback-mounted filesystem freezing. The
 process writing to the filesystem (ext2) gets stuck in uninterruptible
 state with WCHAN showing "lock_p" which I believe to be lock_page.

Could you try with this patch

*.kernel.org/pub/linux/kernel/people/axboe/patches/2.4.0-ac9/loop-2

and see if it helps?

-- 
* Jens Axboe [EMAIL PROTECTED]
* SuSE Labs
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
Please read the FAQ at http://www.tux.org/lkml/



Re: Linux 2.4.0-ac9

2001-01-13 Thread Steven Cole

On Saturday 13 January 2001 20:05, Karsten Hopp wrote:
> You need to enable CONFIG_SWAPFS.
> Those functions are enclosed by #ifdef CONFIG_SWAPFS and #endif, but
> the references to them aren't.
>
>   Karsten
>
> On Sat, Jan 13, 2001 at 06:40:40PM -0700, Steven Cole wrote:
> > I got the following error while building 2.4.0-ac9:
> >
> > shmem.c:971: `shmem_readlink' undeclared here (not in a function)
> > shmem.c:971: initializer element is not constant
> > shmem.c:971: (near initialization for
> > `shmem_symlink_inode_operations.readlink')
> > shmem.c:972: `shmem_follow_link' undeclared here (not in a function)
> > shmem.c:972: initializer element is not constant
> > shmem.c:972: (near initialization for
> > `shmem_symlink_inode_operations.follow_link')
> > shmem.c:973: initializer element is not constant
> > shmem.c:973: (near initialization for `shmem_symlink_inode_operations')
> > shmem.c:973: initializer element is not constant
> > shmem.c:973: (near initialization for `shmem_symlink_inode_operations')
> > make[2]: *** [shmem.o] Error 1
> >

Yes, enabling CONFIG_SWAPFS works just fine:

[scole@localhost scole]$ uname -a
Linux localhost.localdomain 2.4.0-ac9 #2 Sat Jan 13 20:23:00 MST 2001 i686 
unknown

Here is a little patch which also fixes the symptoms of the build problem, and
makes a kernel 1510 bytes smaller (without CONFIG_SWAPFS).  Someone more 
knowlegable than I will have to verify its correctness.  

This patch is against 2.4.0-ac9.

--- linux/mm/shmem.c.orig   Sat Jan 13 20:23:36 2001
+++ linux/mm/shmem.cSat Jan 13 20:27:32 2001
@@ -968,8 +968,10 @@
 
 static struct inode_operations shmem_symlink_inode_operations = {
truncate:   shmem_truncate,
+#ifdef CONFIG_SWAPFS
readlink:   shmem_readlink,
follow_link:shmem_follow_link,
+#endif
 };
 
 static struct file_operations shmem_dir_operations = {
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
Please read the FAQ at http://www.tux.org/lkml/



Re: Linux 2.4.0-ac9

2001-01-13 Thread Karsten Hopp

You need to enable CONFIG_SWAPFS.
Those functions are enclosed by #ifdef CONFIG_SWAPFS and #endif, but 
the references to them aren't.

  Karsten


On Sat, Jan 13, 2001 at 06:40:40PM -0700, Steven Cole wrote:
> I got the following error while building 2.4.0-ac9:
> 
> shmem.c:971: `shmem_readlink' undeclared here (not in a function)
> shmem.c:971: initializer element is not constant
> shmem.c:971: (near initialization for 
> `shmem_symlink_inode_operations.readlink')
> shmem.c:972: `shmem_follow_link' undeclared here (not in a function)
> shmem.c:972: initializer element is not constant
> shmem.c:972: (near initialization for 
> `shmem_symlink_inode_operations.follow_link')
> shmem.c:973: initializer element is not constant
> shmem.c:973: (near initialization for `shmem_symlink_inode_operations')
> shmem.c:973: initializer element is not constant
> shmem.c:973: (near initialization for `shmem_symlink_inode_operations')
> make[2]: *** [shmem.o] Error 1
> 
> It looks like changes were recently made to linux/mm/shmem.c.
> 

--
 Karsten Hopp| Mail: [EMAIL PROTECTED] |
 Red Hat Deutschland |[EMAIL PROTECTED] | SAP-AG LinuxLab
 Hauptstaetterstr.58 | Tel: +49-711-96437-0| Neurottstrasse 16
 D-70178 Stuttgart   | http://www.redhat.de| 69190 Walldorf
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
Please read the FAQ at http://www.tux.org/lkml/



Re: Linux 2.4.0-ac9 (shmem.c errors)

2001-01-13 Thread Mark Orr


On 14-Jan-2001 Steven Cole wrote:
> I got the following error while building 2.4.0-ac9:
> 
> shmem.c:971: `shmem_readlink' undeclared here (not in a function)
> shmem.c:971: initializer element is not constant
> shmem.c:971: (near initialization for 
> `shmem_symlink_inode_operations.readlink')
> shmem.c:972: `shmem_follow_link' undeclared here (not in a function)
> shmem.c:972: initializer element is not constant
> shmem.c:972: (near initialization for 
> `shmem_symlink_inode_operations.follow_link')
> shmem.c:973: initializer element is not constant
> shmem.c:973: (near initialization for `shmem_symlink_inode_operations')
> shmem.c:973: initializer element is not constant
> shmem.c:973: (near initialization for `shmem_symlink_inode_operations')
> make[2]: *** [shmem.o] Error 1
> 
> It looks like changes were recently made to linux/mm/shmem.c.

I'm getting the same errors here.  Christoph Rohland submitted
a series of shm patches to the list -- I tried --dry-run reapplying
them and at least a couple of them partially applied.  Looks like
it didnt all get integrated.

--
Mark Orr
[EMAIL PROTECTED]

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
Please read the FAQ at http://www.tux.org/lkml/



Re: Linux 2.4.0-ac9

2001-01-13 Thread Steven Cole

I got the following error while building 2.4.0-ac9:

shmem.c:971: `shmem_readlink' undeclared here (not in a function)
shmem.c:971: initializer element is not constant
shmem.c:971: (near initialization for 
`shmem_symlink_inode_operations.readlink')
shmem.c:972: `shmem_follow_link' undeclared here (not in a function)
shmem.c:972: initializer element is not constant
shmem.c:972: (near initialization for 
`shmem_symlink_inode_operations.follow_link')
shmem.c:973: initializer element is not constant
shmem.c:973: (near initialization for `shmem_symlink_inode_operations')
shmem.c:973: initializer element is not constant
shmem.c:973: (near initialization for `shmem_symlink_inode_operations')
make[2]: *** [shmem.o] Error 1

It looks like changes were recently made to linux/mm/shmem.c.

Steven
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
Please read the FAQ at http://www.tux.org/lkml/



Linux 2.4.0-ac9

2001-01-13 Thread Alan Cox


ftp://ftp.kernel.org/pub/linux/kernel/people/alan/2.4/

2.4.0-ac9
o   Remove duplicated 8139 fixes(Jeff Garzik)
o   Drop out PS/2 mouse changes (me)
o   Fix raid5 bug   (Neil Brown)
o   Fix mmio reservation leak in starfire   (Ion Badulescu)
o   Update gmac driver to new style (Hans Grobler)
o   Fix misuse of dev_kfree_skb on cycx_x25 (Arnaldo Carvalho 
 de Melo)
o   IPDDP cleanup/fixes (Hans Grobler)
o   Remove = 0 inits from epic100   (Arnaldo Carvalho
 de Melo)
o   Fix resource failure leaks on depca (Arnaldo Carvalho
 de Melo)
o   Document ultrix partition option(Steven Cole)
o   Fixed unused config option on cadet radio   (Russell Kroll)
o   Lose static = 0 inits on bmac   (Arnaldo Carvalho
 de Melo)
o   Fix eql driver to use save/restore flags(Arnaldo Carvalho
 de Melo)
o   Document sysctl interfaces  (John Levon)
o   Clean up 6pack and reduce default footprint (Hans Grobler)
o   Fix the handle alignment issues in NFS  (Trond Myklebust)
o   Chkconfig fixes (Niels Jensen)
o   fusion driver updates   (Steve Ralston)
o   Clean up com20020-pci driver leaks  (Hans Grobler)
o   tmpfs/shmfs (Christoph Rohland)


2.4.0-ac8
o   Fix PS/2 mouse ack/echo handling behaviour  (Julian Bradfield)
| Let me know if you see 'odd' ps/2 stuff   (Chris Hanson)
| in 2.4.0ac8 not in ac7
o   Merge Linus 1pre3. Drop out some of my vm
diffs in favour of his
o   PC110 pad move to new driver style  (Hans Grobler)
o   Clean up/fix leaks in ncr885e   (Hans Grobler)
o   Move dsp56k to new style module stuff   (Hans Grobler)
o   check->request_region, resource leak fixes  (Hans Grobler)
for qlogicisp
o   Fix iounmap leak in iphase  (Hans Grobler)
o   Fix iounmap leaks in ymf_pci(Hans Grobler)
o   Fix s390mach.c for non SMP  (Ulrich Weigand)
o   Export queued_sectors   (Jens Axboe)
o   Fix raid5 build after Linus merge   (Andrea Arcangeli)
o   Documentation and chkconfig update  (Niels Jensen)
o   Fix iounmap leaks in oaknet (Arnaldo Carvalho de Melo)
o   Clean up mac89x0(Arnaldo Carvalho de Melo)
o   Fix leaks on error in myri_sbus (Arnaldo Carvalho de Melo)
o   Convert macsonic.c to new style (Arnaldo Carvalho de Melo)
o   RCPCI further fixes (Rasmus Andersen)

2.4.0-ac7
o   Export a KMALLOC_MAXSIZE for drivers to check   (Hans Grobler)
| this is needed to verify things like firmware
| sizes passed by users
o   Fix highmem compile issues  (Ingo Molnar)
o   Fix kmalloc check missing in hades-pci  (Hans Grobler)
o   Fix kmalloc fail crash in sdla_ppp  (Hans Grobler)
o   cfi locking fixes   (Hans Grobler)
o   Fix missing spin_unlock_irq in hd6457x.c(Hans Grobler)
o   Fix lmc_main missing skb_unlock on error case   (Hans Grobler)
o   Handle out of memory on lanstreamer (Hans Grobler)
o   Bring cs46xx.c into working state for non   (Hans Grobler)
module. Fix locking
o   Fix filesystem locking documentation(Al Viro)
o   Fusion driver updates   (Steve Ralston)
o   Correct netfilter url   (Rusty Russell)
o   rcpci45 fix the pci_table name (again)  (Hans Grobler)
o   Fix scsi option ordering bug noted by   (Michael Zieger)
o   Config.h include updates(Niels Jensen)
o   LFS handling cleanup, move some checks to   (Al Viro)
vmtruncate
o   Fix missing s->maxbytes setup for procfs(me)
o   Replace epic100 patches with alternatives   (Jeff Garzik)
o   eepro fixes for older cards (Aristeu Sergio
 Rozanski Filho)
o   Buz error handling fix  (Hans Grobler)
o   DGRS driver cleanups/kmalloc checks (Arnaldo Carvalho 
de 

Linux 2.4.0-ac9

2001-01-13 Thread Alan Cox


ftp://ftp.kernel.org/pub/linux/kernel/people/alan/2.4/

2.4.0-ac9
o   Remove duplicated 8139 fixes(Jeff Garzik)
o   Drop out PS/2 mouse changes (me)
o   Fix raid5 bug   (Neil Brown)
o   Fix mmio reservation leak in starfire   (Ion Badulescu)
o   Update gmac driver to new style (Hans Grobler)
o   Fix misuse of dev_kfree_skb on cycx_x25 (Arnaldo Carvalho 
 de Melo)
o   IPDDP cleanup/fixes (Hans Grobler)
o   Remove = 0 inits from epic100   (Arnaldo Carvalho
 de Melo)
o   Fix resource failure leaks on depca (Arnaldo Carvalho
 de Melo)
o   Document ultrix partition option(Steven Cole)
o   Fixed unused config option on cadet radio   (Russell Kroll)
o   Lose static = 0 inits on bmac   (Arnaldo Carvalho
 de Melo)
o   Fix eql driver to use save/restore flags(Arnaldo Carvalho
 de Melo)
o   Document sysctl interfaces  (John Levon)
o   Clean up 6pack and reduce default footprint (Hans Grobler)
o   Fix the handle alignment issues in NFS  (Trond Myklebust)
o   Chkconfig fixes (Niels Jensen)
o   fusion driver updates   (Steve Ralston)
o   Clean up com20020-pci driver leaks  (Hans Grobler)
o   tmpfs/shmfs (Christoph Rohland)


2.4.0-ac8
o   Fix PS/2 mouse ack/echo handling behaviour  (Julian Bradfield)
| Let me know if you see 'odd' ps/2 stuff   (Chris Hanson)
| in 2.4.0ac8 not in ac7
o   Merge Linus 1pre3. Drop out some of my vm
diffs in favour of his
o   PC110 pad move to new driver style  (Hans Grobler)
o   Clean up/fix leaks in ncr885e   (Hans Grobler)
o   Move dsp56k to new style module stuff   (Hans Grobler)
o   check-request_region, resource leak fixes  (Hans Grobler)
for qlogicisp
o   Fix iounmap leak in iphase  (Hans Grobler)
o   Fix iounmap leaks in ymf_pci(Hans Grobler)
o   Fix s390mach.c for non SMP  (Ulrich Weigand)
o   Export queued_sectors   (Jens Axboe)
o   Fix raid5 build after Linus merge   (Andrea Arcangeli)
o   Documentation and chkconfig update  (Niels Jensen)
o   Fix iounmap leaks in oaknet (Arnaldo Carvalho de Melo)
o   Clean up mac89x0(Arnaldo Carvalho de Melo)
o   Fix leaks on error in myri_sbus (Arnaldo Carvalho de Melo)
o   Convert macsonic.c to new style (Arnaldo Carvalho de Melo)
o   RCPCI further fixes (Rasmus Andersen)

2.4.0-ac7
o   Export a KMALLOC_MAXSIZE for drivers to check   (Hans Grobler)
| this is needed to verify things like firmware
| sizes passed by users
o   Fix highmem compile issues  (Ingo Molnar)
o   Fix kmalloc check missing in hades-pci  (Hans Grobler)
o   Fix kmalloc fail crash in sdla_ppp  (Hans Grobler)
o   cfi locking fixes   (Hans Grobler)
o   Fix missing spin_unlock_irq in hd6457x.c(Hans Grobler)
o   Fix lmc_main missing skb_unlock on error case   (Hans Grobler)
o   Handle out of memory on lanstreamer (Hans Grobler)
o   Bring cs46xx.c into working state for non   (Hans Grobler)
module. Fix locking
o   Fix filesystem locking documentation(Al Viro)
o   Fusion driver updates   (Steve Ralston)
o   Correct netfilter url   (Rusty Russell)
o   rcpci45 fix the pci_table name (again)  (Hans Grobler)
o   Fix scsi option ordering bug noted by   (Michael Zieger)
o   Config.h include updates(Niels Jensen)
o   LFS handling cleanup, move some checks to   (Al Viro)
vmtruncate
o   Fix missing s-maxbytes setup for procfs(me)
o   Replace epic100 patches with alternatives   (Jeff Garzik)
o   eepro fixes for older cards (Aristeu Sergio
 Rozanski Filho)
o   Buz error handling fix  (Hans Grobler)
o   DGRS driver cleanups/kmalloc checks (Arnaldo Carvalho 
de Melo)

Re: Linux 2.4.0-ac9

2001-01-13 Thread Steven Cole

I got the following error while building 2.4.0-ac9:

shmem.c:971: `shmem_readlink' undeclared here (not in a function)
shmem.c:971: initializer element is not constant
shmem.c:971: (near initialization for 
`shmem_symlink_inode_operations.readlink')
shmem.c:972: `shmem_follow_link' undeclared here (not in a function)
shmem.c:972: initializer element is not constant
shmem.c:972: (near initialization for 
`shmem_symlink_inode_operations.follow_link')
shmem.c:973: initializer element is not constant
shmem.c:973: (near initialization for `shmem_symlink_inode_operations')
shmem.c:973: initializer element is not constant
shmem.c:973: (near initialization for `shmem_symlink_inode_operations')
make[2]: *** [shmem.o] Error 1

It looks like changes were recently made to linux/mm/shmem.c.

Steven
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
Please read the FAQ at http://www.tux.org/lkml/



Re: Linux 2.4.0-ac9 (shmem.c errors)

2001-01-13 Thread Mark Orr


On 14-Jan-2001 Steven Cole wrote:
 I got the following error while building 2.4.0-ac9:
 
 shmem.c:971: `shmem_readlink' undeclared here (not in a function)
 shmem.c:971: initializer element is not constant
 shmem.c:971: (near initialization for 
 `shmem_symlink_inode_operations.readlink')
 shmem.c:972: `shmem_follow_link' undeclared here (not in a function)
 shmem.c:972: initializer element is not constant
 shmem.c:972: (near initialization for 
 `shmem_symlink_inode_operations.follow_link')
 shmem.c:973: initializer element is not constant
 shmem.c:973: (near initialization for `shmem_symlink_inode_operations')
 shmem.c:973: initializer element is not constant
 shmem.c:973: (near initialization for `shmem_symlink_inode_operations')
 make[2]: *** [shmem.o] Error 1
 
 It looks like changes were recently made to linux/mm/shmem.c.

I'm getting the same errors here.  Christoph Rohland submitted
a series of shm patches to the list -- I tried --dry-run reapplying
them and at least a couple of them partially applied.  Looks like
it didnt all get integrated.

--
Mark Orr
[EMAIL PROTECTED]

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
Please read the FAQ at http://www.tux.org/lkml/



Re: Linux 2.4.0-ac9

2001-01-13 Thread Karsten Hopp

You need to enable CONFIG_SWAPFS.
Those functions are enclosed by #ifdef CONFIG_SWAPFS and #endif, but 
the references to them aren't.

  Karsten


On Sat, Jan 13, 2001 at 06:40:40PM -0700, Steven Cole wrote:
 I got the following error while building 2.4.0-ac9:
 
 shmem.c:971: `shmem_readlink' undeclared here (not in a function)
 shmem.c:971: initializer element is not constant
 shmem.c:971: (near initialization for 
 `shmem_symlink_inode_operations.readlink')
 shmem.c:972: `shmem_follow_link' undeclared here (not in a function)
 shmem.c:972: initializer element is not constant
 shmem.c:972: (near initialization for 
 `shmem_symlink_inode_operations.follow_link')
 shmem.c:973: initializer element is not constant
 shmem.c:973: (near initialization for `shmem_symlink_inode_operations')
 shmem.c:973: initializer element is not constant
 shmem.c:973: (near initialization for `shmem_symlink_inode_operations')
 make[2]: *** [shmem.o] Error 1
 
 It looks like changes were recently made to linux/mm/shmem.c.
 

--
 Karsten Hopp| Mail: [EMAIL PROTECTED] |
 Red Hat Deutschland |[EMAIL PROTECTED] | SAP-AG LinuxLab
 Hauptstaetterstr.58 | Tel: +49-711-96437-0| Neurottstrasse 16
 D-70178 Stuttgart   | http://www.redhat.de| 69190 Walldorf
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
Please read the FAQ at http://www.tux.org/lkml/



Re: Linux 2.4.0-ac9

2001-01-13 Thread Steven Cole

On Saturday 13 January 2001 20:05, Karsten Hopp wrote:
 You need to enable CONFIG_SWAPFS.
 Those functions are enclosed by #ifdef CONFIG_SWAPFS and #endif, but
 the references to them aren't.

   Karsten

 On Sat, Jan 13, 2001 at 06:40:40PM -0700, Steven Cole wrote:
  I got the following error while building 2.4.0-ac9:
 
  shmem.c:971: `shmem_readlink' undeclared here (not in a function)
  shmem.c:971: initializer element is not constant
  shmem.c:971: (near initialization for
  `shmem_symlink_inode_operations.readlink')
  shmem.c:972: `shmem_follow_link' undeclared here (not in a function)
  shmem.c:972: initializer element is not constant
  shmem.c:972: (near initialization for
  `shmem_symlink_inode_operations.follow_link')
  shmem.c:973: initializer element is not constant
  shmem.c:973: (near initialization for `shmem_symlink_inode_operations')
  shmem.c:973: initializer element is not constant
  shmem.c:973: (near initialization for `shmem_symlink_inode_operations')
  make[2]: *** [shmem.o] Error 1
 

Yes, enabling CONFIG_SWAPFS works just fine:

[scole@localhost scole]$ uname -a
Linux localhost.localdomain 2.4.0-ac9 #2 Sat Jan 13 20:23:00 MST 2001 i686 
unknown

Here is a little patch which also fixes the symptoms of the build problem, and
makes a kernel 1510 bytes smaller (without CONFIG_SWAPFS).  Someone more 
knowlegable than I will have to verify its correctness.  

This patch is against 2.4.0-ac9.

--- linux/mm/shmem.c.orig   Sat Jan 13 20:23:36 2001
+++ linux/mm/shmem.cSat Jan 13 20:27:32 2001
@@ -968,8 +968,10 @@
 
 static struct inode_operations shmem_symlink_inode_operations = {
truncate:   shmem_truncate,
+#ifdef CONFIG_SWAPFS
readlink:   shmem_readlink,
follow_link:shmem_follow_link,
+#endif
 };
 
 static struct file_operations shmem_dir_operations = {
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
Please read the FAQ at http://www.tux.org/lkml/