Re: [ata crash] Re: Linux 2.6.25-rc1
* Tejun Heo <[EMAIL PROTECTED]> wrote:
> Tejun Heo wrote:
> > Ingo Molnar wrote:
> >> On a second attempt to boot the same bzImage, another ATA related
> >> weirdness showed up:
> >>
> >> [8.226144] Calling initcall 0xc09f3d8e: isapnp_init+0x0/0xf()
> >> [8.232017] Bad IO access at port 0x0 (outb(val,port))
> >> [8.232799] [ cut here ]
> >> [8.232799] WARNING: at lib/iomap.c:44 bad_io_access+0x2f/0x34()
> >> [8.232799] Pid: 1, comm: swapper Not tainted 2.6.25-rc1 #5
> >> [8.232799] [] warn_on_slowpath+0x3c/0x4c
> >> [8.232799] [] ? serial8250_console_write+0x0/0x14e
> >> [8.232799] [] ? __call_console_drivers+0x56/0x63
> >> [8.232799] [] ? _spin_unlock_irqrestore+0x15/0x21
> >> [8.232799] [] ? release_console_sem+0x1c1/0x1c9
> >> [8.232799] [] ? print_trailer+0x6e/0xfc
> >> [8.232799] [] ? check_object+0x10b/0x181
> >> [8.232799] [] ? printk+0x15/0x17
> >> [8.232799] [] bad_io_access+0x2f/0x34
> >> [8.232799] [] iowrite8+0x31/0x34
> >> [8.232799] [] ata_bmdma_freeze+0x1d/0x30
> >> [8.232799] [] __ata_port_freeze+0x2c/0x33
> >> [8.232799] [] ata_eh_freeze_port+0x21/0x2f
> >> [8.232799] [] ata_host_start+0xe1/0x132
> >
> > Does the following patch fix the above problem? pata_isapnp is the
> > only one which can have NULL ctl_addr and libata SFF layer wasn't
> > ready for that.
>
> Ping.
Pong. Please consider it fixed and merge the fix upstream - i havent
seen these problems since i put your fix into my qa tree (and forgot
about it completely). If there's any problem left i'll follow up on it.
(For the record, the patch below is the one i tested with various x86
hardware.)
Ingo
->
Subject: Re: Re: Linux 2.6.25-rc1
From: Tejun Heo <[EMAIL PROTECTED]>
Date: Wed, 13 Feb 2008 18:51:39 +0900
Ingo Molnar wrote:
> On a second attempt to boot the same bzImage, another ATA related
> weirdness showed up:
>
> [8.226144] Calling initcall 0xc09f3d8e: isapnp_init+0x0/0xf()
> [8.232017] Bad IO access at port 0x0 (outb(val,port))
> [8.232799] [ cut here ]
> [8.232799] WARNING: at lib/iomap.c:44 bad_io_access+0x2f/0x34()
> [8.232799] Pid: 1, comm: swapper Not tainted 2.6.25-rc1 #5
> [8.232799] [] warn_on_slowpath+0x3c/0x4c
> [8.232799] [] ? serial8250_console_write+0x0/0x14e
> [8.232799] [] ? __call_console_drivers+0x56/0x63
> [8.232799] [] ? _spin_unlock_irqrestore+0x15/0x21
> [8.232799] [] ? release_console_sem+0x1c1/0x1c9
> [8.232799] [] ? print_trailer+0x6e/0xfc
> [8.232799] [] ? check_object+0x10b/0x181
> [8.232799] [] ? printk+0x15/0x17
> [8.232799] [] bad_io_access+0x2f/0x34
> [8.232799] [] iowrite8+0x31/0x34
> [8.232799] [] ata_bmdma_freeze+0x1d/0x30
> [8.232799] [] __ata_port_freeze+0x2c/0x33
> [8.232799] [] ata_eh_freeze_port+0x21/0x2f
> [8.232799] [] ata_host_start+0xe1/0x132
Does the following patch fix the above problem? pata_isapnp is the
only one which can have NULL ctl_addr and libata SFF layer wasn't
ready for that.
Thanks.
Signed-off-by: Ingo Molnar <[EMAIL PROTECTED]>
---
drivers/ata/libata-eh.c | 10 ++
drivers/ata/libata-sff.c | 22 ++
2 files changed, 24 insertions(+), 8 deletions(-)
Index: linux/drivers/ata/libata-eh.c
===
--- linux.orig/drivers/ata/libata-eh.c
+++ linux/drivers/ata/libata-eh.c
@@ -2150,6 +2150,15 @@ int ata_eh_reset(struct ata_link *link,
ap->ops->set_piomode(ap, dev);
}
+ if (!softreset && !hardreset) {
+ if (verbose)
+ ata_link_printk(link, KERN_INFO, "no reset method "
+ "available, skipping reset\n");
+ if (!(lflags & ATA_LFLAG_ASSUME_CLASS))
+ lflags |= ATA_LFLAG_ASSUME_ATA;
+ goto done;
+ }
+
/* Determine which reset to use and record in ehc->i.action.
* prereset() may examine and modify it.
*/
@@ -2254,6 +2263,7 @@ int ata_eh_reset(struct ata_link *link,
lflags |= ATA_LFLAG_ASSUME_ATA;
}
+ done:
ata_link_for_each_dev(dev, link) {
/* After the reset, the device state is PIO 0 and the
* controller state is undefined. Reset also wakes up
Index: linux/drivers/ata/libata-sff.c
===
--- linux.orig/drivers/ata/libata-sff.c
+++ linux/drivers/ata/l
Re: [ata crash] Re: Linux 2.6.25-rc1
Tejun Heo wrote: > Ingo Molnar wrote: >> On a second attempt to boot the same bzImage, another ATA related >> weirdness showed up: >> >> [8.226144] Calling initcall 0xc09f3d8e: isapnp_init+0x0/0xf() >> [8.232017] Bad IO access at port 0x0 (outb(val,port)) >> [8.232799] [ cut here ] >> [8.232799] WARNING: at lib/iomap.c:44 bad_io_access+0x2f/0x34() >> [8.232799] Pid: 1, comm: swapper Not tainted 2.6.25-rc1 #5 >> [8.232799] [] warn_on_slowpath+0x3c/0x4c >> [8.232799] [] ? serial8250_console_write+0x0/0x14e >> [8.232799] [] ? __call_console_drivers+0x56/0x63 >> [8.232799] [] ? _spin_unlock_irqrestore+0x15/0x21 >> [8.232799] [] ? release_console_sem+0x1c1/0x1c9 >> [8.232799] [] ? print_trailer+0x6e/0xfc >> [8.232799] [] ? check_object+0x10b/0x181 >> [8.232799] [] ? printk+0x15/0x17 >> [8.232799] [] bad_io_access+0x2f/0x34 >> [8.232799] [] iowrite8+0x31/0x34 >> [8.232799] [] ata_bmdma_freeze+0x1d/0x30 >> [8.232799] [] __ata_port_freeze+0x2c/0x33 >> [8.232799] [] ata_eh_freeze_port+0x21/0x2f >> [8.232799] [] ata_host_start+0xe1/0x132 > > Does the following patch fix the above problem? pata_isapnp is the > only one which can have NULL ctl_addr and libata SFF layer wasn't > ready for that. Ping. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [ata crash] Re: Linux 2.6.25-rc1
Tejun Heo wrote: Ingo Molnar wrote: On a second attempt to boot the same bzImage, another ATA related weirdness showed up: [8.226144] Calling initcall 0xc09f3d8e: isapnp_init+0x0/0xf() [8.232017] Bad IO access at port 0x0 (outb(val,port)) [8.232799] [ cut here ] [8.232799] WARNING: at lib/iomap.c:44 bad_io_access+0x2f/0x34() [8.232799] Pid: 1, comm: swapper Not tainted 2.6.25-rc1 #5 [8.232799] [c011fd63] warn_on_slowpath+0x3c/0x4c [8.232799] [c0358e9d] ? serial8250_console_write+0x0/0x14e [8.232799] [c01200a5] ? __call_console_drivers+0x56/0x63 [8.232799] [c06b7acf] ? _spin_unlock_irqrestore+0x15/0x21 [8.232799] [c0120556] ? release_console_sem+0x1c1/0x1c9 [8.232799] [c015c400] ? print_trailer+0x6e/0xfc [8.232799] [c015c77f] ? check_object+0x10b/0x181 [8.232799] [c01209a0] ? printk+0x15/0x17 [8.232799] [c02cc2ce] bad_io_access+0x2f/0x34 [8.232799] [c02cc48a] iowrite8+0x31/0x34 [8.232799] [c04a1c8d] ata_bmdma_freeze+0x1d/0x30 [8.232799] [c04a2063] __ata_port_freeze+0x2c/0x33 [8.232799] [c04a224f] ata_eh_freeze_port+0x21/0x2f [8.232799] [c0497fa9] ata_host_start+0xe1/0x132 Does the following patch fix the above problem? pata_isapnp is the only one which can have NULL ctl_addr and libata SFF layer wasn't ready for that. Ping. -- tejun -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [ata crash] Re: Linux 2.6.25-rc1
* Tejun Heo [EMAIL PROTECTED] wrote:
Tejun Heo wrote:
Ingo Molnar wrote:
On a second attempt to boot the same bzImage, another ATA related
weirdness showed up:
[8.226144] Calling initcall 0xc09f3d8e: isapnp_init+0x0/0xf()
[8.232017] Bad IO access at port 0x0 (outb(val,port))
[8.232799] [ cut here ]
[8.232799] WARNING: at lib/iomap.c:44 bad_io_access+0x2f/0x34()
[8.232799] Pid: 1, comm: swapper Not tainted 2.6.25-rc1 #5
[8.232799] [c011fd63] warn_on_slowpath+0x3c/0x4c
[8.232799] [c0358e9d] ? serial8250_console_write+0x0/0x14e
[8.232799] [c01200a5] ? __call_console_drivers+0x56/0x63
[8.232799] [c06b7acf] ? _spin_unlock_irqrestore+0x15/0x21
[8.232799] [c0120556] ? release_console_sem+0x1c1/0x1c9
[8.232799] [c015c400] ? print_trailer+0x6e/0xfc
[8.232799] [c015c77f] ? check_object+0x10b/0x181
[8.232799] [c01209a0] ? printk+0x15/0x17
[8.232799] [c02cc2ce] bad_io_access+0x2f/0x34
[8.232799] [c02cc48a] iowrite8+0x31/0x34
[8.232799] [c04a1c8d] ata_bmdma_freeze+0x1d/0x30
[8.232799] [c04a2063] __ata_port_freeze+0x2c/0x33
[8.232799] [c04a224f] ata_eh_freeze_port+0x21/0x2f
[8.232799] [c0497fa9] ata_host_start+0xe1/0x132
Does the following patch fix the above problem? pata_isapnp is the
only one which can have NULL ctl_addr and libata SFF layer wasn't
ready for that.
Ping.
Pong. Please consider it fixed and merge the fix upstream - i havent
seen these problems since i put your fix into my qa tree (and forgot
about it completely). If there's any problem left i'll follow up on it.
(For the record, the patch below is the one i tested with various x86
hardware.)
Ingo
-
Subject: Re: Re: Linux 2.6.25-rc1
From: Tejun Heo [EMAIL PROTECTED]
Date: Wed, 13 Feb 2008 18:51:39 +0900
Ingo Molnar wrote:
On a second attempt to boot the same bzImage, another ATA related
weirdness showed up:
[8.226144] Calling initcall 0xc09f3d8e: isapnp_init+0x0/0xf()
[8.232017] Bad IO access at port 0x0 (outb(val,port))
[8.232799] [ cut here ]
[8.232799] WARNING: at lib/iomap.c:44 bad_io_access+0x2f/0x34()
[8.232799] Pid: 1, comm: swapper Not tainted 2.6.25-rc1 #5
[8.232799] [c011fd63] warn_on_slowpath+0x3c/0x4c
[8.232799] [c0358e9d] ? serial8250_console_write+0x0/0x14e
[8.232799] [c01200a5] ? __call_console_drivers+0x56/0x63
[8.232799] [c06b7acf] ? _spin_unlock_irqrestore+0x15/0x21
[8.232799] [c0120556] ? release_console_sem+0x1c1/0x1c9
[8.232799] [c015c400] ? print_trailer+0x6e/0xfc
[8.232799] [c015c77f] ? check_object+0x10b/0x181
[8.232799] [c01209a0] ? printk+0x15/0x17
[8.232799] [c02cc2ce] bad_io_access+0x2f/0x34
[8.232799] [c02cc48a] iowrite8+0x31/0x34
[8.232799] [c04a1c8d] ata_bmdma_freeze+0x1d/0x30
[8.232799] [c04a2063] __ata_port_freeze+0x2c/0x33
[8.232799] [c04a224f] ata_eh_freeze_port+0x21/0x2f
[8.232799] [c0497fa9] ata_host_start+0xe1/0x132
Does the following patch fix the above problem? pata_isapnp is the
only one which can have NULL ctl_addr and libata SFF layer wasn't
ready for that.
Thanks.
Signed-off-by: Ingo Molnar [EMAIL PROTECTED]
---
drivers/ata/libata-eh.c | 10 ++
drivers/ata/libata-sff.c | 22 ++
2 files changed, 24 insertions(+), 8 deletions(-)
Index: linux/drivers/ata/libata-eh.c
===
--- linux.orig/drivers/ata/libata-eh.c
+++ linux/drivers/ata/libata-eh.c
@@ -2150,6 +2150,15 @@ int ata_eh_reset(struct ata_link *link,
ap-ops-set_piomode(ap, dev);
}
+ if (!softreset !hardreset) {
+ if (verbose)
+ ata_link_printk(link, KERN_INFO, no reset method
+ available, skipping reset\n);
+ if (!(lflags ATA_LFLAG_ASSUME_CLASS))
+ lflags |= ATA_LFLAG_ASSUME_ATA;
+ goto done;
+ }
+
/* Determine which reset to use and record in ehc-i.action.
* prereset() may examine and modify it.
*/
@@ -2254,6 +2263,7 @@ int ata_eh_reset(struct ata_link *link,
lflags |= ATA_LFLAG_ASSUME_ATA;
}
+ done:
ata_link_for_each_dev(dev, link) {
/* After the reset, the device state is PIO 0 and the
* controller state is undefined. Reset also wakes up
Index: linux/drivers/ata/libata-sff.c
===
--- linux.orig/drivers/ata/libata-sff.c
+++ linux/drivers/ata/libata-sff.c
@@ -56,7 +56,8 @@ u8 ata_irq_on(struct ata_port *ap)
ap-ctl = ~ATA_NIEN;
ap-last_ctl = ap-ctl;
- iowrite8(ap-ctl, ioaddr-ctl_addr);
+ if (ioaddr-ctl_addr)
+ iowrite8(ap-ctl, ioaddr-ctl_addr);
tmp
Re: Linux 2.6.25-rc1
On Feb 11, 2008 11:15 PM, Andrew Morton <[EMAIL PROTECTED]> wrote: > On Mon, 11 Feb 2008 22:46:18 +0100 > "Torsten Kaiser" <[EMAIL PROTECTED]> wrote: > > > On Feb 11, 2008 1:44 AM, Linus Torvalds <[EMAIL PROTECTED]> wrote: > > > So give it all a good testing. > > > > My mm-mystery-crash has now sneaked into mainline: > > hm, I don't remember that. Last report: http://marc.info/?l=linux-kernel=120129854023202 > > [ 1463.829078] BUG: unable to handle kernel NULL pointer dereference > > at 0378 > > [ 1463.832141] IP: [] ether1394_dg_complete+0x28/0xa0 > > [ 1463.834616] PGD 7955e067 PUD 7955d067 PMD 0 > > [ 1463.836148] Oops: [1] SMP > > [ 1463.836148] CPU 0 > > [ 1463.836148] Modules linked in: radeon drm w83792d ipv6 tuner > > tea5767 tda8290 tuner_xc2028 tda9887 tuner_simple mt20xx tea5761 > > tvaudio msp3400 bttv videodev v4l1_compat ir_common compat_ioctl32 > > v4l2_common videobuf_dma_sg videobuf_core btcx_risc usbhid tveeprom sg > > i2c_nforce2 hid pata_amd > > [ 1463.836148] Pid: 519, comm: khpsbpkt Not tainted 2.6.25-rc1 #1 > > [ 1463.836148] RIP: 0010:[] [] > > ether1394_dg_complete+0x28/0xa0 > > [ 1463.836148] RSP: :81007eeb1e80 EFLAGS: 00010282 > > [ 1463.836148] RAX: RBX: RCX: > > 0001 > > [ 1463.836148] RDX: 81004bc62d80 RSI: RDI: > > 810051873e40 > > [ 1463.836148] RBP: 81007eeb1eb0 R08: R09: > > 0001 > > [ 1463.836148] R10: 0001 R11: 0001 R12: > > 810051873e40 > > [ 1463.836148] R13: 81007e1f7200 R14: 0001 R15: > > 810051873e40 > > [ 1463.836148] FS: 7f727d6d4700() GS:807e8000() > > knlGS: > > [ 1463.836148] CS: 0010 DS: 0018 ES: 0018 CR0: 8005003b > > [ 1463.836148] CR2: 0378 CR3: 79559000 CR4: > > 06e0 > > [ 1463.836148] DR0: DR1: DR2: > > > > [ 1463.836148] DR3: DR6: 0ff0 DR7: > > 0400 > > [ 1463.836148] Process khpsbpkt (pid: 519, threadinfo > > 81007eeb, task 81007ee9e000) > > [ 1463.836148] Stack: 81007eeb1e90 81004bc62b40 > > 810051873e40 > > [ 1463.836148] 0001 81007eeb1ee0 > > 8047b233 > > [ 1463.836148] 81007eeb1ec8 81007eeb1ef0 8046c280 > > 81007ff6df10 > > [ 1463.836148] Call Trace: > > [ 1463.836148] [] ether1394_complete_cb+0xb3/0xd0 > > [ 1463.836148] [] ? hpsbpkt_thread+0x0/0x140 > > [ 1463.836148] [] hpsbpkt_thread+0xbb/0x140 > > [ 1463.836148] [] kthread+0x4d/0x80 > > [ 1463.836148] [] child_rip+0xa/0x12 > > [ 1463.836148] [] ? restore_args+0x0/0x31 > > [ 1463.836148] [] ? kthread+0x0/0x80 > > [ 1463.836148] [] ? child_rip+0x0/0x12 > > [ 1463.836148] > > [ 1463.836148] > > [ 1463.836148] Code: 00 00 00 55 48 89 e5 48 83 ec 30 48 89 5d d8 4c > > 89 75 f0 89 f3 4c 89 7d f8 4c 89 65 e0 49 89 ff 4c 89 6d e8 4c 8b 2f > > 49 8b 45 20 <4c> 8b a0 78 03 00 00 4d 8d b4 24 d0 00 00 00 4c 89 f7 e8 > > 41 f0 > > [ 1463.836148] RIP [] ether1394_dg_complete+0x28/0xa0 > > [ 1463.836148] RSP > > [ 1463.836148] CR2: 0378 > > [ 1463.836208] ohci1394: fw-host0: Waking dma ctx=0 ... processing is > > probably too slow > > [ 1463.839250] BUG: unable to handle kernel NULL pointer dereference > > at > > [ 1463.841549] IP: [] kmem_cache_alloc_node+0x6d/0xa0 > > [ 1463.842925] PGD 7955e067 PUD 7955d067 PMD 0 > > [ 1463.846148] Oops: [2] SMP > > [ 1463.846148] CPU 0 > > [ 1463.846148] Modules linked in: radeon drm w83792d ipv6 tuner > > tea5767 tda8290 tuner_xc2028 tda9887 tuner_simple mt20xx tea5761 > > tvaudio msp3400 bttv videodev v4l1_compat ir_common compat_ioctl32 > > v4l2_common videobuf_dma_sg videobuf_core btcx_risc usbhid tveeprom sg > > i2c_nforce2 hid pata_amd > > [ 1463.846148] Pid: 519, comm: khpsbpkt Tainted: G D 2.6.25-rc1 #1 > > [ 1463.846148] RIP: 0010:[] [] > > kmem_cache_alloc_node+0x6d/0xa0 > > [ 1463.846148] RSP: :80871ae0 EFLAGS: 00010046 > > [ 1463.846148] RAX: RBX: 810001006820 RCX: > > 8052c549 > > [ 1463.846148] RDX: RSI: RDI: > > 807fbec0 > > [ 1463.846148] RBP: 80871b00 R08: 05e0 R09: > > ffc1 > > [ 1463.846148] R10: 0001 R11: R12: > > > > [ 1463.846148] R13: 0020 R14: 0020 R15: > > 807fbec0 > > -> here the output from the serial console stopped. [snip] > But this is a crash inside the 1394 code. So if you're getting a crash > with plain-old-ethernet then it is a different crash. It'd be good if we > could see the oops trace for that one too please. 2.6.24-rc3-mm2: http://marc.info/?l=linux-kernel=119636996902805 -> crash in ether1394 and another one in sunrpc
Re: [ata crash] Re: Linux 2.6.25-rc1
Ingo Molnar wrote:
> On a second attempt to boot the same bzImage, another ATA related
> weirdness showed up:
>
> [8.226144] Calling initcall 0xc09f3d8e: isapnp_init+0x0/0xf()
> [8.232017] Bad IO access at port 0x0 (outb(val,port))
> [8.232799] [ cut here ]
> [8.232799] WARNING: at lib/iomap.c:44 bad_io_access+0x2f/0x34()
> [8.232799] Pid: 1, comm: swapper Not tainted 2.6.25-rc1 #5
> [8.232799] [] warn_on_slowpath+0x3c/0x4c
> [8.232799] [] ? serial8250_console_write+0x0/0x14e
> [8.232799] [] ? __call_console_drivers+0x56/0x63
> [8.232799] [] ? _spin_unlock_irqrestore+0x15/0x21
> [8.232799] [] ? release_console_sem+0x1c1/0x1c9
> [8.232799] [] ? print_trailer+0x6e/0xfc
> [8.232799] [] ? check_object+0x10b/0x181
> [8.232799] [] ? printk+0x15/0x17
> [8.232799] [] bad_io_access+0x2f/0x34
> [8.232799] [] iowrite8+0x31/0x34
> [8.232799] [] ata_bmdma_freeze+0x1d/0x30
> [8.232799] [] __ata_port_freeze+0x2c/0x33
> [8.232799] [] ata_eh_freeze_port+0x21/0x2f
> [8.232799] [] ata_host_start+0xe1/0x132
Does the following patch fix the above problem? pata_isapnp is the
only one which can have NULL ctl_addr and libata SFF layer wasn't
ready for that.
Thanks.
diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
diff --git a/drivers/ata/libata-eh.c b/drivers/ata/libata-eh.c
index 4e31071..c6c04dc 100644
--- a/drivers/ata/libata-eh.c
+++ b/drivers/ata/libata-eh.c
@@ -2150,6 +2150,15 @@ int ata_eh_reset(struct ata_link *link, int classify,
ap->ops->set_piomode(ap, dev);
}
+ if (!softreset && !hardreset) {
+ if (verbose)
+ ata_link_printk(link, KERN_INFO, "no reset method "
+ "available, skipping reset\n");
+ if (!(lflags & ATA_LFLAG_ASSUME_CLASS))
+ lflags |= ATA_LFLAG_ASSUME_ATA;
+ goto done;
+ }
+
/* Determine which reset to use and record in ehc->i.action.
* prereset() may examine and modify it.
*/
@@ -2254,6 +2263,7 @@ int ata_eh_reset(struct ata_link *link, int classify,
lflags |= ATA_LFLAG_ASSUME_ATA;
}
+ done:
ata_link_for_each_dev(dev, link) {
/* After the reset, the device state is PIO 0 and the
* controller state is undefined. Reset also wakes up
diff --git a/drivers/ata/libata-sff.c b/drivers/ata/libata-sff.c
index 60cd4b1..93ea0db 100644
--- a/drivers/ata/libata-sff.c
+++ b/drivers/ata/libata-sff.c
@@ -56,7 +56,8 @@ u8 ata_irq_on(struct ata_port *ap)
ap->ctl &= ~ATA_NIEN;
ap->last_ctl = ap->ctl;
- iowrite8(ap->ctl, ioaddr->ctl_addr);
+ if (ioaddr->ctl_addr)
+ iowrite8(ap->ctl, ioaddr->ctl_addr);
tmp = ata_wait_idle(ap);
ap->ops->irq_clear(ap);
@@ -81,7 +82,8 @@ void ata_tf_load(struct ata_port *ap, const struct
ata_taskfile *tf)
unsigned int is_addr = tf->flags & ATA_TFLAG_ISADDR;
if (tf->ctl != ap->last_ctl) {
- iowrite8(tf->ctl, ioaddr->ctl_addr);
+ if (ioaddr->ctl_addr)
+ iowrite8(tf->ctl, ioaddr->ctl_addr);
ap->last_ctl = tf->ctl;
ata_wait_idle(ap);
}
@@ -167,13 +169,15 @@ void ata_tf_read(struct ata_port *ap, struct ata_taskfile
*tf)
tf->device = ioread8(ioaddr->device_addr);
if (tf->flags & ATA_TFLAG_LBA48) {
- iowrite8(tf->ctl | ATA_HOB, ioaddr->ctl_addr);
+ if (ioaddr->ctl_addr)
+ iowrite8(tf->ctl | ATA_HOB, ioaddr->ctl_addr);
tf->hob_feature = ioread8(ioaddr->error_addr);
tf->hob_nsect = ioread8(ioaddr->nsect_addr);
tf->hob_lbal = ioread8(ioaddr->lbal_addr);
tf->hob_lbam = ioread8(ioaddr->lbam_addr);
tf->hob_lbah = ioread8(ioaddr->lbah_addr);
- iowrite8(tf->ctl, ioaddr->ctl_addr);
+ if (ioaddr->ctl_addr)
+ iowrite8(tf->ctl, ioaddr->ctl_addr);
ap->last_ctl = tf->ctl;
}
}
@@ -352,7 +356,8 @@ void ata_bmdma_freeze(struct ata_port *ap)
ap->ctl |= ATA_NIEN;
ap->last_ctl = ap->ctl;
- iowrite8(ap->ctl, ioaddr->ctl_addr);
+ if (ioaddr->ctl_addr)
+ iowrite8(ap->ctl, ioaddr->ctl_addr);
/* Under certain circumstances, some controllers raise IRQ on
* ATA_NIEN manipulation. Also, many controllers fail to mask
@@ -459,13 +464,14 @@ void ata_bmdma_drive_eh(struct ata_port *ap,
ata_prereset_fn_t prereset,
*/
void ata_bmdma_error_handler(struct ata_port *ap)
{
- ata_reset_fn_t hardreset;
+ ata_reset_fn_t softreset = NULL, hardreset = NULL;
- hardreset = NULL;
+ if (ap->ioaddr.ctl_addr)
+ softreset = ata_std_softreset;
if
Re: [ata crash] Re: Linux 2.6.25-rc1
* Arjan van de Ven <[EMAIL PROTECTED]> wrote: > btw this one was featured in the weekly bug top 10.. it's a rather > popular thing to happen. i didnt get very far with bisection. .23 definitely did not crash and booted up fine - but it produced the "Bad IO ..." messages - so my automated bisector scripts which turned that warning into a crash honed in on the wrong (and probably uninteresting) area. .24 had timeouts but no crash. .25-rc1 had the crash. So it seems like multiple IDE regressions building up a concert of failures here, and it's hard to sort them out. If an IDE/PATA/SATA person could take a look at the various logs i posted and could suggest the most efficient way to proceed it could save me from having to blindly spend hours on this problem. Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [ata crash] Re: Linux 2.6.25-rc1
* Arjan van de Ven [EMAIL PROTECTED] wrote: btw this one was featured in the weekly bug top 10.. it's a rather popular thing to happen. i didnt get very far with bisection. .23 definitely did not crash and booted up fine - but it produced the Bad IO ... messages - so my automated bisector scripts which turned that warning into a crashreboot honed in on the wrong (and probably uninteresting) area. .24 had timeouts but no crash. .25-rc1 had the crash. So it seems like multiple IDE regressions building up a concert of failures here, and it's hard to sort them out. If an IDE/PATA/SATA person could take a look at the various logs i posted and could suggest the most efficient way to proceed it could save me from having to blindly spend hours on this problem. Ingo -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [ata crash] Re: Linux 2.6.25-rc1
Ingo Molnar wrote:
On a second attempt to boot the same bzImage, another ATA related
weirdness showed up:
[8.226144] Calling initcall 0xc09f3d8e: isapnp_init+0x0/0xf()
[8.232017] Bad IO access at port 0x0 (outb(val,port))
[8.232799] [ cut here ]
[8.232799] WARNING: at lib/iomap.c:44 bad_io_access+0x2f/0x34()
[8.232799] Pid: 1, comm: swapper Not tainted 2.6.25-rc1 #5
[8.232799] [c011fd63] warn_on_slowpath+0x3c/0x4c
[8.232799] [c0358e9d] ? serial8250_console_write+0x0/0x14e
[8.232799] [c01200a5] ? __call_console_drivers+0x56/0x63
[8.232799] [c06b7acf] ? _spin_unlock_irqrestore+0x15/0x21
[8.232799] [c0120556] ? release_console_sem+0x1c1/0x1c9
[8.232799] [c015c400] ? print_trailer+0x6e/0xfc
[8.232799] [c015c77f] ? check_object+0x10b/0x181
[8.232799] [c01209a0] ? printk+0x15/0x17
[8.232799] [c02cc2ce] bad_io_access+0x2f/0x34
[8.232799] [c02cc48a] iowrite8+0x31/0x34
[8.232799] [c04a1c8d] ata_bmdma_freeze+0x1d/0x30
[8.232799] [c04a2063] __ata_port_freeze+0x2c/0x33
[8.232799] [c04a224f] ata_eh_freeze_port+0x21/0x2f
[8.232799] [c0497fa9] ata_host_start+0xe1/0x132
Does the following patch fix the above problem? pata_isapnp is the
only one which can have NULL ctl_addr and libata SFF layer wasn't
ready for that.
Thanks.
diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
diff --git a/drivers/ata/libata-eh.c b/drivers/ata/libata-eh.c
index 4e31071..c6c04dc 100644
--- a/drivers/ata/libata-eh.c
+++ b/drivers/ata/libata-eh.c
@@ -2150,6 +2150,15 @@ int ata_eh_reset(struct ata_link *link, int classify,
ap-ops-set_piomode(ap, dev);
}
+ if (!softreset !hardreset) {
+ if (verbose)
+ ata_link_printk(link, KERN_INFO, no reset method
+ available, skipping reset\n);
+ if (!(lflags ATA_LFLAG_ASSUME_CLASS))
+ lflags |= ATA_LFLAG_ASSUME_ATA;
+ goto done;
+ }
+
/* Determine which reset to use and record in ehc-i.action.
* prereset() may examine and modify it.
*/
@@ -2254,6 +2263,7 @@ int ata_eh_reset(struct ata_link *link, int classify,
lflags |= ATA_LFLAG_ASSUME_ATA;
}
+ done:
ata_link_for_each_dev(dev, link) {
/* After the reset, the device state is PIO 0 and the
* controller state is undefined. Reset also wakes up
diff --git a/drivers/ata/libata-sff.c b/drivers/ata/libata-sff.c
index 60cd4b1..93ea0db 100644
--- a/drivers/ata/libata-sff.c
+++ b/drivers/ata/libata-sff.c
@@ -56,7 +56,8 @@ u8 ata_irq_on(struct ata_port *ap)
ap-ctl = ~ATA_NIEN;
ap-last_ctl = ap-ctl;
- iowrite8(ap-ctl, ioaddr-ctl_addr);
+ if (ioaddr-ctl_addr)
+ iowrite8(ap-ctl, ioaddr-ctl_addr);
tmp = ata_wait_idle(ap);
ap-ops-irq_clear(ap);
@@ -81,7 +82,8 @@ void ata_tf_load(struct ata_port *ap, const struct
ata_taskfile *tf)
unsigned int is_addr = tf-flags ATA_TFLAG_ISADDR;
if (tf-ctl != ap-last_ctl) {
- iowrite8(tf-ctl, ioaddr-ctl_addr);
+ if (ioaddr-ctl_addr)
+ iowrite8(tf-ctl, ioaddr-ctl_addr);
ap-last_ctl = tf-ctl;
ata_wait_idle(ap);
}
@@ -167,13 +169,15 @@ void ata_tf_read(struct ata_port *ap, struct ata_taskfile
*tf)
tf-device = ioread8(ioaddr-device_addr);
if (tf-flags ATA_TFLAG_LBA48) {
- iowrite8(tf-ctl | ATA_HOB, ioaddr-ctl_addr);
+ if (ioaddr-ctl_addr)
+ iowrite8(tf-ctl | ATA_HOB, ioaddr-ctl_addr);
tf-hob_feature = ioread8(ioaddr-error_addr);
tf-hob_nsect = ioread8(ioaddr-nsect_addr);
tf-hob_lbal = ioread8(ioaddr-lbal_addr);
tf-hob_lbam = ioread8(ioaddr-lbam_addr);
tf-hob_lbah = ioread8(ioaddr-lbah_addr);
- iowrite8(tf-ctl, ioaddr-ctl_addr);
+ if (ioaddr-ctl_addr)
+ iowrite8(tf-ctl, ioaddr-ctl_addr);
ap-last_ctl = tf-ctl;
}
}
@@ -352,7 +356,8 @@ void ata_bmdma_freeze(struct ata_port *ap)
ap-ctl |= ATA_NIEN;
ap-last_ctl = ap-ctl;
- iowrite8(ap-ctl, ioaddr-ctl_addr);
+ if (ioaddr-ctl_addr)
+ iowrite8(ap-ctl, ioaddr-ctl_addr);
/* Under certain circumstances, some controllers raise IRQ on
* ATA_NIEN manipulation. Also, many controllers fail to mask
@@ -459,13 +464,14 @@ void ata_bmdma_drive_eh(struct ata_port *ap,
ata_prereset_fn_t prereset,
*/
void ata_bmdma_error_handler(struct ata_port *ap)
{
- ata_reset_fn_t hardreset;
+ ata_reset_fn_t softreset = NULL, hardreset = NULL;
- hardreset = NULL;
+ if (ap-ioaddr.ctl_addr)
+ softreset =
Re: Linux 2.6.25-rc1
On Feb 11, 2008 11:15 PM, Andrew Morton [EMAIL PROTECTED] wrote: On Mon, 11 Feb 2008 22:46:18 +0100 Torsten Kaiser [EMAIL PROTECTED] wrote: On Feb 11, 2008 1:44 AM, Linus Torvalds [EMAIL PROTECTED] wrote: So give it all a good testing. My mm-mystery-crash has now sneaked into mainline: hm, I don't remember that. Last report: http://marc.info/?l=linux-kernelm=120129854023202 [ 1463.829078] BUG: unable to handle kernel NULL pointer dereference at 0378 [ 1463.832141] IP: [8047af18] ether1394_dg_complete+0x28/0xa0 [ 1463.834616] PGD 7955e067 PUD 7955d067 PMD 0 [ 1463.836148] Oops: [1] SMP [ 1463.836148] CPU 0 [ 1463.836148] Modules linked in: radeon drm w83792d ipv6 tuner tea5767 tda8290 tuner_xc2028 tda9887 tuner_simple mt20xx tea5761 tvaudio msp3400 bttv videodev v4l1_compat ir_common compat_ioctl32 v4l2_common videobuf_dma_sg videobuf_core btcx_risc usbhid tveeprom sg i2c_nforce2 hid pata_amd [ 1463.836148] Pid: 519, comm: khpsbpkt Not tainted 2.6.25-rc1 #1 [ 1463.836148] RIP: 0010:[8047af18] [8047af18] ether1394_dg_complete+0x28/0xa0 [ 1463.836148] RSP: :81007eeb1e80 EFLAGS: 00010282 [ 1463.836148] RAX: RBX: RCX: 0001 [ 1463.836148] RDX: 81004bc62d80 RSI: RDI: 810051873e40 [ 1463.836148] RBP: 81007eeb1eb0 R08: R09: 0001 [ 1463.836148] R10: 0001 R11: 0001 R12: 810051873e40 [ 1463.836148] R13: 81007e1f7200 R14: 0001 R15: 810051873e40 [ 1463.836148] FS: 7f727d6d4700() GS:807e8000() knlGS: [ 1463.836148] CS: 0010 DS: 0018 ES: 0018 CR0: 8005003b [ 1463.836148] CR2: 0378 CR3: 79559000 CR4: 06e0 [ 1463.836148] DR0: DR1: DR2: [ 1463.836148] DR3: DR6: 0ff0 DR7: 0400 [ 1463.836148] Process khpsbpkt (pid: 519, threadinfo 81007eeb, task 81007ee9e000) [ 1463.836148] Stack: 81007eeb1e90 81004bc62b40 810051873e40 [ 1463.836148] 0001 81007eeb1ee0 8047b233 [ 1463.836148] 81007eeb1ec8 81007eeb1ef0 8046c280 81007ff6df10 [ 1463.836148] Call Trace: [ 1463.836148] [8047b233] ether1394_complete_cb+0xb3/0xd0 [ 1463.836148] [8046c280] ? hpsbpkt_thread+0x0/0x140 [ 1463.836148] [8046c33b] hpsbpkt_thread+0xbb/0x140 [ 1463.836148] [8024aead] kthread+0x4d/0x80 [ 1463.836148] [8020c578] child_rip+0xa/0x12 [ 1463.836148] [8020bc8f] ? restore_args+0x0/0x31 [ 1463.836148] [8024ae60] ? kthread+0x0/0x80 [ 1463.836148] [8020c56e] ? child_rip+0x0/0x12 [ 1463.836148] [ 1463.836148] [ 1463.836148] Code: 00 00 00 55 48 89 e5 48 83 ec 30 48 89 5d d8 4c 89 75 f0 89 f3 4c 89 7d f8 4c 89 65 e0 49 89 ff 4c 89 6d e8 4c 8b 2f 49 8b 45 20 4c 8b a0 78 03 00 00 4d 8d b4 24 d0 00 00 00 4c 89 f7 e8 41 f0 [ 1463.836148] RIP [8047af18] ether1394_dg_complete+0x28/0xa0 [ 1463.836148] RSP 81007eeb1e80 [ 1463.836148] CR2: 0378 [ 1463.836208] ohci1394: fw-host0: Waking dma ctx=0 ... processing is probably too slow [ 1463.839250] BUG: unable to handle kernel NULL pointer dereference at [ 1463.841549] IP: [80296d1d] kmem_cache_alloc_node+0x6d/0xa0 [ 1463.842925] PGD 7955e067 PUD 7955d067 PMD 0 [ 1463.846148] Oops: [2] SMP [ 1463.846148] CPU 0 [ 1463.846148] Modules linked in: radeon drm w83792d ipv6 tuner tea5767 tda8290 tuner_xc2028 tda9887 tuner_simple mt20xx tea5761 tvaudio msp3400 bttv videodev v4l1_compat ir_common compat_ioctl32 v4l2_common videobuf_dma_sg videobuf_core btcx_risc usbhid tveeprom sg i2c_nforce2 hid pata_amd [ 1463.846148] Pid: 519, comm: khpsbpkt Tainted: G D 2.6.25-rc1 #1 [ 1463.846148] RIP: 0010:[80296d1d] [80296d1d] kmem_cache_alloc_node+0x6d/0xa0 [ 1463.846148] RSP: :80871ae0 EFLAGS: 00010046 [ 1463.846148] RAX: RBX: 810001006820 RCX: 8052c549 [ 1463.846148] RDX: RSI: RDI: 807fbec0 [ 1463.846148] RBP: 80871b00 R08: 05e0 R09: ffc1 [ 1463.846148] R10: 0001 R11: R12: [ 1463.846148] R13: 0020 R14: 0020 R15: 807fbec0 - here the output from the serial console stopped. [snip] But this is a crash inside the 1394 code. So if you're getting a crash with plain-old-ethernet then it is a different crash. It'd be good if we could see the oops trace for that one too please. 2.6.24-rc3-mm2: http://marc.info/?l=linux-kernelm=119636996902805 -
Re: [ata crash] Re: Linux 2.6.25-rc1
On Tue, 12 Feb 2008 09:18:16 +0100 Ingo Molnar <[EMAIL PROTECTED]> wrote: > > hm, ata_port_wait_eh() started crashing on a testsystem (8-way box): > > [ 39.324116] Calling initcall 0xc09f41eb: legacy_init+0x0/0x888() > [ 39.331868] BUG: unable to handle kernel NULL pointer dereference > at 00e4 [ 39.338811] IP: [] ata_port_wait_eh+0x77/0xa2 > [ 39.344115] *pde = > [ 39.347778] Oops: [#1] SMP > [ 39.350769] > [ 39.350769] Pid: 1, comm: swapper Not tainted (2.6.25-rc1 #5) > [ 39.350769] EIP: 0060:[] EFLAGS: 00010246 CPU: 1 > [ 39.350769] EIP is at ata_port_wait_eh+0x77/0xa2 > [ 39.350769] EAX: f72e5d9c EBX: f734 ECX: c035eb18 EDX: > [ 39.350769] ESI: f73424f0 EDI: 0246 EBP: f7c63efc ESP: f7c63edc > [ 39.350769] DS: 007b ES: 007b FS: 00d8 GS: SS: 0068 > [ 39.350769] Process swapper (pid: 1, ti=f7c62000 task=f7c6 > task.ti=f7c62) [ 39.350769] Stack: f7c6 c012fd31 > f7c63ee8 f7c63ee8 f734 f73 [ 39.350769]f7c63f18 > c049c4b1 f72e5d9c f734 00810001 000 > [ 39.350769]c09f4a60 c0b79a9c 0001 > 0001 000 [ 39.350769] Call Trace: [ 39.350769] > [] ? autoremove_wake_function+0x0/0x30 [ 39.350769] > [] ? ata_host_detach+0x4c/0x13b [ 39.350769] > [] ? legacy_init+0x875/0x888 [ 39.350769] [] ? > getnstimeofday+0x35/0xc0 [ 39.350769] [] ? > kernel_init+0x12a/0x277 [ 39.350769] [] ? > do_early_param+0x34/0x6f [ 39.350769] [] ? > kernel_init+0x0/0x277 [ 39.350769] [] ? > kernel_thread_helper+0x7/0x10 [ 39.350769] === > [ 39.350769] Code: e8 82 0f 21 00 8b 43 08 e8 28 2c 21 00 89 c7 f6 > 43 10 03 8 [ 39.350769] EIP: [] > ata_port_wait_eh+0x77/0xa2 SS:ESP 0068:f7c63edc[ 39.350793] > ---[ end trace 07a6e399b623c9d0 ]--- [ 39.354119] Kernel panic - > not syncing: Attempted to kill init! > > no particular commit stands out at me - so i Cc:-ed various PATA > folks. Config attached [it's randconfig generated so might have weird > option combinations in it]. [ Note: the box uses BLK_CPQ_DA as its > primary storage, ATA is just a CDROM side-thing - so it was never > heavily tested here. It never crashed the bootup before though. ] > > On a second attempt to boot the same bzImage, another ATA related > weirdness showed up: > > [8.226144] Calling initcall 0xc09f3d8e: isapnp_init+0x0/0xf() > [8.232017] Bad IO access at port 0x0 (outb(val,port)) > [8.232799] [ cut here ] > [8.232799] WARNING: at lib/iomap.c:44 bad_io_access+0x2f/0x34() > [8.232799] Pid: 1, comm: swapper Not tainted 2.6.25-rc1 #5 > [8.232799] [] warn_on_slowpath+0x3c/0x4c > [8.232799] [] ? serial8250_console_write+0x0/0x14e > [8.232799] [] ? __call_console_drivers+0x56/0x63 > [8.232799] [] ? _spin_unlock_irqrestore+0x15/0x21 > [8.232799] [] ? release_console_sem+0x1c1/0x1c9 > [8.232799] [] ? print_trailer+0x6e/0xfc > [8.232799] [] ? check_object+0x10b/0x181 > [8.232799] [] ? printk+0x15/0x17 > [8.232799] [] bad_io_access+0x2f/0x34 > [8.232799] [] iowrite8+0x31/0x34 > [8.232799] [] ata_bmdma_freeze+0x1d/0x30 btw this one was featured in the weekly bug top 10.. it's a rather popular thing to happen. -- If you want to reach me at my work email, use [EMAIL PROTECTED] For development, discussion and tips for power savings, visit http://www.lesswatts.org -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [ata crash] Re: Linux 2.6.25-rc1
On Tue, 12 Feb 2008 09:18:16 +0100 Ingo Molnar [EMAIL PROTECTED] wrote: hm, ata_port_wait_eh() started crashing on a testsystem (8-way box): [ 39.324116] Calling initcall 0xc09f41eb: legacy_init+0x0/0x888() [ 39.331868] BUG: unable to handle kernel NULL pointer dereference at 00e4 [ 39.338811] IP: [c04a4e11] ata_port_wait_eh+0x77/0xa2 [ 39.344115] *pde = [ 39.347778] Oops: [#1] SMP [ 39.350769] [ 39.350769] Pid: 1, comm: swapper Not tainted (2.6.25-rc1 #5) [ 39.350769] EIP: 0060:[c04a4e11] EFLAGS: 00010246 CPU: 1 [ 39.350769] EIP is at ata_port_wait_eh+0x77/0xa2 [ 39.350769] EAX: f72e5d9c EBX: f734 ECX: c035eb18 EDX: [ 39.350769] ESI: f73424f0 EDI: 0246 EBP: f7c63efc ESP: f7c63edc [ 39.350769] DS: 007b ES: 007b FS: 00d8 GS: SS: 0068 [ 39.350769] Process swapper (pid: 1, ti=f7c62000 task=f7c6 task.ti=f7c62) [ 39.350769] Stack: f7c6 c012fd31 f7c63ee8 f7c63ee8 f734 f73 [ 39.350769]f7c63f18 c049c4b1 f72e5d9c f734 00810001 000 [ 39.350769]c09f4a60 c0b79a9c 0001 0001 000 [ 39.350769] Call Trace: [ 39.350769] [c012fd31] ? autoremove_wake_function+0x0/0x30 [ 39.350769] [c049c4b1] ? ata_host_detach+0x4c/0x13b [ 39.350769] [c09f4a60] ? legacy_init+0x875/0x888 [ 39.350769] [c0133fa6] ? getnstimeofday+0x35/0xc0 [ 39.350769] [c09d7465] ? kernel_init+0x12a/0x277 [ 39.350769] [c09d7300] ? do_early_param+0x34/0x6f [ 39.350769] [c09d733b] ? kernel_init+0x0/0x277 [ 39.350769] [c0104b17] ? kernel_thread_helper+0x7/0x10 [ 39.350769] === [ 39.350769] Code: e8 82 0f 21 00 8b 43 08 e8 28 2c 21 00 89 c7 f6 43 10 03 8 [ 39.350769] EIP: [c04a4e11] ata_port_wait_eh+0x77/0xa2 SS:ESP 0068:f7c63edc[ 39.350793] ---[ end trace 07a6e399b623c9d0 ]--- [ 39.354119] Kernel panic - not syncing: Attempted to kill init! no particular commit stands out at me - so i Cc:-ed various PATA folks. Config attached [it's randconfig generated so might have weird option combinations in it]. [ Note: the box uses BLK_CPQ_DA as its primary storage, ATA is just a CDROM side-thing - so it was never heavily tested here. It never crashed the bootup before though. ] On a second attempt to boot the same bzImage, another ATA related weirdness showed up: [8.226144] Calling initcall 0xc09f3d8e: isapnp_init+0x0/0xf() [8.232017] Bad IO access at port 0x0 (outb(val,port)) [8.232799] [ cut here ] [8.232799] WARNING: at lib/iomap.c:44 bad_io_access+0x2f/0x34() [8.232799] Pid: 1, comm: swapper Not tainted 2.6.25-rc1 #5 [8.232799] [c011fd63] warn_on_slowpath+0x3c/0x4c [8.232799] [c0358e9d] ? serial8250_console_write+0x0/0x14e [8.232799] [c01200a5] ? __call_console_drivers+0x56/0x63 [8.232799] [c06b7acf] ? _spin_unlock_irqrestore+0x15/0x21 [8.232799] [c0120556] ? release_console_sem+0x1c1/0x1c9 [8.232799] [c015c400] ? print_trailer+0x6e/0xfc [8.232799] [c015c77f] ? check_object+0x10b/0x181 [8.232799] [c01209a0] ? printk+0x15/0x17 [8.232799] [c02cc2ce] bad_io_access+0x2f/0x34 [8.232799] [c02cc48a] iowrite8+0x31/0x34 [8.232799] [c04a1c8d] ata_bmdma_freeze+0x1d/0x30 btw this one was featured in the weekly bug top 10.. it's a rather popular thing to happen. -- If you want to reach me at my work email, use [EMAIL PROTECTED] For development, discussion and tips for power savings, visit http://www.lesswatts.org -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: Linux 2.6.25-rc1 , syntax error near unexpected token `;'
Hello Sam , On Mon, 11 Feb 2008, Sam Ravnborg wrote: On Sun, Feb 10, 2008 at 04:47:43PM -0900, Mr. James W. Laferriere wrote: Hello All , grabbed using git just moments ago . make V=1 KBUILD_VERBOSE=1 INSTALL_PATH=/boot clean all install modules_install ...snip... make -f scripts/Makefile.clean obj=sound/usb/usx2y make -f scripts/Makefile.clean obj=usr rm -rf .tmp_versions rm -f arch/x86/boot/fdimage arch/x86/boot/image.iso arch/x86/boot/mtools.conf vmlinux System.map .tmp_kallsyms* .tmp_version .tmp_vmlinux* .tmp_System.map rm -f include/config/kernel.release echo 2.6.25-rc1 > include/config/kernel.release set -e; ; mkdir -p include/linux/; (echo \#define LINUX_VERSION_CODE 132633; echo '#define KERNEL_VERSION(a,b,c) (((a) << 16) + ((b) << 8) + (c))';) < /usr/src/linux-2.6.25-rc1-git/Makefile > include/linux/version.h.tmp; if [ -r include/linux/version.h ] && cmp -s include/linux/version.h include/linux/version.h.tmp; then rm -f include/linux/version.h.tmp; else ; mv -f include/linux/version.h.tmp include/linux/version.h; fi /bin/sh: -c: line 0: syntax error near unexpected token `;' /bin/sh: -c: line 0: `set -e; ; mkdir -p include/linux/;(echo \#define LINUX_VERSION_CODE 132633; echo '#define KERNEL_VERSION(a,b,c) (((a) << 16) + ((b) << 8) + (c))';) < /usr/src/linux-2.6.25-rc1-git/Makefile > include/linux/version.h.tmp; if [ -r include/linux/version.h ] && cmp -s include/linux/version.h include/linux/version.h.tmp; then rm -f include/linux/version.h.tmp; else ; mv -f include/linux/version.h.tmp include/linux/version.h; fi' make: *** [include/linux/version.h] Error 2 Please use following fix. Sam diff --git a/scripts/Kbuild.include b/scripts/Kbuild.include index da3559e..d64e6ba 100644 --- a/scripts/Kbuild.include +++ b/scripts/Kbuild.include @@ -39,10 +39,13 @@ escsq = $(subst $(squote),'\$(squote)',$1) # - If they are equal no change, and no timestamp update # - stdin is piped in from the first prerequisite ($<) so one has # to specify a valid file as first prerequisite (often the kbuild file) + chk_filechk = : quiet_chk_filechk = echo ' CHK $@' silent_chk_filechk = : + upd_filechk = : quiet_upd_filechk = echo ' UPD $@' silent_upd_filechk = : + define filechk $(Q)set -e; \ $($(quiet)chk_filechk); \ Thank You . that got me past that error . 2.6.25-rc1 is compiling as I write this . Tnx Agn , JimL -- +--+ | James W. Laferriere | SystemTechniques | Give me VMS | | Network Engineer | 2133McCullam Ave | Give me Linux | | [EMAIL PROTECTED] | Fairbanks, AK. 99701 | only on AXP | +--+ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: Linux 2.6.25-rc1
Andrew Morton wrote: > On Mon, 11 Feb 2008 22:46:18 +0100 > "Torsten Kaiser" <[EMAIL PROTECTED]> wrote: >> The system is a dual opteron x86_64 system with 4 GB ECC RAM and an >> nVidia 3600 chipset (MCP55). >> As noted in the rc3-mm2-thread the crash will also happen, if I use >> normal ethernet instead of ether1394. > > But this is a crash inside the 1394 code. So if you're getting a crash > with plain-old-ethernet then it is a different crash. It'd be good if we > could see the oops trace for that one too please. There are no bugs in 1394. :-) Here are two postings from Torsten which I found in my mail archive. 2007-11-29, an IP-over-1394 backtrace + an ethernet backtrace: http://marc.info/?l=linux-kernel=119636996902805 2007-12-03, a backtrace in the TCP code: http://marc.info/?l=linux-kernel=119671371413299 -- Stefan Richter -=-==--- --=- -=-== http://arcgraph.de/sr/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: Linux 2.6.25-rc1
On Mon, 11 Feb 2008 22:46:18 +0100 "Torsten Kaiser" <[EMAIL PROTECTED]> wrote: > On Feb 11, 2008 1:44 AM, Linus Torvalds <[EMAIL PROTECTED]> wrote: > > So give it all a good testing. > > My mm-mystery-crash has now sneaked into mainline: hm, I don't remember that. > [ 1463.829078] BUG: unable to handle kernel NULL pointer dereference > at 0378 > [ 1463.832141] IP: [] ether1394_dg_complete+0x28/0xa0 > [ 1463.834616] PGD 7955e067 PUD 7955d067 PMD 0 > [ 1463.836148] Oops: [1] SMP > [ 1463.836148] CPU 0 > [ 1463.836148] Modules linked in: radeon drm w83792d ipv6 tuner > tea5767 tda8290 tuner_xc2028 tda9887 tuner_simple mt20xx tea5761 > tvaudio msp3400 bttv videodev v4l1_compat ir_common compat_ioctl32 > v4l2_common videobuf_dma_sg videobuf_core btcx_risc usbhid tveeprom sg > i2c_nforce2 hid pata_amd > [ 1463.836148] Pid: 519, comm: khpsbpkt Not tainted 2.6.25-rc1 #1 > [ 1463.836148] RIP: 0010:[] [] > ether1394_dg_complete+0x28/0xa0 > [ 1463.836148] RSP: :81007eeb1e80 EFLAGS: 00010282 > [ 1463.836148] RAX: RBX: RCX: > 0001 > [ 1463.836148] RDX: 81004bc62d80 RSI: RDI: > 810051873e40 > [ 1463.836148] RBP: 81007eeb1eb0 R08: R09: > 0001 > [ 1463.836148] R10: 0001 R11: 0001 R12: > 810051873e40 > [ 1463.836148] R13: 81007e1f7200 R14: 0001 R15: > 810051873e40 > [ 1463.836148] FS: 7f727d6d4700() GS:807e8000() > knlGS: > [ 1463.836148] CS: 0010 DS: 0018 ES: 0018 CR0: 8005003b > [ 1463.836148] CR2: 0378 CR3: 79559000 CR4: > 06e0 > [ 1463.836148] DR0: DR1: DR2: > > [ 1463.836148] DR3: DR6: 0ff0 DR7: > 0400 > [ 1463.836148] Process khpsbpkt (pid: 519, threadinfo > 81007eeb, task 81007ee9e000) > [ 1463.836148] Stack: 81007eeb1e90 81004bc62b40 > 810051873e40 > [ 1463.836148] 0001 81007eeb1ee0 > 8047b233 > [ 1463.836148] 81007eeb1ec8 81007eeb1ef0 8046c280 > 81007ff6df10 > [ 1463.836148] Call Trace: > [ 1463.836148] [] ether1394_complete_cb+0xb3/0xd0 > [ 1463.836148] [] ? hpsbpkt_thread+0x0/0x140 > [ 1463.836148] [] hpsbpkt_thread+0xbb/0x140 > [ 1463.836148] [] kthread+0x4d/0x80 > [ 1463.836148] [] child_rip+0xa/0x12 > [ 1463.836148] [] ? restore_args+0x0/0x31 > [ 1463.836148] [] ? kthread+0x0/0x80 > [ 1463.836148] [] ? child_rip+0x0/0x12 > [ 1463.836148] > [ 1463.836148] > [ 1463.836148] Code: 00 00 00 55 48 89 e5 48 83 ec 30 48 89 5d d8 4c > 89 75 f0 89 f3 4c 89 7d f8 4c 89 65 e0 49 89 ff 4c 89 6d e8 4c 8b 2f > 49 8b 45 20 <4c> 8b a0 78 03 00 00 4d 8d b4 24 d0 00 00 00 4c 89 f7 e8 > 41 f0 > [ 1463.836148] RIP [] ether1394_dg_complete+0x28/0xa0 > [ 1463.836148] RSP > [ 1463.836148] CR2: 0378 > [ 1463.836208] ohci1394: fw-host0: Waking dma ctx=0 ... processing is > probably too slow > [ 1463.839250] BUG: unable to handle kernel NULL pointer dereference > at > [ 1463.841549] IP: [] kmem_cache_alloc_node+0x6d/0xa0 > [ 1463.842925] PGD 7955e067 PUD 7955d067 PMD 0 > [ 1463.846148] Oops: [2] SMP > [ 1463.846148] CPU 0 > [ 1463.846148] Modules linked in: radeon drm w83792d ipv6 tuner > tea5767 tda8290 tuner_xc2028 tda9887 tuner_simple mt20xx tea5761 > tvaudio msp3400 bttv videodev v4l1_compat ir_common compat_ioctl32 > v4l2_common videobuf_dma_sg videobuf_core btcx_risc usbhid tveeprom sg > i2c_nforce2 hid pata_amd > [ 1463.846148] Pid: 519, comm: khpsbpkt Tainted: G D 2.6.25-rc1 #1 > [ 1463.846148] RIP: 0010:[] [] > kmem_cache_alloc_node+0x6d/0xa0 > [ 1463.846148] RSP: :80871ae0 EFLAGS: 00010046 > [ 1463.846148] RAX: RBX: 810001006820 RCX: > 8052c549 > [ 1463.846148] RDX: RSI: RDI: > 807fbec0 > [ 1463.846148] RBP: 80871b00 R08: 05e0 R09: > ffc1 > [ 1463.846148] R10: 0001 R11: R12: > > [ 1463.846148] R13: 0020 R14: 0020 R15: > 807fbec0 > -> here the output from the serial console stopped. > Caps lock and Scroll lock where flashing again and as it hit a 'good' > spot during the installing of the package this crash resulted in a > corrupted ld.so.cache and damage several housekeeping files of the > package manager. :-( > > Last good mm was 2.6.24-rc2-mm1, the next booting mm was > 2.6.24-rc3-mm2 and that version had these "random" crashes. > Last good mainline was 2.6.24-rc7 that I was testing with the new > iommu patches that where added to 2.6.24-rc3-mm2. > > I did a partly bisect of 2.6.24-rc6-mm1 that narrow it to this range: > 2.6.24-rc6 + mm-patches up to (including) git.nfsd -> worked > 2.6.24-rc6 + mm-patches up to
Re: Linux 2.6.25-rc1
On Feb 11, 2008 1:44 AM, Linus Torvalds <[EMAIL PROTECTED]> wrote: > So give it all a good testing. My mm-mystery-crash has now sneaked into mainline: [ 1463.829078] BUG: unable to handle kernel NULL pointer dereference at 0378 [ 1463.832141] IP: [] ether1394_dg_complete+0x28/0xa0 [ 1463.834616] PGD 7955e067 PUD 7955d067 PMD 0 [ 1463.836148] Oops: [1] SMP [ 1463.836148] CPU 0 [ 1463.836148] Modules linked in: radeon drm w83792d ipv6 tuner tea5767 tda8290 tuner_xc2028 tda9887 tuner_simple mt20xx tea5761 tvaudio msp3400 bttv videodev v4l1_compat ir_common compat_ioctl32 v4l2_common videobuf_dma_sg videobuf_core btcx_risc usbhid tveeprom sg i2c_nforce2 hid pata_amd [ 1463.836148] Pid: 519, comm: khpsbpkt Not tainted 2.6.25-rc1 #1 [ 1463.836148] RIP: 0010:[] [] ether1394_dg_complete+0x28/0xa0 [ 1463.836148] RSP: :81007eeb1e80 EFLAGS: 00010282 [ 1463.836148] RAX: RBX: RCX: 0001 [ 1463.836148] RDX: 81004bc62d80 RSI: RDI: 810051873e40 [ 1463.836148] RBP: 81007eeb1eb0 R08: R09: 0001 [ 1463.836148] R10: 0001 R11: 0001 R12: 810051873e40 [ 1463.836148] R13: 81007e1f7200 R14: 0001 R15: 810051873e40 [ 1463.836148] FS: 7f727d6d4700() GS:807e8000() knlGS: [ 1463.836148] CS: 0010 DS: 0018 ES: 0018 CR0: 8005003b [ 1463.836148] CR2: 0378 CR3: 79559000 CR4: 06e0 [ 1463.836148] DR0: DR1: DR2: [ 1463.836148] DR3: DR6: 0ff0 DR7: 0400 [ 1463.836148] Process khpsbpkt (pid: 519, threadinfo 81007eeb, task 81007ee9e000) [ 1463.836148] Stack: 81007eeb1e90 81004bc62b40 810051873e40 [ 1463.836148] 0001 81007eeb1ee0 8047b233 [ 1463.836148] 81007eeb1ec8 81007eeb1ef0 8046c280 81007ff6df10 [ 1463.836148] Call Trace: [ 1463.836148] [] ether1394_complete_cb+0xb3/0xd0 [ 1463.836148] [] ? hpsbpkt_thread+0x0/0x140 [ 1463.836148] [] hpsbpkt_thread+0xbb/0x140 [ 1463.836148] [] kthread+0x4d/0x80 [ 1463.836148] [] child_rip+0xa/0x12 [ 1463.836148] [] ? restore_args+0x0/0x31 [ 1463.836148] [] ? kthread+0x0/0x80 [ 1463.836148] [] ? child_rip+0x0/0x12 [ 1463.836148] [ 1463.836148] [ 1463.836148] Code: 00 00 00 55 48 89 e5 48 83 ec 30 48 89 5d d8 4c 89 75 f0 89 f3 4c 89 7d f8 4c 89 65 e0 49 89 ff 4c 89 6d e8 4c 8b 2f 49 8b 45 20 <4c> 8b a0 78 03 00 00 4d 8d b4 24 d0 00 00 00 4c 89 f7 e8 41 f0 [ 1463.836148] RIP [] ether1394_dg_complete+0x28/0xa0 [ 1463.836148] RSP [ 1463.836148] CR2: 0378 [ 1463.836208] ohci1394: fw-host0: Waking dma ctx=0 ... processing is probably too slow [ 1463.839250] BUG: unable to handle kernel NULL pointer dereference at [ 1463.841549] IP: [] kmem_cache_alloc_node+0x6d/0xa0 [ 1463.842925] PGD 7955e067 PUD 7955d067 PMD 0 [ 1463.846148] Oops: [2] SMP [ 1463.846148] CPU 0 [ 1463.846148] Modules linked in: radeon drm w83792d ipv6 tuner tea5767 tda8290 tuner_xc2028 tda9887 tuner_simple mt20xx tea5761 tvaudio msp3400 bttv videodev v4l1_compat ir_common compat_ioctl32 v4l2_common videobuf_dma_sg videobuf_core btcx_risc usbhid tveeprom sg i2c_nforce2 hid pata_amd [ 1463.846148] Pid: 519, comm: khpsbpkt Tainted: G D 2.6.25-rc1 #1 [ 1463.846148] RIP: 0010:[] [] kmem_cache_alloc_node+0x6d/0xa0 [ 1463.846148] RSP: :80871ae0 EFLAGS: 00010046 [ 1463.846148] RAX: RBX: 810001006820 RCX: 8052c549 [ 1463.846148] RDX: RSI: RDI: 807fbec0 [ 1463.846148] RBP: 80871b00 R08: 05e0 R09: ffc1 [ 1463.846148] R10: 0001 R11: R12: [ 1463.846148] R13: 0020 R14: 0020 R15: 807fbec0 -> here the output from the serial console stopped. Caps lock and Scroll lock where flashing again and as it hit a 'good' spot during the installing of the package this crash resulted in a corrupted ld.so.cache and damage several housekeeping files of the package manager. :-( Last good mm was 2.6.24-rc2-mm1, the next booting mm was 2.6.24-rc3-mm2 and that version had these "random" crashes. Last good mainline was 2.6.24-rc7 that I was testing with the new iommu patches that where added to 2.6.24-rc3-mm2. I did a partly bisect of 2.6.24-rc6-mm1 that narrow it to this range: 2.6.24-rc6 + mm-patches up to (including) git.nfsd -> worked 2.6.24-rc6 + mm-patches up to (including) git.xfs -> crashed I think the only added patch between rc2-mm1 and rc3-mm2 in that range where the iommu changes that I later ruled out. That leaves some git trees as suspects: git-ocfs2.patch git-selinux.patch git-s390.patch git-sched.patch git-sh.patch git-scsi-misc.patch git-unionfs.patch git-v9fs.patch
Re: Linux 2.6.25-rc1
On Monday 11 February 2008, Sam Ravnborg wrote: > From 49af821e4b1c07e756cbc2e389eba9d885912602 Mon Sep 17 00:00:00 2001 > From: Sam Ravnborg <[EMAIL PROTECTED]> > Date: Mon, 11 Feb 2008 14:26:26 +0100 > Subject: [PATCH] kbuild: fix make V=1 > > When make -s support were added to filechk to > combination created with make V=1 were not > covered. > Fix it by explicitly cover this case too. > > Signed-off-by: Sam Ravnborg <[EMAIL PROTECTED]> > Cc: Mike Frysinger <[EMAIL PROTECTED]> erp, i wondered if there was another case i was missing ... you'll also need the attached fixed ... --- When make -s support was added to compile.h, it broke make V=1. Signed-off-by: Mike Frysinger <[EMAIL PROTECTED]> --- diff --git a/init/Makefile b/init/Makefile index c5f157c..781f102 100644 --- a/init/Makefile +++ b/init/Makefile @@ -26,7 +26,7 @@ $(obj)/version.o: include/linux/compile.h # so we regenerate it always. # mkcompile_h will make sure to only update the # actual file if its content has changed. - + chk_compile.h = : quiet_chk_compile.h = echo ' CHK $@' silent_chk_compile.h = : include/linux/compile.h: FORCE signature.asc Description: This is a digitally signed message part.
Re: Linux 2.6.25-rc1
On Mon, 11 Feb 2008 08:39:11 +0100 Brice Goglin <[EMAIL PROTECTED]> wrote: > Linus Torvalds wrote: > > - Lots of cleanups from the x86 merge (making more and more use of > > common files), but also the big page attribute stuff is in and > > caused a fair amount of churn, and while most of the issues should > > have been very obvious and all got fixed, this is definitely one of > > those things that we want a lot of very wide testing of to make > > sure nothing regressed. > > Now that __ioremap isn't available anymore, is there anything in the > new pageattr stuff to replace a manual __ioremap with __PAGE_PCD or if you want uncached memory, use iorenmap_uncached... > __PAGE_PSE? or do we have to wait for 2.6.26 to bring PAT support? I __PAGE_PSE is the large page bit... that should be managed by the core for sure. (yes I know that the same bit may have different meanings, but it's not __PAGE_PSE then). PAT has a bunch of complications that really need to be resolved in the core (eg how to deal with aliases etc etc) > don't see any new function accepting random page attributes as > __ioremap did. correct -- If you want to reach me at my work email, use [EMAIL PROTECTED] For development, discussion and tips for power savings, visit http://www.lesswatts.org -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: Linux 2.6.25-rc1
Hi Linus. A kbuild bug sneaked in. Please pull from: ssh://master.kernel.org/pub/scm/linux/kernel/git/sam/kbuild.git to fix the following bug. Sam >From 49af821e4b1c07e756cbc2e389eba9d885912602 Mon Sep 17 00:00:00 2001 From: Sam Ravnborg <[EMAIL PROTECTED]> Date: Mon, 11 Feb 2008 14:26:26 +0100 Subject: [PATCH] kbuild: fix make V=1 When make -s support were added to filechk to combination created with make V=1 were not covered. Fix it by explicitly cover this case too. Signed-off-by: Sam Ravnborg <[EMAIL PROTECTED]> Cc: Mike Frysinger <[EMAIL PROTECTED]> --- scripts/Kbuild.include |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/scripts/Kbuild.include b/scripts/Kbuild.include index da3559e..d64e6ba 100644 --- a/scripts/Kbuild.include +++ b/scripts/Kbuild.include @@ -39,10 +39,13 @@ escsq = $(subst $(squote),'\$(squote)',$1) # - If they are equal no change, and no timestamp update # - stdin is piped in from the first prerequisite ($<) so one has # to specify a valid file as first prerequisite (often the kbuild file) + chk_filechk = : quiet_chk_filechk = echo ' CHK $@' silent_chk_filechk = : + upd_filechk = : quiet_upd_filechk = echo ' UPD $@' silent_upd_filechk = : + define filechk $(Q)set -e; \ $($(quiet)chk_filechk); \ -- 1.5.4.rc3.14.g44397 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: Linux 2.6.25-rc1 , syntax error near unexpected token `;'
On Sun, Feb 10, 2008 at 04:47:43PM -0900, Mr. James W. Laferriere wrote: > Hello All , grabbed using git just moments ago . > > make V=1 KBUILD_VERBOSE=1 INSTALL_PATH=/boot clean all install > modules_install > > ...snip... > make -f scripts/Makefile.clean obj=sound/usb/usx2y > make -f scripts/Makefile.clean obj=usr > rm -rf .tmp_versions > rm -f arch/x86/boot/fdimage arch/x86/boot/image.iso > arch/x86/boot/mtools.conf vmlinux System.map .tmp_kallsyms* .tmp_version > .tmp_vmlinux* .tmp_System.map > rm -f include/config/kernel.release > echo 2.6.25-rc1 > include/config/kernel.release > set -e; ; mkdir -p include/linux/; (echo \#define LINUX_VERSION_CODE > 132633; echo '#define KERNEL_VERSION(a,b,c) (((a) << 16) + ((b) << 8) + > (c))';) < /usr/src/linux-2.6.25-rc1-git/Makefile > > include/linux/version.h.tmp; if [ -r include/linux/version.h ] && cmp -s > include/linux/version.h include/linux/version.h.tmp; then rm -f > include/linux/version.h.tmp; else ; mv -f include/linux/version.h.tmp > include/linux/version.h; fi > /bin/sh: -c: line 0: syntax error near unexpected token `;' > /bin/sh: -c: line 0: `set -e; ; mkdir -p include/linux/;(echo > \#define LINUX_VERSION_CODE 132633; echo '#define KERNEL_VERSION(a,b,c) > (((a) << 16) + ((b) << 8) + (c))';) < > /usr/src/linux-2.6.25-rc1-git/Makefile > include/linux/version.h.tmp; if [ > -r include/linux/version.h ] && cmp -s include/linux/version.h > include/linux/version.h.tmp; then rm -f include/linux/version.h.tmp; else ; > mv -f include/linux/version.h.tmp include/linux/version.h; fi' > make: *** [include/linux/version.h] Error 2 Please use following fix. Sam diff --git a/scripts/Kbuild.include b/scripts/Kbuild.include index da3559e..d64e6ba 100644 --- a/scripts/Kbuild.include +++ b/scripts/Kbuild.include @@ -39,10 +39,13 @@ escsq = $(subst $(squote),'\$(squote)',$1) # - If they are equal no change, and no timestamp update # - stdin is piped in from the first prerequisite ($<) so one has # to specify a valid file as first prerequisite (often the kbuild file) + chk_filechk = : quiet_chk_filechk = echo ' CHK $@' silent_chk_filechk = : + upd_filechk = : quiet_upd_filechk = echo ' UPD $@' silent_upd_filechk = : + define filechk $(Q)set -e; \ $($(quiet)chk_filechk); \ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[patch] Re: Linux 2.6.25-rc1 , syntax error near unexpected token `;'
>> set -e; ; mkdir -p include/linux/; (echo \#define LINUX_VERSION_CODE http://mid.gmane.org/[EMAIL PROTECTED] _ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: Linux 2.6.25-rc1
Linus Torvalds wrote: > - Lots of cleanups from the x86 merge (making more and more use of common >files), but also the big page attribute stuff is in and caused a fair >amount of churn, and while most of the issues should have been very >obvious and all got fixed, this is definitely one of those things that >we want a lot of very wide testing of to make sure nothing regressed. > Now that __ioremap isn't available anymore, is there anything in the new pageattr stuff to replace a manual __ioremap with __PAGE_PCD or __PAGE_PSE? or do we have to wait for 2.6.26 to bring PAT support? I don't see any new function accepting random page attributes as __ioremap did. thanks, Brice -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: Linux 2.6.25-rc1
Andrew Morton wrote: On Mon, 11 Feb 2008 22:46:18 +0100 Torsten Kaiser [EMAIL PROTECTED] wrote: The system is a dual opteron x86_64 system with 4 GB ECC RAM and an nVidia 3600 chipset (MCP55). As noted in the rc3-mm2-thread the crash will also happen, if I use normal ethernet instead of ether1394. But this is a crash inside the 1394 code. So if you're getting a crash with plain-old-ethernet then it is a different crash. It'd be good if we could see the oops trace for that one too please. There are no bugs in 1394. :-) Here are two postings from Torsten which I found in my mail archive. 2007-11-29, an IP-over-1394 backtrace + an ethernet backtrace: http://marc.info/?l=linux-kernelm=119636996902805 2007-12-03, a backtrace in the TCP code: http://marc.info/?l=linux-kernelm=119671371413299 -- Stefan Richter -=-==--- --=- -=-== http://arcgraph.de/sr/ -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: Linux 2.6.25-rc1
On Mon, 11 Feb 2008 22:46:18 +0100 Torsten Kaiser [EMAIL PROTECTED] wrote: On Feb 11, 2008 1:44 AM, Linus Torvalds [EMAIL PROTECTED] wrote: So give it all a good testing. My mm-mystery-crash has now sneaked into mainline: hm, I don't remember that. [ 1463.829078] BUG: unable to handle kernel NULL pointer dereference at 0378 [ 1463.832141] IP: [8047af18] ether1394_dg_complete+0x28/0xa0 [ 1463.834616] PGD 7955e067 PUD 7955d067 PMD 0 [ 1463.836148] Oops: [1] SMP [ 1463.836148] CPU 0 [ 1463.836148] Modules linked in: radeon drm w83792d ipv6 tuner tea5767 tda8290 tuner_xc2028 tda9887 tuner_simple mt20xx tea5761 tvaudio msp3400 bttv videodev v4l1_compat ir_common compat_ioctl32 v4l2_common videobuf_dma_sg videobuf_core btcx_risc usbhid tveeprom sg i2c_nforce2 hid pata_amd [ 1463.836148] Pid: 519, comm: khpsbpkt Not tainted 2.6.25-rc1 #1 [ 1463.836148] RIP: 0010:[8047af18] [8047af18] ether1394_dg_complete+0x28/0xa0 [ 1463.836148] RSP: :81007eeb1e80 EFLAGS: 00010282 [ 1463.836148] RAX: RBX: RCX: 0001 [ 1463.836148] RDX: 81004bc62d80 RSI: RDI: 810051873e40 [ 1463.836148] RBP: 81007eeb1eb0 R08: R09: 0001 [ 1463.836148] R10: 0001 R11: 0001 R12: 810051873e40 [ 1463.836148] R13: 81007e1f7200 R14: 0001 R15: 810051873e40 [ 1463.836148] FS: 7f727d6d4700() GS:807e8000() knlGS: [ 1463.836148] CS: 0010 DS: 0018 ES: 0018 CR0: 8005003b [ 1463.836148] CR2: 0378 CR3: 79559000 CR4: 06e0 [ 1463.836148] DR0: DR1: DR2: [ 1463.836148] DR3: DR6: 0ff0 DR7: 0400 [ 1463.836148] Process khpsbpkt (pid: 519, threadinfo 81007eeb, task 81007ee9e000) [ 1463.836148] Stack: 81007eeb1e90 81004bc62b40 810051873e40 [ 1463.836148] 0001 81007eeb1ee0 8047b233 [ 1463.836148] 81007eeb1ec8 81007eeb1ef0 8046c280 81007ff6df10 [ 1463.836148] Call Trace: [ 1463.836148] [8047b233] ether1394_complete_cb+0xb3/0xd0 [ 1463.836148] [8046c280] ? hpsbpkt_thread+0x0/0x140 [ 1463.836148] [8046c33b] hpsbpkt_thread+0xbb/0x140 [ 1463.836148] [8024aead] kthread+0x4d/0x80 [ 1463.836148] [8020c578] child_rip+0xa/0x12 [ 1463.836148] [8020bc8f] ? restore_args+0x0/0x31 [ 1463.836148] [8024ae60] ? kthread+0x0/0x80 [ 1463.836148] [8020c56e] ? child_rip+0x0/0x12 [ 1463.836148] [ 1463.836148] [ 1463.836148] Code: 00 00 00 55 48 89 e5 48 83 ec 30 48 89 5d d8 4c 89 75 f0 89 f3 4c 89 7d f8 4c 89 65 e0 49 89 ff 4c 89 6d e8 4c 8b 2f 49 8b 45 20 4c 8b a0 78 03 00 00 4d 8d b4 24 d0 00 00 00 4c 89 f7 e8 41 f0 [ 1463.836148] RIP [8047af18] ether1394_dg_complete+0x28/0xa0 [ 1463.836148] RSP 81007eeb1e80 [ 1463.836148] CR2: 0378 [ 1463.836208] ohci1394: fw-host0: Waking dma ctx=0 ... processing is probably too slow [ 1463.839250] BUG: unable to handle kernel NULL pointer dereference at [ 1463.841549] IP: [80296d1d] kmem_cache_alloc_node+0x6d/0xa0 [ 1463.842925] PGD 7955e067 PUD 7955d067 PMD 0 [ 1463.846148] Oops: [2] SMP [ 1463.846148] CPU 0 [ 1463.846148] Modules linked in: radeon drm w83792d ipv6 tuner tea5767 tda8290 tuner_xc2028 tda9887 tuner_simple mt20xx tea5761 tvaudio msp3400 bttv videodev v4l1_compat ir_common compat_ioctl32 v4l2_common videobuf_dma_sg videobuf_core btcx_risc usbhid tveeprom sg i2c_nforce2 hid pata_amd [ 1463.846148] Pid: 519, comm: khpsbpkt Tainted: G D 2.6.25-rc1 #1 [ 1463.846148] RIP: 0010:[80296d1d] [80296d1d] kmem_cache_alloc_node+0x6d/0xa0 [ 1463.846148] RSP: :80871ae0 EFLAGS: 00010046 [ 1463.846148] RAX: RBX: 810001006820 RCX: 8052c549 [ 1463.846148] RDX: RSI: RDI: 807fbec0 [ 1463.846148] RBP: 80871b00 R08: 05e0 R09: ffc1 [ 1463.846148] R10: 0001 R11: R12: [ 1463.846148] R13: 0020 R14: 0020 R15: 807fbec0 - here the output from the serial console stopped. Caps lock and Scroll lock where flashing again and as it hit a 'good' spot during the installing of the package this crash resulted in a corrupted ld.so.cache and damage several housekeeping files of the package manager. :-( Last good mm was 2.6.24-rc2-mm1, the next booting mm was 2.6.24-rc3-mm2 and that version had these random crashes. Last good mainline was 2.6.24-rc7 that I was testing with the new iommu patches that where added to 2.6.24-rc3-mm2. I did a partly bisect of
Re: Linux 2.6.25-rc1
On Mon, 11 Feb 2008 08:39:11 +0100 Brice Goglin [EMAIL PROTECTED] wrote: Linus Torvalds wrote: - Lots of cleanups from the x86 merge (making more and more use of common files), but also the big page attribute stuff is in and caused a fair amount of churn, and while most of the issues should have been very obvious and all got fixed, this is definitely one of those things that we want a lot of very wide testing of to make sure nothing regressed. Now that __ioremap isn't available anymore, is there anything in the new pageattr stuff to replace a manual __ioremap with __PAGE_PCD or if you want uncached memory, use iorenmap_uncached... __PAGE_PSE? or do we have to wait for 2.6.26 to bring PAT support? I __PAGE_PSE is the large page bit... that should be managed by the core for sure. (yes I know that the same bit may have different meanings, but it's not __PAGE_PSE then). PAT has a bunch of complications that really need to be resolved in the core (eg how to deal with aliases etc etc) don't see any new function accepting random page attributes as __ioremap did. correct -- If you want to reach me at my work email, use [EMAIL PROTECTED] For development, discussion and tips for power savings, visit http://www.lesswatts.org -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: Linux 2.6.25-rc1
On Feb 11, 2008 1:44 AM, Linus Torvalds [EMAIL PROTECTED] wrote: So give it all a good testing. My mm-mystery-crash has now sneaked into mainline: [ 1463.829078] BUG: unable to handle kernel NULL pointer dereference at 0378 [ 1463.832141] IP: [8047af18] ether1394_dg_complete+0x28/0xa0 [ 1463.834616] PGD 7955e067 PUD 7955d067 PMD 0 [ 1463.836148] Oops: [1] SMP [ 1463.836148] CPU 0 [ 1463.836148] Modules linked in: radeon drm w83792d ipv6 tuner tea5767 tda8290 tuner_xc2028 tda9887 tuner_simple mt20xx tea5761 tvaudio msp3400 bttv videodev v4l1_compat ir_common compat_ioctl32 v4l2_common videobuf_dma_sg videobuf_core btcx_risc usbhid tveeprom sg i2c_nforce2 hid pata_amd [ 1463.836148] Pid: 519, comm: khpsbpkt Not tainted 2.6.25-rc1 #1 [ 1463.836148] RIP: 0010:[8047af18] [8047af18] ether1394_dg_complete+0x28/0xa0 [ 1463.836148] RSP: :81007eeb1e80 EFLAGS: 00010282 [ 1463.836148] RAX: RBX: RCX: 0001 [ 1463.836148] RDX: 81004bc62d80 RSI: RDI: 810051873e40 [ 1463.836148] RBP: 81007eeb1eb0 R08: R09: 0001 [ 1463.836148] R10: 0001 R11: 0001 R12: 810051873e40 [ 1463.836148] R13: 81007e1f7200 R14: 0001 R15: 810051873e40 [ 1463.836148] FS: 7f727d6d4700() GS:807e8000() knlGS: [ 1463.836148] CS: 0010 DS: 0018 ES: 0018 CR0: 8005003b [ 1463.836148] CR2: 0378 CR3: 79559000 CR4: 06e0 [ 1463.836148] DR0: DR1: DR2: [ 1463.836148] DR3: DR6: 0ff0 DR7: 0400 [ 1463.836148] Process khpsbpkt (pid: 519, threadinfo 81007eeb, task 81007ee9e000) [ 1463.836148] Stack: 81007eeb1e90 81004bc62b40 810051873e40 [ 1463.836148] 0001 81007eeb1ee0 8047b233 [ 1463.836148] 81007eeb1ec8 81007eeb1ef0 8046c280 81007ff6df10 [ 1463.836148] Call Trace: [ 1463.836148] [8047b233] ether1394_complete_cb+0xb3/0xd0 [ 1463.836148] [8046c280] ? hpsbpkt_thread+0x0/0x140 [ 1463.836148] [8046c33b] hpsbpkt_thread+0xbb/0x140 [ 1463.836148] [8024aead] kthread+0x4d/0x80 [ 1463.836148] [8020c578] child_rip+0xa/0x12 [ 1463.836148] [8020bc8f] ? restore_args+0x0/0x31 [ 1463.836148] [8024ae60] ? kthread+0x0/0x80 [ 1463.836148] [8020c56e] ? child_rip+0x0/0x12 [ 1463.836148] [ 1463.836148] [ 1463.836148] Code: 00 00 00 55 48 89 e5 48 83 ec 30 48 89 5d d8 4c 89 75 f0 89 f3 4c 89 7d f8 4c 89 65 e0 49 89 ff 4c 89 6d e8 4c 8b 2f 49 8b 45 20 4c 8b a0 78 03 00 00 4d 8d b4 24 d0 00 00 00 4c 89 f7 e8 41 f0 [ 1463.836148] RIP [8047af18] ether1394_dg_complete+0x28/0xa0 [ 1463.836148] RSP 81007eeb1e80 [ 1463.836148] CR2: 0378 [ 1463.836208] ohci1394: fw-host0: Waking dma ctx=0 ... processing is probably too slow [ 1463.839250] BUG: unable to handle kernel NULL pointer dereference at [ 1463.841549] IP: [80296d1d] kmem_cache_alloc_node+0x6d/0xa0 [ 1463.842925] PGD 7955e067 PUD 7955d067 PMD 0 [ 1463.846148] Oops: [2] SMP [ 1463.846148] CPU 0 [ 1463.846148] Modules linked in: radeon drm w83792d ipv6 tuner tea5767 tda8290 tuner_xc2028 tda9887 tuner_simple mt20xx tea5761 tvaudio msp3400 bttv videodev v4l1_compat ir_common compat_ioctl32 v4l2_common videobuf_dma_sg videobuf_core btcx_risc usbhid tveeprom sg i2c_nforce2 hid pata_amd [ 1463.846148] Pid: 519, comm: khpsbpkt Tainted: G D 2.6.25-rc1 #1 [ 1463.846148] RIP: 0010:[80296d1d] [80296d1d] kmem_cache_alloc_node+0x6d/0xa0 [ 1463.846148] RSP: :80871ae0 EFLAGS: 00010046 [ 1463.846148] RAX: RBX: 810001006820 RCX: 8052c549 [ 1463.846148] RDX: RSI: RDI: 807fbec0 [ 1463.846148] RBP: 80871b00 R08: 05e0 R09: ffc1 [ 1463.846148] R10: 0001 R11: R12: [ 1463.846148] R13: 0020 R14: 0020 R15: 807fbec0 - here the output from the serial console stopped. Caps lock and Scroll lock where flashing again and as it hit a 'good' spot during the installing of the package this crash resulted in a corrupted ld.so.cache and damage several housekeeping files of the package manager. :-( Last good mm was 2.6.24-rc2-mm1, the next booting mm was 2.6.24-rc3-mm2 and that version had these random crashes. Last good mainline was 2.6.24-rc7 that I was testing with the new iommu patches that where added to 2.6.24-rc3-mm2. I did a partly bisect of 2.6.24-rc6-mm1 that narrow it to this range: 2.6.24-rc6 + mm-patches up to (including) git.nfsd - worked 2.6.24-rc6 + mm-patches up to (including) git.xfs - crashed I think the only added patch between rc2-mm1 and rc3-mm2 in
Re: Linux 2.6.25-rc1 , syntax error near unexpected token `;'
On Sun, Feb 10, 2008 at 04:47:43PM -0900, Mr. James W. Laferriere wrote: Hello All , grabbed using git just moments ago . make V=1 KBUILD_VERBOSE=1 INSTALL_PATH=/boot clean all install modules_install ...snip... make -f scripts/Makefile.clean obj=sound/usb/usx2y make -f scripts/Makefile.clean obj=usr rm -rf .tmp_versions rm -f arch/x86/boot/fdimage arch/x86/boot/image.iso arch/x86/boot/mtools.conf vmlinux System.map .tmp_kallsyms* .tmp_version .tmp_vmlinux* .tmp_System.map rm -f include/config/kernel.release echo 2.6.25-rc1 include/config/kernel.release set -e; ; mkdir -p include/linux/; (echo \#define LINUX_VERSION_CODE 132633; echo '#define KERNEL_VERSION(a,b,c) (((a) 16) + ((b) 8) + (c))';) /usr/src/linux-2.6.25-rc1-git/Makefile include/linux/version.h.tmp; if [ -r include/linux/version.h ] cmp -s include/linux/version.h include/linux/version.h.tmp; then rm -f include/linux/version.h.tmp; else ; mv -f include/linux/version.h.tmp include/linux/version.h; fi /bin/sh: -c: line 0: syntax error near unexpected token `;' /bin/sh: -c: line 0: `set -e; ; mkdir -p include/linux/;(echo \#define LINUX_VERSION_CODE 132633; echo '#define KERNEL_VERSION(a,b,c) (((a) 16) + ((b) 8) + (c))';) /usr/src/linux-2.6.25-rc1-git/Makefile include/linux/version.h.tmp; if [ -r include/linux/version.h ] cmp -s include/linux/version.h include/linux/version.h.tmp; then rm -f include/linux/version.h.tmp; else ; mv -f include/linux/version.h.tmp include/linux/version.h; fi' make: *** [include/linux/version.h] Error 2 Please use following fix. Sam diff --git a/scripts/Kbuild.include b/scripts/Kbuild.include index da3559e..d64e6ba 100644 --- a/scripts/Kbuild.include +++ b/scripts/Kbuild.include @@ -39,10 +39,13 @@ escsq = $(subst $(squote),'\$(squote)',$1) # - If they are equal no change, and no timestamp update # - stdin is piped in from the first prerequisite ($) so one has # to specify a valid file as first prerequisite (often the kbuild file) + chk_filechk = : quiet_chk_filechk = echo ' CHK $@' silent_chk_filechk = : + upd_filechk = : quiet_upd_filechk = echo ' UPD $@' silent_upd_filechk = : + define filechk $(Q)set -e; \ $($(quiet)chk_filechk); \ -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: Linux 2.6.25-rc1
Linus Torvalds wrote: - Lots of cleanups from the x86 merge (making more and more use of common files), but also the big page attribute stuff is in and caused a fair amount of churn, and while most of the issues should have been very obvious and all got fixed, this is definitely one of those things that we want a lot of very wide testing of to make sure nothing regressed. Now that __ioremap isn't available anymore, is there anything in the new pageattr stuff to replace a manual __ioremap with __PAGE_PCD or __PAGE_PSE? or do we have to wait for 2.6.26 to bring PAT support? I don't see any new function accepting random page attributes as __ioremap did. thanks, Brice -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: Linux 2.6.25-rc1 , syntax error near unexpected token `;'
Hello Sam , On Mon, 11 Feb 2008, Sam Ravnborg wrote: On Sun, Feb 10, 2008 at 04:47:43PM -0900, Mr. James W. Laferriere wrote: Hello All , grabbed using git just moments ago . make V=1 KBUILD_VERBOSE=1 INSTALL_PATH=/boot clean all install modules_install ...snip... make -f scripts/Makefile.clean obj=sound/usb/usx2y make -f scripts/Makefile.clean obj=usr rm -rf .tmp_versions rm -f arch/x86/boot/fdimage arch/x86/boot/image.iso arch/x86/boot/mtools.conf vmlinux System.map .tmp_kallsyms* .tmp_version .tmp_vmlinux* .tmp_System.map rm -f include/config/kernel.release echo 2.6.25-rc1 include/config/kernel.release set -e; ; mkdir -p include/linux/; (echo \#define LINUX_VERSION_CODE 132633; echo '#define KERNEL_VERSION(a,b,c) (((a) 16) + ((b) 8) + (c))';) /usr/src/linux-2.6.25-rc1-git/Makefile include/linux/version.h.tmp; if [ -r include/linux/version.h ] cmp -s include/linux/version.h include/linux/version.h.tmp; then rm -f include/linux/version.h.tmp; else ; mv -f include/linux/version.h.tmp include/linux/version.h; fi /bin/sh: -c: line 0: syntax error near unexpected token `;' /bin/sh: -c: line 0: `set -e; ; mkdir -p include/linux/;(echo \#define LINUX_VERSION_CODE 132633; echo '#define KERNEL_VERSION(a,b,c) (((a) 16) + ((b) 8) + (c))';) /usr/src/linux-2.6.25-rc1-git/Makefile include/linux/version.h.tmp; if [ -r include/linux/version.h ] cmp -s include/linux/version.h include/linux/version.h.tmp; then rm -f include/linux/version.h.tmp; else ; mv -f include/linux/version.h.tmp include/linux/version.h; fi' make: *** [include/linux/version.h] Error 2 Please use following fix. Sam diff --git a/scripts/Kbuild.include b/scripts/Kbuild.include index da3559e..d64e6ba 100644 --- a/scripts/Kbuild.include +++ b/scripts/Kbuild.include @@ -39,10 +39,13 @@ escsq = $(subst $(squote),'\$(squote)',$1) # - If they are equal no change, and no timestamp update # - stdin is piped in from the first prerequisite ($) so one has # to specify a valid file as first prerequisite (often the kbuild file) + chk_filechk = : quiet_chk_filechk = echo ' CHK $@' silent_chk_filechk = : + upd_filechk = : quiet_upd_filechk = echo ' UPD $@' silent_upd_filechk = : + define filechk $(Q)set -e; \ $($(quiet)chk_filechk); \ Thank You . that got me past that error . 2.6.25-rc1 is compiling as I write this . Tnx Agn , JimL -- +--+ | James W. Laferriere | SystemTechniques | Give me VMS | | NetworkSystem Engineer | 2133McCullam Ave | Give me Linux | | [EMAIL PROTECTED] | Fairbanks, AK. 99701 | only on AXP | +--+ -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: Linux 2.6.25-rc1
On Monday 11 February 2008, Sam Ravnborg wrote: From 49af821e4b1c07e756cbc2e389eba9d885912602 Mon Sep 17 00:00:00 2001 From: Sam Ravnborg [EMAIL PROTECTED] Date: Mon, 11 Feb 2008 14:26:26 +0100 Subject: [PATCH] kbuild: fix make V=1 When make -s support were added to filechk to combination created with make V=1 were not covered. Fix it by explicitly cover this case too. Signed-off-by: Sam Ravnborg [EMAIL PROTECTED] Cc: Mike Frysinger [EMAIL PROTECTED] erp, i wondered if there was another case i was missing ... you'll also need the attached fixed ... --- When make -s support was added to compile.h, it broke make V=1. Signed-off-by: Mike Frysinger [EMAIL PROTECTED] --- diff --git a/init/Makefile b/init/Makefile index c5f157c..781f102 100644 --- a/init/Makefile +++ b/init/Makefile @@ -26,7 +26,7 @@ $(obj)/version.o: include/linux/compile.h # so we regenerate it always. # mkcompile_h will make sure to only update the # actual file if its content has changed. - + chk_compile.h = : quiet_chk_compile.h = echo ' CHK $@' silent_chk_compile.h = : include/linux/compile.h: FORCE signature.asc Description: This is a digitally signed message part.
Re: Linux 2.6.25-rc1
Hi Linus. A kbuild bug sneaked in. Please pull from: ssh://master.kernel.org/pub/scm/linux/kernel/git/sam/kbuild.git to fix the following bug. Sam From 49af821e4b1c07e756cbc2e389eba9d885912602 Mon Sep 17 00:00:00 2001 From: Sam Ravnborg [EMAIL PROTECTED] Date: Mon, 11 Feb 2008 14:26:26 +0100 Subject: [PATCH] kbuild: fix make V=1 When make -s support were added to filechk to combination created with make V=1 were not covered. Fix it by explicitly cover this case too. Signed-off-by: Sam Ravnborg [EMAIL PROTECTED] Cc: Mike Frysinger [EMAIL PROTECTED] --- scripts/Kbuild.include |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/scripts/Kbuild.include b/scripts/Kbuild.include index da3559e..d64e6ba 100644 --- a/scripts/Kbuild.include +++ b/scripts/Kbuild.include @@ -39,10 +39,13 @@ escsq = $(subst $(squote),'\$(squote)',$1) # - If they are equal no change, and no timestamp update # - stdin is piped in from the first prerequisite ($) so one has # to specify a valid file as first prerequisite (often the kbuild file) + chk_filechk = : quiet_chk_filechk = echo ' CHK $@' silent_chk_filechk = : + upd_filechk = : quiet_upd_filechk = echo ' UPD $@' silent_upd_filechk = : + define filechk $(Q)set -e; \ $($(quiet)chk_filechk); \ -- 1.5.4.rc3.14.g44397 -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[patch] Re: Linux 2.6.25-rc1 , syntax error near unexpected token `;'
set -e; ; mkdir -p include/linux/; (echo \#define LINUX_VERSION_CODE http://mid.gmane.org/[EMAIL PROTECTED] _ -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: Linux 2.6.25-rc1 , syntax error near unexpected token `;'
On Feb 10, 2008 5:47 PM, Mr. James W. Laferriere <[EMAIL PROTECTED]> wrote: > Hello All , grabbed using git just moments ago . > > make V=1 KBUILD_VERBOSE=1 INSTALL_PATH=/boot clean all install modules_install > > ...snip... > make -f scripts/Makefile.clean obj=sound/usb/usx2y > make -f scripts/Makefile.clean obj=usr >rm -rf .tmp_versions >rm -f arch/x86/boot/fdimage arch/x86/boot/image.iso > arch/x86/boot/mtools.conf > vmlinux System.map .tmp_kallsyms* .tmp_version .tmp_vmlinux* .tmp_System.map > rm -f include/config/kernel.release > echo 2.6.25-rc1 > include/config/kernel.release > set -e; ; mkdir -p include/linux/; (echo \#define LINUX_VERSION_CODE > 132633; echo '#define KERNEL_VERSION(a,b,c) (((a) << 16) + ((b) << 8) + > (c))';) > < /usr/src/linux-2.6.25-rc1-git/Makefile > include/linux/version.h.tmp; if [ > -r > include/linux/version.h ] && cmp -s include/linux/version.h > include/linux/version.h.tmp; then rm -f include/linux/version.h.tmp; else ; mv > -f include/linux/version.h.tmp include/linux/version.h; fi > /bin/sh: -c: line 0: syntax error near unexpected token `;' > /bin/sh: -c: line 0: `set -e; ; mkdir -p include/linux/;(echo \#define > LINUX_VERSION_CODE 132633; echo '#define KERNEL_VERSION(a,b,c) (((a) << 16) + > ((b) << 8) + (c))';) < /usr/src/linux-2.6.25-rc1-git/Makefile > > include/linux/version.h.tmp; if [ -r include/linux/version.h ] && cmp -s > include/linux/version.h include/linux/version.h.tmp; then rm -f > include/linux/version.h.tmp; else ; mv -f include/linux/version.h.tmp > include/linux/version.h; fi' > make: *** [include/linux/version.h] Error 2 > > > # scripts/ver_linux > If some fields are empty or look unusual you may have an old version. > Compare to the current minimal requirements in Documentation/Changes. > > Linux filesrv2 2.6.23-rc9 #1 SMP Wed Oct 3 02:12:33 UTC 2007 i686 pentium4 > i386 GNU/Linux > > Gnu C 3.4.6 > Gnu make 3.81 > binutils 2.15.92.0.2 > util-linux 2.12r > mount 2.12r > module-init-tools 3.2.2 > e2fsprogs 1.38 > jfsutils 1.1.11 > reiserfsprogs 3.6.19 > xfsprogs 2.8.10 > pcmciautils014 > pcmcia-cs 3.2.8 > quota-tools3.13. > PPP2.4.4 > Linux C Library2.3.6 > Dynamic linker (ldd) 2.3.6 > Linux C++ Library 6.0.3 > Procps 3.2.7 > Net-tools 1.60 > Kbd1.12 > oprofile 0.9.1 > Sh-utils 5.97 > udev 097 > Modules Loaded > > -- Please send your .config as well so someone can try to reproduce this. And have you done a make mrproper first before trying to compile? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: Linux 2.6.25-rc1
On Sunday 10 February 2008, Linus Torvalds wrote: >Ok, it's a bloody large -rc (as was 24-rc1, for that matter), probably >because the 2.6.24 release cycle dragged out, so people had a lot of >things pending. > >The full diff is something like 11MB and 1.4M lines of diffs, with the >bulk of the stuff being in architecture updates and drivers. > >Just to have some fun, I did trivial statistics, and of the 1.4M lines of >diffs, about 38% - 530k lines - were in architecture files (400k+ lines of >diffs in arch/, 100k+ lines of diffs in include/asm-*), and another big >chunk is in drivers (including sound) at about 44% - 610k lines - of >changes. > >The rest comes in much smaller, but still noticeable is networking (8% - >110k lines), with filesystems at 4%, and documentation at about 2%. The >remaining crumbles being spread out mostly over block layer, crypto, >kernel core, and security layer updates (ie SElinux and smack). > >[ Just to make it more obvious how driver and architecture-dominated the > kernel changelogs are: just the network driver changes were 200kloc, and > even just infiniband - which came way behind not just networking > drivers, but also DVB, SCSI, char and ide - generated more lines of code > changed than the "core" kernel code under the kernel/ subdirectory. > > And that's despite the fact that the "core" code was actually under a > fairly active merge cycle, with a lot of namespace- and scheduling- > related stuff. ] > >Now, some of that is files moving about and other reorganizations (SH and >to a lesser degree sparc starting to merge 32-bit and 64-bit >architectures), but most of it really is just the normal flood of changes >and new driver or platform support. > >The full shortlog is half a meg in size (and the diffstat is even bigger), >so I won't be including that here, but some things that may be worth >pointing out not because they are big in line sizes, but because they have >potential to be noticed by more people: > > - the intel graphics driver is starting to do suspend/resume natively > (ie even without X support), which is a welcome sign of the times and > may help some people. It helped on my laptop. > > - Other suspend/resume changes in device access ordering etc, and the > usual ACPI changes means that we really want reports from people about > this all even if you don't have intel graphics. > > - Lots of cleanups from the x86 merge (making more and more use of common > files), but also the big page attribute stuff is in and caused a fair > amount of churn, and while most of the issues should have been very > obvious and all got fixed, this is definitely one of those things that > we want a lot of very wide testing of to make sure nothing regressed. > > - fair number of changes to things like the legacy IDE drivers too, and a > totally new driver for the very common PCIE version of the Intel e1000 > network card etc. > > - .. and I've probably totally forgotten about tons of other stuff I > should have mentioned, but the point is that not only do we have lots > of new core, we do have a fair amout of changes to basic stuff that can > actually affect perfectly bog-standard hardware setups. > >So give it all a good testing. I just did, and while non-x seems stable, the latest nvidia driver, about a week old, will not build a valid kernel module, so X bails out with a failed to load it, even though its sitting in /lib/modules/`uname -r`/kernel/drivers/video with exactly the same length as the one built for 2.6.24. The nvidia-installer log recommends doing a 'make prepare' which I did, but nvidia still errors out during the module build. So obviously I am back to 2.6.24, and my next stop is the nvidia web site to see if they have a fix. Other than that, it feels good. > Linus >-- >To unsubscribe from this list: send the line "unsubscribe linux-kernel" in >the body of a message to [EMAIL PROTECTED] >More majordomo info at http://vger.kernel.org/majordomo-info.html >Please read the FAQ at http://www.tux.org/lkml/ -- Cheers, Gene "There are four boxes to be used in defense of liberty: soap, ballot, jury, and ammo. Please use in that order." -Ed Howdershelt (Author) Idleness is the holiday of fools. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: Linux 2.6.25-rc1 , syntax error near unexpected token `;'
Hello All , grabbed using git just moments ago . make V=1 KBUILD_VERBOSE=1 INSTALL_PATH=/boot clean all install modules_install ...snip... make -f scripts/Makefile.clean obj=sound/usb/usx2y make -f scripts/Makefile.clean obj=usr rm -rf .tmp_versions rm -f arch/x86/boot/fdimage arch/x86/boot/image.iso arch/x86/boot/mtools.conf vmlinux System.map .tmp_kallsyms* .tmp_version .tmp_vmlinux* .tmp_System.map rm -f include/config/kernel.release echo 2.6.25-rc1 > include/config/kernel.release set -e; ; mkdir -p include/linux/; (echo \#define LINUX_VERSION_CODE 132633; echo '#define KERNEL_VERSION(a,b,c) (((a) << 16) + ((b) << 8) + (c))';) < /usr/src/linux-2.6.25-rc1-git/Makefile > include/linux/version.h.tmp; if [ -r include/linux/version.h ] && cmp -s include/linux/version.h include/linux/version.h.tmp; then rm -f include/linux/version.h.tmp; else ; mv -f include/linux/version.h.tmp include/linux/version.h; fi /bin/sh: -c: line 0: syntax error near unexpected token `;' /bin/sh: -c: line 0: `set -e; ; mkdir -p include/linux/;(echo \#define LINUX_VERSION_CODE 132633; echo '#define KERNEL_VERSION(a,b,c) (((a) << 16) + ((b) << 8) + (c))';) < /usr/src/linux-2.6.25-rc1-git/Makefile > include/linux/version.h.tmp; if [ -r include/linux/version.h ] && cmp -s include/linux/version.h include/linux/version.h.tmp; then rm -f include/linux/version.h.tmp; else ; mv -f include/linux/version.h.tmp include/linux/version.h; fi' make: *** [include/linux/version.h] Error 2 # scripts/ver_linux If some fields are empty or look unusual you may have an old version. Compare to the current minimal requirements in Documentation/Changes. Linux filesrv2 2.6.23-rc9 #1 SMP Wed Oct 3 02:12:33 UTC 2007 i686 pentium4 i386 GNU/Linux Gnu C 3.4.6 Gnu make 3.81 binutils 2.15.92.0.2 util-linux 2.12r mount 2.12r module-init-tools 3.2.2 e2fsprogs 1.38 jfsutils 1.1.11 reiserfsprogs 3.6.19 xfsprogs 2.8.10 pcmciautils014 pcmcia-cs 3.2.8 quota-tools3.13. PPP2.4.4 Linux C Library2.3.6 Dynamic linker (ldd) 2.3.6 Linux C++ Library 6.0.3 Procps 3.2.7 Net-tools 1.60 Kbd1.12 oprofile 0.9.1 Sh-utils 5.97 udev 097 Modules Loaded -- +--+ | James W. Laferriere | SystemTechniques | Give me VMS | | Network Engineer | 2133McCullam Ave | Give me Linux | | [EMAIL PROTECTED] | Fairbanks, AK. 99701 | only on AXP | +--+ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Linux 2.6.25-rc1
Ok, it's a bloody large -rc (as was 24-rc1, for that matter), probably because the 2.6.24 release cycle dragged out, so people had a lot of things pending. The full diff is something like 11MB and 1.4M lines of diffs, with the bulk of the stuff being in architecture updates and drivers. Just to have some fun, I did trivial statistics, and of the 1.4M lines of diffs, about 38% - 530k lines - were in architecture files (400k+ lines of diffs in arch/, 100k+ lines of diffs in include/asm-*), and another big chunk is in drivers (including sound) at about 44% - 610k lines - of changes. The rest comes in much smaller, but still noticeable is networking (8% - 110k lines), with filesystems at 4%, and documentation at about 2%. The remaining crumbles being spread out mostly over block layer, crypto, kernel core, and security layer updates (ie SElinux and smack). [ Just to make it more obvious how driver and architecture-dominated the kernel changelogs are: just the network driver changes were 200kloc, and even just infiniband - which came way behind not just networking drivers, but also DVB, SCSI, char and ide - generated more lines of code changed than the "core" kernel code under the kernel/ subdirectory. And that's despite the fact that the "core" code was actually under a fairly active merge cycle, with a lot of namespace- and scheduling- related stuff. ] Now, some of that is files moving about and other reorganizations (SH and to a lesser degree sparc starting to merge 32-bit and 64-bit architectures), but most of it really is just the normal flood of changes and new driver or platform support. The full shortlog is half a meg in size (and the diffstat is even bigger), so I won't be including that here, but some things that may be worth pointing out not because they are big in line sizes, but because they have potential to be noticed by more people: - the intel graphics driver is starting to do suspend/resume natively (ie even without X support), which is a welcome sign of the times and may help some people. It helped on my laptop. - Other suspend/resume changes in device access ordering etc, and the usual ACPI changes means that we really want reports from people about this all even if you don't have intel graphics. - Lots of cleanups from the x86 merge (making more and more use of common files), but also the big page attribute stuff is in and caused a fair amount of churn, and while most of the issues should have been very obvious and all got fixed, this is definitely one of those things that we want a lot of very wide testing of to make sure nothing regressed. - fair number of changes to things like the legacy IDE drivers too, and a totally new driver for the very common PCIE version of the Intel e1000 network card etc. - .. and I've probably totally forgotten about tons of other stuff I should have mentioned, but the point is that not only do we have lots of new core, we do have a fair amout of changes to basic stuff that can actually affect perfectly bog-standard hardware setups. So give it all a good testing. Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Linux 2.6.25-rc1
Ok, it's a bloody large -rc (as was 24-rc1, for that matter), probably because the 2.6.24 release cycle dragged out, so people had a lot of things pending. The full diff is something like 11MB and 1.4M lines of diffs, with the bulk of the stuff being in architecture updates and drivers. Just to have some fun, I did trivial statistics, and of the 1.4M lines of diffs, about 38% - 530k lines - were in architecture files (400k+ lines of diffs in arch/, 100k+ lines of diffs in include/asm-*), and another big chunk is in drivers (including sound) at about 44% - 610k lines - of changes. The rest comes in much smaller, but still noticeable is networking (8% - 110k lines), with filesystems at 4%, and documentation at about 2%. The remaining crumbles being spread out mostly over block layer, crypto, kernel core, and security layer updates (ie SElinux and smack). [ Just to make it more obvious how driver and architecture-dominated the kernel changelogs are: just the network driver changes were 200kloc, and even just infiniband - which came way behind not just networking drivers, but also DVB, SCSI, char and ide - generated more lines of code changed than the core kernel code under the kernel/ subdirectory. And that's despite the fact that the core code was actually under a fairly active merge cycle, with a lot of namespace- and scheduling- related stuff. ] Now, some of that is files moving about and other reorganizations (SH and to a lesser degree sparc starting to merge 32-bit and 64-bit architectures), but most of it really is just the normal flood of changes and new driver or platform support. The full shortlog is half a meg in size (and the diffstat is even bigger), so I won't be including that here, but some things that may be worth pointing out not because they are big in line sizes, but because they have potential to be noticed by more people: - the intel graphics driver is starting to do suspend/resume natively (ie even without X support), which is a welcome sign of the times and may help some people. It helped on my laptop. - Other suspend/resume changes in device access ordering etc, and the usual ACPI changes means that we really want reports from people about this all even if you don't have intel graphics. - Lots of cleanups from the x86 merge (making more and more use of common files), but also the big page attribute stuff is in and caused a fair amount of churn, and while most of the issues should have been very obvious and all got fixed, this is definitely one of those things that we want a lot of very wide testing of to make sure nothing regressed. - fair number of changes to things like the legacy IDE drivers too, and a totally new driver for the very common PCIE version of the Intel e1000 network card etc. - .. and I've probably totally forgotten about tons of other stuff I should have mentioned, but the point is that not only do we have lots of new core, we do have a fair amout of changes to basic stuff that can actually affect perfectly bog-standard hardware setups. So give it all a good testing. Linus -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: Linux 2.6.25-rc1 , syntax error near unexpected token `;'
Hello All , grabbed using git just moments ago . make V=1 KBUILD_VERBOSE=1 INSTALL_PATH=/boot clean all install modules_install ...snip... make -f scripts/Makefile.clean obj=sound/usb/usx2y make -f scripts/Makefile.clean obj=usr rm -rf .tmp_versions rm -f arch/x86/boot/fdimage arch/x86/boot/image.iso arch/x86/boot/mtools.conf vmlinux System.map .tmp_kallsyms* .tmp_version .tmp_vmlinux* .tmp_System.map rm -f include/config/kernel.release echo 2.6.25-rc1 include/config/kernel.release set -e; ; mkdir -p include/linux/; (echo \#define LINUX_VERSION_CODE 132633; echo '#define KERNEL_VERSION(a,b,c) (((a) 16) + ((b) 8) + (c))';) /usr/src/linux-2.6.25-rc1-git/Makefile include/linux/version.h.tmp; if [ -r include/linux/version.h ] cmp -s include/linux/version.h include/linux/version.h.tmp; then rm -f include/linux/version.h.tmp; else ; mv -f include/linux/version.h.tmp include/linux/version.h; fi /bin/sh: -c: line 0: syntax error near unexpected token `;' /bin/sh: -c: line 0: `set -e; ; mkdir -p include/linux/;(echo \#define LINUX_VERSION_CODE 132633; echo '#define KERNEL_VERSION(a,b,c) (((a) 16) + ((b) 8) + (c))';) /usr/src/linux-2.6.25-rc1-git/Makefile include/linux/version.h.tmp; if [ -r include/linux/version.h ] cmp -s include/linux/version.h include/linux/version.h.tmp; then rm -f include/linux/version.h.tmp; else ; mv -f include/linux/version.h.tmp include/linux/version.h; fi' make: *** [include/linux/version.h] Error 2 # scripts/ver_linux If some fields are empty or look unusual you may have an old version. Compare to the current minimal requirements in Documentation/Changes. Linux filesrv2 2.6.23-rc9 #1 SMP Wed Oct 3 02:12:33 UTC 2007 i686 pentium4 i386 GNU/Linux Gnu C 3.4.6 Gnu make 3.81 binutils 2.15.92.0.2 util-linux 2.12r mount 2.12r module-init-tools 3.2.2 e2fsprogs 1.38 jfsutils 1.1.11 reiserfsprogs 3.6.19 xfsprogs 2.8.10 pcmciautils014 pcmcia-cs 3.2.8 quota-tools3.13. PPP2.4.4 Linux C Library2.3.6 Dynamic linker (ldd) 2.3.6 Linux C++ Library 6.0.3 Procps 3.2.7 Net-tools 1.60 Kbd1.12 oprofile 0.9.1 Sh-utils 5.97 udev 097 Modules Loaded -- +--+ | James W. Laferriere | SystemTechniques | Give me VMS | | NetworkSystem Engineer | 2133McCullam Ave | Give me Linux | | [EMAIL PROTECTED] | Fairbanks, AK. 99701 | only on AXP | +--+ -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: Linux 2.6.25-rc1
On Sunday 10 February 2008, Linus Torvalds wrote: Ok, it's a bloody large -rc (as was 24-rc1, for that matter), probably because the 2.6.24 release cycle dragged out, so people had a lot of things pending. The full diff is something like 11MB and 1.4M lines of diffs, with the bulk of the stuff being in architecture updates and drivers. Just to have some fun, I did trivial statistics, and of the 1.4M lines of diffs, about 38% - 530k lines - were in architecture files (400k+ lines of diffs in arch/, 100k+ lines of diffs in include/asm-*), and another big chunk is in drivers (including sound) at about 44% - 610k lines - of changes. The rest comes in much smaller, but still noticeable is networking (8% - 110k lines), with filesystems at 4%, and documentation at about 2%. The remaining crumbles being spread out mostly over block layer, crypto, kernel core, and security layer updates (ie SElinux and smack). [ Just to make it more obvious how driver and architecture-dominated the kernel changelogs are: just the network driver changes were 200kloc, and even just infiniband - which came way behind not just networking drivers, but also DVB, SCSI, char and ide - generated more lines of code changed than the core kernel code under the kernel/ subdirectory. And that's despite the fact that the core code was actually under a fairly active merge cycle, with a lot of namespace- and scheduling- related stuff. ] Now, some of that is files moving about and other reorganizations (SH and to a lesser degree sparc starting to merge 32-bit and 64-bit architectures), but most of it really is just the normal flood of changes and new driver or platform support. The full shortlog is half a meg in size (and the diffstat is even bigger), so I won't be including that here, but some things that may be worth pointing out not because they are big in line sizes, but because they have potential to be noticed by more people: - the intel graphics driver is starting to do suspend/resume natively (ie even without X support), which is a welcome sign of the times and may help some people. It helped on my laptop. - Other suspend/resume changes in device access ordering etc, and the usual ACPI changes means that we really want reports from people about this all even if you don't have intel graphics. - Lots of cleanups from the x86 merge (making more and more use of common files), but also the big page attribute stuff is in and caused a fair amount of churn, and while most of the issues should have been very obvious and all got fixed, this is definitely one of those things that we want a lot of very wide testing of to make sure nothing regressed. - fair number of changes to things like the legacy IDE drivers too, and a totally new driver for the very common PCIE version of the Intel e1000 network card etc. - .. and I've probably totally forgotten about tons of other stuff I should have mentioned, but the point is that not only do we have lots of new core, we do have a fair amout of changes to basic stuff that can actually affect perfectly bog-standard hardware setups. So give it all a good testing. I just did, and while non-x seems stable, the latest nvidia driver, about a week old, will not build a valid kernel module, so X bails out with a failed to load it, even though its sitting in /lib/modules/`uname -r`/kernel/drivers/video with exactly the same length as the one built for 2.6.24. The nvidia-installer log recommends doing a 'make prepare' which I did, but nvidia still errors out during the module build. So obviously I am back to 2.6.24, and my next stop is the nvidia web site to see if they have a fix. Other than that, it feels good. Linus -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ -- Cheers, Gene There are four boxes to be used in defense of liberty: soap, ballot, jury, and ammo. Please use in that order. -Ed Howdershelt (Author) Idleness is the holiday of fools. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: Linux 2.6.25-rc1 , syntax error near unexpected token `;'
On Feb 10, 2008 5:47 PM, Mr. James W. Laferriere [EMAIL PROTECTED] wrote: Hello All , grabbed using git just moments ago . make V=1 KBUILD_VERBOSE=1 INSTALL_PATH=/boot clean all install modules_install ...snip... make -f scripts/Makefile.clean obj=sound/usb/usx2y make -f scripts/Makefile.clean obj=usr rm -rf .tmp_versions rm -f arch/x86/boot/fdimage arch/x86/boot/image.iso arch/x86/boot/mtools.conf vmlinux System.map .tmp_kallsyms* .tmp_version .tmp_vmlinux* .tmp_System.map rm -f include/config/kernel.release echo 2.6.25-rc1 include/config/kernel.release set -e; ; mkdir -p include/linux/; (echo \#define LINUX_VERSION_CODE 132633; echo '#define KERNEL_VERSION(a,b,c) (((a) 16) + ((b) 8) + (c))';) /usr/src/linux-2.6.25-rc1-git/Makefile include/linux/version.h.tmp; if [ -r include/linux/version.h ] cmp -s include/linux/version.h include/linux/version.h.tmp; then rm -f include/linux/version.h.tmp; else ; mv -f include/linux/version.h.tmp include/linux/version.h; fi /bin/sh: -c: line 0: syntax error near unexpected token `;' /bin/sh: -c: line 0: `set -e; ; mkdir -p include/linux/;(echo \#define LINUX_VERSION_CODE 132633; echo '#define KERNEL_VERSION(a,b,c) (((a) 16) + ((b) 8) + (c))';) /usr/src/linux-2.6.25-rc1-git/Makefile include/linux/version.h.tmp; if [ -r include/linux/version.h ] cmp -s include/linux/version.h include/linux/version.h.tmp; then rm -f include/linux/version.h.tmp; else ; mv -f include/linux/version.h.tmp include/linux/version.h; fi' make: *** [include/linux/version.h] Error 2 # scripts/ver_linux If some fields are empty or look unusual you may have an old version. Compare to the current minimal requirements in Documentation/Changes. Linux filesrv2 2.6.23-rc9 #1 SMP Wed Oct 3 02:12:33 UTC 2007 i686 pentium4 i386 GNU/Linux Gnu C 3.4.6 Gnu make 3.81 binutils 2.15.92.0.2 util-linux 2.12r mount 2.12r module-init-tools 3.2.2 e2fsprogs 1.38 jfsutils 1.1.11 reiserfsprogs 3.6.19 xfsprogs 2.8.10 pcmciautils014 pcmcia-cs 3.2.8 quota-tools3.13. PPP2.4.4 Linux C Library2.3.6 Dynamic linker (ldd) 2.3.6 Linux C++ Library 6.0.3 Procps 3.2.7 Net-tools 1.60 Kbd1.12 oprofile 0.9.1 Sh-utils 5.97 udev 097 Modules Loaded -- Please send your .config as well so someone can try to reproduce this. And have you done a make mrproper first before trying to compile? -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
