Re: Stable backport request, Was: Re: [regression] external HDD in USB3 enclosure cannot be dynamically removed (Re: Linux 3.7.5)
On Tue, Mar 05, 2013 at 02:10:50PM -0800, Sarah Sharp wrote: > On Fri, Mar 01, 2013 at 08:48:39AM -0800, Greg KH wrote: > > On Wed, Feb 13, 2013 at 02:12:50PM -0800, Sarah Sharp wrote: > > > On Wed, Feb 13, 2013 at 01:31:29PM -0800, Greg KH wrote: > > > > On Wed, Feb 13, 2013 at 01:08:46PM -0800, Sarah Sharp wrote: > > > > > On Wed, Feb 13, 2013 at 09:04:13PM +0100, Matthias Schniedermeyer > > > > > wrote: > > > > > > On 13.02.2013 11:33, Sarah Sharp wrote: > > > > > Greg, > > > > > > > > > > How do you want to handle this? The above four patches should go into > > > > > 3.8 and stable, but they're not currently in Linus' tree and it's > > > > > probably too late in the cycle to merge them this week. Should we > > > > > just > > > > > wait until 3.9 is out and put the patches into the stable trees then? > > > > > > > > > My email shows that the bad commit > > > > > f7965c0846d74b270e246c1470ca955d5078eb07 has been added to the 3.2, > > > > > 3.4, > > > > > and 3.7 stable trees, as well as Canonical's 3.7 stable tree. I'm > > > > > also > > > > > fine with just reverting that commit from 3.8 and stable. > > > > > > > > It's probably easier at this point in time to just revert that commit, > > > > leave the stable kernels alone, and then everything will be fixed in > > > > 3.9. When the commits go into Linus's tree, we can backport everything > > > > to the stable releases (including 3.8.1) at that point. > > > > > > > > As long as someone remembers to send the needed information to > > > > sta...@vger.kernel.org, I know I'll forget :) > > > > > > > > Sound ok? > > > > > > Yep, sounds fine. I'll attempt to remember to send email to stable once > > > 3.9 is out. > > > > Did this happen yet? > > Nope. Here's the upstream commit IDs of the patches that need to be > backported to stable. Let me know if you need them in patch form: > > d3b9d7a9051d7024a93c76a84b2f84b3b66ad6d5 USB: Fix connected device switch to > Inactive state. As this first patch doesn't apply to the 3.8-stable tree, and I can't figure out how to fix it to work properly, I am going to need these in patch forme, sorry. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Stable backport request, Was: Re: [regression] external HDD in USB3 enclosure cannot be dynamically removed (Re: Linux 3.7.5)
On Fri, Mar 01, 2013 at 08:48:39AM -0800, Greg KH wrote: > On Wed, Feb 13, 2013 at 02:12:50PM -0800, Sarah Sharp wrote: > > On Wed, Feb 13, 2013 at 01:31:29PM -0800, Greg KH wrote: > > > On Wed, Feb 13, 2013 at 01:08:46PM -0800, Sarah Sharp wrote: > > > > On Wed, Feb 13, 2013 at 09:04:13PM +0100, Matthias Schniedermeyer wrote: > > > > > On 13.02.2013 11:33, Sarah Sharp wrote: > > > > Greg, > > > > > > > > How do you want to handle this? The above four patches should go into > > > > 3.8 and stable, but they're not currently in Linus' tree and it's > > > > probably too late in the cycle to merge them this week. Should we just > > > > wait until 3.9 is out and put the patches into the stable trees then? > > > > > > > My email shows that the bad commit > > > > f7965c0846d74b270e246c1470ca955d5078eb07 has been added to the 3.2, 3.4, > > > > and 3.7 stable trees, as well as Canonical's 3.7 stable tree. I'm also > > > > fine with just reverting that commit from 3.8 and stable. > > > > > > It's probably easier at this point in time to just revert that commit, > > > leave the stable kernels alone, and then everything will be fixed in > > > 3.9. When the commits go into Linus's tree, we can backport everything > > > to the stable releases (including 3.8.1) at that point. > > > > > > As long as someone remembers to send the needed information to > > > sta...@vger.kernel.org, I know I'll forget :) > > > > > > Sound ok? > > > > Yep, sounds fine. I'll attempt to remember to send email to stable once > > 3.9 is out. > > Did this happen yet? Nope. Here's the upstream commit IDs of the patches that need to be backported to stable. Let me know if you need them in patch form: d3b9d7a9051d7024a93c76a84b2f84b3b66ad6d5 USB: Fix connected device switch to Inactive state. a24a6078754f28528bc91e7e7b3e6ae86bd936d8 USB: Rip out recursive call on warm port reset. 2d4fa940f99663c82ba55b2244638833b388e4e2 USB: Prepare for refactoring by adding extra udev checks. 0fe51aa5eee51db7c7ecd201d42a977ad79c58b6 USB: Don't use EHCI port sempahore for USB 3.0 hubs. Sarah Sharp -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Stable backport request, Was: Re: [regression] external HDD in USB3 enclosure cannot be dynamically removed (Re: Linux 3.7.5)
On Fri, Mar 01, 2013 at 08:48:39AM -0800, Greg KH wrote: On Wed, Feb 13, 2013 at 02:12:50PM -0800, Sarah Sharp wrote: On Wed, Feb 13, 2013 at 01:31:29PM -0800, Greg KH wrote: On Wed, Feb 13, 2013 at 01:08:46PM -0800, Sarah Sharp wrote: On Wed, Feb 13, 2013 at 09:04:13PM +0100, Matthias Schniedermeyer wrote: On 13.02.2013 11:33, Sarah Sharp wrote: Greg, How do you want to handle this? The above four patches should go into 3.8 and stable, but they're not currently in Linus' tree and it's probably too late in the cycle to merge them this week. Should we just wait until 3.9 is out and put the patches into the stable trees then? My email shows that the bad commit f7965c0846d74b270e246c1470ca955d5078eb07 has been added to the 3.2, 3.4, and 3.7 stable trees, as well as Canonical's 3.7 stable tree. I'm also fine with just reverting that commit from 3.8 and stable. It's probably easier at this point in time to just revert that commit, leave the stable kernels alone, and then everything will be fixed in 3.9. When the commits go into Linus's tree, we can backport everything to the stable releases (including 3.8.1) at that point. As long as someone remembers to send the needed information to sta...@vger.kernel.org, I know I'll forget :) Sound ok? Yep, sounds fine. I'll attempt to remember to send email to stable once 3.9 is out. Did this happen yet? Nope. Here's the upstream commit IDs of the patches that need to be backported to stable. Let me know if you need them in patch form: d3b9d7a9051d7024a93c76a84b2f84b3b66ad6d5 USB: Fix connected device switch to Inactive state. a24a6078754f28528bc91e7e7b3e6ae86bd936d8 USB: Rip out recursive call on warm port reset. 2d4fa940f99663c82ba55b2244638833b388e4e2 USB: Prepare for refactoring by adding extra udev checks. 0fe51aa5eee51db7c7ecd201d42a977ad79c58b6 USB: Don't use EHCI port sempahore for USB 3.0 hubs. Sarah Sharp -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: Stable backport request, Was: Re: [regression] external HDD in USB3 enclosure cannot be dynamically removed (Re: Linux 3.7.5)
On Tue, Mar 05, 2013 at 02:10:50PM -0800, Sarah Sharp wrote: On Fri, Mar 01, 2013 at 08:48:39AM -0800, Greg KH wrote: On Wed, Feb 13, 2013 at 02:12:50PM -0800, Sarah Sharp wrote: On Wed, Feb 13, 2013 at 01:31:29PM -0800, Greg KH wrote: On Wed, Feb 13, 2013 at 01:08:46PM -0800, Sarah Sharp wrote: On Wed, Feb 13, 2013 at 09:04:13PM +0100, Matthias Schniedermeyer wrote: On 13.02.2013 11:33, Sarah Sharp wrote: Greg, How do you want to handle this? The above four patches should go into 3.8 and stable, but they're not currently in Linus' tree and it's probably too late in the cycle to merge them this week. Should we just wait until 3.9 is out and put the patches into the stable trees then? My email shows that the bad commit f7965c0846d74b270e246c1470ca955d5078eb07 has been added to the 3.2, 3.4, and 3.7 stable trees, as well as Canonical's 3.7 stable tree. I'm also fine with just reverting that commit from 3.8 and stable. It's probably easier at this point in time to just revert that commit, leave the stable kernels alone, and then everything will be fixed in 3.9. When the commits go into Linus's tree, we can backport everything to the stable releases (including 3.8.1) at that point. As long as someone remembers to send the needed information to sta...@vger.kernel.org, I know I'll forget :) Sound ok? Yep, sounds fine. I'll attempt to remember to send email to stable once 3.9 is out. Did this happen yet? Nope. Here's the upstream commit IDs of the patches that need to be backported to stable. Let me know if you need them in patch form: d3b9d7a9051d7024a93c76a84b2f84b3b66ad6d5 USB: Fix connected device switch to Inactive state. As this first patch doesn't apply to the 3.8-stable tree, and I can't figure out how to fix it to work properly, I am going to need these in patch forme, sorry. thanks, greg k-h -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [regression] external HDD in USB3 enclosure cannot be dynamically removed (Re: Linux 3.7.5)
On Wed, Feb 13, 2013 at 02:12:50PM -0800, Sarah Sharp wrote: > On Wed, Feb 13, 2013 at 01:31:29PM -0800, Greg KH wrote: > > On Wed, Feb 13, 2013 at 01:08:46PM -0800, Sarah Sharp wrote: > > > On Wed, Feb 13, 2013 at 09:04:13PM +0100, Matthias Schniedermeyer wrote: > > > > On 13.02.2013 11:33, Sarah Sharp wrote: > > > > > On Wed, Feb 13, 2013 at 06:16:56PM +0100, Matthias Schniedermeyer > > > > > wrote: > > > > > > On 13.02.2013 09:28, Holger Hoffstätte wrote: > > > > > > > On 12.02.2013 21:42, Sarah Sharp wrote: > > > > > > > > [..] > > > > > > > > There was a further set of patches queued for 3.9 to deal with > > > > > > > > connected > > > > > > > > devices going to the Inactive state, but they looked like they > > > > > > > > were too > > > > > > > > big for stable: > > > > > > > > > > > > > > > > d3b9d7a USB: Fix connected device switch to Inactive state. > > > > > > > > a24a607 USB: Rip out recursive call on warm port reset. > > > > > > > > 2d4fa94 USB: Prepare for refactoring by adding extra udev > > > > > > > > checks. > > > > > > > > 0fe51aa USB: Don't use EHCI port sempahore for USB 3.0 hubs. > > > > > > > > > > Holger and Matthias, can you double check that cherry picking just > > > > > those > > > > > four patches on top of 3.7.7 or 3.8 works as well? > > > > > > > > 3.7.7 + those 4 patches workes for me. > > > > > > > > As i'm not very firm in git i generated separate diffs for each commit > > > > and applying them in the order 2d4fa94 0fe51aa d3b9d7a a24a607 worked > > > > without hunks dropped. > > > > > > > > I have attached `git diff` against vanilla 3.7.7, so you can check that > > > > i got it right. > > > > > > Yep, that diff looks fine compared to the git diff of those four patches. > > > > > > Greg, > > > > > > How do you want to handle this? The above four patches should go into > > > 3.8 and stable, but they're not currently in Linus' tree and it's > > > probably too late in the cycle to merge them this week. Should we just > > > wait until 3.9 is out and put the patches into the stable trees then? > > > > > My email shows that the bad commit > > > f7965c0846d74b270e246c1470ca955d5078eb07 has been added to the 3.2, 3.4, > > > and 3.7 stable trees, as well as Canonical's 3.7 stable tree. I'm also > > > fine with just reverting that commit from 3.8 and stable. > > > > It's probably easier at this point in time to just revert that commit, > > leave the stable kernels alone, and then everything will be fixed in > > 3.9. When the commits go into Linus's tree, we can backport everything > > to the stable releases (including 3.8.1) at that point. > > > > As long as someone remembers to send the needed information to > > sta...@vger.kernel.org, I know I'll forget :) > > > > Sound ok? > > Yep, sounds fine. I'll attempt to remember to send email to stable once > 3.9 is out. Did this happen yet? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [regression] external HDD in USB3 enclosure cannot be dynamically removed (Re: Linux 3.7.5)
On Wed, Feb 13, 2013 at 02:12:50PM -0800, Sarah Sharp wrote: On Wed, Feb 13, 2013 at 01:31:29PM -0800, Greg KH wrote: On Wed, Feb 13, 2013 at 01:08:46PM -0800, Sarah Sharp wrote: On Wed, Feb 13, 2013 at 09:04:13PM +0100, Matthias Schniedermeyer wrote: On 13.02.2013 11:33, Sarah Sharp wrote: On Wed, Feb 13, 2013 at 06:16:56PM +0100, Matthias Schniedermeyer wrote: On 13.02.2013 09:28, Holger Hoffstätte wrote: On 12.02.2013 21:42, Sarah Sharp wrote: [..] There was a further set of patches queued for 3.9 to deal with connected devices going to the Inactive state, but they looked like they were too big for stable: d3b9d7a USB: Fix connected device switch to Inactive state. a24a607 USB: Rip out recursive call on warm port reset. 2d4fa94 USB: Prepare for refactoring by adding extra udev checks. 0fe51aa USB: Don't use EHCI port sempahore for USB 3.0 hubs. Holger and Matthias, can you double check that cherry picking just those four patches on top of 3.7.7 or 3.8 works as well? 3.7.7 + those 4 patches workes for me. As i'm not very firm in git i generated separate diffs for each commit and applying them in the order 2d4fa94 0fe51aa d3b9d7a a24a607 worked without hunks dropped. I have attached `git diff` against vanilla 3.7.7, so you can check that i got it right. Yep, that diff looks fine compared to the git diff of those four patches. Greg, How do you want to handle this? The above four patches should go into 3.8 and stable, but they're not currently in Linus' tree and it's probably too late in the cycle to merge them this week. Should we just wait until 3.9 is out and put the patches into the stable trees then? My email shows that the bad commit f7965c0846d74b270e246c1470ca955d5078eb07 has been added to the 3.2, 3.4, and 3.7 stable trees, as well as Canonical's 3.7 stable tree. I'm also fine with just reverting that commit from 3.8 and stable. It's probably easier at this point in time to just revert that commit, leave the stable kernels alone, and then everything will be fixed in 3.9. When the commits go into Linus's tree, we can backport everything to the stable releases (including 3.8.1) at that point. As long as someone remembers to send the needed information to sta...@vger.kernel.org, I know I'll forget :) Sound ok? Yep, sounds fine. I'll attempt to remember to send email to stable once 3.9 is out. Did this happen yet? thanks, greg k-h -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [regression] external HDD in USB3 enclosure cannot be dynamically removed (Re: Linux 3.7.5)
On Wed, Feb 13, 2013 at 01:31:29PM -0800, Greg KH wrote: > On Wed, Feb 13, 2013 at 01:08:46PM -0800, Sarah Sharp wrote: > > On Wed, Feb 13, 2013 at 09:04:13PM +0100, Matthias Schniedermeyer wrote: > > > On 13.02.2013 11:33, Sarah Sharp wrote: > > > > On Wed, Feb 13, 2013 at 06:16:56PM +0100, Matthias Schniedermeyer wrote: > > > > > On 13.02.2013 09:28, Holger Hoffstätte wrote: > > > > > > On 12.02.2013 21:42, Sarah Sharp wrote: > > > > > > > [..] > > > > > > > There was a further set of patches queued for 3.9 to deal with > > > > > > > connected > > > > > > > devices going to the Inactive state, but they looked like they > > > > > > > were too > > > > > > > big for stable: > > > > > > > > > > > > > > d3b9d7a USB: Fix connected device switch to Inactive state. > > > > > > > a24a607 USB: Rip out recursive call on warm port reset. > > > > > > > 2d4fa94 USB: Prepare for refactoring by adding extra udev checks. > > > > > > > 0fe51aa USB: Don't use EHCI port sempahore for USB 3.0 hubs. > > > > > > > > Holger and Matthias, can you double check that cherry picking just those > > > > four patches on top of 3.7.7 or 3.8 works as well? > > > > > > 3.7.7 + those 4 patches workes for me. > > > > > > As i'm not very firm in git i generated separate diffs for each commit > > > and applying them in the order 2d4fa94 0fe51aa d3b9d7a a24a607 worked > > > without hunks dropped. > > > > > > I have attached `git diff` against vanilla 3.7.7, so you can check that > > > i got it right. > > > > Yep, that diff looks fine compared to the git diff of those four patches. > > > > Greg, > > > > How do you want to handle this? The above four patches should go into > > 3.8 and stable, but they're not currently in Linus' tree and it's > > probably too late in the cycle to merge them this week. Should we just > > wait until 3.9 is out and put the patches into the stable trees then? > > > My email shows that the bad commit > > f7965c0846d74b270e246c1470ca955d5078eb07 has been added to the 3.2, 3.4, > > and 3.7 stable trees, as well as Canonical's 3.7 stable tree. I'm also > > fine with just reverting that commit from 3.8 and stable. > > It's probably easier at this point in time to just revert that commit, > leave the stable kernels alone, and then everything will be fixed in > 3.9. When the commits go into Linus's tree, we can backport everything > to the stable releases (including 3.8.1) at that point. > > As long as someone remembers to send the needed information to > sta...@vger.kernel.org, I know I'll forget :) > > Sound ok? Yep, sounds fine. I'll attempt to remember to send email to stable once 3.9 is out. Sarah Sharp -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [regression] external HDD in USB3 enclosure cannot be dynamically removed (Re: Linux 3.7.5)
On Wed, Feb 13, 2013 at 01:08:46PM -0800, Sarah Sharp wrote: > On Wed, Feb 13, 2013 at 09:04:13PM +0100, Matthias Schniedermeyer wrote: > > On 13.02.2013 11:33, Sarah Sharp wrote: > > > On Wed, Feb 13, 2013 at 06:16:56PM +0100, Matthias Schniedermeyer wrote: > > > > On 13.02.2013 09:28, Holger Hoffstätte wrote: > > > > > On 12.02.2013 21:42, Sarah Sharp wrote: > > > > > > [..] > > > > > > There was a further set of patches queued for 3.9 to deal with > > > > > > connected > > > > > > devices going to the Inactive state, but they looked like they were > > > > > > too > > > > > > big for stable: > > > > > > > > > > > > d3b9d7a USB: Fix connected device switch to Inactive state. > > > > > > a24a607 USB: Rip out recursive call on warm port reset. > > > > > > 2d4fa94 USB: Prepare for refactoring by adding extra udev checks. > > > > > > 0fe51aa USB: Don't use EHCI port sempahore for USB 3.0 hubs. > > > > > > Holger and Matthias, can you double check that cherry picking just those > > > four patches on top of 3.7.7 or 3.8 works as well? > > > > 3.7.7 + those 4 patches workes for me. > > > > As i'm not very firm in git i generated separate diffs for each commit > > and applying them in the order 2d4fa94 0fe51aa d3b9d7a a24a607 worked > > without hunks dropped. > > > > I have attached `git diff` against vanilla 3.7.7, so you can check that > > i got it right. > > Yep, that diff looks fine compared to the git diff of those four patches. > > Greg, > > How do you want to handle this? The above four patches should go into > 3.8 and stable, but they're not currently in Linus' tree and it's > probably too late in the cycle to merge them this week. Should we just > wait until 3.9 is out and put the patches into the stable trees then? > My email shows that the bad commit > f7965c0846d74b270e246c1470ca955d5078eb07 has been added to the 3.2, 3.4, > and 3.7 stable trees, as well as Canonical's 3.7 stable tree. I'm also > fine with just reverting that commit from 3.8 and stable. It's probably easier at this point in time to just revert that commit, leave the stable kernels alone, and then everything will be fixed in 3.9. When the commits go into Linus's tree, we can backport everything to the stable releases (including 3.8.1) at that point. As long as someone remembers to send the needed information to sta...@vger.kernel.org, I know I'll forget :) Sound ok? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [regression] external HDD in USB3 enclosure cannot be dynamically removed (Re: Linux 3.7.5)
On Wed, Feb 13, 2013 at 09:04:13PM +0100, Matthias Schniedermeyer wrote: > On 13.02.2013 11:33, Sarah Sharp wrote: > > On Wed, Feb 13, 2013 at 06:16:56PM +0100, Matthias Schniedermeyer wrote: > > > On 13.02.2013 09:28, Holger Hoffstätte wrote: > > > > On 12.02.2013 21:42, Sarah Sharp wrote: > > > > > [..] > > > > > There was a further set of patches queued for 3.9 to deal with > > > > > connected > > > > > devices going to the Inactive state, but they looked like they were > > > > > too > > > > > big for stable: > > > > > > > > > > d3b9d7a USB: Fix connected device switch to Inactive state. > > > > > a24a607 USB: Rip out recursive call on warm port reset. > > > > > 2d4fa94 USB: Prepare for refactoring by adding extra udev checks. > > > > > 0fe51aa USB: Don't use EHCI port sempahore for USB 3.0 hubs. > > > > Holger and Matthias, can you double check that cherry picking just those > > four patches on top of 3.7.7 or 3.8 works as well? > > 3.7.7 + those 4 patches workes for me. > > As i'm not very firm in git i generated separate diffs for each commit > and applying them in the order 2d4fa94 0fe51aa d3b9d7a a24a607 worked > without hunks dropped. > > I have attached `git diff` against vanilla 3.7.7, so you can check that > i got it right. Yep, that diff looks fine compared to the git diff of those four patches. Greg, How do you want to handle this? The above four patches should go into 3.8 and stable, but they're not currently in Linus' tree and it's probably too late in the cycle to merge them this week. Should we just wait until 3.9 is out and put the patches into the stable trees then? My email shows that the bad commit f7965c0846d74b270e246c1470ca955d5078eb07 has been added to the 3.2, 3.4, and 3.7 stable trees, as well as Canonical's 3.7 stable tree. I'm also fine with just reverting that commit from 3.8 and stable. Sarah Sharp -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [regression] external HDD in USB3 enclosure cannot be dynamically removed (Re: Linux 3.7.5)
On 13.02.2013 11:33, Sarah Sharp wrote: > On Wed, Feb 13, 2013 at 06:16:56PM +0100, Matthias Schniedermeyer wrote: > > On 13.02.2013 09:28, Holger Hoffstätte wrote: > > > On 12.02.2013 21:42, Sarah Sharp wrote: > > > > [..] > > > > There was a further set of patches queued for 3.9 to deal with connected > > > > devices going to the Inactive state, but they looked like they were too > > > > big for stable: > > > > > > > > d3b9d7a USB: Fix connected device switch to Inactive state. > > > > a24a607 USB: Rip out recursive call on warm port reset. > > > > 2d4fa94 USB: Prepare for refactoring by adding extra udev checks. > > > > 0fe51aa USB: Don't use EHCI port sempahore for USB 3.0 hubs. > > > > > > > > Can you retry with Greg's usb-next branch? > > > > > > > > git clone git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git > > > > -b usb-next > > > > > > > > If that fixes your problem, we should either get those additional > > > > patches into 3.8 and the stable trees, or do a revert of the whole > > > > series and just let 3.9 carry the full patchset. > > > > > > Good news! This one does indeed work as expected - the device can be > > > removed and is gone for good. Upstream & Stable plz :) > > > > That kernel fixes the problem for me too. > > Great! > > Holger and Matthias, can you double check that cherry picking just those > four patches on top of 3.7.7 or 3.8 works as well? 3.7.7 + those 4 patches workes for me. As i'm not very firm in git i generated separate diffs for each commit and applying them in the order 2d4fa94 0fe51aa d3b9d7a a24a607 worked without hunks dropped. I have attached `git diff` against vanilla 3.7.7, so you can check that i got it right. -- Matthias combined.diff.gz Description: Binary data
Re: [regression] external HDD in USB3 enclosure cannot be dynamically removed (Re: Linux 3.7.5)
On Wed, Feb 13, 2013 at 06:16:56PM +0100, Matthias Schniedermeyer wrote: > On 13.02.2013 09:28, Holger Hoffstätte wrote: > > On 12.02.2013 21:42, Sarah Sharp wrote: > > > [..] > > > There was a further set of patches queued for 3.9 to deal with connected > > > devices going to the Inactive state, but they looked like they were too > > > big for stable: > > > > > > d3b9d7a USB: Fix connected device switch to Inactive state. > > > a24a607 USB: Rip out recursive call on warm port reset. > > > 2d4fa94 USB: Prepare for refactoring by adding extra udev checks. > > > 0fe51aa USB: Don't use EHCI port sempahore for USB 3.0 hubs. > > > > > > Can you retry with Greg's usb-next branch? > > > > > > git clone git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git -b > > > usb-next > > > > > > If that fixes your problem, we should either get those additional > > > patches into 3.8 and the stable trees, or do a revert of the whole > > > series and just let 3.9 carry the full patchset. > > > > Good news! This one does indeed work as expected - the device can be > > removed and is gone for good. Upstream & Stable plz :) > > That kernel fixes the problem for me too. Great! Holger and Matthias, can you double check that cherry picking just those four patches on top of 3.7.7 or 3.8 works as well? Sarah Sharp -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [regression] external HDD in USB3 enclosure cannot be dynamically removed (Re: Linux 3.7.5)
On 13.02.2013 09:28, Holger Hoffstätte wrote: > On 12.02.2013 21:42, Sarah Sharp wrote: > > [..] > > I think I see the issue. Your host controller reports the Inactive > > state after a USB disconnect. My host controllers go to the RxDetect > > state on a disconnect. > > > > The patches that went into 3.8 and the stable kernels to better handle > > the Inactive state were not designed to handle a connected device going > > to the Inactive state. I thought that would be a rare case, but > > apparently it's not. > > > > There was a further set of patches queued for 3.9 to deal with connected > > devices going to the Inactive state, but they looked like they were too > > big for stable: > > > > d3b9d7a USB: Fix connected device switch to Inactive state. > > a24a607 USB: Rip out recursive call on warm port reset. > > 2d4fa94 USB: Prepare for refactoring by adding extra udev checks. > > 0fe51aa USB: Don't use EHCI port sempahore for USB 3.0 hubs. > > > > Can you retry with Greg's usb-next branch? > > > > git clone git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git -b > > usb-next > > > > If that fixes your problem, we should either get those additional > > patches into 3.8 and the stable trees, or do a revert of the whole > > series and just let 3.9 carry the full patchset. > > Good news! This one does indeed work as expected - the device can be > removed and is gone for good. Upstream & Stable plz :) That kernel fixes the problem for me too. -- Matthias -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [regression] external HDD in USB3 enclosure cannot be dynamically removed (Re: Linux 3.7.5)
On 12.02.2013 21:42, Sarah Sharp wrote: > [..] > I think I see the issue. Your host controller reports the Inactive > state after a USB disconnect. My host controllers go to the RxDetect > state on a disconnect. > > The patches that went into 3.8 and the stable kernels to better handle > the Inactive state were not designed to handle a connected device going > to the Inactive state. I thought that would be a rare case, but > apparently it's not. > > There was a further set of patches queued for 3.9 to deal with connected > devices going to the Inactive state, but they looked like they were too > big for stable: > > d3b9d7a USB: Fix connected device switch to Inactive state. > a24a607 USB: Rip out recursive call on warm port reset. > 2d4fa94 USB: Prepare for refactoring by adding extra udev checks. > 0fe51aa USB: Don't use EHCI port sempahore for USB 3.0 hubs. > > Can you retry with Greg's usb-next branch? > > git clone git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git -b > usb-next > > If that fixes your problem, we should either get those additional > patches into 3.8 and the stable trees, or do a revert of the whole > series and just let 3.9 carry the full patchset. Good news! This one does indeed work as expected - the device can be removed and is gone for good. Upstream & Stable plz :) thanks all! Holger -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [regression] external HDD in USB3 enclosure cannot be dynamically removed (Re: Linux 3.7.5)
On 12.02.2013 21:42, Sarah Sharp wrote: [..] I think I see the issue. Your host controller reports the Inactive state after a USB disconnect. My host controllers go to the RxDetect state on a disconnect. The patches that went into 3.8 and the stable kernels to better handle the Inactive state were not designed to handle a connected device going to the Inactive state. I thought that would be a rare case, but apparently it's not. There was a further set of patches queued for 3.9 to deal with connected devices going to the Inactive state, but they looked like they were too big for stable: d3b9d7a USB: Fix connected device switch to Inactive state. a24a607 USB: Rip out recursive call on warm port reset. 2d4fa94 USB: Prepare for refactoring by adding extra udev checks. 0fe51aa USB: Don't use EHCI port sempahore for USB 3.0 hubs. Can you retry with Greg's usb-next branch? git clone git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git -b usb-next If that fixes your problem, we should either get those additional patches into 3.8 and the stable trees, or do a revert of the whole series and just let 3.9 carry the full patchset. Good news! This one does indeed work as expected - the device can be removed and is gone for good. Upstream Stable plz :) thanks all! Holger -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [regression] external HDD in USB3 enclosure cannot be dynamically removed (Re: Linux 3.7.5)
On 13.02.2013 09:28, Holger Hoffstätte wrote: On 12.02.2013 21:42, Sarah Sharp wrote: [..] I think I see the issue. Your host controller reports the Inactive state after a USB disconnect. My host controllers go to the RxDetect state on a disconnect. The patches that went into 3.8 and the stable kernels to better handle the Inactive state were not designed to handle a connected device going to the Inactive state. I thought that would be a rare case, but apparently it's not. There was a further set of patches queued for 3.9 to deal with connected devices going to the Inactive state, but they looked like they were too big for stable: d3b9d7a USB: Fix connected device switch to Inactive state. a24a607 USB: Rip out recursive call on warm port reset. 2d4fa94 USB: Prepare for refactoring by adding extra udev checks. 0fe51aa USB: Don't use EHCI port sempahore for USB 3.0 hubs. Can you retry with Greg's usb-next branch? git clone git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git -b usb-next If that fixes your problem, we should either get those additional patches into 3.8 and the stable trees, or do a revert of the whole series and just let 3.9 carry the full patchset. Good news! This one does indeed work as expected - the device can be removed and is gone for good. Upstream Stable plz :) That kernel fixes the problem for me too. -- Matthias -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [regression] external HDD in USB3 enclosure cannot be dynamically removed (Re: Linux 3.7.5)
On Wed, Feb 13, 2013 at 06:16:56PM +0100, Matthias Schniedermeyer wrote: On 13.02.2013 09:28, Holger Hoffstätte wrote: On 12.02.2013 21:42, Sarah Sharp wrote: [..] There was a further set of patches queued for 3.9 to deal with connected devices going to the Inactive state, but they looked like they were too big for stable: d3b9d7a USB: Fix connected device switch to Inactive state. a24a607 USB: Rip out recursive call on warm port reset. 2d4fa94 USB: Prepare for refactoring by adding extra udev checks. 0fe51aa USB: Don't use EHCI port sempahore for USB 3.0 hubs. Can you retry with Greg's usb-next branch? git clone git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git -b usb-next If that fixes your problem, we should either get those additional patches into 3.8 and the stable trees, or do a revert of the whole series and just let 3.9 carry the full patchset. Good news! This one does indeed work as expected - the device can be removed and is gone for good. Upstream Stable plz :) That kernel fixes the problem for me too. Great! Holger and Matthias, can you double check that cherry picking just those four patches on top of 3.7.7 or 3.8 works as well? Sarah Sharp -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [regression] external HDD in USB3 enclosure cannot be dynamically removed (Re: Linux 3.7.5)
On 13.02.2013 11:33, Sarah Sharp wrote: On Wed, Feb 13, 2013 at 06:16:56PM +0100, Matthias Schniedermeyer wrote: On 13.02.2013 09:28, Holger Hoffstätte wrote: On 12.02.2013 21:42, Sarah Sharp wrote: [..] There was a further set of patches queued for 3.9 to deal with connected devices going to the Inactive state, but they looked like they were too big for stable: d3b9d7a USB: Fix connected device switch to Inactive state. a24a607 USB: Rip out recursive call on warm port reset. 2d4fa94 USB: Prepare for refactoring by adding extra udev checks. 0fe51aa USB: Don't use EHCI port sempahore for USB 3.0 hubs. Can you retry with Greg's usb-next branch? git clone git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git -b usb-next If that fixes your problem, we should either get those additional patches into 3.8 and the stable trees, or do a revert of the whole series and just let 3.9 carry the full patchset. Good news! This one does indeed work as expected - the device can be removed and is gone for good. Upstream Stable plz :) That kernel fixes the problem for me too. Great! Holger and Matthias, can you double check that cherry picking just those four patches on top of 3.7.7 or 3.8 works as well? 3.7.7 + those 4 patches workes for me. As i'm not very firm in git i generated separate diffs for each commit and applying them in the order 2d4fa94 0fe51aa d3b9d7a a24a607 worked without hunks dropped. I have attached `git diff` against vanilla 3.7.7, so you can check that i got it right. -- Matthias combined.diff.gz Description: Binary data
Re: [regression] external HDD in USB3 enclosure cannot be dynamically removed (Re: Linux 3.7.5)
On Wed, Feb 13, 2013 at 09:04:13PM +0100, Matthias Schniedermeyer wrote: On 13.02.2013 11:33, Sarah Sharp wrote: On Wed, Feb 13, 2013 at 06:16:56PM +0100, Matthias Schniedermeyer wrote: On 13.02.2013 09:28, Holger Hoffstätte wrote: On 12.02.2013 21:42, Sarah Sharp wrote: [..] There was a further set of patches queued for 3.9 to deal with connected devices going to the Inactive state, but they looked like they were too big for stable: d3b9d7a USB: Fix connected device switch to Inactive state. a24a607 USB: Rip out recursive call on warm port reset. 2d4fa94 USB: Prepare for refactoring by adding extra udev checks. 0fe51aa USB: Don't use EHCI port sempahore for USB 3.0 hubs. Holger and Matthias, can you double check that cherry picking just those four patches on top of 3.7.7 or 3.8 works as well? 3.7.7 + those 4 patches workes for me. As i'm not very firm in git i generated separate diffs for each commit and applying them in the order 2d4fa94 0fe51aa d3b9d7a a24a607 worked without hunks dropped. I have attached `git diff` against vanilla 3.7.7, so you can check that i got it right. Yep, that diff looks fine compared to the git diff of those four patches. Greg, How do you want to handle this? The above four patches should go into 3.8 and stable, but they're not currently in Linus' tree and it's probably too late in the cycle to merge them this week. Should we just wait until 3.9 is out and put the patches into the stable trees then? My email shows that the bad commit f7965c0846d74b270e246c1470ca955d5078eb07 has been added to the 3.2, 3.4, and 3.7 stable trees, as well as Canonical's 3.7 stable tree. I'm also fine with just reverting that commit from 3.8 and stable. Sarah Sharp -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [regression] external HDD in USB3 enclosure cannot be dynamically removed (Re: Linux 3.7.5)
On Wed, Feb 13, 2013 at 01:08:46PM -0800, Sarah Sharp wrote: On Wed, Feb 13, 2013 at 09:04:13PM +0100, Matthias Schniedermeyer wrote: On 13.02.2013 11:33, Sarah Sharp wrote: On Wed, Feb 13, 2013 at 06:16:56PM +0100, Matthias Schniedermeyer wrote: On 13.02.2013 09:28, Holger Hoffstätte wrote: On 12.02.2013 21:42, Sarah Sharp wrote: [..] There was a further set of patches queued for 3.9 to deal with connected devices going to the Inactive state, but they looked like they were too big for stable: d3b9d7a USB: Fix connected device switch to Inactive state. a24a607 USB: Rip out recursive call on warm port reset. 2d4fa94 USB: Prepare for refactoring by adding extra udev checks. 0fe51aa USB: Don't use EHCI port sempahore for USB 3.0 hubs. Holger and Matthias, can you double check that cherry picking just those four patches on top of 3.7.7 or 3.8 works as well? 3.7.7 + those 4 patches workes for me. As i'm not very firm in git i generated separate diffs for each commit and applying them in the order 2d4fa94 0fe51aa d3b9d7a a24a607 worked without hunks dropped. I have attached `git diff` against vanilla 3.7.7, so you can check that i got it right. Yep, that diff looks fine compared to the git diff of those four patches. Greg, How do you want to handle this? The above four patches should go into 3.8 and stable, but they're not currently in Linus' tree and it's probably too late in the cycle to merge them this week. Should we just wait until 3.9 is out and put the patches into the stable trees then? My email shows that the bad commit f7965c0846d74b270e246c1470ca955d5078eb07 has been added to the 3.2, 3.4, and 3.7 stable trees, as well as Canonical's 3.7 stable tree. I'm also fine with just reverting that commit from 3.8 and stable. It's probably easier at this point in time to just revert that commit, leave the stable kernels alone, and then everything will be fixed in 3.9. When the commits go into Linus's tree, we can backport everything to the stable releases (including 3.8.1) at that point. As long as someone remembers to send the needed information to sta...@vger.kernel.org, I know I'll forget :) Sound ok? thanks, greg k-h -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [regression] external HDD in USB3 enclosure cannot be dynamically removed (Re: Linux 3.7.5)
On Wed, Feb 13, 2013 at 01:31:29PM -0800, Greg KH wrote: On Wed, Feb 13, 2013 at 01:08:46PM -0800, Sarah Sharp wrote: On Wed, Feb 13, 2013 at 09:04:13PM +0100, Matthias Schniedermeyer wrote: On 13.02.2013 11:33, Sarah Sharp wrote: On Wed, Feb 13, 2013 at 06:16:56PM +0100, Matthias Schniedermeyer wrote: On 13.02.2013 09:28, Holger Hoffstätte wrote: On 12.02.2013 21:42, Sarah Sharp wrote: [..] There was a further set of patches queued for 3.9 to deal with connected devices going to the Inactive state, but they looked like they were too big for stable: d3b9d7a USB: Fix connected device switch to Inactive state. a24a607 USB: Rip out recursive call on warm port reset. 2d4fa94 USB: Prepare for refactoring by adding extra udev checks. 0fe51aa USB: Don't use EHCI port sempahore for USB 3.0 hubs. Holger and Matthias, can you double check that cherry picking just those four patches on top of 3.7.7 or 3.8 works as well? 3.7.7 + those 4 patches workes for me. As i'm not very firm in git i generated separate diffs for each commit and applying them in the order 2d4fa94 0fe51aa d3b9d7a a24a607 worked without hunks dropped. I have attached `git diff` against vanilla 3.7.7, so you can check that i got it right. Yep, that diff looks fine compared to the git diff of those four patches. Greg, How do you want to handle this? The above four patches should go into 3.8 and stable, but they're not currently in Linus' tree and it's probably too late in the cycle to merge them this week. Should we just wait until 3.9 is out and put the patches into the stable trees then? My email shows that the bad commit f7965c0846d74b270e246c1470ca955d5078eb07 has been added to the 3.2, 3.4, and 3.7 stable trees, as well as Canonical's 3.7 stable tree. I'm also fine with just reverting that commit from 3.8 and stable. It's probably easier at this point in time to just revert that commit, leave the stable kernels alone, and then everything will be fixed in 3.9. When the commits go into Linus's tree, we can backport everything to the stable releases (including 3.8.1) at that point. As long as someone remembers to send the needed information to sta...@vger.kernel.org, I know I'll forget :) Sound ok? Yep, sounds fine. I'll attempt to remember to send email to stable once 3.9 is out. Sarah Sharp -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [regression] external HDD in USB3 enclosure cannot be dynamically removed (Re: Linux 3.7.5)
On Tue, Feb 12, 2013 at 11:35:29AM +0100, Holger Hoffstätte wrote: > On 02/12/13 01:40, Sarah Sharp wrote: > > Can you turn on CONFIG_USB_DEBUG and CONFIG_USB_XHCI_HCD_DEBUGGING, > > recompile the 3.7.5 kernel, and send me dmesg starting from the point > > you unmount the device and then power it off? > > I don't even need to mount/unmount; just plugging in/unplugging > reproduces the problem. Note again that this is independent of both the > used USB 3.0 card (might be the same chipset though?) and the attached > device/enclosure. > > So time to make a freshly built 3.8-rc7 go Ding Dong! :) xHCI doorbells are fun. :) I think I see the issue. Your host controller reports the Inactive state after a USB disconnect. My host controllers go to the RxDetect state on a disconnect. The patches that went into 3.8 and the stable kernels to better handle the Inactive state were not designed to handle a connected device going to the Inactive state. I thought that would be a rare case, but apparently it's not. There was a further set of patches queued for 3.9 to deal with connected devices going to the Inactive state, but they looked like they were too big for stable: d3b9d7a USB: Fix connected device switch to Inactive state. a24a607 USB: Rip out recursive call on warm port reset. 2d4fa94 USB: Prepare for refactoring by adding extra udev checks. 0fe51aa USB: Don't use EHCI port sempahore for USB 3.0 hubs. Can you retry with Greg's usb-next branch? git clone git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git -b usb-next If that fixes your problem, we should either get those additional patches into 3.8 and the stable trees, or do a revert of the whole series and just let 3.9 carry the full patchset. Sarah Sharp -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [regression] external HDD in USB3 enclosure cannot be dynamically removed (Re: Linux 3.7.5)
On 12.02.2013 01:54, Jonathan Nieder wrote: > Sarah Sharp wrote: > >> Can you turn on CONFIG_USB_DEBUG and CONFIG_USB_XHCI_HCD_DEBUGGING, >> recompile the 3.7.5 kernel, and send me dmesg starting from the point >> you unmount the device and then power it off? >> >> I'd like to keep that patch in stable, but I need to understand what >> exactly is failing with it. > > Note that Holger ran into the same problem using a mainline (3.8-rc5) > kernel. Yup, which is why I'll try 3.8-rc7 first. Glad this has some attention. :) -h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [regression] external HDD in USB3 enclosure cannot be dynamically removed (Re: Linux 3.7.5)
On 12.02.2013 01:54, Jonathan Nieder wrote: Sarah Sharp wrote: Can you turn on CONFIG_USB_DEBUG and CONFIG_USB_XHCI_HCD_DEBUGGING, recompile the 3.7.5 kernel, and send me dmesg starting from the point you unmount the device and then power it off? I'd like to keep that patch in stable, but I need to understand what exactly is failing with it. Note that Holger ran into the same problem using a mainline (3.8-rc5) kernel. Yup, which is why I'll try 3.8-rc7 first. Glad this has some attention. :) -h -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [regression] external HDD in USB3 enclosure cannot be dynamically removed (Re: Linux 3.7.5)
On Tue, Feb 12, 2013 at 11:35:29AM +0100, Holger Hoffstätte wrote: On 02/12/13 01:40, Sarah Sharp wrote: Can you turn on CONFIG_USB_DEBUG and CONFIG_USB_XHCI_HCD_DEBUGGING, recompile the 3.7.5 kernel, and send me dmesg starting from the point you unmount the device and then power it off? I don't even need to mount/unmount; just plugging in/unplugging reproduces the problem. Note again that this is independent of both the used USB 3.0 card (might be the same chipset though?) and the attached device/enclosure. So time to make a freshly built 3.8-rc7 go Ding Dong! :) xHCI doorbells are fun. :) I think I see the issue. Your host controller reports the Inactive state after a USB disconnect. My host controllers go to the RxDetect state on a disconnect. The patches that went into 3.8 and the stable kernels to better handle the Inactive state were not designed to handle a connected device going to the Inactive state. I thought that would be a rare case, but apparently it's not. There was a further set of patches queued for 3.9 to deal with connected devices going to the Inactive state, but they looked like they were too big for stable: d3b9d7a USB: Fix connected device switch to Inactive state. a24a607 USB: Rip out recursive call on warm port reset. 2d4fa94 USB: Prepare for refactoring by adding extra udev checks. 0fe51aa USB: Don't use EHCI port sempahore for USB 3.0 hubs. Can you retry with Greg's usb-next branch? git clone git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git -b usb-next If that fixes your problem, we should either get those additional patches into 3.8 and the stable trees, or do a revert of the whole series and just let 3.9 carry the full patchset. Sarah Sharp -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [regression] external HDD in USB3 enclosure cannot be dynamically removed (Re: Linux 3.7.5)
Sarah Sharp wrote: > Can you turn on CONFIG_USB_DEBUG and CONFIG_USB_XHCI_HCD_DEBUGGING, > recompile the 3.7.5 kernel, and send me dmesg starting from the point > you unmount the device and then power it off? > > I'd like to keep that patch in stable, but I need to understand what > exactly is failing with it. Note that Holger ran into the same problem using a mainline (3.8-rc5) kernel. Thanks, Jonathan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [regression] external HDD in USB3 enclosure cannot be dynamically removed (Re: Linux 3.7.5)
Hi Holger, Can you turn on CONFIG_USB_DEBUG and CONFIG_USB_XHCI_HCD_DEBUGGING, recompile the 3.7.5 kernel, and send me dmesg starting from the point you unmount the device and then power it off? I'd like to keep that patch in stable, but I need to understand what exactly is failing with it. Sarah Sharp On Mon, Jan 28, 2013 at 12:46:39PM -0800, Jonathan Nieder wrote: > Hi Holger, > > Holger Hoffstaette wrote: > >> On Mon, Jan 28, 2013 at 12:42:16PM +0100, Holger Hoffstaette wrote: > > >>> Apologies for being late but I'm afraid I just found at least one > >>> regression in this release. > >>> > >>> I have an external HDD in an USB3 enclosure for the occasional backup. I > >>> turn it on, it gets registered as sdX, I mount it/use it/unmount it and > >>> turn it off, which worked fine with kernels including 3.7.4. With 3.7.5 > > > > FWIW it didn't really work with 3.7.4 either - just didn't notice before. > > > >>> the kernel seems no longer notified of the changed device power status; > >>> nothing in dmesg and the device stays in the list of SCSI devices as > >>> e.g. shown by lsscsi. This is repeatable. Turning the device back > >>> on/using it works fine, it's just that I cannot dynamically remove it > >>> any longer. > [...] > > No, current 3.8-rc5 did not work either. I first found 3.7.2 OK and 3.7.3 > > bad. Bisecting found: > > > > --snip-- > > f7965c0846d74b270e246c1470ca955d5078eb07 is the first bad commit > > commit f7965c0846d74b270e246c1470ca955d5078eb07 > > Author: Sarah Sharp > > Date: Wed Nov 14 17:58:04 2012 -0800 > > > > USB: Handle warm reset failure on empty port. > > > > commit 65bdac5effd15d6af619b3b7218627ef4d84ed6a upstream. > [...] > > Reverting this from 3.7.3 all the way to 3.8-rc5 makes USB 3.0 > > disconnection/power-off device removal work again. Verified both on the > > bisection box and by now also the original machine. > > Thanks for tracking this down. Forwarding to relevant people. > > Hope that helps, > Jonathan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [regression] external HDD in USB3 enclosure cannot be dynamically removed (Re: Linux 3.7.5)
Hi Holger, Can you turn on CONFIG_USB_DEBUG and CONFIG_USB_XHCI_HCD_DEBUGGING, recompile the 3.7.5 kernel, and send me dmesg starting from the point you unmount the device and then power it off? I'd like to keep that patch in stable, but I need to understand what exactly is failing with it. Sarah Sharp On Mon, Jan 28, 2013 at 12:46:39PM -0800, Jonathan Nieder wrote: Hi Holger, Holger Hoffstaette wrote: On Mon, Jan 28, 2013 at 12:42:16PM +0100, Holger Hoffstaette wrote: Apologies for being late but I'm afraid I just found at least one regression in this release. I have an external HDD in an USB3 enclosure for the occasional backup. I turn it on, it gets registered as sdX, I mount it/use it/unmount it and turn it off, which worked fine with kernels including 3.7.4. With 3.7.5 FWIW it didn't really work with 3.7.4 either - just didn't notice before. the kernel seems no longer notified of the changed device power status; nothing in dmesg and the device stays in the list of SCSI devices as e.g. shown by lsscsi. This is repeatable. Turning the device back on/using it works fine, it's just that I cannot dynamically remove it any longer. [...] No, current 3.8-rc5 did not work either. I first found 3.7.2 OK and 3.7.3 bad. Bisecting found: --snip-- f7965c0846d74b270e246c1470ca955d5078eb07 is the first bad commit commit f7965c0846d74b270e246c1470ca955d5078eb07 Author: Sarah Sharp sarah.a.sh...@linux.intel.com Date: Wed Nov 14 17:58:04 2012 -0800 USB: Handle warm reset failure on empty port. commit 65bdac5effd15d6af619b3b7218627ef4d84ed6a upstream. [...] Reverting this from 3.7.3 all the way to 3.8-rc5 makes USB 3.0 disconnection/power-off device removal work again. Verified both on the bisection box and by now also the original machine. Thanks for tracking this down. Forwarding to relevant people. Hope that helps, Jonathan -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [regression] external HDD in USB3 enclosure cannot be dynamically removed (Re: Linux 3.7.5)
Sarah Sharp wrote: Can you turn on CONFIG_USB_DEBUG and CONFIG_USB_XHCI_HCD_DEBUGGING, recompile the 3.7.5 kernel, and send me dmesg starting from the point you unmount the device and then power it off? I'd like to keep that patch in stable, but I need to understand what exactly is failing with it. Note that Holger ran into the same problem using a mainline (3.8-rc5) kernel. Thanks, Jonathan -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[regression] external HDD in USB3 enclosure cannot be dynamically removed (Re: Linux 3.7.5)
Hi Holger, Holger Hoffstaette wrote: >> On Mon, Jan 28, 2013 at 12:42:16PM +0100, Holger Hoffstaette wrote: >>> Apologies for being late but I'm afraid I just found at least one >>> regression in this release. >>> >>> I have an external HDD in an USB3 enclosure for the occasional backup. I >>> turn it on, it gets registered as sdX, I mount it/use it/unmount it and >>> turn it off, which worked fine with kernels including 3.7.4. With 3.7.5 > > FWIW it didn't really work with 3.7.4 either - just didn't notice before. > >>> the kernel seems no longer notified of the changed device power status; >>> nothing in dmesg and the device stays in the list of SCSI devices as >>> e.g. shown by lsscsi. This is repeatable. Turning the device back >>> on/using it works fine, it's just that I cannot dynamically remove it >>> any longer. [...] > No, current 3.8-rc5 did not work either. I first found 3.7.2 OK and 3.7.3 > bad. Bisecting found: > > --snip-- > f7965c0846d74b270e246c1470ca955d5078eb07 is the first bad commit > commit f7965c0846d74b270e246c1470ca955d5078eb07 > Author: Sarah Sharp > Date: Wed Nov 14 17:58:04 2012 -0800 > > USB: Handle warm reset failure on empty port. > > commit 65bdac5effd15d6af619b3b7218627ef4d84ed6a upstream. [...] > Reverting this from 3.7.3 all the way to 3.8-rc5 makes USB 3.0 > disconnection/power-off device removal work again. Verified both on the > bisection box and by now also the original machine. Thanks for tracking this down. Forwarding to relevant people. Hope that helps, Jonathan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: Linux 3.7.5
On Mon, Jan 28, 2013 at 12:42:16PM +0100, Holger Hoffstaette wrote: > On Sun, 27 Jan 2013 20:56:58 -0800, Greg KH wrote: > > > I'm announcing the release of the 3.7.5 kernel. > > Apologies for being late but I'm afraid I just found at least one > regression in this release. > > I have an external HDD in an USB3 enclosure for the occasional backup. I > turn it on, it gets registered as sdX, I mount it/use it/unmount it and > turn it off, which worked fine with kernels including 3.7.4. > With 3.7.5 the kernel seems no longer notified of the changed device power > status; nothing in dmesg and the device stays in the list of SCSI devices > as e.g. shown by lsscsi. This is repeatable. Turning the device back > on/using it works fine, it's just that I cannot dynamically remove it any > longer. > > I cannot run a bisect at the moment, but reading the changelog points > to a few USB and libata related changes. I hope this helps. If you could run 'git bisect' to determine which patch causes this problem, that would be wonderful. Also, does 3.8-rc5 work for you properly or not on this hardware? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: Linux 3.7.5
On Mon, Jan 28, 2013 at 12:42:16PM +0100, Holger Hoffstaette wrote: On Sun, 27 Jan 2013 20:56:58 -0800, Greg KH wrote: I'm announcing the release of the 3.7.5 kernel. Apologies for being late but I'm afraid I just found at least one regression in this release. I have an external HDD in an USB3 enclosure for the occasional backup. I turn it on, it gets registered as sdX, I mount it/use it/unmount it and turn it off, which worked fine with kernels including 3.7.4. With 3.7.5 the kernel seems no longer notified of the changed device power status; nothing in dmesg and the device stays in the list of SCSI devices as e.g. shown by lsscsi. This is repeatable. Turning the device back on/using it works fine, it's just that I cannot dynamically remove it any longer. I cannot run a bisect at the moment, but reading the changelog points to a few USB and libata related changes. I hope this helps. If you could run 'git bisect' to determine which patch causes this problem, that would be wonderful. Also, does 3.8-rc5 work for you properly or not on this hardware? thanks, greg k-h -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[regression] external HDD in USB3 enclosure cannot be dynamically removed (Re: Linux 3.7.5)
Hi Holger, Holger Hoffstaette wrote: On Mon, Jan 28, 2013 at 12:42:16PM +0100, Holger Hoffstaette wrote: Apologies for being late but I'm afraid I just found at least one regression in this release. I have an external HDD in an USB3 enclosure for the occasional backup. I turn it on, it gets registered as sdX, I mount it/use it/unmount it and turn it off, which worked fine with kernels including 3.7.4. With 3.7.5 FWIW it didn't really work with 3.7.4 either - just didn't notice before. the kernel seems no longer notified of the changed device power status; nothing in dmesg and the device stays in the list of SCSI devices as e.g. shown by lsscsi. This is repeatable. Turning the device back on/using it works fine, it's just that I cannot dynamically remove it any longer. [...] No, current 3.8-rc5 did not work either. I first found 3.7.2 OK and 3.7.3 bad. Bisecting found: --snip-- f7965c0846d74b270e246c1470ca955d5078eb07 is the first bad commit commit f7965c0846d74b270e246c1470ca955d5078eb07 Author: Sarah Sharp sarah.a.sh...@linux.intel.com Date: Wed Nov 14 17:58:04 2012 -0800 USB: Handle warm reset failure on empty port. commit 65bdac5effd15d6af619b3b7218627ef4d84ed6a upstream. [...] Reverting this from 3.7.3 all the way to 3.8-rc5 makes USB 3.0 disconnection/power-off device removal work again. Verified both on the bisection box and by now also the original machine. Thanks for tracking this down. Forwarding to relevant people. Hope that helps, Jonathan -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Linux 3.7.5
I'm announcing the release of the 3.7.5 kernel.
All users of the 3.7 kernel series must upgrade.
The updated 3.7.y git tree can be found at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git
linux-3.7.y
and can be browsed at the normal kernel.org git web browser:
http://git.kernel.org/?p=linux/kernel/git/stable/linux-stable.git;a=summary
thanks,
greg k-h
Makefile |4
arch/arm64/include/asm/elf.h |5
arch/x86/kernel/cpu/perf_event.c |6 -
arch/x86/kernel/step.c |9 -
drivers/acpi/processor_idle.c |4
drivers/acpi/processor_perflib.c |7 +
drivers/ata/ahci.c |8 +
drivers/ata/libahci.c |6 -
drivers/ata/libata-core.c | 22 ++--
drivers/ata/libata-eh.c|2
drivers/block/virtio_blk.c |7 +
drivers/cpufreq/Kconfig.x86|2
drivers/cpufreq/acpi-cpufreq.c |7 +
drivers/dma/ioat/dma_v3.c |2
drivers/dma/tegra20-apb-dma.c |8 +
drivers/firmware/dmi_scan.c| 78 ---
drivers/gpu/drm/i915/i915_gem_execbuffer.c | 21
drivers/gpu/drm/i915/i915_reg.h|1
drivers/gpu/drm/i915/intel_pm.c|4
drivers/i2c/busses/i2c-mxs.c |2
drivers/idle/intel_idle.c |3
drivers/media/usb/gspca/kinect.c |1
drivers/misc/ti-st/st_kim.c| 37 +++
drivers/pci/hotplug/pciehp.h |2
drivers/pci/hotplug/pciehp_core.c | 11 --
drivers/pci/hotplug/pciehp_ctrl.c |8 -
drivers/pci/hotplug/pciehp_hpc.c | 11 +-
drivers/pci/hotplug/shpchp.h |3
drivers/pci/hotplug/shpchp_core.c | 35 ++
drivers/pci/hotplug/shpchp_ctrl.c |6 -
drivers/pci/pcie/aer/aerdrv_core.c |1
drivers/pci/pcie/aspm.c|3
drivers/scsi/sd.c | 13 +-
drivers/usb/dwc3/gadget.c |1
drivers/usb/gadget/f_fs.c |6 -
drivers/usb/host/uhci-hcd.c| 15 +-
drivers/usb/musb/cppi_dma.c|4
drivers/vfio/pci/vfio_pci_rdwr.c |4
include/linux/ata.h|8 -
include/linux/libata.h |4
include/linux/module.h | 10 -
include/linux/sched.h | 11 +-
init/do_mounts_initrd.c|4
init/main.c|4
kernel/async.c | 27 +++--
kernel/debug/kdb/kdb_main.c|2
kernel/module.c| 147 +++--
kernel/ptrace.c| 72 +++---
kernel/sched/core.c|3
kernel/signal.c| 19 +--
kernel/trace/ftrace.c |2
lib/bug.c |1
security/integrity/evm/evm_crypto.c|4
sound/pci/hda/patch_conexant.c |9 +
sound/pci/hda/patch_realtek.c |1
tools/perf/Makefile|2
56 files changed, 491 insertions(+), 208 deletions(-)
Al Viro (1):
make sure that /linuxrc has std{in,out,err}
Alan Stern (1):
USB: UHCI: fix IRQ race during initialization
Alex Williamson (1):
vfio-pci: Fix buffer overfill
Alexander Graf (1):
virtio-blk: Don't free ida when disk is in use
Benoit Goby (1):
usb: gadget: FunctionFS: Fix missing braces in parse_opts
Betty Dall (1):
PCI/AER: pci_get_domain_bus_and_slot() call missing required pci_dev_put()
Bian Yu (1):
libata: ahci: Fix lack of command retry after a success error handler.
Bjorn Helgaas (2):
PCI: shpchp: Handle push button event asynchronously
PCI: shpchp: Use per-slot workqueues to avoid deadlock
Borislav Petkov (1):
powernow-k8: Add a kconfig dependency on acpi-cpufreq
Chris Wilson (1):
drm/i915: Invalidate the relocation presumed_offsets along the slow path
Colin Ian King (1):
PCI: Allow pcie_aspm=force even when FADT indicates it is unsupported
Daniel Vetter (1):
drm/i915: Implement WaDisableHiZPlanesWhenMSAAEnabled
David Ahern (1):
perf x86: revert 20b279 - require exclude_guest to use PEBS - kernel side
David Henningsson (1):
ALSA: hda - Fix mute led for another HP machine
Dmitry Kasatkin (1):
evm: checking if removexattr is not a NULL
Fabio Estevam (1):
i2c: mxs: Fix type of error code
Greg Kroah-Hartman (1):
Linux 3.7.5
Hugh Daschbach (1):
libata: ahci: Add support for Enmotus Bobcat device.
Jacob Schloss (1):
media
Linux 3.7.5
I'm announcing the release of the 3.7.5 kernel.
All users of the 3.7 kernel series must upgrade.
The updated 3.7.y git tree can be found at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git
linux-3.7.y
and can be browsed at the normal kernel.org git web browser:
http://git.kernel.org/?p=linux/kernel/git/stable/linux-stable.git;a=summary
thanks,
greg k-h
Makefile |4
arch/arm64/include/asm/elf.h |5
arch/x86/kernel/cpu/perf_event.c |6 -
arch/x86/kernel/step.c |9 -
drivers/acpi/processor_idle.c |4
drivers/acpi/processor_perflib.c |7 +
drivers/ata/ahci.c |8 +
drivers/ata/libahci.c |6 -
drivers/ata/libata-core.c | 22 ++--
drivers/ata/libata-eh.c|2
drivers/block/virtio_blk.c |7 +
drivers/cpufreq/Kconfig.x86|2
drivers/cpufreq/acpi-cpufreq.c |7 +
drivers/dma/ioat/dma_v3.c |2
drivers/dma/tegra20-apb-dma.c |8 +
drivers/firmware/dmi_scan.c| 78 ---
drivers/gpu/drm/i915/i915_gem_execbuffer.c | 21
drivers/gpu/drm/i915/i915_reg.h|1
drivers/gpu/drm/i915/intel_pm.c|4
drivers/i2c/busses/i2c-mxs.c |2
drivers/idle/intel_idle.c |3
drivers/media/usb/gspca/kinect.c |1
drivers/misc/ti-st/st_kim.c| 37 +++
drivers/pci/hotplug/pciehp.h |2
drivers/pci/hotplug/pciehp_core.c | 11 --
drivers/pci/hotplug/pciehp_ctrl.c |8 -
drivers/pci/hotplug/pciehp_hpc.c | 11 +-
drivers/pci/hotplug/shpchp.h |3
drivers/pci/hotplug/shpchp_core.c | 35 ++
drivers/pci/hotplug/shpchp_ctrl.c |6 -
drivers/pci/pcie/aer/aerdrv_core.c |1
drivers/pci/pcie/aspm.c|3
drivers/scsi/sd.c | 13 +-
drivers/usb/dwc3/gadget.c |1
drivers/usb/gadget/f_fs.c |6 -
drivers/usb/host/uhci-hcd.c| 15 +-
drivers/usb/musb/cppi_dma.c|4
drivers/vfio/pci/vfio_pci_rdwr.c |4
include/linux/ata.h|8 -
include/linux/libata.h |4
include/linux/module.h | 10 -
include/linux/sched.h | 11 +-
init/do_mounts_initrd.c|4
init/main.c|4
kernel/async.c | 27 +++--
kernel/debug/kdb/kdb_main.c|2
kernel/module.c| 147 +++--
kernel/ptrace.c| 72 +++---
kernel/sched/core.c|3
kernel/signal.c| 19 +--
kernel/trace/ftrace.c |2
lib/bug.c |1
security/integrity/evm/evm_crypto.c|4
sound/pci/hda/patch_conexant.c |9 +
sound/pci/hda/patch_realtek.c |1
tools/perf/Makefile|2
56 files changed, 491 insertions(+), 208 deletions(-)
Al Viro (1):
make sure that /linuxrc has std{in,out,err}
Alan Stern (1):
USB: UHCI: fix IRQ race during initialization
Alex Williamson (1):
vfio-pci: Fix buffer overfill
Alexander Graf (1):
virtio-blk: Don't free ida when disk is in use
Benoit Goby (1):
usb: gadget: FunctionFS: Fix missing braces in parse_opts
Betty Dall (1):
PCI/AER: pci_get_domain_bus_and_slot() call missing required pci_dev_put()
Bian Yu (1):
libata: ahci: Fix lack of command retry after a success error handler.
Bjorn Helgaas (2):
PCI: shpchp: Handle push button event asynchronously
PCI: shpchp: Use per-slot workqueues to avoid deadlock
Borislav Petkov (1):
powernow-k8: Add a kconfig dependency on acpi-cpufreq
Chris Wilson (1):
drm/i915: Invalidate the relocation presumed_offsets along the slow path
Colin Ian King (1):
PCI: Allow pcie_aspm=force even when FADT indicates it is unsupported
Daniel Vetter (1):
drm/i915: Implement WaDisableHiZPlanesWhenMSAAEnabled
David Ahern (1):
perf x86: revert 20b279 - require exclude_guest to use PEBS - kernel side
David Henningsson (1):
ALSA: hda - Fix mute led for another HP machine
Dmitry Kasatkin (1):
evm: checking if removexattr is not a NULL
Fabio Estevam (1):
i2c: mxs: Fix type of error code
Greg Kroah-Hartman (1):
Linux 3.7.5
Hugh Daschbach (1):
libata: ahci: Add support for Enmotus Bobcat device.
Jacob Schloss (1):
media
