Re: Linux 4.18-rc6
On Wed, 25 Jul 2018 12:40:26 -0700 Kees Cook wrote: > On Tue, Jul 24, 2018 at 12:24 AM, Martin Schwidefsky > wrote: > > On Tue, 24 Jul 2018 09:15:58 +0200 > > Christian Borntraeger wrote: > > > >> On 07/24/2018 08:18 AM, Martin Schwidefsky wrote: > >> > On Mon, 23 Jul 2018 16:17:22 -0700 > >> > Linus Torvalds wrote: > >> > > >> >> On Mon, Jul 23, 2018 at 2:23 PM Guenter Roeck > >> >> wrote: > >> >>> > >> > >> Martin - can we just remove the > >> > >> select HAVE_GCC_PLUGINS > >> > >> from the s390 Kconfig file (or perhaps add "if BROKEN" or something to > >> disable it). > >> > >> Because if it's not getting fixed, it shouldn't be exposed. > >> > >> >>> The problem only affects 4.18 - the code has been rearranged in -next. > >> >>> Only, in my builders, I can't disable a flag for individual releases, > >> >>> so I just disabled it completely for s390. > >> >> > >> >> Well, I'm not going to release a 4.18 with a known problem, so in 4.18 > >> >> this *will* be disabled if it's not fixed. > >> >> > >> >> The fact that it might be fixed in linux-next is entirely immaterial > >> >> to the release of 4.18. > >> > > >> > Ok, if gcc with the plugins and an allmodconfig is considered to be > >> > important enough to warrant a fix, it can be pulled from here: > >> > > >> > git://git.kernel.org/pub/scm/linux/kernel/git/s390/linux.git for-linus > >> > > >> > Martin Schwidefsky (1): > >> > s390: disable gcc plugins > >> > > >> > Once that is in I will create another patch to undo this one and place > >> > it after the early boot rework. > >> > >> On the list a different fix was proposed about 2 weeks ago, > > https://lkml.kernel.org/r/cagxu5jkyesypd1mym7brvfpkdy9+hqrcpxckg5ikczwdgzl...@mail.gmail.com > > >> > >> something like > >> > >> CFLAGS_als.o += $(DISABLE_LATENT_ENTROPY_PLUGIN) > >> > >> and I prefer that. Because your patch disables all gcc plugins. > > > > This change would cause trouble with patch dependencies as als.c is moved > > to a different directory. I would prefer to disable all gcc plugins for > > 4.18. > > I don't understand why not just add it to the Makefile. For -next and > 4.19, just drop the line again once you merge with 4.18? A CFLAGS_*.o > entry for a file that doesn't exist should be harmless... > > Of course, if no one is actually using the gcc plugins on s390, then > okay, disabling them isn't a problem. :) But since it's been working > on s390 since 4.15, it seems weird to turn all of them off just for > 4.18 when a trivial fix is available. The gcc plugins have not in wide-spread use, it is no problem to just disable them all. The advantage doing the fixing with the Kconfig file is that I avoid a merge conflict with the current features branch. And I do not want to rebase that branch this late in the -rcs just because of this problem. -- blue skies, Martin. "Reality continues to ruin my life." - Calvin.
Re: Linux 4.18-rc6
On Wed, 25 Jul 2018 12:40:26 -0700 Kees Cook wrote: > On Tue, Jul 24, 2018 at 12:24 AM, Martin Schwidefsky > wrote: > > On Tue, 24 Jul 2018 09:15:58 +0200 > > Christian Borntraeger wrote: > > > >> On 07/24/2018 08:18 AM, Martin Schwidefsky wrote: > >> > On Mon, 23 Jul 2018 16:17:22 -0700 > >> > Linus Torvalds wrote: > >> > > >> >> On Mon, Jul 23, 2018 at 2:23 PM Guenter Roeck > >> >> wrote: > >> >>> > >> > >> Martin - can we just remove the > >> > >> select HAVE_GCC_PLUGINS > >> > >> from the s390 Kconfig file (or perhaps add "if BROKEN" or something to > >> disable it). > >> > >> Because if it's not getting fixed, it shouldn't be exposed. > >> > >> >>> The problem only affects 4.18 - the code has been rearranged in -next. > >> >>> Only, in my builders, I can't disable a flag for individual releases, > >> >>> so I just disabled it completely for s390. > >> >> > >> >> Well, I'm not going to release a 4.18 with a known problem, so in 4.18 > >> >> this *will* be disabled if it's not fixed. > >> >> > >> >> The fact that it might be fixed in linux-next is entirely immaterial > >> >> to the release of 4.18. > >> > > >> > Ok, if gcc with the plugins and an allmodconfig is considered to be > >> > important enough to warrant a fix, it can be pulled from here: > >> > > >> > git://git.kernel.org/pub/scm/linux/kernel/git/s390/linux.git for-linus > >> > > >> > Martin Schwidefsky (1): > >> > s390: disable gcc plugins > >> > > >> > Once that is in I will create another patch to undo this one and place > >> > it after the early boot rework. > >> > >> On the list a different fix was proposed about 2 weeks ago, > > https://lkml.kernel.org/r/cagxu5jkyesypd1mym7brvfpkdy9+hqrcpxckg5ikczwdgzl...@mail.gmail.com > > >> > >> something like > >> > >> CFLAGS_als.o += $(DISABLE_LATENT_ENTROPY_PLUGIN) > >> > >> and I prefer that. Because your patch disables all gcc plugins. > > > > This change would cause trouble with patch dependencies as als.c is moved > > to a different directory. I would prefer to disable all gcc plugins for > > 4.18. > > I don't understand why not just add it to the Makefile. For -next and > 4.19, just drop the line again once you merge with 4.18? A CFLAGS_*.o > entry for a file that doesn't exist should be harmless... > > Of course, if no one is actually using the gcc plugins on s390, then > okay, disabling them isn't a problem. :) But since it's been working > on s390 since 4.15, it seems weird to turn all of them off just for > 4.18 when a trivial fix is available. The gcc plugins have not in wide-spread use, it is no problem to just disable them all. The advantage doing the fixing with the Kconfig file is that I avoid a merge conflict with the current features branch. And I do not want to rebase that branch this late in the -rcs just because of this problem. -- blue skies, Martin. "Reality continues to ruin my life." - Calvin.
Re: Linux 4.18-rc6
On Tue, Jul 24, 2018 at 12:24 AM, Martin Schwidefsky wrote: > On Tue, 24 Jul 2018 09:15:58 +0200 > Christian Borntraeger wrote: > >> On 07/24/2018 08:18 AM, Martin Schwidefsky wrote: >> > On Mon, 23 Jul 2018 16:17:22 -0700 >> > Linus Torvalds wrote: >> > >> >> On Mon, Jul 23, 2018 at 2:23 PM Guenter Roeck wrote: >> >>> >> >> Martin - can we just remove the >> >> select HAVE_GCC_PLUGINS >> >> from the s390 Kconfig file (or perhaps add "if BROKEN" or something to >> disable it). >> >> Because if it's not getting fixed, it shouldn't be exposed. >> >> >>> The problem only affects 4.18 - the code has been rearranged in -next. >> >>> Only, in my builders, I can't disable a flag for individual releases, >> >>> so I just disabled it completely for s390. >> >> >> >> Well, I'm not going to release a 4.18 with a known problem, so in 4.18 >> >> this *will* be disabled if it's not fixed. >> >> >> >> The fact that it might be fixed in linux-next is entirely immaterial >> >> to the release of 4.18. >> > >> > Ok, if gcc with the plugins and an allmodconfig is considered to be >> > important enough to warrant a fix, it can be pulled from here: >> > >> > git://git.kernel.org/pub/scm/linux/kernel/git/s390/linux.git for-linus >> > >> > Martin Schwidefsky (1): >> > s390: disable gcc plugins >> > >> > Once that is in I will create another patch to undo this one and place >> > it after the early boot rework. >> >> On the list a different fix was proposed about 2 weeks ago, https://lkml.kernel.org/r/cagxu5jkyesypd1mym7brvfpkdy9+hqrcpxckg5ikczwdgzl...@mail.gmail.com >> >> something like >> >> CFLAGS_als.o += $(DISABLE_LATENT_ENTROPY_PLUGIN) >> >> and I prefer that. Because your patch disables all gcc plugins. > > This change would cause trouble with patch dependencies as als.c is moved > to a different directory. I would prefer to disable all gcc plugins for > 4.18. I don't understand why not just add it to the Makefile. For -next and 4.19, just drop the line again once you merge with 4.18? A CFLAGS_*.o entry for a file that doesn't exist should be harmless... Of course, if no one is actually using the gcc plugins on s390, then okay, disabling them isn't a problem. :) But since it's been working on s390 since 4.15, it seems weird to turn all of them off just for 4.18 when a trivial fix is available. -Kees -- Kees Cook Pixel Security
Re: Linux 4.18-rc6
On Tue, Jul 24, 2018 at 12:24 AM, Martin Schwidefsky wrote: > On Tue, 24 Jul 2018 09:15:58 +0200 > Christian Borntraeger wrote: > >> On 07/24/2018 08:18 AM, Martin Schwidefsky wrote: >> > On Mon, 23 Jul 2018 16:17:22 -0700 >> > Linus Torvalds wrote: >> > >> >> On Mon, Jul 23, 2018 at 2:23 PM Guenter Roeck wrote: >> >>> >> >> Martin - can we just remove the >> >> select HAVE_GCC_PLUGINS >> >> from the s390 Kconfig file (or perhaps add "if BROKEN" or something to >> disable it). >> >> Because if it's not getting fixed, it shouldn't be exposed. >> >> >>> The problem only affects 4.18 - the code has been rearranged in -next. >> >>> Only, in my builders, I can't disable a flag for individual releases, >> >>> so I just disabled it completely for s390. >> >> >> >> Well, I'm not going to release a 4.18 with a known problem, so in 4.18 >> >> this *will* be disabled if it's not fixed. >> >> >> >> The fact that it might be fixed in linux-next is entirely immaterial >> >> to the release of 4.18. >> > >> > Ok, if gcc with the plugins and an allmodconfig is considered to be >> > important enough to warrant a fix, it can be pulled from here: >> > >> > git://git.kernel.org/pub/scm/linux/kernel/git/s390/linux.git for-linus >> > >> > Martin Schwidefsky (1): >> > s390: disable gcc plugins >> > >> > Once that is in I will create another patch to undo this one and place >> > it after the early boot rework. >> >> On the list a different fix was proposed about 2 weeks ago, https://lkml.kernel.org/r/cagxu5jkyesypd1mym7brvfpkdy9+hqrcpxckg5ikczwdgzl...@mail.gmail.com >> >> something like >> >> CFLAGS_als.o += $(DISABLE_LATENT_ENTROPY_PLUGIN) >> >> and I prefer that. Because your patch disables all gcc plugins. > > This change would cause trouble with patch dependencies as als.c is moved > to a different directory. I would prefer to disable all gcc plugins for > 4.18. I don't understand why not just add it to the Makefile. For -next and 4.19, just drop the line again once you merge with 4.18? A CFLAGS_*.o entry for a file that doesn't exist should be harmless... Of course, if no one is actually using the gcc plugins on s390, then okay, disabling them isn't a problem. :) But since it's been working on s390 since 4.15, it seems weird to turn all of them off just for 4.18 when a trivial fix is available. -Kees -- Kees Cook Pixel Security
Re: Linux 4.18-rc6
On 07/24/2018 09:24 AM, Martin Schwidefsky wrote: > On Tue, 24 Jul 2018 09:15:58 +0200 > Christian Borntraeger wrote: > >> On 07/24/2018 08:18 AM, Martin Schwidefsky wrote: >>> On Mon, 23 Jul 2018 16:17:22 -0700 >>> Linus Torvalds wrote: >>> On Mon, Jul 23, 2018 at 2:23 PM Guenter Roeck wrote: > >> >> Martin - can we just remove the >> >> select HAVE_GCC_PLUGINS >> >> from the s390 Kconfig file (or perhaps add "if BROKEN" or something to >> disable it). >> >> Because if it's not getting fixed, it shouldn't be exposed. >> > The problem only affects 4.18 - the code has been rearranged in -next. > Only, in my builders, I can't disable a flag for individual releases, > so I just disabled it completely for s390. Well, I'm not going to release a 4.18 with a known problem, so in 4.18 this *will* be disabled if it's not fixed. The fact that it might be fixed in linux-next is entirely immaterial to the release of 4.18. >>> >>> Ok, if gcc with the plugins and an allmodconfig is considered to be >>> important enough to warrant a fix, it can be pulled from here: >>> >>> git://git.kernel.org/pub/scm/linux/kernel/git/s390/linux.git for-linus >>> >>> Martin Schwidefsky (1): >>> s390: disable gcc plugins >>> >>> Once that is in I will create another patch to undo this one and place >>> it after the early boot rework. >> >> On the list a different fix was proposed about 2 weeks ago, >> >> something like >> >> CFLAGS_als.o += $(DISABLE_LATENT_ENTROPY_PLUGIN) >> >> and I prefer that. Because your patch disables all gcc plugins. > > This change would cause trouble with patch dependencies as als.c is moved > to a different directory. I would prefer to disable all gcc plugins for > 4.18. ok.
Re: Linux 4.18-rc6
On 07/24/2018 09:24 AM, Martin Schwidefsky wrote: > On Tue, 24 Jul 2018 09:15:58 +0200 > Christian Borntraeger wrote: > >> On 07/24/2018 08:18 AM, Martin Schwidefsky wrote: >>> On Mon, 23 Jul 2018 16:17:22 -0700 >>> Linus Torvalds wrote: >>> On Mon, Jul 23, 2018 at 2:23 PM Guenter Roeck wrote: > >> >> Martin - can we just remove the >> >> select HAVE_GCC_PLUGINS >> >> from the s390 Kconfig file (or perhaps add "if BROKEN" or something to >> disable it). >> >> Because if it's not getting fixed, it shouldn't be exposed. >> > The problem only affects 4.18 - the code has been rearranged in -next. > Only, in my builders, I can't disable a flag for individual releases, > so I just disabled it completely for s390. Well, I'm not going to release a 4.18 with a known problem, so in 4.18 this *will* be disabled if it's not fixed. The fact that it might be fixed in linux-next is entirely immaterial to the release of 4.18. >>> >>> Ok, if gcc with the plugins and an allmodconfig is considered to be >>> important enough to warrant a fix, it can be pulled from here: >>> >>> git://git.kernel.org/pub/scm/linux/kernel/git/s390/linux.git for-linus >>> >>> Martin Schwidefsky (1): >>> s390: disable gcc plugins >>> >>> Once that is in I will create another patch to undo this one and place >>> it after the early boot rework. >> >> On the list a different fix was proposed about 2 weeks ago, >> >> something like >> >> CFLAGS_als.o += $(DISABLE_LATENT_ENTROPY_PLUGIN) >> >> and I prefer that. Because your patch disables all gcc plugins. > > This change would cause trouble with patch dependencies as als.c is moved > to a different directory. I would prefer to disable all gcc plugins for > 4.18. ok.
Re: Linux 4.18-rc6
On Tue, 24 Jul 2018 09:15:58 +0200 Christian Borntraeger wrote: > On 07/24/2018 08:18 AM, Martin Schwidefsky wrote: > > On Mon, 23 Jul 2018 16:17:22 -0700 > > Linus Torvalds wrote: > > > >> On Mon, Jul 23, 2018 at 2:23 PM Guenter Roeck wrote: > >>> > > Martin - can we just remove the > > select HAVE_GCC_PLUGINS > > from the s390 Kconfig file (or perhaps add "if BROKEN" or something to > disable it). > > Because if it's not getting fixed, it shouldn't be exposed. > > >>> The problem only affects 4.18 - the code has been rearranged in -next. > >>> Only, in my builders, I can't disable a flag for individual releases, > >>> so I just disabled it completely for s390. > >> > >> Well, I'm not going to release a 4.18 with a known problem, so in 4.18 > >> this *will* be disabled if it's not fixed. > >> > >> The fact that it might be fixed in linux-next is entirely immaterial > >> to the release of 4.18. > > > > Ok, if gcc with the plugins and an allmodconfig is considered to be > > important enough to warrant a fix, it can be pulled from here: > > > > git://git.kernel.org/pub/scm/linux/kernel/git/s390/linux.git for-linus > > > > Martin Schwidefsky (1): > > s390: disable gcc plugins > > > > Once that is in I will create another patch to undo this one and place > > it after the early boot rework. > > On the list a different fix was proposed about 2 weeks ago, > > something like > > CFLAGS_als.o += $(DISABLE_LATENT_ENTROPY_PLUGIN) > > and I prefer that. Because your patch disables all gcc plugins. This change would cause trouble with patch dependencies as als.c is moved to a different directory. I would prefer to disable all gcc plugins for 4.18. -- blue skies, Martin. "Reality continues to ruin my life." - Calvin.
Re: Linux 4.18-rc6
On Tue, 24 Jul 2018 09:15:58 +0200 Christian Borntraeger wrote: > On 07/24/2018 08:18 AM, Martin Schwidefsky wrote: > > On Mon, 23 Jul 2018 16:17:22 -0700 > > Linus Torvalds wrote: > > > >> On Mon, Jul 23, 2018 at 2:23 PM Guenter Roeck wrote: > >>> > > Martin - can we just remove the > > select HAVE_GCC_PLUGINS > > from the s390 Kconfig file (or perhaps add "if BROKEN" or something to > disable it). > > Because if it's not getting fixed, it shouldn't be exposed. > > >>> The problem only affects 4.18 - the code has been rearranged in -next. > >>> Only, in my builders, I can't disable a flag for individual releases, > >>> so I just disabled it completely for s390. > >> > >> Well, I'm not going to release a 4.18 with a known problem, so in 4.18 > >> this *will* be disabled if it's not fixed. > >> > >> The fact that it might be fixed in linux-next is entirely immaterial > >> to the release of 4.18. > > > > Ok, if gcc with the plugins and an allmodconfig is considered to be > > important enough to warrant a fix, it can be pulled from here: > > > > git://git.kernel.org/pub/scm/linux/kernel/git/s390/linux.git for-linus > > > > Martin Schwidefsky (1): > > s390: disable gcc plugins > > > > Once that is in I will create another patch to undo this one and place > > it after the early boot rework. > > On the list a different fix was proposed about 2 weeks ago, > > something like > > CFLAGS_als.o += $(DISABLE_LATENT_ENTROPY_PLUGIN) > > and I prefer that. Because your patch disables all gcc plugins. This change would cause trouble with patch dependencies as als.c is moved to a different directory. I would prefer to disable all gcc plugins for 4.18. -- blue skies, Martin. "Reality continues to ruin my life." - Calvin.
Re: Linux 4.18-rc6
On 07/24/2018 08:18 AM, Martin Schwidefsky wrote: > On Mon, 23 Jul 2018 16:17:22 -0700 > Linus Torvalds wrote: > >> On Mon, Jul 23, 2018 at 2:23 PM Guenter Roeck wrote: >>> Martin - can we just remove the select HAVE_GCC_PLUGINS from the s390 Kconfig file (or perhaps add "if BROKEN" or something to disable it). Because if it's not getting fixed, it shouldn't be exposed. >>> The problem only affects 4.18 - the code has been rearranged in -next. >>> Only, in my builders, I can't disable a flag for individual releases, >>> so I just disabled it completely for s390. >> >> Well, I'm not going to release a 4.18 with a known problem, so in 4.18 >> this *will* be disabled if it's not fixed. >> >> The fact that it might be fixed in linux-next is entirely immaterial >> to the release of 4.18. > > Ok, if gcc with the plugins and an allmodconfig is considered to be > important enough to warrant a fix, it can be pulled from here: > > git://git.kernel.org/pub/scm/linux/kernel/git/s390/linux.git for-linus > > Martin Schwidefsky (1): > s390: disable gcc plugins > > Once that is in I will create another patch to undo this one and place > it after the early boot rework. On the list a different fix was proposed about 2 weeks ago, something like CFLAGS_als.o += $(DISABLE_LATENT_ENTROPY_PLUGIN) and I prefer that. Because your patch disables all gcc plugins.
Re: Linux 4.18-rc6
On 07/24/2018 08:18 AM, Martin Schwidefsky wrote: > On Mon, 23 Jul 2018 16:17:22 -0700 > Linus Torvalds wrote: > >> On Mon, Jul 23, 2018 at 2:23 PM Guenter Roeck wrote: >>> Martin - can we just remove the select HAVE_GCC_PLUGINS from the s390 Kconfig file (or perhaps add "if BROKEN" or something to disable it). Because if it's not getting fixed, it shouldn't be exposed. >>> The problem only affects 4.18 - the code has been rearranged in -next. >>> Only, in my builders, I can't disable a flag for individual releases, >>> so I just disabled it completely for s390. >> >> Well, I'm not going to release a 4.18 with a known problem, so in 4.18 >> this *will* be disabled if it's not fixed. >> >> The fact that it might be fixed in linux-next is entirely immaterial >> to the release of 4.18. > > Ok, if gcc with the plugins and an allmodconfig is considered to be > important enough to warrant a fix, it can be pulled from here: > > git://git.kernel.org/pub/scm/linux/kernel/git/s390/linux.git for-linus > > Martin Schwidefsky (1): > s390: disable gcc plugins > > Once that is in I will create another patch to undo this one and place > it after the early boot rework. On the list a different fix was proposed about 2 weeks ago, something like CFLAGS_als.o += $(DISABLE_LATENT_ENTROPY_PLUGIN) and I prefer that. Because your patch disables all gcc plugins.
Re: Linux 4.18-rc6
On Mon, 23 Jul 2018 16:17:22 -0700 Linus Torvalds wrote: > On Mon, Jul 23, 2018 at 2:23 PM Guenter Roeck wrote: > > > > > > > > Martin - can we just remove the > > > > > > select HAVE_GCC_PLUGINS > > > > > > from the s390 Kconfig file (or perhaps add "if BROKEN" or something to > > > disable it). > > > > > > Because if it's not getting fixed, it shouldn't be exposed. > > > > > The problem only affects 4.18 - the code has been rearranged in -next. > > Only, in my builders, I can't disable a flag for individual releases, > > so I just disabled it completely for s390. > > Well, I'm not going to release a 4.18 with a known problem, so in 4.18 > this *will* be disabled if it's not fixed. > > The fact that it might be fixed in linux-next is entirely immaterial > to the release of 4.18. Ok, if gcc with the plugins and an allmodconfig is considered to be important enough to warrant a fix, it can be pulled from here: git://git.kernel.org/pub/scm/linux/kernel/git/s390/linux.git for-linus Martin Schwidefsky (1): s390: disable gcc plugins Once that is in I will create another patch to undo this one and place it after the early boot rework. -- blue skies, Martin. "Reality continues to ruin my life." - Calvin.
Re: Linux 4.18-rc6
On Mon, 23 Jul 2018 16:17:22 -0700 Linus Torvalds wrote: > On Mon, Jul 23, 2018 at 2:23 PM Guenter Roeck wrote: > > > > > > > > Martin - can we just remove the > > > > > > select HAVE_GCC_PLUGINS > > > > > > from the s390 Kconfig file (or perhaps add "if BROKEN" or something to > > > disable it). > > > > > > Because if it's not getting fixed, it shouldn't be exposed. > > > > > The problem only affects 4.18 - the code has been rearranged in -next. > > Only, in my builders, I can't disable a flag for individual releases, > > so I just disabled it completely for s390. > > Well, I'm not going to release a 4.18 with a known problem, so in 4.18 > this *will* be disabled if it's not fixed. > > The fact that it might be fixed in linux-next is entirely immaterial > to the release of 4.18. Ok, if gcc with the plugins and an allmodconfig is considered to be important enough to warrant a fix, it can be pulled from here: git://git.kernel.org/pub/scm/linux/kernel/git/s390/linux.git for-linus Martin Schwidefsky (1): s390: disable gcc plugins Once that is in I will create another patch to undo this one and place it after the early boot rework. -- blue skies, Martin. "Reality continues to ruin my life." - Calvin.
Re: Linux 4.18-rc6
On Mon, Jul 23, 2018 at 2:23 PM Guenter Roeck wrote: > > > > > Martin - can we just remove the > > > > select HAVE_GCC_PLUGINS > > > > from the s390 Kconfig file (or perhaps add "if BROKEN" or something to > > disable it). > > > > Because if it's not getting fixed, it shouldn't be exposed. > > > The problem only affects 4.18 - the code has been rearranged in -next. > Only, in my builders, I can't disable a flag for individual releases, > so I just disabled it completely for s390. Well, I'm not going to release a 4.18 with a known problem, so in 4.18 this *will* be disabled if it's not fixed. The fact that it might be fixed in linux-next is entirely immaterial to the release of 4.18. Linus
Re: Linux 4.18-rc6
On Mon, Jul 23, 2018 at 2:23 PM Guenter Roeck wrote: > > > > > Martin - can we just remove the > > > > select HAVE_GCC_PLUGINS > > > > from the s390 Kconfig file (or perhaps add "if BROKEN" or something to > > disable it). > > > > Because if it's not getting fixed, it shouldn't be exposed. > > > The problem only affects 4.18 - the code has been rearranged in -next. > Only, in my builders, I can't disable a flag for individual releases, > so I just disabled it completely for s390. Well, I'm not going to release a 4.18 with a known problem, so in 4.18 this *will* be disabled if it's not fixed. The fact that it might be fixed in linux-next is entirely immaterial to the release of 4.18. Linus
Re: Linux 4.18-rc6
On Mon, Jul 23, 2018 at 2:23 PM Guenter Roeck wrote: > > My patch is also at > > https://patchwork.ozlabs.org/patch/937283/ Ah, ok, so that just adds the forward-declaration of 'struct page' in the right global namespace. Anyway, I'll just re-order the includes as I suggested, which I think is the right fix and makes the forward-declaration unnecessary (although not _wrong_) Linus
Re: Linux 4.18-rc6
On Mon, Jul 23, 2018 at 2:23 PM Guenter Roeck wrote: > > My patch is also at > > https://patchwork.ozlabs.org/patch/937283/ Ah, ok, so that just adds the forward-declaration of 'struct page' in the right global namespace. Anyway, I'll just re-order the includes as I suggested, which I think is the right fix and makes the forward-declaration unnecessary (although not _wrong_) Linus
Re: Linux 4.18-rc6
On Mon, Jul 23, 2018 at 01:56:15PM -0700, Linus Torvalds wrote: > Adding davem for the sparc issue, Martin for the s390 one. > > On Mon, Jul 23, 2018 at 1:46 PM Guenter Roeck wrote: > > > > The s390 gcc plugins related build error reported previously has not really > > been fixed; after feedback from the s390 maintainers, suggesting that it > > won't get fixed in 4.18, I disabled GCC_PLUGINS for s390 builds. This is > > not my preferred solution, but it beats not testing s390:allmodconfig > > builds at all. > > Martin - can we just remove the > > select HAVE_GCC_PLUGINS > > from the s390 Kconfig file (or perhaps add "if BROKEN" or something to > disable it). > > Because if it's not getting fixed, it shouldn't be exposed. > The problem only affects 4.18 - the code has been rearranged in -next. Only, in my builders, I can't disable a flag for individual releases, so I just disabled it completely for s390. > > The sparc32 build error is still: > > > > In file included from > > ... > > from drivers/staging/media/omap4iss/iss_video.c:15: > > include/linux/highmem.h: In function 'clear_user_highpage': > > include/linux/highmem.h:137:31: error: > > passing argument 1 of 'sparc_flush_page_to_ram' from incompatible > > pointer type > > > > due to a missing declaration of 'struct page', as previously reported. > > Hmm. I assume it's > > arch/sparc/include/asm/cacheflush_32.h > > that wants a forward-declaration of 'struct page', and doesn't include > any header files. > > The fix is presumably to move the > >#include > > in drivers/staging/media/omap4iss/iss_video.c down to below the > includes? > Good idea. > The old patchwork link you had for a fix no longer works, I think > because the patchwork database got re-generated during the upgrade > (and the patchwork numbering isn't stable). > Looks like they dropped lkml completely. Odd. My patch is also at https://patchwork.ozlabs.org/patch/937283/ Also, there is now another patch from Randy Dunlap, pretty much doing the same. https://patchwork.ozlabs.org/patch/947434/ I'll submit separate patches to address the include file ordering; it does make sense to do that. I'll do the same for android/binder.c; it has the same problem, only there it only generates a warning. Thanks, Guenter
Re: Linux 4.18-rc6
On Mon, Jul 23, 2018 at 01:56:15PM -0700, Linus Torvalds wrote: > Adding davem for the sparc issue, Martin for the s390 one. > > On Mon, Jul 23, 2018 at 1:46 PM Guenter Roeck wrote: > > > > The s390 gcc plugins related build error reported previously has not really > > been fixed; after feedback from the s390 maintainers, suggesting that it > > won't get fixed in 4.18, I disabled GCC_PLUGINS for s390 builds. This is > > not my preferred solution, but it beats not testing s390:allmodconfig > > builds at all. > > Martin - can we just remove the > > select HAVE_GCC_PLUGINS > > from the s390 Kconfig file (or perhaps add "if BROKEN" or something to > disable it). > > Because if it's not getting fixed, it shouldn't be exposed. > The problem only affects 4.18 - the code has been rearranged in -next. Only, in my builders, I can't disable a flag for individual releases, so I just disabled it completely for s390. > > The sparc32 build error is still: > > > > In file included from > > ... > > from drivers/staging/media/omap4iss/iss_video.c:15: > > include/linux/highmem.h: In function 'clear_user_highpage': > > include/linux/highmem.h:137:31: error: > > passing argument 1 of 'sparc_flush_page_to_ram' from incompatible > > pointer type > > > > due to a missing declaration of 'struct page', as previously reported. > > Hmm. I assume it's > > arch/sparc/include/asm/cacheflush_32.h > > that wants a forward-declaration of 'struct page', and doesn't include > any header files. > > The fix is presumably to move the > >#include > > in drivers/staging/media/omap4iss/iss_video.c down to below the > includes? > Good idea. > The old patchwork link you had for a fix no longer works, I think > because the patchwork database got re-generated during the upgrade > (and the patchwork numbering isn't stable). > Looks like they dropped lkml completely. Odd. My patch is also at https://patchwork.ozlabs.org/patch/937283/ Also, there is now another patch from Randy Dunlap, pretty much doing the same. https://patchwork.ozlabs.org/patch/947434/ I'll submit separate patches to address the include file ordering; it does make sense to do that. I'll do the same for android/binder.c; it has the same problem, only there it only generates a warning. Thanks, Guenter
Re: Linux 4.18-rc6
From: Linus Torvalds Date: Mon, 23 Jul 2018 13:56:15 -0700 > Hmm. I assume it's > > arch/sparc/include/asm/cacheflush_32.h > > that wants a forward-declaration of 'struct page', and doesn't include > any header files. > > The fix is presumably to move the > >#include > > in drivers/staging/media/omap4iss/iss_video.c down to below the > includes? > > The old patchwork link you had for a fix no longer works, I think > because the patchwork database got re-generated during the upgrade > (and the patchwork numbering isn't stable). I think modifying the include order in that driver is the best fix. BTW, here is a proper patchwork link in the SPARC project on ozlabs: http://patchwork.ozlabs.org/patch/947434/
Re: Linux 4.18-rc6
From: Linus Torvalds Date: Mon, 23 Jul 2018 13:56:15 -0700 > Hmm. I assume it's > > arch/sparc/include/asm/cacheflush_32.h > > that wants a forward-declaration of 'struct page', and doesn't include > any header files. > > The fix is presumably to move the > >#include > > in drivers/staging/media/omap4iss/iss_video.c down to below the > includes? > > The old patchwork link you had for a fix no longer works, I think > because the patchwork database got re-generated during the upgrade > (and the patchwork numbering isn't stable). I think modifying the include order in that driver is the best fix. BTW, here is a proper patchwork link in the SPARC project on ozlabs: http://patchwork.ozlabs.org/patch/947434/
Re: Linux 4.18-rc6
Adding davem for the sparc issue, Martin for the s390 one. On Mon, Jul 23, 2018 at 1:46 PM Guenter Roeck wrote: > > The s390 gcc plugins related build error reported previously has not really > been fixed; after feedback from the s390 maintainers, suggesting that it > won't get fixed in 4.18, I disabled GCC_PLUGINS for s390 builds. This is > not my preferred solution, but it beats not testing s390:allmodconfig > builds at all. Martin - can we just remove the select HAVE_GCC_PLUGINS from the s390 Kconfig file (or perhaps add "if BROKEN" or something to disable it). Because if it's not getting fixed, it shouldn't be exposed. > The sparc32 build error is still: > > In file included from > ... > from drivers/staging/media/omap4iss/iss_video.c:15: > include/linux/highmem.h: In function 'clear_user_highpage': > include/linux/highmem.h:137:31: error: > passing argument 1 of 'sparc_flush_page_to_ram' from incompatible > pointer type > > due to a missing declaration of 'struct page', as previously reported. Hmm. I assume it's arch/sparc/include/asm/cacheflush_32.h that wants a forward-declaration of 'struct page', and doesn't include any header files. The fix is presumably to move the #include in drivers/staging/media/omap4iss/iss_video.c down to below the includes? The old patchwork link you had for a fix no longer works, I think because the patchwork database got re-generated during the upgrade (and the patchwork numbering isn't stable). Davem? Linus
Re: Linux 4.18-rc6
Adding davem for the sparc issue, Martin for the s390 one. On Mon, Jul 23, 2018 at 1:46 PM Guenter Roeck wrote: > > The s390 gcc plugins related build error reported previously has not really > been fixed; after feedback from the s390 maintainers, suggesting that it > won't get fixed in 4.18, I disabled GCC_PLUGINS for s390 builds. This is > not my preferred solution, but it beats not testing s390:allmodconfig > builds at all. Martin - can we just remove the select HAVE_GCC_PLUGINS from the s390 Kconfig file (or perhaps add "if BROKEN" or something to disable it). Because if it's not getting fixed, it shouldn't be exposed. > The sparc32 build error is still: > > In file included from > ... > from drivers/staging/media/omap4iss/iss_video.c:15: > include/linux/highmem.h: In function 'clear_user_highpage': > include/linux/highmem.h:137:31: error: > passing argument 1 of 'sparc_flush_page_to_ram' from incompatible > pointer type > > due to a missing declaration of 'struct page', as previously reported. Hmm. I assume it's arch/sparc/include/asm/cacheflush_32.h that wants a forward-declaration of 'struct page', and doesn't include any header files. The fix is presumably to move the #include in drivers/staging/media/omap4iss/iss_video.c down to below the includes? The old patchwork link you had for a fix no longer works, I think because the patchwork database got re-generated during the upgrade (and the patchwork numbering isn't stable). Davem? Linus
Re: Linux 4.18-rc6
On Sun, Jul 22, 2018 at 02:23:39PM -0700, Linus Torvalds wrote: > So this was the week when the other shoe dropped ... The reason the > two previous rc releases were so nice and small was that David hadn't > sent me much networking fixes, and they came in this week. > Build results: total: 134 pass: 133 fail: 1 Failed builds: sparc32:allmodconfig Qemu test results: total: 172 pass: 172 fail: 0 The s390 gcc plugins related build error reported previously has not really been fixed; after feedback from the s390 maintainers, suggesting that it won't get fixed in 4.18, I disabled GCC_PLUGINS for s390 builds. This is not my preferred solution, but it beats not testing s390:allmodconfig builds at all. The sparc32 build error is still: In file included from ... from drivers/staging/media/omap4iss/iss_video.c:15: include/linux/highmem.h: In function 'clear_user_highpage': include/linux/highmem.h:137:31: error: passing argument 1 of 'sparc_flush_page_to_ram' from incompatible pointer type due to a missing declaration of 'struct page', as previously reported. Guenter
Re: Linux 4.18-rc6
On Sun, Jul 22, 2018 at 02:23:39PM -0700, Linus Torvalds wrote: > So this was the week when the other shoe dropped ... The reason the > two previous rc releases were so nice and small was that David hadn't > sent me much networking fixes, and they came in this week. > Build results: total: 134 pass: 133 fail: 1 Failed builds: sparc32:allmodconfig Qemu test results: total: 172 pass: 172 fail: 0 The s390 gcc plugins related build error reported previously has not really been fixed; after feedback from the s390 maintainers, suggesting that it won't get fixed in 4.18, I disabled GCC_PLUGINS for s390 builds. This is not my preferred solution, but it beats not testing s390:allmodconfig builds at all. The sparc32 build error is still: In file included from ... from drivers/staging/media/omap4iss/iss_video.c:15: include/linux/highmem.h: In function 'clear_user_highpage': include/linux/highmem.h:137:31: error: passing argument 1 of 'sparc_flush_page_to_ram' from incompatible pointer type due to a missing declaration of 'struct page', as previously reported. Guenter
Linux 4.18-rc6
ibmvnic: Fix error recovery on login failure John Fastabend (6): bpf: sockmap, error path can not release psock in multi-map case bpf: sockmap, hash table is RCU so readers do not need locks bpf: fix sk_skb programs without skb->dev assigned bpf: sockhash, disallow bpf_tcp_close and update in parallel bpf: sockmap, consume_skb in close path bpf: sockmap, convert bpf_compute_data_pointers to bpf_*_sk_skb Jon Maloy (4): tipc: fix wrong return value from function tipc_node_try_addr() tipc: correct discovery message handling during address trial period tipc: fix correct setting of message type in second discoverer tipc: make function tipc_net_finalize() thread safe Jonathan Neuschäfer (1): dt-bindings: Fix unbalanced quotation marks Juri Lelli (1): sched/deadline: Fix switched_from_dl() warning Karsten Graul (1): net/smc: reset recv timeout after clc handshake Keith Busch (1): nvme-pci: fix memory leak on probe failure Kishon Vijay Abraham I (1): PCI: endpoint: Fix NULL pointer dereference error when CONFIGFS is disabled Krzysztof Kozlowski (1): MAINTAINERS: Drop inactive Vitaly Bordug's email Lan Tianyu (1): KVM/Eventfd: Avoid crash when assign and deassign specific eventfd in parallel. Leo Liu (1): drm/amdgpu: Make sure IB tests flushed after IP resume Linus Lüssing (2): batman-adv: Avoid storing non-TT-sync flags on singular entries too batman-adv: Fix multicast TT issues with bogus ROAM flags Linus Torvalds (5): Mark HI and TASKLET softirq synchronous mm: use helper functions for allocating and freeing vm_area structs mm: make vm_area_dup() actually copy the old vma data mm: make vm_area_alloc() initialize core fields Linux 4.18-rc6 Liran Alon (1): KVM: VMX: Mark VMXArea with revision_id of physical CPU even when eVMCS enabled Lorenzo Colitti (1): net: diag: Don't double-free TCP_NEW_SYN_RECV sockets in tcp_abort Lu Baolu (1): Revert "iommu/vt-d: Clean up pasid quirk for pre-production devices" Lubomir Rintel (1): ieee802154: 6lowpan: set IFLA_LINK Luc Van Oostenryck (1): nds32: define __NDS32_E[BL]__ for sparse Lyude Paul (5): drm/nouveau: Use drm_connector_list_iter_* for iterating connectors drm/nouveau: Avoid looping through fake MST connectors drm/nouveau/drm/nouveau: Fix runtime PM leak in nv50_disp_atomic_commit() drm/nouveau: Remove bogus crtc check in pmops_runtime_idle drm/nouveau: Set DRIVER_ATOMIC cap earlier to fix debugfs Magnus Karlsson (8): xsk: fix potential lost completion message in SKB path xsk: frame could be completed more than once in SKB path samples/bpf: deal with EBUSY return code from sendmsg in xdpsock sample xsk: fix potential race in SKB TX completion code xsk: do not return ENXIO from TX copy mode xsk: do not return EAGAIN from sendmsg when completion queue is full xsk: always return ENOBUFS from sendmsg if there is no TX queue xsk: do not return EMSGSIZE in copy mode for packets larger than MTU Manish Rangankar (1): scsi: qedi: Send driver state to MFW Masanari Iida (1): bonding: Fix a typo in bonding.txt Matevz Vucnik (1): qmi_wwan: add support for Quectel EG91 Mathieu Malaterre (1): mm/memblock: add missing include Mathieu Xhonneux (1): bpf: fix availability probing for seg6 helpers Mauricio Vasquez B (1): bpf: hash map: decrement counter on error Mauro Carvalho Chehab (2): networking: e100.rst: Get rid of Sphinx warnings networking: e1000.rst: Get rid of Sphinx warnings Michael Chan (4): bnxt_en: Fix inconsistent BNXT_FLAG_AGG_RINGS logic. bnxt_en: Always set output parameters in bnxt_get_max_rings(). bnxt_en: Support clearing of the IFF_BROADCAST flag. bnxt_en: Do not modify max IRQ count after RDMA driver requests/frees IRQs. Michael Ellerman (1): powerpc/xmon: Fix disassembly since printf changes Michael Heimpold (1): net: ethtool: fix spelling mistake: "tubale" -> "tunable" Michael Hennerich (2): net: ieee802154: adf7242: Fix erroneous RX enable net: ieee802154: adf7242: Fix OCL calibration runs Michael Trimarchi (1): brcmfmac: stop watchdog before detach and free everything Michel Dänzer (1): drm/amdgpu: Reserve VM root shared fence slot for command submission (v3) Mikko Perttunen (1): drm/tegra: Fix comparison operator for buffer size Mikulas Patocka (1): dm writecache: support optional offset for start of device Máté Eckl (1): netfilter: nf_tproxy: fix possible non-linear access to transport header Naohiro Aota (1): btrfs: fix use-after-free of cmp workspace pages Nicholas Mc Guire (1): liquidio: make timeout HZ independent and readable Niklas Söderlund (1): pinctrl: sh-pfc: r8a77970: remove SH_P
Linux 4.18-rc6
ibmvnic: Fix error recovery on login failure John Fastabend (6): bpf: sockmap, error path can not release psock in multi-map case bpf: sockmap, hash table is RCU so readers do not need locks bpf: fix sk_skb programs without skb->dev assigned bpf: sockhash, disallow bpf_tcp_close and update in parallel bpf: sockmap, consume_skb in close path bpf: sockmap, convert bpf_compute_data_pointers to bpf_*_sk_skb Jon Maloy (4): tipc: fix wrong return value from function tipc_node_try_addr() tipc: correct discovery message handling during address trial period tipc: fix correct setting of message type in second discoverer tipc: make function tipc_net_finalize() thread safe Jonathan Neuschäfer (1): dt-bindings: Fix unbalanced quotation marks Juri Lelli (1): sched/deadline: Fix switched_from_dl() warning Karsten Graul (1): net/smc: reset recv timeout after clc handshake Keith Busch (1): nvme-pci: fix memory leak on probe failure Kishon Vijay Abraham I (1): PCI: endpoint: Fix NULL pointer dereference error when CONFIGFS is disabled Krzysztof Kozlowski (1): MAINTAINERS: Drop inactive Vitaly Bordug's email Lan Tianyu (1): KVM/Eventfd: Avoid crash when assign and deassign specific eventfd in parallel. Leo Liu (1): drm/amdgpu: Make sure IB tests flushed after IP resume Linus Lüssing (2): batman-adv: Avoid storing non-TT-sync flags on singular entries too batman-adv: Fix multicast TT issues with bogus ROAM flags Linus Torvalds (5): Mark HI and TASKLET softirq synchronous mm: use helper functions for allocating and freeing vm_area structs mm: make vm_area_dup() actually copy the old vma data mm: make vm_area_alloc() initialize core fields Linux 4.18-rc6 Liran Alon (1): KVM: VMX: Mark VMXArea with revision_id of physical CPU even when eVMCS enabled Lorenzo Colitti (1): net: diag: Don't double-free TCP_NEW_SYN_RECV sockets in tcp_abort Lu Baolu (1): Revert "iommu/vt-d: Clean up pasid quirk for pre-production devices" Lubomir Rintel (1): ieee802154: 6lowpan: set IFLA_LINK Luc Van Oostenryck (1): nds32: define __NDS32_E[BL]__ for sparse Lyude Paul (5): drm/nouveau: Use drm_connector_list_iter_* for iterating connectors drm/nouveau: Avoid looping through fake MST connectors drm/nouveau/drm/nouveau: Fix runtime PM leak in nv50_disp_atomic_commit() drm/nouveau: Remove bogus crtc check in pmops_runtime_idle drm/nouveau: Set DRIVER_ATOMIC cap earlier to fix debugfs Magnus Karlsson (8): xsk: fix potential lost completion message in SKB path xsk: frame could be completed more than once in SKB path samples/bpf: deal with EBUSY return code from sendmsg in xdpsock sample xsk: fix potential race in SKB TX completion code xsk: do not return ENXIO from TX copy mode xsk: do not return EAGAIN from sendmsg when completion queue is full xsk: always return ENOBUFS from sendmsg if there is no TX queue xsk: do not return EMSGSIZE in copy mode for packets larger than MTU Manish Rangankar (1): scsi: qedi: Send driver state to MFW Masanari Iida (1): bonding: Fix a typo in bonding.txt Matevz Vucnik (1): qmi_wwan: add support for Quectel EG91 Mathieu Malaterre (1): mm/memblock: add missing include Mathieu Xhonneux (1): bpf: fix availability probing for seg6 helpers Mauricio Vasquez B (1): bpf: hash map: decrement counter on error Mauro Carvalho Chehab (2): networking: e100.rst: Get rid of Sphinx warnings networking: e1000.rst: Get rid of Sphinx warnings Michael Chan (4): bnxt_en: Fix inconsistent BNXT_FLAG_AGG_RINGS logic. bnxt_en: Always set output parameters in bnxt_get_max_rings(). bnxt_en: Support clearing of the IFF_BROADCAST flag. bnxt_en: Do not modify max IRQ count after RDMA driver requests/frees IRQs. Michael Ellerman (1): powerpc/xmon: Fix disassembly since printf changes Michael Heimpold (1): net: ethtool: fix spelling mistake: "tubale" -> "tunable" Michael Hennerich (2): net: ieee802154: adf7242: Fix erroneous RX enable net: ieee802154: adf7242: Fix OCL calibration runs Michael Trimarchi (1): brcmfmac: stop watchdog before detach and free everything Michel Dänzer (1): drm/amdgpu: Reserve VM root shared fence slot for command submission (v3) Mikko Perttunen (1): drm/tegra: Fix comparison operator for buffer size Mikulas Patocka (1): dm writecache: support optional offset for start of device Máté Eckl (1): netfilter: nf_tproxy: fix possible non-linear access to transport header Naohiro Aota (1): btrfs: fix use-after-free of cmp workspace pages Nicholas Mc Guire (1): liquidio: make timeout HZ independent and readable Niklas Söderlund (1): pinctrl: sh-pfc: r8a77970: remove SH_P
[GIT PULL] KVM fixes for Linux 4.18-rc6
Linus, The following changes since commit 786b71f5b754273ccef6d9462e52062b3e1f9877: Merge tag 'nds32-for-linus-4.17-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/greentime/linux (2018-05-28 05:25:57 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/virt/kvm/kvm.git tags/for-linus for you to fetch changes up to 3a9706d9e077e4a264a5cf4045da04200b93228f: kvmclock: fix nested guest always in tsc_early clocksource (2018-07-18 11:31:29 +0200) Miscellaneous bugfixes, plus a small patchlet related to Spectre v2. Janakarajan Natarajan (1): x86/kvm/Kconfig: Ensure CRYPTO_DEV_CCP_DD state at minimum matches KVM_AMD Jim Mattson (1): kvm: nVMX: Restore exit qual for VM-entry failure due to MSR loading Lan Tianyu (1): KVM/Eventfd: Avoid crash when assign and deassign specific eventfd in parallel. Liran Alon (1): KVM: VMX: Mark VMXArea with revision_id of physical CPU even when eVMCS enabled Paolo Bonzini (2): KVM: VMX: support MSR_IA32_ARCH_CAPABILITIES as a feature MSR KVM: irqfd: fix race between EPOLLHUP and irq_bypass_register_consumer Peng Hao (1): kvmclock: fix nested guest always in tsc_early clocksource Radim Krčmář (1): x86/kvmclock: set pvti_cpu0_va after enabling kvmclock Vitaly Kuznetsov (1): x86/kvm/vmx: don't read current->thread.{fs,gs}base of legacy tasks arch/x86/kernel/kvmclock.c | 12 - arch/x86/kvm/Kconfig | 2 +- arch/x86/kvm/vmx.c | 61 +++--- arch/x86/kvm/x86.c | 4 ++- virt/kvm/eventfd.c | 17 - 5 files changed, 63 insertions(+), 33 deletions(-)
[GIT PULL] KVM fixes for Linux 4.18-rc6
Linus, The following changes since commit 786b71f5b754273ccef6d9462e52062b3e1f9877: Merge tag 'nds32-for-linus-4.17-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/greentime/linux (2018-05-28 05:25:57 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/virt/kvm/kvm.git tags/for-linus for you to fetch changes up to 3a9706d9e077e4a264a5cf4045da04200b93228f: kvmclock: fix nested guest always in tsc_early clocksource (2018-07-18 11:31:29 +0200) Miscellaneous bugfixes, plus a small patchlet related to Spectre v2. Janakarajan Natarajan (1): x86/kvm/Kconfig: Ensure CRYPTO_DEV_CCP_DD state at minimum matches KVM_AMD Jim Mattson (1): kvm: nVMX: Restore exit qual for VM-entry failure due to MSR loading Lan Tianyu (1): KVM/Eventfd: Avoid crash when assign and deassign specific eventfd in parallel. Liran Alon (1): KVM: VMX: Mark VMXArea with revision_id of physical CPU even when eVMCS enabled Paolo Bonzini (2): KVM: VMX: support MSR_IA32_ARCH_CAPABILITIES as a feature MSR KVM: irqfd: fix race between EPOLLHUP and irq_bypass_register_consumer Peng Hao (1): kvmclock: fix nested guest always in tsc_early clocksource Radim Krčmář (1): x86/kvmclock: set pvti_cpu0_va after enabling kvmclock Vitaly Kuznetsov (1): x86/kvm/vmx: don't read current->thread.{fs,gs}base of legacy tasks arch/x86/kernel/kvmclock.c | 12 - arch/x86/kvm/Kconfig | 2 +- arch/x86/kvm/vmx.c | 61 +++--- arch/x86/kvm/x86.c | 4 ++- virt/kvm/eventfd.c | 17 - 5 files changed, 63 insertions(+), 33 deletions(-)