Re: Linux 4.5-rc2
On 01.02.2016, Linus Torvalds wrote: > Heinz? Did you actually test rc2 or something else? You're right, my bad! In fact, I tested 4.4.1-rc1 and 4.5-rc1. Sorry for the noise!
Re: Linux 4.5-rc2
On Mon, Feb 1, 2016 at 12:41 PM, Greg KH wrote: > > The patch you show below is included in 4.5-rc2, it's commit > 25cad69f21f5532d99e2ee73c8ab6512bcab614c. Right you are, Greg. Heinz? Did you actually test rc2 or something else? Linus
Re: Linux 4.5-rc2
On Mon, Feb 1, 2016 at 11:08 AM, Heinz Diehl wrote: > > Still, some Asus laptops are hanging at boot-time, both with latest > -stable and 4.5-rc1/rc2: > > [4.056862] asus_laptop:model detected > [4.058731] BUG: unable to handle kernel NULL pointer dereference at > 0e20 > [4.060018] IP: [] asus_sysfs_is_visible+0x13/0x1d0 > [asus_laptop] > > The bug is also reported here: > https://bugzilla.kernel.org/show_bug.cgi?id=110751 > > This patch fixes the problem (both for me and others): > > [ https://patchwork.ozlabs.org/patch/552082/ ] Greg, do you have that pending, or should I just apply it directly? Linus
Re: Linux 4.5-rc2
On Mon, Feb 01, 2016 at 08:08:01PM +0100, Heinz Diehl wrote: > Hi, > > On 01.02.2016, Linus Torvalds wrote: > > > Go forth and test, > > > > Linus > > Still, some Asus laptops are hanging at boot-time, both with latest > -stable and 4.5-rc1/rc2: > > [4.056862] asus_laptop:model detected > [4.058731] BUG: unable to handle kernel NULL pointer dereference at > 0e20 > [4.060018] IP: [] asus_sysfs_is_visible+0x13/0x1d0 > [asus_laptop] > [4.061346] PGD 0 > [4.062629] Oops: [#1] PREEMPT SMP > [4.063960] Modules linked in: wmi asus_laptop(+) input_polldev > sparse_keymap rfkill nfsd auth_rpcgss oid_registry nfs_acl lockd grace sunrpc > sch_fq_codel tcp_westwood xfs libcrc32c > +hid_logitech_dj crc32c_intel serio_raw atl1c i915 i2c_algo_bit > drm_kms_helper syscopyarea sysfillrect sysimgblt fb_sys_fops drm i2c_core > video > [4.067026] CPU: 1 PID: 536 Comm: systemd-udevd Not tainted 4.4.0 #1 > [4.068515] Hardware name: ASUSTeK Computer Inc. U45JC/U45JC, BIOS > U45JC.208 02/24/2011 > [4.070023] task: 88003645b680 ti: 8800a4a0c000 task.ti: > 8800a4a0c000 > [4.071568] RIP: 0010:[] [] > asus_sysfs_is_visible+0x13/0x1d0 [asus_laptop] > [4.073188] RSP: :8800a4a0faf8 EFLAGS: 00010282 > [4.074820] RAX: RBX: RCX: > > [4.076462] RDX: RSI: c03d63c0 RDI: > 88003675b420 > [4.078109] RBP: 8800a4a0fb08 R08: 8801428940c8 R09: > 0124 > [4.079777] R10: 88014348d100 R11: 0014 R12: > c03d4940 > [4.081470] R13: R14: 8801418af000 R15: > c03d6220 > [4.083156] FS: 7f58ba6dd8c0() GS:880147c4() > knlGS: > [4.084885] CS: 0010 DS: ES: CR0: 80050033 > [4.086611] CR2: 0e20 CR3: a49f3000 CR4: > 06e0 > [4.088351] Stack: > [4.090066] c03d4940 8800a4a0fb50 > 8122d12b > [4.091838] 88003675b420 880141327000 > > [4.093606] 880036b42498 0001 > 8800a4a0fb60 > [4.095386] Call Trace: > [4.097151] [] internal_create_group+0xbb/0x310 > [4.098943] [] sysfs_create_group+0x13/0x20 > [4.100748] [] asus_acpi_add+0x3bb/0xea0 [asus_laptop] > [4.102583] [] acpi_device_probe+0x4f/0xf5 > [4.104415] [] driver_probe_device+0x167/0x490 > [4.106254] [] __driver_attach+0x84/0x90 > [4.108087] [] ? driver_probe_device+0x490/0x490 > [4.109931] [] bus_for_each_dev+0x64/0xa0 > [4.111724] [] driver_attach+0x1e/0x20 > [4.113509] [] bus_add_driver+0x1eb/0x280 > [4.115273] [] ? 0xc03da000 > [4.117032] [] driver_register+0x60/0xe0 > [4.118818] [] acpi_bus_register_driver+0x38/0x40 > [4.120619] [] asus_laptop_init+0x2a/0x1000 > [asus_laptop] > [4.122433] [] do_one_initcall+0xab/0x1c0 > [4.124276] [] do_init_module+0x5f/0x1e5 > [4.126114] [] load_module+0x1f3f/0x2530 > [4.127943] [] ? __symbol_put+0x50/0x50 > [4.129786] [] ? copy_module_from_fd.isra.50+0xdb/0x130 > [4.131653] [] SyS_finit_module+0x9a/0xc0 > [4.133521] [] entry_SYSCALL_64_fastpath+0x12/0x6a > [4.135378] Code: c7 80 48 3d c0 e8 11 7e d7 c0 4c 89 f7 e8 66 3c e5 ff e9 > 27 ff ff ff 90 66 66 66 66 90 55 48 89 e5 41 54 53 48 8b 8790 00 00 00 <4c> > 8b a0 20 0e 00 00 0f b6 80 95 0d 00 00 84 c0 74 1a 48 81 fe > [4.139719] RIP [] asus_sysfs_is_visible+0x13/0x1d0 > [asus_laptop] > [4.141788] RSP > [4.143809] CR2: 0e20 > [4.145867] ---[ end trace 7d8d7d572a3e9126 ]--- > > The bug is also reported here: > https://bugzilla.kernel.org/show_bug.cgi?id=110751 > > This patch fixes the problem (both for me and others): > > From: Martin Wilck The patch you show below is included in 4.5-rc2, it's commit 25cad69f21f5532d99e2ee73c8ab6512bcab614c. So how could you apply it to 4.5-rc2 and have this fix the issue for you? confused, greg k-h > Since b8b2c7d845d5, platform_drv_probe() is called for all platform > devices. If drv->probe is NULL, and dev_pm_domain_attach() fails, > platform_drv_probe() will return the error code from dev_pm_domain_attach(). > > This causes real_probe() to enter the "probe_failed" path and set > dev->driver to NULL. Before b8b2c7d845d5, real_probe() would assume > success if both dev->bus->probe and drv->probe were missing. As a result, > a device and driver could be "bound" together just by matching their names; > this doesn't work any more after b8b2c7d845d5. > > This change broke the assumptions of certain drivers; for example, the TPM > code has long assumed that platform driver and device with matching name > could be bound in this way. That assumption may cause such drivers to > fail with Oops during initiali
Re: Linux 4.5-rc2
Hi,
On 01.02.2016, Linus Torvalds wrote:
> Go forth and test,
>
> Linus
Still, some Asus laptops are hanging at boot-time, both with latest
-stable and 4.5-rc1/rc2:
[4.056862] asus_laptop:model detected
[4.058731] BUG: unable to handle kernel NULL pointer dereference at
0e20
[4.060018] IP: [] asus_sysfs_is_visible+0x13/0x1d0
[asus_laptop]
[4.061346] PGD 0
[4.062629] Oops: [#1] PREEMPT SMP
[4.063960] Modules linked in: wmi asus_laptop(+) input_polldev
sparse_keymap rfkill nfsd auth_rpcgss oid_registry nfs_acl lockd grace sunrpc
sch_fq_codel tcp_westwood xfs libcrc32c
+hid_logitech_dj crc32c_intel serio_raw atl1c i915 i2c_algo_bit drm_kms_helper
syscopyarea sysfillrect sysimgblt fb_sys_fops drm i2c_core video
[4.067026] CPU: 1 PID: 536 Comm: systemd-udevd Not tainted 4.4.0 #1
[4.068515] Hardware name: ASUSTeK Computer Inc. U45JC/U45JC, BIOS
U45JC.208 02/24/2011
[4.070023] task: 88003645b680 ti: 8800a4a0c000 task.ti:
8800a4a0c000
[4.071568] RIP: 0010:[] []
asus_sysfs_is_visible+0x13/0x1d0 [asus_laptop]
[4.073188] RSP: :8800a4a0faf8 EFLAGS: 00010282
[4.074820] RAX: RBX: RCX:
[4.076462] RDX: RSI: c03d63c0 RDI: 88003675b420
[4.078109] RBP: 8800a4a0fb08 R08: 8801428940c8 R09: 0124
[4.079777] R10: 88014348d100 R11: 0014 R12: c03d4940
[4.081470] R13: R14: 8801418af000 R15: c03d6220
[4.083156] FS: 7f58ba6dd8c0() GS:880147c4()
knlGS:
[4.084885] CS: 0010 DS: ES: CR0: 80050033
[4.086611] CR2: 0e20 CR3: a49f3000 CR4: 06e0
[4.088351] Stack:
[4.090066] c03d4940 8800a4a0fb50
8122d12b
[4.091838] 88003675b420 880141327000
[4.093606] 880036b42498 0001
8800a4a0fb60
[4.095386] Call Trace:
[4.097151] [] internal_create_group+0xbb/0x310
[4.098943] [] sysfs_create_group+0x13/0x20
[4.100748] [] asus_acpi_add+0x3bb/0xea0 [asus_laptop]
[4.102583] [] acpi_device_probe+0x4f/0xf5
[4.104415] [] driver_probe_device+0x167/0x490
[4.106254] [] __driver_attach+0x84/0x90
[4.108087] [] ? driver_probe_device+0x490/0x490
[4.109931] [] bus_for_each_dev+0x64/0xa0
[4.111724] [] driver_attach+0x1e/0x20
[4.113509] [] bus_add_driver+0x1eb/0x280
[4.115273] [] ? 0xc03da000
[4.117032] [] driver_register+0x60/0xe0
[4.118818] [] acpi_bus_register_driver+0x38/0x40
[4.120619] [] asus_laptop_init+0x2a/0x1000 [asus_laptop]
[4.122433] [] do_one_initcall+0xab/0x1c0
[4.124276] [] do_init_module+0x5f/0x1e5
[4.126114] [] load_module+0x1f3f/0x2530
[4.127943] [] ? __symbol_put+0x50/0x50
[4.129786] [] ? copy_module_from_fd.isra.50+0xdb/0x130
[4.131653] [] SyS_finit_module+0x9a/0xc0
[4.133521] [] entry_SYSCALL_64_fastpath+0x12/0x6a
[4.135378] Code: c7 80 48 3d c0 e8 11 7e d7 c0 4c 89 f7 e8 66 3c e5 ff e9
27 ff ff ff 90 66 66 66 66 90 55 48 89 e5 41 54 53 48 8b 8790 00 00 00 <4c> 8b
a0 20 0e 00 00 0f b6 80 95 0d 00 00 84 c0 74 1a 48 81 fe
[4.139719] RIP [] asus_sysfs_is_visible+0x13/0x1d0
[asus_laptop]
[4.141788] RSP
[4.143809] CR2: 0e20
[4.145867] ---[ end trace 7d8d7d572a3e9126 ]---
The bug is also reported here:
https://bugzilla.kernel.org/show_bug.cgi?id=110751
This patch fixes the problem (both for me and others):
From: Martin Wilck
Since b8b2c7d845d5, platform_drv_probe() is called for all platform
devices. If drv->probe is NULL, and dev_pm_domain_attach() fails,
platform_drv_probe() will return the error code from dev_pm_domain_attach().
This causes real_probe() to enter the "probe_failed" path and set
dev->driver to NULL. Before b8b2c7d845d5, real_probe() would assume
success if both dev->bus->probe and drv->probe were missing. As a result,
a device and driver could be "bound" together just by matching their names;
this doesn't work any more after b8b2c7d845d5.
This change broke the assumptions of certain drivers; for example, the TPM
code has long assumed that platform driver and device with matching name
could be bound in this way. That assumption may cause such drivers to
fail with Oops during initialization after applying this change. Failure
in suspend/resume tests under qemu has also been reported.
This patch restores the previous (4.3.0 and earlier) behavior of
platform_drv_probe() in the case when the associated platform driver has
no "probe" function.
Fixes: b8b2c7d845d5 ("base/platform: assert that dev_pm_domain callbacks are
called unconditionally")
Signed-off-by: Martin Wilck
---
v2: fixed style issues, rephrased commit message.
v3: rephrased commit message a
Re: Linux 4.5-rc2
Gerd Hoffmann [2016-02-01 15:18]: > n Mo, 2016-02-01 at 14:19 +0100, Harald Arnesen wrote: >> I still get the blank screen than Bjørn Mork reported and bisected when >> 4.5-rc1 was released. > > Fix[1] is already queued by Jani Nikula, I suspect it simply missed the > boat because there was no drm-intel-fixes merge in -rc2. Confirmed, this patch fixes the bug. -- Hilsen Harald
Re: Linux 4.5-rc2
On Mo, 2016-02-01 at 14:19 +0100, Harald Arnesen wrote: > I still get the blank screen than Bjørn Mork reported and bisected when > 4.5-rc1 was released. > > Reverting this commit fixes it: > > HEAD is now at 39bfcd5235e0 drm/i915: more virtual south bridge detection > 39bfcd5235e07e95ad3e70eab8e0b85db181de9e is the first bad commit > commit 39bfcd5235e07e95ad3e70eab8e0b85db181de9e > Author: Gerd Hoffmann > Date: Thu Nov 26 12:03:51 2015 +0100 > > drm/i915: more virtual south bridge detection > > Commit "30c964a drm/i915: Detect virtual south bridge" detects and > handles the southbridge emulated by vmware esx. Add the ich9 south > bridge emulated by 'qemu -M q35'. > > Signed-off-by: Gerd Hoffmann > Signed-off-by: Daniel Vetter > > :04 04 b59ceb519d517a00e41e575346505b9ebde06288 > 825eb4e5684952de0931312183d1cf163c43219a M drivers Fix[1] is already queued by Jani Nikula, I suspect it simply missed the boat because there was no drm-intel-fixes merge in -rc2. cheers, Gerd [1] https://lkml.org/lkml/2016/1/25/280
Re: Linux 4.5-rc2
I still get the blank screen than Bjørn Mork reported and bisected when 4.5-rc1 was released. Reverting this commit fixes it: HEAD is now at 39bfcd5235e0 drm/i915: more virtual south bridge detection 39bfcd5235e07e95ad3e70eab8e0b85db181de9e is the first bad commit commit 39bfcd5235e07e95ad3e70eab8e0b85db181de9e Author: Gerd Hoffmann Date: Thu Nov 26 12:03:51 2015 +0100 drm/i915: more virtual south bridge detection Commit "30c964a drm/i915: Detect virtual south bridge" detects and handles the southbridge emulated by vmware esx. Add the ich9 south bridge emulated by 'qemu -M q35'. Signed-off-by: Gerd Hoffmann Signed-off-by: Daniel Vetter :04 04 b59ceb519d517a00e41e575346505b9ebde06288 825eb4e5684952de0931312183d1cf163c43219a M drivers -- Hilsen Harald
Linux 4.5-rc2
Jia Shi (1): KVM: s390: Enable the KVM-VFIO device Du, Changbin (1): usb: hub: do not clear BOS field during reset device Eric Anholt (1): drm/vc4: Remove broken attempt at GPU reset using genpd. Eric Huang (1): drm/amd/amdgpu: Improve amdgpu_dpm* macros to avoid unexpected result (v2) Fabio Estevam (1): drm/etnaviv: remove owner assignment from platform_driver Fengguang Wu (1): MAINTAINERS: add git URL for swiotlb Filipe Manana (1): Btrfs: fix race between fsync and lockless direct IO writes Gautham R Shenoy (1): cpufreq: Use list_is_last() to check last entry of the policy list Gavin Guo (1): sched/numa: Fix use-after-free bug in the task_numa_compare Gavin Shan (1): powerpc/eeh: Fix PE location code Geert Uytterhoeven (2): hisi_sas: SCSI_HISI_SAS should depend on HAS_DMA hisi_sas: Restrict SCSI_HISI_SAS to arm64 Geyslan G. Bem (1): KVM: PPC: Book3S PR: Remove unused variable 'vcpu_book3s' Gioh Kim (1): hwmon: (fam15h_power) Add bit masking for tdp_limit Greg Kroah-Hartman (1): USB: serial: ftdi_sio: add support for Yaesu SCU-18 cable Greg Kurz (1): KVM: PPC: Fix ONE_REG AltiVec support Guillaume Fougnies (1): ALSA: usb-audio: Fix TEAC UD-501/UD-503/NT-503 usb delay Gustavo Padovan (1): tracing/dma-buf/fence: Fix timeline str value on fence_annotate_wait_on Hans de Goede (1): ACPI: Revert "ACPI / video: Add Dell Inspiron 5737 to the blacklist" Heiko Carstens (5): s390/numa: allocate memory with correct alignment s390: remove superfluous memblock_alloc() return value checks s390: wire up copy_file_range syscall s390: remove all usages of PSW_ADDR_AMODE s390: remove all usages of PSW_ADDR_INSN Ingo Tuchscherer (1): s390/zcrypt: Fix cryptographic device id in kernel messages Insu Yun (1): ACPI / PCI / hotplug: unlock in error path in acpiphp_enable_slot() Jan Beulich (1): x86/mm: Fix types used in pgprot cacheability flags translations Jann Horn (1): seccomp: always propagate NO_NEW_PRIVS on tsync Jean Delvare (3): i2c: piix4: Fix SB800 locking i2c: piix4: Fully initialize SB800 before it is registered i2c: piix4: don't regress on bus names Jeremy McNicoll (1): iommu/vt-d: Don't skip PCI devices when disabling IOTLB Jiang Liu (2): x86/irq: Fix a race in x86_vector_free_irqs() x86/irq: Do not use apic_chip_data.old_domain as temporary buffer Jiri Olsa (4): perf build: Add feature-dump target perf build: Introduce FEATURES_DUMP make variable perf hists: Fix HISTC_MEM_DCACHELINE width setting perf stat: Do not clean event's private stats Johan Hovold (1): USB: visor: fix null-deref at probe John Ernberg (1): USB: option: fix Cinterion AHxx enumeration John Keeping (5): drm/rockchip: vop: fix mask when updating interrupts drm/atomic-helper: Export framebuffer_changed() drm/rockchip: don't wait for vblank if fb hasn't changed drm/rockchip: explain why we can't wait_for_vblanks drm/rockchip: respect CONFIG_DRM_FBDEV_EMULATION John Stultz (2): ntp: Fix ADJ_SETOFFSET being used w/ ADJ_NANO kselftests: timers: Add adjtimex SETOFFSET validity tests Jordan Lazare (1): drm/amdgpu: Allow the driver to load if amdgpu.powerplay=1 on asics without powerplay support Julia Lawall (1): cleancache: constify cleancache_ops structure Kees Cook (1): ARM: 8500/1: fix atags_to_fdt with stack-protector-strong Lada Trimasova (1): iommu/io-pgtable-arm: Fix io-pgtable-arm build failure Lars-Peter Clausen (1): iio: adis_buffer: Fix out-of-bounds memory access Libin Yang (1): ALSA: hda - disable dynamic clock gating on Broxton before reset Linus Torvalds (1): Linux 4.5-rc2 Lorenzo Pieralisi (1): arm64: kernel: fix architected PMU registers unconditional access Lu Baolu (2): usb: cdc-acm: handle unlinked urb in acm read callback usb: cdc-acm: send zero packet for intel 7260 modem Lucas Stach (5): drm/etnaviv: hold object lock while getting pages for coredump drm/etnaviv: fix memory leak in IOMMU init path drm/etnaviv: fix get pages error path in etnaviv_gem_vaddr drm/etnaviv: rename etnaviv_gem_vaddr to etnaviv_gem_vmap drm/etnaviv: call correct function when trying to vmap a DMABUF Lucas Tanure (1): ALSA: bebob: Use a signed return type for get_formation_index Madhavan Srinivasan (1): powerpc/perf: Remove PPMU_HAS_SSLOT flag for Power8 Magnus Damm (1): iommu: Update struct iommu_ops comments Marc Zyngier (3): irqdomain: Allow domain lookup with DOMAIN_BUS_WIRED token of: MSI: Simplify irqdomain lookup irqchip/gic-v3-its: Recompute the number of pages on page size change Marek Szyprowski (1): PM / domains: fix lockdep issue for all subdo
