Re: Linux 5.10.25
On Sun, Mar 21, 2021 at 11:07:08PM +, Jamie Heilman wrote: > Jamie Heilman wrote: > > Greg Kroah-Hartman wrote: > > > On Sat, Mar 20, 2021 at 09:31:55PM +, Jamie Heilman wrote: > > > > [ugh, resent with the lkml headers unbroken, sorry about the dupe] > > > > > > > > Greg Kroah-Hartman wrote: > > > > > J. Bruce Fields (2): > > > > > Revert "nfsd4: remove check_conflicting_opens warning" > > > > > Revert "nfsd4: a client's own opens needn't prevent delegations" > > > > > > > > Hrm, just got this when I udpated my nfs server (32bit Via EPIA system) > > > > from 5.10.20 to 5.10.25: > > > > > > > > [ 49.225914] NFSD: Using UMH upcall client tracking operations. > > > > [ 49.231919] NFSD: starting 90-second grace period (net f036) > > > > [ 50.036973] [ cut here ] > > > > [ 50.041771] WARNING: CPU: 0 PID: 2284 at fs/nfsd/nfs4state.c:4968 > > > > nfsd4_process_open2+0xf9c/0x1170 [nfsd] > > > > [ 50.051434] Modules linked in: md5 cpufreq_conservative > > > > cpufreq_userspace cpufreq_powersave cpufreq_ondemand autofs4 quota_v2 > > > > quota_tree nfsd auth_rpcgss nfs lockd grace nfs_ssc fscache sunrpc > > > > xt_mark cls_fw sch_htb iptable_nat xt_nat nf_nat ipt_REJECT > > > > nf_reject_ipv4 xt_tcpudp xt_multiport iptable_mangle xt_state > > > > xt_conntrack nf_conntrack nf_defrag_ipv4 nf_log_ipv4 nf_log_common > > > > xt_LOG xt_limit iptable_filter ip_tables x_tables nhpoly1305 > > > > chacha_generic libchacha adiantum libpoly1305 dm_crypt dm_mod > > > > snd_hda_codec_via snd_hda_codec_generic snd_hda_intel snd_intel_dspcfg > > > > snd_hda_codec snd_hwdep snd_hda_core snd_pcm snd_timer snd via_rhine > > > > psmouse soundcore mii via_agp sg via_velocity evdev agpgart > > > > [ 50.113386] CPU: 0 PID: 2284 Comm: nfsd Tainted: GT > > > > 5.10.25 #1 > > > > [ 50.120669] Hardware name: To Be Filled By O.E.M. To Be Filled By > > > > O.E.M./To be filled by O.E.M., BIOS 080014 06/01/2009 > > > > [ 50.131652] EIP: nfsd4_process_open2+0xf9c/0x1170 [nfsd] > > > > [ 50.137036] Code: 04 88 45 a4 88 07 8b 45 a0 8d 78 49 8b 45 84 8d 70 > > > > 01 e9 2b f8 ff ff c7 45 9c 00 00 00 00 31 ff bb 00 00 27 67 e9 04 f6 ff > > > > ff <0f> 0b e9 a0 f5 ff ff 0f b6 d4 0f a3 15 94 3f 23 f8 0f 83 b1 fd ff > > > > [ 50.155866] EAX: EBX: 82da25b0 ECX: 830c0920 EDX: > > > > [ 50.162187] ESI: 82da25b0 EDI: 82da55a0 EBP: 8310be68 ESP: 8310bddc > > > > [ 50.168507] DS: 007b ES: 007b FS: GS: 00e0 SS: 0068 EFLAGS: > > > > 00010246 > > > > [ 50.175338] CR0: 80050033 CR2: 00551e50 CR3: 03222000 CR4: 06b0 > > > > [ 50.181654] Call Trace: > > > > [ 50.184165] ? inode_permission+0x17/0xc0 > > > > [ 50.188289] nfsd4_open+0x429/0x910 [nfsd] > > > > [ 50.192483] ? nfsd4_encode_operation+0x185/0x1e0 [nfsd] > > > > [ 50.197900] ? nfsd4_rename+0x1a0/0x1a0 [nfsd] > > > > [ 50.202439] nfsd4_proc_compound+0x457/0x6c0 [nfsd] > > > > [ 50.207419] nfsd_dispatch+0xdc/0x1a0 [nfsd] > > > > [ 50.211816] svc_process_common+0x38a/0x650 [sunrpc] > > > > [ 50.216880] ? svc_xprt_do_enqueue+0xd7/0xe0 [sunrpc] > > > > [ 50.222017] ? svc_xprt_received+0x5d/0xf0 [sunrpc] > > > > [ 50.227000] ? nfsd_svc+0x300/0x300 [nfsd] > > > > [ 50.231190] svc_process+0xa9/0xf0 [sunrpc] > > > > [ 50.235468] nfsd+0xcd/0x120 [nfsd] > > > > [ 50.239025] kthread+0xe1/0x100 > > > > [ 50.242259] ? nfsd_destroy+0x50/0x50 [nfsd] > > > > [ 50.246588] ? kthread_create_on_node+0x30/0x30 > > > > [ 50.251165] ret_from_fork+0x1c/0x28 > > > > [ 50.254789] ---[ end trace 171bde4774bc9795 ]--- > > > > > > > > Can't readily reproduce it though, so likely a race condition or > > > > something that requires more state buildup than I have after a few > > > > minutes of uptime. Kernel config at > > > > http://audible.transient.net/~jamie/k/nfsd.config-5.10.25 in case you > > > > think this worth more investigation. > > > > > > Do you also have this issue in Linus's tree and the latest 5.11.y > > > release? > > > > Haven't tried it, but like I said, I couldn't even reproduce it again > > with 5.10.25, or booting between 5.10.20 to 5.10.25 again ... I'll > > give the others a shot and see if I can repro it there. > > Yeah, can't repro it with 5.11.8 or 5.12.0-rc3-00281-g1d4345eb51a1 > either, seems to have been a spurious thing. I've seen at least one report previously, so it's not a regression. I'm not sure what's going on there. I think it might actually be possible if a CLOSE arrives from the client at exactly the wrong moment. In which case, all that happens here is we decline to give out a delegation. Probably the warning should just be removed. --b.
Re: Linux 5.10.25
Jamie Heilman wrote: > Greg Kroah-Hartman wrote: > > On Sat, Mar 20, 2021 at 09:31:55PM +, Jamie Heilman wrote: > > > [ugh, resent with the lkml headers unbroken, sorry about the dupe] > > > > > > Greg Kroah-Hartman wrote: > > > > J. Bruce Fields (2): > > > > Revert "nfsd4: remove check_conflicting_opens warning" > > > > Revert "nfsd4: a client's own opens needn't prevent delegations" > > > > > > Hrm, just got this when I udpated my nfs server (32bit Via EPIA system) > > > from 5.10.20 to 5.10.25: > > > > > > [ 49.225914] NFSD: Using UMH upcall client tracking operations. > > > [ 49.231919] NFSD: starting 90-second grace period (net f036) > > > [ 50.036973] [ cut here ] > > > [ 50.041771] WARNING: CPU: 0 PID: 2284 at fs/nfsd/nfs4state.c:4968 > > > nfsd4_process_open2+0xf9c/0x1170 [nfsd] > > > [ 50.051434] Modules linked in: md5 cpufreq_conservative > > > cpufreq_userspace cpufreq_powersave cpufreq_ondemand autofs4 quota_v2 > > > quota_tree nfsd auth_rpcgss nfs lockd grace nfs_ssc fscache sunrpc > > > xt_mark cls_fw sch_htb iptable_nat xt_nat nf_nat ipt_REJECT > > > nf_reject_ipv4 xt_tcpudp xt_multiport iptable_mangle xt_state > > > xt_conntrack nf_conntrack nf_defrag_ipv4 nf_log_ipv4 nf_log_common xt_LOG > > > xt_limit iptable_filter ip_tables x_tables nhpoly1305 chacha_generic > > > libchacha adiantum libpoly1305 dm_crypt dm_mod snd_hda_codec_via > > > snd_hda_codec_generic snd_hda_intel snd_intel_dspcfg snd_hda_codec > > > snd_hwdep snd_hda_core snd_pcm snd_timer snd via_rhine psmouse soundcore > > > mii via_agp sg via_velocity evdev agpgart > > > [ 50.113386] CPU: 0 PID: 2284 Comm: nfsd Tainted: GT > > > 5.10.25 #1 > > > [ 50.120669] Hardware name: To Be Filled By O.E.M. To Be Filled By > > > O.E.M./To be filled by O.E.M., BIOS 080014 06/01/2009 > > > [ 50.131652] EIP: nfsd4_process_open2+0xf9c/0x1170 [nfsd] > > > [ 50.137036] Code: 04 88 45 a4 88 07 8b 45 a0 8d 78 49 8b 45 84 8d 70 > > > 01 e9 2b f8 ff ff c7 45 9c 00 00 00 00 31 ff bb 00 00 27 67 e9 04 f6 ff > > > ff <0f> 0b e9 a0 f5 ff ff 0f b6 d4 0f a3 15 94 3f 23 f8 0f 83 b1 fd ff > > > [ 50.155866] EAX: EBX: 82da25b0 ECX: 830c0920 EDX: > > > [ 50.162187] ESI: 82da25b0 EDI: 82da55a0 EBP: 8310be68 ESP: 8310bddc > > > [ 50.168507] DS: 007b ES: 007b FS: GS: 00e0 SS: 0068 EFLAGS: > > > 00010246 > > > [ 50.175338] CR0: 80050033 CR2: 00551e50 CR3: 03222000 CR4: 06b0 > > > [ 50.181654] Call Trace: > > > [ 50.184165] ? inode_permission+0x17/0xc0 > > > [ 50.188289] nfsd4_open+0x429/0x910 [nfsd] > > > [ 50.192483] ? nfsd4_encode_operation+0x185/0x1e0 [nfsd] > > > [ 50.197900] ? nfsd4_rename+0x1a0/0x1a0 [nfsd] > > > [ 50.202439] nfsd4_proc_compound+0x457/0x6c0 [nfsd] > > > [ 50.207419] nfsd_dispatch+0xdc/0x1a0 [nfsd] > > > [ 50.211816] svc_process_common+0x38a/0x650 [sunrpc] > > > [ 50.216880] ? svc_xprt_do_enqueue+0xd7/0xe0 [sunrpc] > > > [ 50.222017] ? svc_xprt_received+0x5d/0xf0 [sunrpc] > > > [ 50.227000] ? nfsd_svc+0x300/0x300 [nfsd] > > > [ 50.231190] svc_process+0xa9/0xf0 [sunrpc] > > > [ 50.235468] nfsd+0xcd/0x120 [nfsd] > > > [ 50.239025] kthread+0xe1/0x100 > > > [ 50.242259] ? nfsd_destroy+0x50/0x50 [nfsd] > > > [ 50.246588] ? kthread_create_on_node+0x30/0x30 > > > [ 50.251165] ret_from_fork+0x1c/0x28 > > > [ 50.254789] ---[ end trace 171bde4774bc9795 ]--- > > > > > > Can't readily reproduce it though, so likely a race condition or > > > something that requires more state buildup than I have after a few > > > minutes of uptime. Kernel config at > > > http://audible.transient.net/~jamie/k/nfsd.config-5.10.25 in case you > > > think this worth more investigation. > > > > Do you also have this issue in Linus's tree and the latest 5.11.y > > release? > > Haven't tried it, but like I said, I couldn't even reproduce it again > with 5.10.25, or booting between 5.10.20 to 5.10.25 again ... I'll > give the others a shot and see if I can repro it there. Yeah, can't repro it with 5.11.8 or 5.12.0-rc3-00281-g1d4345eb51a1 either, seems to have been a spurious thing. -- Jamie Heilman http://audible.transient.net/~jamie/
Re: Linux 5.10.25
Greg Kroah-Hartman wrote: > On Sat, Mar 20, 2021 at 09:31:55PM +, Jamie Heilman wrote: > > [ugh, resent with the lkml headers unbroken, sorry about the dupe] > > > > Greg Kroah-Hartman wrote: > > > J. Bruce Fields (2): > > > Revert "nfsd4: remove check_conflicting_opens warning" > > > Revert "nfsd4: a client's own opens needn't prevent delegations" > > > > Hrm, just got this when I udpated my nfs server (32bit Via EPIA system) > > from 5.10.20 to 5.10.25: > > > > [ 49.225914] NFSD: Using UMH upcall client tracking operations. > > [ 49.231919] NFSD: starting 90-second grace period (net f036) > > [ 50.036973] [ cut here ] > > [ 50.041771] WARNING: CPU: 0 PID: 2284 at fs/nfsd/nfs4state.c:4968 > > nfsd4_process_open2+0xf9c/0x1170 [nfsd] > > [ 50.051434] Modules linked in: md5 cpufreq_conservative > > cpufreq_userspace cpufreq_powersave cpufreq_ondemand autofs4 quota_v2 > > quota_tree nfsd auth_rpcgss nfs lockd grace nfs_ssc fscache sunrpc xt_mark > > cls_fw sch_htb iptable_nat xt_nat nf_nat ipt_REJECT nf_reject_ipv4 > > xt_tcpudp xt_multiport iptable_mangle xt_state xt_conntrack nf_conntrack > > nf_defrag_ipv4 nf_log_ipv4 nf_log_common xt_LOG xt_limit iptable_filter > > ip_tables x_tables nhpoly1305 chacha_generic libchacha adiantum libpoly1305 > > dm_crypt dm_mod snd_hda_codec_via snd_hda_codec_generic snd_hda_intel > > snd_intel_dspcfg snd_hda_codec snd_hwdep snd_hda_core snd_pcm snd_timer snd > > via_rhine psmouse soundcore mii via_agp sg via_velocity evdev agpgart > > [ 50.113386] CPU: 0 PID: 2284 Comm: nfsd Tainted: GT > > 5.10.25 #1 > > [ 50.120669] Hardware name: To Be Filled By O.E.M. To Be Filled By > > O.E.M./To be filled by O.E.M., BIOS 080014 06/01/2009 > > [ 50.131652] EIP: nfsd4_process_open2+0xf9c/0x1170 [nfsd] > > [ 50.137036] Code: 04 88 45 a4 88 07 8b 45 a0 8d 78 49 8b 45 84 8d 70 01 > > e9 2b f8 ff ff c7 45 9c 00 00 00 00 31 ff bb 00 00 27 67 e9 04 f6 ff ff > > <0f> 0b e9 a0 f5 ff ff 0f b6 d4 0f a3 15 94 3f 23 f8 0f 83 b1 fd ff > > [ 50.155866] EAX: EBX: 82da25b0 ECX: 830c0920 EDX: > > [ 50.162187] ESI: 82da25b0 EDI: 82da55a0 EBP: 8310be68 ESP: 8310bddc > > [ 50.168507] DS: 007b ES: 007b FS: GS: 00e0 SS: 0068 EFLAGS: 00010246 > > [ 50.175338] CR0: 80050033 CR2: 00551e50 CR3: 03222000 CR4: 06b0 > > [ 50.181654] Call Trace: > > [ 50.184165] ? inode_permission+0x17/0xc0 > > [ 50.188289] nfsd4_open+0x429/0x910 [nfsd] > > [ 50.192483] ? nfsd4_encode_operation+0x185/0x1e0 [nfsd] > > [ 50.197900] ? nfsd4_rename+0x1a0/0x1a0 [nfsd] > > [ 50.202439] nfsd4_proc_compound+0x457/0x6c0 [nfsd] > > [ 50.207419] nfsd_dispatch+0xdc/0x1a0 [nfsd] > > [ 50.211816] svc_process_common+0x38a/0x650 [sunrpc] > > [ 50.216880] ? svc_xprt_do_enqueue+0xd7/0xe0 [sunrpc] > > [ 50.222017] ? svc_xprt_received+0x5d/0xf0 [sunrpc] > > [ 50.227000] ? nfsd_svc+0x300/0x300 [nfsd] > > [ 50.231190] svc_process+0xa9/0xf0 [sunrpc] > > [ 50.235468] nfsd+0xcd/0x120 [nfsd] > > [ 50.239025] kthread+0xe1/0x100 > > [ 50.242259] ? nfsd_destroy+0x50/0x50 [nfsd] > > [ 50.246588] ? kthread_create_on_node+0x30/0x30 > > [ 50.251165] ret_from_fork+0x1c/0x28 > > [ 50.254789] ---[ end trace 171bde4774bc9795 ]--- > > > > Can't readily reproduce it though, so likely a race condition or > > something that requires more state buildup than I have after a few > > minutes of uptime. Kernel config at > > http://audible.transient.net/~jamie/k/nfsd.config-5.10.25 in case you > > think this worth more investigation. > > Do you also have this issue in Linus's tree and the latest 5.11.y > release? Haven't tried it, but like I said, I couldn't even reproduce it again with 5.10.25, or booting between 5.10.20 to 5.10.25 again ... I'll give the others a shot and see if I can repro it there. -- Jamie Heilman http://audible.transient.net/~jamie/
Re: Linux 5.10.25
On Sat, Mar 20, 2021 at 09:31:55PM +, Jamie Heilman wrote: > [ugh, resent with the lkml headers unbroken, sorry about the dupe] > > Greg Kroah-Hartman wrote: > > J. Bruce Fields (2): > > Revert "nfsd4: remove check_conflicting_opens warning" > > Revert "nfsd4: a client's own opens needn't prevent delegations" > > Hrm, just got this when I udpated my nfs server (32bit Via EPIA system) > from 5.10.20 to 5.10.25: > > [ 49.225914] NFSD: Using UMH upcall client tracking operations. > [ 49.231919] NFSD: starting 90-second grace period (net f036) > [ 50.036973] [ cut here ] > [ 50.041771] WARNING: CPU: 0 PID: 2284 at fs/nfsd/nfs4state.c:4968 > nfsd4_process_open2+0xf9c/0x1170 [nfsd] > [ 50.051434] Modules linked in: md5 cpufreq_conservative cpufreq_userspace > cpufreq_powersave cpufreq_ondemand autofs4 quota_v2 quota_tree nfsd > auth_rpcgss nfs lockd grace nfs_ssc fscache sunrpc xt_mark cls_fw sch_htb > iptable_nat xt_nat nf_nat ipt_REJECT nf_reject_ipv4 xt_tcpudp xt_multiport > iptable_mangle xt_state xt_conntrack nf_conntrack nf_defrag_ipv4 nf_log_ipv4 > nf_log_common xt_LOG xt_limit iptable_filter ip_tables x_tables nhpoly1305 > chacha_generic libchacha adiantum libpoly1305 dm_crypt dm_mod > snd_hda_codec_via snd_hda_codec_generic snd_hda_intel snd_intel_dspcfg > snd_hda_codec snd_hwdep snd_hda_core snd_pcm snd_timer snd via_rhine psmouse > soundcore mii via_agp sg via_velocity evdev agpgart > [ 50.113386] CPU: 0 PID: 2284 Comm: nfsd Tainted: GT > 5.10.25 #1 > [ 50.120669] Hardware name: To Be Filled By O.E.M. To Be Filled By > O.E.M./To be filled by O.E.M., BIOS 080014 06/01/2009 > [ 50.131652] EIP: nfsd4_process_open2+0xf9c/0x1170 [nfsd] > [ 50.137036] Code: 04 88 45 a4 88 07 8b 45 a0 8d 78 49 8b 45 84 8d 70 01 e9 > 2b f8 ff ff c7 45 9c 00 00 00 00 31 ff bb 00 00 27 67 e9 04 f6 ff ff <0f> 0b > e9 a0 f5 ff ff 0f b6 d4 0f a3 15 94 3f 23 f8 0f 83 b1 fd ff > [ 50.155866] EAX: EBX: 82da25b0 ECX: 830c0920 EDX: > [ 50.162187] ESI: 82da25b0 EDI: 82da55a0 EBP: 8310be68 ESP: 8310bddc > [ 50.168507] DS: 007b ES: 007b FS: GS: 00e0 SS: 0068 EFLAGS: 00010246 > [ 50.175338] CR0: 80050033 CR2: 00551e50 CR3: 03222000 CR4: 06b0 > [ 50.181654] Call Trace: > [ 50.184165] ? inode_permission+0x17/0xc0 > [ 50.188289] nfsd4_open+0x429/0x910 [nfsd] > [ 50.192483] ? nfsd4_encode_operation+0x185/0x1e0 [nfsd] > [ 50.197900] ? nfsd4_rename+0x1a0/0x1a0 [nfsd] > [ 50.202439] nfsd4_proc_compound+0x457/0x6c0 [nfsd] > [ 50.207419] nfsd_dispatch+0xdc/0x1a0 [nfsd] > [ 50.211816] svc_process_common+0x38a/0x650 [sunrpc] > [ 50.216880] ? svc_xprt_do_enqueue+0xd7/0xe0 [sunrpc] > [ 50.222017] ? svc_xprt_received+0x5d/0xf0 [sunrpc] > [ 50.227000] ? nfsd_svc+0x300/0x300 [nfsd] > [ 50.231190] svc_process+0xa9/0xf0 [sunrpc] > [ 50.235468] nfsd+0xcd/0x120 [nfsd] > [ 50.239025] kthread+0xe1/0x100 > [ 50.242259] ? nfsd_destroy+0x50/0x50 [nfsd] > [ 50.246588] ? kthread_create_on_node+0x30/0x30 > [ 50.251165] ret_from_fork+0x1c/0x28 > [ 50.254789] ---[ end trace 171bde4774bc9795 ]--- > > Can't readily reproduce it though, so likely a race condition or > something that requires more state buildup than I have after a few > minutes of uptime. Kernel config at > http://audible.transient.net/~jamie/k/nfsd.config-5.10.25 in case you > think this worth more investigation. Do you also have this issue in Linus's tree and the latest 5.11.y release? thanks, greg k-h
Re: Linux 5.10.25
[ugh, resent with the lkml headers unbroken, sorry about the dupe] Greg Kroah-Hartman wrote: > J. Bruce Fields (2): > Revert "nfsd4: remove check_conflicting_opens warning" > Revert "nfsd4: a client's own opens needn't prevent delegations" Hrm, just got this when I udpated my nfs server (32bit Via EPIA system) from 5.10.20 to 5.10.25: [ 49.225914] NFSD: Using UMH upcall client tracking operations. [ 49.231919] NFSD: starting 90-second grace period (net f036) [ 50.036973] [ cut here ] [ 50.041771] WARNING: CPU: 0 PID: 2284 at fs/nfsd/nfs4state.c:4968 nfsd4_process_open2+0xf9c/0x1170 [nfsd] [ 50.051434] Modules linked in: md5 cpufreq_conservative cpufreq_userspace cpufreq_powersave cpufreq_ondemand autofs4 quota_v2 quota_tree nfsd auth_rpcgss nfs lockd grace nfs_ssc fscache sunrpc xt_mark cls_fw sch_htb iptable_nat xt_nat nf_nat ipt_REJECT nf_reject_ipv4 xt_tcpudp xt_multiport iptable_mangle xt_state xt_conntrack nf_conntrack nf_defrag_ipv4 nf_log_ipv4 nf_log_common xt_LOG xt_limit iptable_filter ip_tables x_tables nhpoly1305 chacha_generic libchacha adiantum libpoly1305 dm_crypt dm_mod snd_hda_codec_via snd_hda_codec_generic snd_hda_intel snd_intel_dspcfg snd_hda_codec snd_hwdep snd_hda_core snd_pcm snd_timer snd via_rhine psmouse soundcore mii via_agp sg via_velocity evdev agpgart [ 50.113386] CPU: 0 PID: 2284 Comm: nfsd Tainted: GT 5.10.25 #1 [ 50.120669] Hardware name: To Be Filled By O.E.M. To Be Filled By O.E.M./To be filled by O.E.M., BIOS 080014 06/01/2009 [ 50.131652] EIP: nfsd4_process_open2+0xf9c/0x1170 [nfsd] [ 50.137036] Code: 04 88 45 a4 88 07 8b 45 a0 8d 78 49 8b 45 84 8d 70 01 e9 2b f8 ff ff c7 45 9c 00 00 00 00 31 ff bb 00 00 27 67 e9 04 f6 ff ff <0f> 0b e9 a0 f5 ff ff 0f b6 d4 0f a3 15 94 3f 23 f8 0f 83 b1 fd ff [ 50.155866] EAX: EBX: 82da25b0 ECX: 830c0920 EDX: [ 50.162187] ESI: 82da25b0 EDI: 82da55a0 EBP: 8310be68 ESP: 8310bddc [ 50.168507] DS: 007b ES: 007b FS: GS: 00e0 SS: 0068 EFLAGS: 00010246 [ 50.175338] CR0: 80050033 CR2: 00551e50 CR3: 03222000 CR4: 06b0 [ 50.181654] Call Trace: [ 50.184165] ? inode_permission+0x17/0xc0 [ 50.188289] nfsd4_open+0x429/0x910 [nfsd] [ 50.192483] ? nfsd4_encode_operation+0x185/0x1e0 [nfsd] [ 50.197900] ? nfsd4_rename+0x1a0/0x1a0 [nfsd] [ 50.202439] nfsd4_proc_compound+0x457/0x6c0 [nfsd] [ 50.207419] nfsd_dispatch+0xdc/0x1a0 [nfsd] [ 50.211816] svc_process_common+0x38a/0x650 [sunrpc] [ 50.216880] ? svc_xprt_do_enqueue+0xd7/0xe0 [sunrpc] [ 50.222017] ? svc_xprt_received+0x5d/0xf0 [sunrpc] [ 50.227000] ? nfsd_svc+0x300/0x300 [nfsd] [ 50.231190] svc_process+0xa9/0xf0 [sunrpc] [ 50.235468] nfsd+0xcd/0x120 [nfsd] [ 50.239025] kthread+0xe1/0x100 [ 50.242259] ? nfsd_destroy+0x50/0x50 [nfsd] [ 50.246588] ? kthread_create_on_node+0x30/0x30 [ 50.251165] ret_from_fork+0x1c/0x28 [ 50.254789] ---[ end trace 171bde4774bc9795 ]--- Can't readily reproduce it though, so likely a race condition or something that requires more state buildup than I have after a few minutes of uptime. Kernel config at http://audible.transient.net/~jamie/k/nfsd.config-5.10.25 in case you think this worth more investigation. -- Jamie Heilman http://audible.transient.net/~jamie/
Linux 5.10.25
I'm announcing the release of the 5.10.25 kernel. All users of the 5.10 kernel series must upgrade. The updated 5.10.y git tree can be found at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git linux-5.10.y and can be browsed at the normal kernel.org git web browser: https://git.kernel.org/?p=linux/kernel/git/stable/linux-stable.git;a=summary thanks, greg k-h Makefile|2 arch/x86/crypto/aesni-intel_asm.S | 133 +--- arch/x86/crypto/aesni-intel_avx-x86_64.S| 20 +- arch/x86/crypto/aesni-intel_glue.c | 25 +-- drivers/infiniband/ulp/srp/ib_srp.c | 110 + drivers/net/dsa/b53/b53_common.c| 18 ++ drivers/net/dsa/b53/b53_regs.h |1 drivers/net/dsa/bcm_sf2.c | 15 - fs/fuse/fuse_i.h|1 fs/locks.c |3 fs/nfsd/nfs4state.c | 53 +- kernel/bpf/verifier.c | 33 ++- sound/usb/endpoint.c|3 sound/usb/pcm.c |5 tools/testing/selftests/bpf/verifier/bounds_deduction.c | 27 ++- tools/testing/selftests/bpf/verifier/map_ptr.c |4 tools/testing/selftests/bpf/verifier/unpriv.c | 15 + tools/testing/selftests/bpf/verifier/value_ptr_arith.c | 23 ++ 18 files changed, 265 insertions(+), 226 deletions(-) Amir Goldstein (1): fuse: fix live lock in fuse_iget() Ard Biesheuvel (1): crypto: x86/aes-ni-xts - use direct calls to and 4-way stride Florian Fainelli (1): net: dsa: b53: Support setting learning on port Greg Kroah-Hartman (1): Linux 5.10.25 J. Bruce Fields (2): Revert "nfsd4: remove check_conflicting_opens warning" Revert "nfsd4: a client's own opens needn't prevent delegations" Nicolas Morey-Chaisemartin (1): RDMA/srp: Fix support for unpopulated and unbalanced NUMA nodes Piotr Krysiuk (5): bpf: Prohibit alu ops for pointer types not defining ptr_limit bpf: Fix off-by-one for area size in creating mask to left bpf: Simplify alu_limit masking for pointer arithmetic bpf: Add sanity check for upper ptr_limit bpf, selftests: Fix up some test_verifier cases for unprivileged Takashi Iwai (1): ALSA: usb-audio: Don't avoid stopping the stream at disconnection Uros Bizjak (1): crypto: aesni - Use TEST %reg,%reg instead of CMP $0,%reg
Re: Linux 5.10.25
diff --git a/Makefile b/Makefile index 3a435c928e75..6858425cbe6c 100644 --- a/Makefile +++ b/Makefile @@ -1,7 +1,7 @@ # SPDX-License-Identifier: GPL-2.0 VERSION = 5 PATCHLEVEL = 10 -SUBLEVEL = 24 +SUBLEVEL = 25 EXTRAVERSION = NAME = Dare mighty things diff --git a/arch/x86/crypto/aesni-intel_asm.S b/arch/x86/crypto/aesni-intel_asm.S index 1852b19a73a0..57aef3f5a81e 100644 --- a/arch/x86/crypto/aesni-intel_asm.S +++ b/arch/x86/crypto/aesni-intel_asm.S @@ -318,7 +318,7 @@ _initial_blocks_\@: # Main loop - Encrypt/Decrypt remaining blocks - cmp $0, %r13 + test%r13, %r13 je _zero_cipher_left_\@ sub $64, %r13 je _four_cipher_left_\@ @@ -437,7 +437,7 @@ _multiple_of_16_bytes_\@: mov PBlockLen(%arg2), %r12 - cmp $0, %r12 + test %r12, %r12 je _partial_done\@ GHASH_MUL %xmm8, %xmm13, %xmm9, %xmm10, %xmm11, %xmm5, %xmm6 @@ -474,7 +474,7 @@ _T_8_\@: add $8, %r10 sub $8, %r11 psrldq $8, %xmm0 - cmp $0, %r11 + test%r11, %r11 je _return_T_done_\@ _T_4_\@: movd%xmm0, %eax @@ -482,7 +482,7 @@ _T_4_\@: add $4, %r10 sub $4, %r11 psrldq $4, %xmm0 - cmp $0, %r11 + test%r11, %r11 je _return_T_done_\@ _T_123_\@: movd%xmm0, %eax @@ -619,7 +619,7 @@ _get_AAD_blocks\@: /* read the last <16B of AAD */ _get_AAD_rest\@: - cmp$0, %r11 + test %r11, %r11 je _get_AAD_done\@ READ_PARTIAL_BLOCK %r10, %r11, \TMP1, \TMP7 @@ -640,7 +640,7 @@ _get_AAD_done\@: .macro PARTIAL_BLOCK CYPH_PLAIN_OUT PLAIN_CYPH_IN PLAIN_CYPH_LEN DATA_OFFSET \ AAD_HASH operation mov PBlockLen(%arg2), %r13 - cmp $0, %r13 + test%r13, %r13 je _partial_block_done_\@ # Leave Macro if no partial blocks # Read in input data without over reading cmp $16, \PLAIN_CYPH_LEN @@ -692,7 +692,7 @@ _no_extra_mask_1_\@: pshufb %xmm2, %xmm3 pxor%xmm3, \AAD_HASH - cmp $0, %r10 + test%r10, %r10 jl _partial_incomplete_1_\@ # GHASH computation for the last <16 Byte block @@ -727,7 +727,7 @@ _no_extra_mask_2_\@: pshufb %xmm2, %xmm9 pxor%xmm9, \AAD_HASH - cmp $0, %r10 + test%r10, %r10 jl _partial_incomplete_2_\@ # GHASH computation for the last <16 Byte block @@ -747,7 +747,7 @@ _encode_done_\@: pshufb %xmm2, %xmm9 .endif # output encrypted Bytes - cmp $0, %r10 + test%r10, %r10 jl _partial_fill_\@ mov %r13, %r12 mov $16, %r13 @@ -2715,25 +2715,18 @@ SYM_FUNC_END(aesni_ctr_enc) pxor CTR, IV; /* - * void aesni_xts_crypt8(const struct crypto_aes_ctx *ctx, u8 *dst, - * const u8 *src, bool enc, le128 *iv) + * void aesni_xts_encrypt(const struct crypto_aes_ctx *ctx, u8 *dst, + * const u8 *src, unsigned int len, le128 *iv) */ -SYM_FUNC_START(aesni_xts_crypt8) +SYM_FUNC_START(aesni_xts_encrypt) FRAME_BEGIN - cmpb $0, %cl - movl $0, %ecx - movl $240, %r10d - leaq _aesni_enc4, %r11 - leaq _aesni_dec4, %rax - cmovel %r10d, %ecx - cmoveq %rax, %r11 movdqa .Lgf128mul_x_ble_mask, GF128MUL_MASK movups (IVP), IV mov 480(KEYP), KLEN - addq %rcx, KEYP +.Lxts_enc_loop4: movdqa IV, STATE1 movdqu 0x00(INP), INC pxor INC, STATE1 @@ -2757,71 +2750,103 @@ SYM_FUNC_START(aesni_xts_crypt8) pxor INC, STATE4 movdqu IV, 0x30(OUTP) - CALL_NOSPEC r11 + call _aesni_enc4 movdqu 0x00(OUTP), INC pxor INC, STATE1 movdqu STATE1, 0x00(OUTP) - _aesni_gf128mul_x_ble() - movdqa IV, STATE1 - movdqu 0x40(INP), INC - pxor INC, STATE1 - movdqu IV, 0x40(OUTP) - movdqu 0x10(OUTP), INC pxor INC, STATE2 movdqu STATE2, 0x10(OUTP) - _aesni_gf128mul_x_ble() - movdqa IV, STATE2 - movdqu 0x50(INP), INC - pxor INC, STATE2 - movdqu IV, 0x50(OUTP) - movdqu 0x20(OUTP), INC pxor INC, STATE3 movdqu STATE3, 0x20(OUTP) - _aesni_gf128mul_x_ble() - movdqa IV, STATE3 - movdqu 0x60(INP), INC - pxor INC, STATE3 - movdqu IV, 0x60(OUTP) - movdqu 0x30(OUTP), INC pxor INC, STATE4 movdqu STATE4, 0x30(OUTP) _aesni_gf128mul_x_ble() - movdqa IV, STATE4 - movdqu 0x70(INP), INC - pxor INC, STATE4 - movdqu IV, 0x70(OUTP) - _aesni_gf128mul_x_ble() + add $64, INP + add $64, OUTP + sub $64, LEN + ja .Lxts_enc_loop4 + movups IV, (IVP) - CALL_NOSPEC r11 + FRAME_END + ret
