Re: MPX is broken for 32bit programs on a 64bit host

2018-12-05 Thread Sebastian Andrzej Siewior
On 2018-11-29 09:13:04 [-0800], Dave Hansen wrote:
> On 11/29/18 6:17 AM, Sebastian Andrzej Siewior wrote:
> > This is broken since v4.12-rc1. This is known [1] since April this year.
> > Should I send a removal patch for MPX or is someone actually going to
> > fix this? Or do we wait for gcc-9 to be released?
> 
> I've got a git tree prepared to do MPX removal.  I'll send a pull
> request for 4.21 (or whatever we call it).

Cold you please do it soon? I saw it on k.o. and it collides with my FPU
patches. I think that the MPX removal will be routed via the TIP tree.
So once it is there (and waiting for the merge window to open), I could
rebase my things on top of it (I doubt that it will be the other way
around).

Sebastian


Re: MPX is broken for 32bit programs on a 64bit host

2018-11-29 Thread Dave Hansen
On 11/29/18 6:17 AM, Sebastian Andrzej Siewior wrote:
> This is broken since v4.12-rc1. This is known [1] since April this year.
> Should I send a removal patch for MPX or is someone actually going to
> fix this? Or do we wait for gcc-9 to be released?

I've got a git tree prepared to do MPX removal.  I'll send a pull
request for 4.21 (or whatever we call it).


MPX is broken for 32bit programs on a 64bit host

2018-11-29 Thread Sebastian Andrzej Siewior
so I've been testing my FPU patches and noticed that the test
mpx-mini-test_32 [0] fails on 64bit host.
I went back to v4.4 and it didn't pass there fully, it ended with:
| starting mpx bounds table test
| ERROR: siginfo bounds do not match shadow bounds for register 0

But it did way more than it does today. Since commit 1b028f784e8c3
("x86/mm: Introduce mmap_compat_base() for 32-bit mmap()") it is broken
and ends very early with

| mpx dig (  1) complete, SUCCESS (   0 /0)
| #BR status == 2, missing bounds table,kernel should have handled!!

The 64bit cases passes. Didn't try the 32bit test case on a 32bit host.
Maybe the test case is fishy (I can't tell).

This is broken since v4.12-rc1. This is known [1] since April this year.
Should I send a removal patch for MPX or is someone actually going to
fix this? Or do we wait for gcc-9 to be released?

[0] tools/testing/selftests/x86/mpx-mini-test_32
[1] https://lkml.kernel.org/r/20180428175043.y35czmhcursyr...@gmail.com

Sebastian