Re: Oops with 2.6.24 git when loading iwl3945
[Thomas Tuttle - Sun, Dec 02, 2007 at 12:46:01PM -0500]
| On Sun, 2 Dec 2007 19:43:16 +0300, "Cyrill Gorcunov"
| <[EMAIL PROTECTED]> said:
| > [Thomas Tuttle - Tue, Nov 27, 2007 at 03:43:57PM -0500]
| > | Hey.
| > |
| > | I'm using a git snapshot that gentoo distributed mere hours ago (so I'm
| > | fairly confident it's current), and I'm getting an Oops when I try to
| > | load the iwl3945 driver. I've attached it as plain text.
| > |
| > | Hope this helps,
| > |
| > | Thomas Tuttle
| >
| > Hi Thomas,
| > Could you please test the patch?
|
| It didn't help. The original oops says the problem was in strcmp. It
| was a GPF, which suggests to me that one of the arguments is NULL.
| Since ops->name is checked at the beginning of the function, the only
| other possibility is that alg->ops->name is NULL. I added a bit of code
| to check for this, and it turns out that one of the strings was indeed
| NULL. I didn't know where to go from there in debugging, but I hope it
| helps.
|
| Thanks,
|
| Thomas Tuttle
|
Hi Thomas,
could you please try that one ;)
Ayway as my previous patch and this one have to be applied anyway (regardless
the OOPs you catched). So I've sent previous patch to list and this one too,
but that is more important for - does these (both) patch helped. Thanks a lot
for patience (i know the problem is in strcmp but it seems that is a side issue
-
main problems seems to be in sych. events)
Cyrill
---
From: Cyrill Gorcunov <[EMAIL PROTECTED]>
Date: Mon, 3 Dec 2007 22:12:30 +0300
Subject: [PATCH] [PATCH] NET: mac80211 - fix inappropriate memory freeing
This patch does fix inappropriate memory freeing in case
of requested rate_control_ops was not found. In this case
the list head entity is going to be accidently wasted.
Signed-off-by: Cyrill Gorcunov <[EMAIL PROTECTED]>
---
net/mac80211/ieee80211_rate.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/net/mac80211/ieee80211_rate.c b/net/mac80211/ieee80211_rate.c
index 3260a4a..c3f2783 100644
--- a/net/mac80211/ieee80211_rate.c
+++ b/net/mac80211/ieee80211_rate.c
@@ -60,11 +60,11 @@ void ieee80211_rate_control_unregister(struct
rate_control_ops *ops)
list_for_each_entry(alg, &rate_ctrl_algs, list) {
if (alg->ops == ops) {
list_del(&alg->list);
+ kfree(alg);
break;
}
}
mutex_unlock(&rate_ctrl_mutex);
- kfree(alg);
}
EXPORT_SYMBOL(ieee80211_rate_control_unregister);
--
1.5.3.5
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: Oops with 2.6.24 git when loading iwl3945
On 12/2/07, Thomas Tuttle <[EMAIL PROTECTED]> wrote: > On Sun, 2 Dec 2007 19:43:16 +0300, "Cyrill Gorcunov" > <[EMAIL PROTECTED]> said: > > [Thomas Tuttle - Tue, Nov 27, 2007 at 03:43:57PM -0500] > > | Hey. > > | > > | I'm using a git snapshot that gentoo distributed mere hours ago (so I'm > > | fairly confident it's current), and I'm getting an Oops when I try to > > | load the iwl3945 driver. I've attached it as plain text. > > | > > | Hope this helps, > > | > > | Thomas Tuttle > > > > Hi Thomas, > > Could you please test the patch? > > It didn't help. The original oops says the problem was in strcmp. It > was a GPF, which suggests to me that one of the arguments is NULL. > Since ops->name is checked at the beginning of the function, the only > other possibility is that alg->ops->name is NULL. I added a bit of code > to check for this, and it turns out that one of the strings was indeed > NULL. I didn't know where to go from there in debugging, but I hope it > helps. > > Thanks, > > Thomas Tuttle > Hi Thomas, could you please attach your kernel's .config (and in bugzilla too). Thanks. Cyrill -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: Oops with 2.6.24 git when loading iwl3945
[Thomas Tuttle - Sun, Dec 02, 2007 at 12:46:01PM -0500] | On Sun, 2 Dec 2007 19:43:16 +0300, "Cyrill Gorcunov" | <[EMAIL PROTECTED]> said: | > [Thomas Tuttle - Tue, Nov 27, 2007 at 03:43:57PM -0500] | > | Hey. | > | | > | I'm using a git snapshot that gentoo distributed mere hours ago (so I'm | > | fairly confident it's current), and I'm getting an Oops when I try to | > | load the iwl3945 driver. I've attached it as plain text. | > | | > | Hope this helps, | > | | > | Thomas Tuttle | > | > Hi Thomas, | > Could you please test the patch? | | It didn't help. The original oops says the problem was in strcmp. It | was a GPF, which suggests to me that one of the arguments is NULL. | Since ops->name is checked at the beginning of the function, the only | other possibility is that alg->ops->name is NULL. I added a bit of code | to check for this, and it turns out that one of the strings was indeed | NULL. I didn't know where to go from there in debugging, but I hope it | helps. | | Thanks, | | Thomas Tuttle | thanks, i do know that problem is in strcmp, i just thought the reason of bug was a delayed procedure execution 'case of missing mutex unlock. Have to dig deeper ;) Cyrill -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: Oops with 2.6.24 git when loading iwl3945
On Sun, 2 Dec 2007 19:43:16 +0300, "Cyrill Gorcunov" <[EMAIL PROTECTED]> said: > [Thomas Tuttle - Tue, Nov 27, 2007 at 03:43:57PM -0500] > | Hey. > | > | I'm using a git snapshot that gentoo distributed mere hours ago (so I'm > | fairly confident it's current), and I'm getting an Oops when I try to > | load the iwl3945 driver. I've attached it as plain text. > | > | Hope this helps, > | > | Thomas Tuttle > > Hi Thomas, > Could you please test the patch? It didn't help. The original oops says the problem was in strcmp. It was a GPF, which suggests to me that one of the arguments is NULL. Since ops->name is checked at the beginning of the function, the only other possibility is that alg->ops->name is NULL. I added a bit of code to check for this, and it turns out that one of the strings was indeed NULL. I didn't know where to go from there in debugging, but I hope it helps. Thanks, Thomas Tuttle -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: Oops with 2.6.24 git when loading iwl3945
[Thomas Tuttle - Tue, Nov 27, 2007 at 03:43:57PM -0500]
| Hey.
|
| I'm using a git snapshot that gentoo distributed mere hours ago (so I'm
| fairly confident it's current), and I'm getting an Oops when I try to
| load the iwl3945 driver. I've attached it as plain text.
|
| Hope this helps,
|
| Thomas Tuttle
Hi Thomas,
Could you please test the patch?
Cyrill
---
Seems just mutex unlock is missed ;)
net/mac80211/ieee80211_rate.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/net/mac80211/ieee80211_rate.c b/net/mac80211/ieee80211_rate.c
index 7254bd6..3260a4a 100644
--- a/net/mac80211/ieee80211_rate.c
+++ b/net/mac80211/ieee80211_rate.c
@@ -33,6 +33,7 @@ int ieee80211_rate_control_register(struct rate_control_ops
*ops)
if (!strcmp(alg->ops->name, ops->name)) {
/* don't register an algorithm twice */
WARN_ON(1);
+ mutex_unlock(&rate_ctrl_mutex);
return -EALREADY;
}
}
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: Oops with 2.6.24 git when loading iwl3945
On Tuesday, 27 of November 2007, Thomas Tuttle wrote: > Hey. > > I'm using a git snapshot that gentoo distributed mere hours ago (so I'm > fairly confident it's current), and I'm getting an Oops when I try to > load the iwl3945 driver. I've attached it as plain text. Can you also attach it to the Bugzilla entry at http://bugzilla.kernel.org/show_bug.cgi?id=9470 , please? Thanks, Rafael - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: Oops with 2.6.24 git when loading iwl3945
Andrew Morton wrote: > I have a shiny new t61p which uses iwl3945. It barely runs carefully > selected bits of the fc8 2.6.23-based kernel and heaven knows what 2.6.24 > will do to it. It will join my Vaio as a > tool-of-kernel-developer-tormenting. This means that your wireless should > keep working ;) My X60 is boringly stable with currentish kernels, and the recent changes to the wireless driver have made it feel actually solid. Unless you want blinky lights. J - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: Oops with 2.6.24 git when loading iwl3945
On Tue, 27 Nov 2007 15:43:57 -0500 "Thomas Tuttle" <[EMAIL PROTECTED]> wrote: > Hey. > > I'm using a git snapshot that gentoo distributed mere hours ago (so I'm > fairly confident it's current), and I'm getting an Oops when I try to > load the iwl3945 driver. I've attached it as plain text. > Let's cc linux-wireless. > ieee80211_crypt: registered algorithm 'NULL' > ieee80211_crypt: registered algorithm 'WEP' > iwl3945: Intel(R) PRO/Wireless 3945ABG/BG Network Connection driver for > Linux, 1.1.17kds > iwl3945: Copyright(c) 2003-2007 Intel Corporation > ACPI: PCI Interrupt :0c:00.0[A] -> GSI 17 (level, low) -> IRQ 17 > PCI: Setting latency timer of device :0c:00.0 to 64 > iwl3945: Detected Intel PRO/Wireless 3945ABG Network Connection > iwl3945: Tunable channels: 11 802.11bg, 13 802.11a channels > general protection fault: [1] SMP > CPU 0 > Modules linked in: iwl3945 ieee80211_crypt_wep ieee80211_crypt mac80211 > cfg80211 i915 drm snd_seq_oss snd_seq_device snd_seq_midi_event snd_seq > snd_pcm_oss snd_mixer_oss snd_hda_intel snd_pcm snd_timer snd soundcore > snd_page_alloc coretemp hwmon rtc rfcomm l2cap hci_usb bluetooth uhci_hcd > ehci_hcd usbcore evdev b44 ssb psmouse > Pid: 5230, comm: iwl3945/0 Not tainted 2.6.24-rc3-git2 #1 > RIP: 0010:[] [] strcmp+0x0/0x1a > RSP: 0018:810074d93dd8 EFLAGS: 00010287 > RAX: 881c2e80 RBX: 8100752b84e0 RCX: 810074d92000 > RDX: 810074de2073 RSI: 881c086b RDI: 00020074016b > RBP: 881c8e80 R08: 810074d92000 R09: 810002bf77a0 > R10: R11: 0001 R12: 88197540 > R13: 810074de2060 R14: 810074de2030 R15: 0038 > FS: () GS:8059d000() knlGS: > CS: 0010 DS: 0018 ES: 0018 CR0: 8005003b > CR2: 2b313ecef000 CR3: 7d10 CR4: 06e0 > DR0: DR1: DR2: > DR3: DR6: 0ff0 DR7: 0400 > Process iwl3945/0 (pid: 5230, threadinfo 810074d92000, task > 81007c812000) > Stack: 88183a0e 810074d52220 810074d518c0 810074de2000 > 881a81e2 74d93e30 > 81007c812000 > Call Trace: > [] :mac80211:ieee80211_rate_control_register+0x3d/0xdd > [] :iwl3945:iwl_bg_alive_start+0xc96/0xef9 > [] thread_return+0x3d/0x81 > [] :iwl3945:iwl_bg_alive_start+0x0/0xef9 > [] run_workqueue+0x7f/0x10b > [] worker_thread+0x0/0xe4 > [] worker_thread+0xda/0xe4 > [] autoremove_wake_function+0x0/0x2e > [] kthread+0x47/0x75 > [] child_rip+0xa/0x12 > [] kthread+0x0/0x75 > [] child_rip+0x0/0x12 > > > Code: 8a 17 89 d0 2a 06 48 ff c6 84 c0 75 09 84 d2 74 05 48 ff c7 > RIP [] strcmp+0x0/0x1a > RSP > I have a shiny new t61p which uses iwl3945. It barely runs carefully selected bits of the fc8 2.6.23-based kernel and heaven knows what 2.6.24 will do to it. It will join my Vaio as a tool-of-kernel-developer-tormenting. This means that your wireless should keep working ;) - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Oops with 2.6.24 git when loading iwl3945
Hey. I'm using a git snapshot that gentoo distributed mere hours ago (so I'm fairly confident it's current), and I'm getting an Oops when I try to load the iwl3945 driver. I've attached it as plain text. Hope this helps, Thomas Tuttle ieee80211_crypt: registered algorithm 'NULL' ieee80211_crypt: registered algorithm 'WEP' iwl3945: Intel(R) PRO/Wireless 3945ABG/BG Network Connection driver for Linux, 1.1.17kds iwl3945: Copyright(c) 2003-2007 Intel Corporation ACPI: PCI Interrupt :0c:00.0[A] -> GSI 17 (level, low) -> IRQ 17 PCI: Setting latency timer of device :0c:00.0 to 64 iwl3945: Detected Intel PRO/Wireless 3945ABG Network Connection iwl3945: Tunable channels: 11 802.11bg, 13 802.11a channels general protection fault: [1] SMP CPU 0 Modules linked in: iwl3945 ieee80211_crypt_wep ieee80211_crypt mac80211 cfg80211 i915 drm snd_seq_oss snd_seq_device snd_seq_midi_event snd_seq snd_pcm_oss snd_mixer_oss snd_hda_intel snd_pcm snd_timer snd soundcore snd_page_alloc coretemp hwmon rtc rfcomm l2cap hci_usb bluetooth uhci_hcd ehci_hcd usbcore evdev b44 ssb psmouse Pid: 5230, comm: iwl3945/0 Not tainted 2.6.24-rc3-git2 #1 RIP: 0010:[] [] strcmp+0x0/0x1a RSP: 0018:810074d93dd8 EFLAGS: 00010287 RAX: 881c2e80 RBX: 8100752b84e0 RCX: 810074d92000 RDX: 810074de2073 RSI: 881c086b RDI: 00020074016b RBP: 881c8e80 R08: 810074d92000 R09: 810002bf77a0 R10: R11: 0001 R12: 88197540 R13: 810074de2060 R14: 810074de2030 R15: 0038 FS: () GS:8059d000() knlGS: CS: 0010 DS: 0018 ES: 0018 CR0: 8005003b CR2: 2b313ecef000 CR3: 7d10 CR4: 06e0 DR0: DR1: DR2: DR3: DR6: 0ff0 DR7: 0400 Process iwl3945/0 (pid: 5230, threadinfo 810074d92000, task 81007c812000) Stack: 88183a0e 810074d52220 810074d518c0 810074de2000 881a81e2 74d93e30 81007c812000 Call Trace: [] :mac80211:ieee80211_rate_control_register+0x3d/0xdd [] :iwl3945:iwl_bg_alive_start+0xc96/0xef9 [] thread_return+0x3d/0x81 [] :iwl3945:iwl_bg_alive_start+0x0/0xef9 [] run_workqueue+0x7f/0x10b [] worker_thread+0x0/0xe4 [] worker_thread+0xda/0xe4 [] autoremove_wake_function+0x0/0x2e [] kthread+0x47/0x75 [] child_rip+0xa/0x12 [] kthread+0x0/0x75 [] child_rip+0x0/0x12 Code: 8a 17 89 d0 2a 06 48 ff c6 84 c0 75 09 84 d2 74 05 48 ff c7 RIP [] strcmp+0x0/0x1a RSP
