Re: PATCH: 2.4.3 tinny module interface cleanum

[Hugh Dickins]

On Thu, 26 Apr 2001, Ingo Oeser wrote:
> On Thu, Apr 26, 2001 at 10:58:46AM +0200, Martin Dalecki wrote:
> > 1. Help making the module interface cleaner by a tinny margin :-).
> 
> You only help changing the API during a stable[1] series. Wait until 2.5
> for this.
> 
> API cannot change during stable series. (ABI can, BTW)
> 
> So lets just forget about this, ok ;-)

Wrong answer: AV already did it (static get_empty_super) in 2.4.4-pre4.

Hugh

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: PATCH: 2.4.3 tinny module interface cleanum

[Martin Dalecki]

Ingo Oeser wrote:
> 
> On Thu, Apr 26, 2001 at 10:58:46AM +0200, Martin Dalecki wrote:
> > 1. Help making the module interface cleaner by a tinny margin :-).
> 
> You only help changing the API during a stable[1] series. Wait until 2.5
> for this.
> 
> API cannot change during stable series. (ABI can, BTW)
> So lets just forget about this, ok ;-)

So just show me one module using this function in a non-broken way!
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: PATCH: 2.4.3 tinny module interface cleanum

[Ingo Oeser]

On Thu, Apr 26, 2001 at 10:58:46AM +0200, Martin Dalecki wrote:
> 1. Help making the module interface cleaner by a tinny margin :-).

You only help changing the API during a stable[1] series. Wait until 2.5
for this.

API cannot change during stable series. (ABI can, BTW)

So lets just forget about this, ok ;-)

Regards

Ingo Oeser

[1] By stable I mean "marked as the stable branch" not the actual
   behavior >;)
-- 
10.+11.03.2001 - 3. Chemnitzer LinuxTag 
  been there and had much fun   
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

PATCH: 2.4.3 tinny module interface cleanum

[Martin Dalecki]

Hello!

The following patch is making the get_empty_super() function
just local to the place where it's only use is and where it's only
use should be: fs/super.c

The removal of this symbol from ksyms.c should:

1. Help making the module interface cleaner by a tinny margin :-).

2. shouldn't hurt anything sane.

Please apply... line sloops in the patch are due to bla bla, and
don't hurt...

Thank's

-- 
- phone: +49 214 8656 283
- job:   eVision-Ventures AG, LEV .de (MY OPINIONS ARE MY OWN!)
- langs: de_DE.ISO8859-1, en_US, pl_PL.ISO8859-2, last ressort:
ru_RU.KOI8-R

diff -ur linux/fs/super.c new/fs/super.c
--- linux/fs/super.cWed Apr 18 20:41:17 2001
+++ new/fs/super.c  Thu Apr 26 01:08:48 2001
@@ -691,7 +691,7 @@
  * the request.
  */
  
-struct super_block *get_empty_super(void)
+static struct super_block *get_empty_super(void)
 {
struct super_block *s;
 
diff -ur linux/include/linux/fs.h new/include/linux/fs.h
--- linux/include/linux/fs.hWed Apr 18 20:41:18 2001
+++ new/include/linux/fs.h  Thu Apr 26 01:03:03 2001
@@ -1291,7 +1285,6 @@
 
 extern struct file_system_type *get_fs_type(const char *name);
 extern struct super_block *get_super(kdev_t);
-struct super_block *get_empty_super(void);
 extern void put_super(kdev_t);
 unsigned long generate_cluster(kdev_t, int b[], int);
 unsigned long generate_cluster_swab32(kdev_t, int b[], int);
diff -ur linux/kernel/ksyms.c new/kernel/ksyms.c
--- linux/kernel/ksyms.cWed Apr 18 20:41:19 2001
+++ new/kernel/ksyms.c  Thu Apr 26 00:40:48 2001
@@ -129,7 +129,6 @@
 EXPORT_SYMBOL(update_atime);
 EXPORT_SYMBOL(get_fs_type);
 EXPORT_SYMBOL(get_super);
-EXPORT_SYMBOL(get_empty_super);
 EXPORT_SYMBOL(getname);
 EXPORT_SYMBOL(names_cachep);
 EXPORT_SYMBOL(fput);

PATCH: 2.4.3 tinny module interface cleanum

[Martin Dalecki]

Hello!

The following patch is making the get_empty_super() function
just local to the place where it's only use is and where it's only
use should be: fs/super.c

The removal of this symbol from ksyms.c should:

1. Help making the module interface cleaner by a tinny margin :-).

2. shouldn't hurt anything sane.

Please apply... line sloops in the patch are due to bla bla, and
don't hurt...

Thank's

-- 
- phone: +49 214 8656 283
- job:   eVision-Ventures AG, LEV .de (MY OPINIONS ARE MY OWN!)
- langs: de_DE.ISO8859-1, en_US, pl_PL.ISO8859-2, last ressort:
ru_RU.KOI8-R

diff -ur linux/fs/super.c new/fs/super.c
--- linux/fs/super.cWed Apr 18 20:41:17 2001
+++ new/fs/super.c  Thu Apr 26 01:08:48 2001
@@ -691,7 +691,7 @@
  * the request.
  */
  
-struct super_block *get_empty_super(void)
+static struct super_block *get_empty_super(void)
 {
struct super_block *s;
 
diff -ur linux/include/linux/fs.h new/include/linux/fs.h
--- linux/include/linux/fs.hWed Apr 18 20:41:18 2001
+++ new/include/linux/fs.h  Thu Apr 26 01:03:03 2001
@@ -1291,7 +1285,6 @@
 
 extern struct file_system_type *get_fs_type(const char *name);
 extern struct super_block *get_super(kdev_t);
-struct super_block *get_empty_super(void);
 extern void put_super(kdev_t);
 unsigned long generate_cluster(kdev_t, int b[], int);
 unsigned long generate_cluster_swab32(kdev_t, int b[], int);
diff -ur linux/kernel/ksyms.c new/kernel/ksyms.c
--- linux/kernel/ksyms.cWed Apr 18 20:41:19 2001
+++ new/kernel/ksyms.c  Thu Apr 26 00:40:48 2001
@@ -129,7 +129,6 @@
 EXPORT_SYMBOL(update_atime);
 EXPORT_SYMBOL(get_fs_type);
 EXPORT_SYMBOL(get_super);
-EXPORT_SYMBOL(get_empty_super);
 EXPORT_SYMBOL(getname);
 EXPORT_SYMBOL(names_cachep);
 EXPORT_SYMBOL(fput);

Re: PATCH: 2.4.3 tinny module interface cleanum

[Ingo Oeser]

On Thu, Apr 26, 2001 at 10:58:46AM +0200, Martin Dalecki wrote:
 1. Help making the module interface cleaner by a tinny margin :-).

You only help changing the API during a stable[1] series. Wait until 2.5
for this.

API cannot change during stable series. (ABI can, BTW)

So lets just forget about this, ok ;-)

Regards

Ingo Oeser

[1] By stable I mean marked as the stable branch not the actual
   behavior ;)
-- 
10.+11.03.2001 - 3. Chemnitzer LinuxTag http://www.tu-chemnitz.de/linux/tag
  been there and had much fun   
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: PATCH: 2.4.3 tinny module interface cleanum

[Martin Dalecki]

Ingo Oeser wrote:
 
 On Thu, Apr 26, 2001 at 10:58:46AM +0200, Martin Dalecki wrote:
  1. Help making the module interface cleaner by a tinny margin :-).
 
 You only help changing the API during a stable[1] series. Wait until 2.5
 for this.
 
 API cannot change during stable series. (ABI can, BTW)
 So lets just forget about this, ok ;-)

So just show me one module using this function in a non-broken way!
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: PATCH: 2.4.3 tinny module interface cleanum

[Hugh Dickins]

On Thu, 26 Apr 2001, Ingo Oeser wrote:
 On Thu, Apr 26, 2001 at 10:58:46AM +0200, Martin Dalecki wrote:
  1. Help making the module interface cleaner by a tinny margin :-).
 
 You only help changing the API during a stable[1] series. Wait until 2.5
 for this.
 
 API cannot change during stable series. (ABI can, BTW)
 
 So lets just forget about this, ok ;-)

Wrong answer: AV already did it (static get_empty_super) in 2.4.4-pre4.

Hugh

-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/