Re: Problems with SMP & ACPI powering off
Rafael J. Wysocki wrote: On Friday, 28 September 2007 15:22, Mark Lord wrote: Rafael J. Wysocki wrote: On Friday, 28 September 2007 06:57, Len Brown wrote: On Thursday 27 September 2007 18:00, Rafael J. Wysocki wrote: On Thursday, 27 September 2007 23:29, Mark Lord wrote: Question: do we disable all CPUs except 0 when doing ACPI power off? No, but we should. We used to. It is absolutely mandatory -- else it confuses the BIOS on some boards b/c it isn't expecting SMM to get entered from other than cpu0. Can we use the CPU hotplug for that, like in the suspend/hibernation case? Well, so far it's working: about ten poweroffs since I patched it, and no issues with any of them. Prior to that, it seemed like about one in five poweroffs wouldn't (power off). It'll take a lot more testing to confirm, though. What can I call to determine if more than one CPU is enabled, anyway? Here's the hack I'm using here, very situation (2 cores) specific, and it still has some printk's leftover with a sleep so I have time to read them before the lights go out. :) Well, we have disable_nonboot_cpus() that we use for suspend and that is supposed to be general. The question is when to call it. How about from the obvious candidate: kernel/sys.c::kernel_power_off() ? I'll rework my hack into a proper patch there, repost it here, and test with it for another day or two. -ml - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: Problems with SMP & ACPI powering off
On Friday, 28 September 2007 15:22, Mark Lord wrote: > Rafael J. Wysocki wrote: > > On Friday, 28 September 2007 06:57, Len Brown wrote: > >> On Thursday 27 September 2007 18:00, Rafael J. Wysocki wrote: > >>> On Thursday, 27 September 2007 23:29, Mark Lord wrote: > Question: do we disable all CPUs except 0 when doing ACPI power off? > >>> No, but we should. > >> We used to. > >> It is absolutely mandatory -- else it confuses the BIOS on some boards > >> b/c it isn't expecting SMM to get entered from other than cpu0. > > > > Can we use the CPU hotplug for that, like in the suspend/hibernation case? > > Well, so far it's working: about ten poweroffs since I patched it, > and no issues with any of them. Prior to that, it seemed like about > one in five poweroffs wouldn't (power off). > > It'll take a lot more testing to confirm, though. > > What can I call to determine if more than one CPU is enabled, anyway? > > Here's the hack I'm using here, very situation (2 cores) specific, > and it still has some printk's leftover with a sleep so I have time > to read them before the lights go out. :) Well, we have disable_nonboot_cpus() that we use for suspend and that is supposed to be general. The question is when to call it. Greetings, Rafael - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: Problems with SMP & ACPI powering off
Rafael J. Wysocki wrote:
On Friday, 28 September 2007 06:57, Len Brown wrote:
On Thursday 27 September 2007 18:00, Rafael J. Wysocki wrote:
On Thursday, 27 September 2007 23:29, Mark Lord wrote:
Question: do we disable all CPUs except 0 when doing ACPI power off?
No, but we should.
We used to.
It is absolutely mandatory -- else it confuses the BIOS on some boards
b/c it isn't expecting SMM to get entered from other than cpu0.
Can we use the CPU hotplug for that, like in the suspend/hibernation case?
Well, so far it's working: about ten poweroffs since I patched it,
and no issues with any of them. Prior to that, it seemed like about
one in five poweroffs wouldn't (power off).
It'll take a lot more testing to confirm, though.
What can I call to determine if more than one CPU is enabled, anyway?
Here's the hack I'm using here, very situation (2 cores) specific,
and it still has some printk's leftover with a sleep so I have time
to read them before the lights go out. :)
--- old/arch/i386/kernel/reboot.c 2007-09-27 17:17:00.0 -0400
+++ linux/arch/i386/kernel/reboot.c 2007-09-27 17:15:35.0 -0400
@@ -393,8 +393,22 @@
.halt = native_machine_halt,
};
+static void kill_cpu1(void)
+{
+ extern int cpu_down(unsigned int cpu);
+
+ printk(KERN_EMERG "kill_cpu1: was running on CPU%d\n",
smp_processor_id());
+ /* Some bioses don't like being called from CPU != 0 */
+ set_cpus_allowed(current, cpumask_of_cpu(0));
+ printk(KERN_EMERG "kill_cpu1: now running on CPU%d\n",
smp_processor_id());
+ cpu_down(1);
+ printk(KERN_EMERG "kill_cpu1: done\n");
+ msleep(1000);
+}
+
void machine_power_off(void)
{
+ (void)kill_cpu1();
machine_ops.power_off();
}
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: Problems with SMP & ACPI powering off
On Friday, 28 September 2007 06:57, Len Brown wrote: > On Thursday 27 September 2007 18:00, Rafael J. Wysocki wrote: > > On Thursday, 27 September 2007 23:29, Mark Lord wrote: > > > Question: do we disable all CPUs except 0 when doing ACPI power off? > > > > No, but we should. > > We used to. > It is absolutely mandatory -- else it confuses the BIOS on some boards > b/c it isn't expecting SMM to get entered from other than cpu0. Can we use the CPU hotplug for that, like in the suspend/hibernation case? Rafael - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: Problems with SMP ACPI powering off
On Friday, 28 September 2007 15:22, Mark Lord wrote: Rafael J. Wysocki wrote: On Friday, 28 September 2007 06:57, Len Brown wrote: On Thursday 27 September 2007 18:00, Rafael J. Wysocki wrote: On Thursday, 27 September 2007 23:29, Mark Lord wrote: Question: do we disable all CPUs except 0 when doing ACPI power off? No, but we should. We used to. It is absolutely mandatory -- else it confuses the BIOS on some boards b/c it isn't expecting SMM to get entered from other than cpu0. Can we use the CPU hotplug for that, like in the suspend/hibernation case? Well, so far it's working: about ten poweroffs since I patched it, and no issues with any of them. Prior to that, it seemed like about one in five poweroffs wouldn't (power off). It'll take a lot more testing to confirm, though. What can I call to determine if more than one CPU is enabled, anyway? Here's the hack I'm using here, very situation (2 cores) specific, and it still has some printk's leftover with a sleep so I have time to read them before the lights go out. :) Well, we have disable_nonboot_cpus() that we use for suspend and that is supposed to be general. The question is when to call it. Greetings, Rafael - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: Problems with SMP ACPI powering off
Rafael J. Wysocki wrote: On Friday, 28 September 2007 15:22, Mark Lord wrote: Rafael J. Wysocki wrote: On Friday, 28 September 2007 06:57, Len Brown wrote: On Thursday 27 September 2007 18:00, Rafael J. Wysocki wrote: On Thursday, 27 September 2007 23:29, Mark Lord wrote: Question: do we disable all CPUs except 0 when doing ACPI power off? No, but we should. We used to. It is absolutely mandatory -- else it confuses the BIOS on some boards b/c it isn't expecting SMM to get entered from other than cpu0. Can we use the CPU hotplug for that, like in the suspend/hibernation case? Well, so far it's working: about ten poweroffs since I patched it, and no issues with any of them. Prior to that, it seemed like about one in five poweroffs wouldn't (power off). It'll take a lot more testing to confirm, though. What can I call to determine if more than one CPU is enabled, anyway? Here's the hack I'm using here, very situation (2 cores) specific, and it still has some printk's leftover with a sleep so I have time to read them before the lights go out. :) Well, we have disable_nonboot_cpus() that we use for suspend and that is supposed to be general. The question is when to call it. How about from the obvious candidate: kernel/sys.c::kernel_power_off() ? I'll rework my hack into a proper patch there, repost it here, and test with it for another day or two. -ml - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: Problems with SMP ACPI powering off
Rafael J. Wysocki wrote:
On Friday, 28 September 2007 06:57, Len Brown wrote:
On Thursday 27 September 2007 18:00, Rafael J. Wysocki wrote:
On Thursday, 27 September 2007 23:29, Mark Lord wrote:
Question: do we disable all CPUs except 0 when doing ACPI power off?
No, but we should.
We used to.
It is absolutely mandatory -- else it confuses the BIOS on some boards
b/c it isn't expecting SMM to get entered from other than cpu0.
Can we use the CPU hotplug for that, like in the suspend/hibernation case?
Well, so far it's working: about ten poweroffs since I patched it,
and no issues with any of them. Prior to that, it seemed like about
one in five poweroffs wouldn't (power off).
It'll take a lot more testing to confirm, though.
What can I call to determine if more than one CPU is enabled, anyway?
Here's the hack I'm using here, very situation (2 cores) specific,
and it still has some printk's leftover with a sleep so I have time
to read them before the lights go out. :)
--- old/arch/i386/kernel/reboot.c 2007-09-27 17:17:00.0 -0400
+++ linux/arch/i386/kernel/reboot.c 2007-09-27 17:15:35.0 -0400
@@ -393,8 +393,22 @@
.halt = native_machine_halt,
};
+static void kill_cpu1(void)
+{
+ extern int cpu_down(unsigned int cpu);
+
+ printk(KERN_EMERG kill_cpu1: was running on CPU%d\n,
smp_processor_id());
+ /* Some bioses don't like being called from CPU != 0 */
+ set_cpus_allowed(current, cpumask_of_cpu(0));
+ printk(KERN_EMERG kill_cpu1: now running on CPU%d\n,
smp_processor_id());
+ cpu_down(1);
+ printk(KERN_EMERG kill_cpu1: done\n);
+ msleep(1000);
+}
+
void machine_power_off(void)
{
+ (void)kill_cpu1();
machine_ops.power_off();
}
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: Problems with SMP ACPI powering off
On Friday, 28 September 2007 06:57, Len Brown wrote: On Thursday 27 September 2007 18:00, Rafael J. Wysocki wrote: On Thursday, 27 September 2007 23:29, Mark Lord wrote: Question: do we disable all CPUs except 0 when doing ACPI power off? No, but we should. We used to. It is absolutely mandatory -- else it confuses the BIOS on some boards b/c it isn't expecting SMM to get entered from other than cpu0. Can we use the CPU hotplug for that, like in the suspend/hibernation case? Rafael - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: Problems with SMP & ACPI powering off
On Thursday 27 September 2007 18:00, Rafael J. Wysocki wrote: > On Thursday, 27 September 2007 23:29, Mark Lord wrote: > > Question: do we disable all CPUs except 0 when doing ACPI power off? > > No, but we should. We used to. It is absolutely mandatory -- else it confuses the BIOS on some boards b/c it isn't expecting SMM to get entered from other than cpu0. -Len - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: Problems with SMP & ACPI powering off
Rafael J. Wysocki wrote: On Thursday, 27 September 2007 23:29, Mark Lord wrote: Question: do we disable all CPUs except 0 when doing ACPI power off? No, but we should. Background: I have a machine here dedicated to running MythTV. It powers up to record, and then sets the RTC alarm for next time and powers down again in between recordings. It has an Intel Core2duo E6300 CPU, currently on an ICH8 motherboard. Previously it was on a completely different (vendor,bios,...) ICH7 motherboard. In both cases, "halt -p" sometimes fails to actually turn off the power, which means that it later then fails to "turn on" to record again. Annoying. This is a 32-bit kernel/runtime, with full ACPI (not APM) kernel support enabled. So I'm wondering if it may be due to the old SMP-poweroff bogeyman ? May be. Which kernel? Latest 2.6.23-rc-git. Same problem from time to time on 2.6.17, as well. Dunno about in between those Revs., but it's much more common on the latest than it was on the old kernel. For now, I've hardcoded a cpu_down(1) into the poweroff code, and we'll see if that helps or is merely redundant. But I do wonder where else to look for a cause? Two different boards, vendors, BIOSs, same CPU chip. Same problem. Same chipset, perchance? Mmmm I originally didn't think so. But actually one board is ICH8, the other ICH8R, so yes, they use the same chipset. Cheers - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: Problems with SMP & ACPI powering off
On Thursday, 27 September 2007 23:29, Mark Lord wrote: > Question: do we disable all CPUs except 0 when doing ACPI power off? No, but we should. > Background: > I have a machine here dedicated to running MythTV. > It powers up to record, and then sets the RTC alarm for next time > and powers down again in between recordings. > > It has an Intel Core2duo E6300 CPU, currently on an ICH8 motherboard. > Previously it was on a completely different (vendor,bios,...) ICH7 > motherboard. > > In both cases, "halt -p" sometimes fails to actually turn off the power, > which means that it later then fails to "turn on" to record again. > > Annoying. > > This is a 32-bit kernel/runtime, with full ACPI (not APM) kernel support > enabled. > > So I'm wondering if it may be due to the old SMP-poweroff bogeyman ? May be. Which kernel? > For now, I've hardcoded a cpu_down(1) into the poweroff code, > and we'll see if that helps or is merely redundant. > > But I do wonder where else to look for a cause? > > Two different boards, vendors, BIOSs, same CPU chip. Same problem. Same chipset, perchance? Greetings, Rafael - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: Problems with SMP & ACPI powering off
Mark Lord wrote: Question: do we disable all CPUs except 0 when doing ACPI power off? Background: I have a machine here dedicated to running MythTV. It powers up to record, and then sets the RTC alarm for next time and powers down again in between recordings. It has an Intel Core2duo E6300 CPU, currently on an ICH8 motherboard. Previously it was on a completely different (vendor,bios,...) ICH7 motherboard. In both cases, "halt -p" sometimes fails to actually turn off the power, which means that it later then fails to "turn on" to record again. Annoying. This is a 32-bit kernel/runtime, with full ACPI (not APM) kernel support enabled. So I'm wondering if it may be due to the old SMP-poweroff bogeyman ? For now, I've hardcoded a cpu_down(1) into the poweroff code, and we'll see if that helps or is merely redundant. But I do wonder where else to look for a cause? Two different boards, vendors, BIOSs, same CPU chip. Same problem. Oh, and two different power-supplies, too. -ml - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Problems with SMP & ACPI powering off
Question: do we disable all CPUs except 0 when doing ACPI power off? Background: I have a machine here dedicated to running MythTV. It powers up to record, and then sets the RTC alarm for next time and powers down again in between recordings. It has an Intel Core2duo E6300 CPU, currently on an ICH8 motherboard. Previously it was on a completely different (vendor,bios,...) ICH7 motherboard. In both cases, "halt -p" sometimes fails to actually turn off the power, which means that it later then fails to "turn on" to record again. Annoying. This is a 32-bit kernel/runtime, with full ACPI (not APM) kernel support enabled. So I'm wondering if it may be due to the old SMP-poweroff bogeyman ? For now, I've hardcoded a cpu_down(1) into the poweroff code, and we'll see if that helps or is merely redundant. But I do wonder where else to look for a cause? Two different boards, vendors, BIOSs, same CPU chip. Same problem. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Problems with SMP ACPI powering off
Question: do we disable all CPUs except 0 when doing ACPI power off? Background: I have a machine here dedicated to running MythTV. It powers up to record, and then sets the RTC alarm for next time and powers down again in between recordings. It has an Intel Core2duo E6300 CPU, currently on an ICH8 motherboard. Previously it was on a completely different (vendor,bios,...) ICH7 motherboard. In both cases, halt -p sometimes fails to actually turn off the power, which means that it later then fails to turn on to record again. Annoying. This is a 32-bit kernel/runtime, with full ACPI (not APM) kernel support enabled. So I'm wondering if it may be due to the old SMP-poweroff bogeyman ? For now, I've hardcoded a cpu_down(1) into the poweroff code, and we'll see if that helps or is merely redundant. But I do wonder where else to look for a cause? Two different boards, vendors, BIOSs, same CPU chip. Same problem. - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: Problems with SMP ACPI powering off
Mark Lord wrote: Question: do we disable all CPUs except 0 when doing ACPI power off? Background: I have a machine here dedicated to running MythTV. It powers up to record, and then sets the RTC alarm for next time and powers down again in between recordings. It has an Intel Core2duo E6300 CPU, currently on an ICH8 motherboard. Previously it was on a completely different (vendor,bios,...) ICH7 motherboard. In both cases, halt -p sometimes fails to actually turn off the power, which means that it later then fails to turn on to record again. Annoying. This is a 32-bit kernel/runtime, with full ACPI (not APM) kernel support enabled. So I'm wondering if it may be due to the old SMP-poweroff bogeyman ? For now, I've hardcoded a cpu_down(1) into the poweroff code, and we'll see if that helps or is merely redundant. But I do wonder where else to look for a cause? Two different boards, vendors, BIOSs, same CPU chip. Same problem. Oh, and two different power-supplies, too. -ml - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: Problems with SMP ACPI powering off
On Thursday, 27 September 2007 23:29, Mark Lord wrote: Question: do we disable all CPUs except 0 when doing ACPI power off? No, but we should. Background: I have a machine here dedicated to running MythTV. It powers up to record, and then sets the RTC alarm for next time and powers down again in between recordings. It has an Intel Core2duo E6300 CPU, currently on an ICH8 motherboard. Previously it was on a completely different (vendor,bios,...) ICH7 motherboard. In both cases, halt -p sometimes fails to actually turn off the power, which means that it later then fails to turn on to record again. Annoying. This is a 32-bit kernel/runtime, with full ACPI (not APM) kernel support enabled. So I'm wondering if it may be due to the old SMP-poweroff bogeyman ? May be. Which kernel? For now, I've hardcoded a cpu_down(1) into the poweroff code, and we'll see if that helps or is merely redundant. But I do wonder where else to look for a cause? Two different boards, vendors, BIOSs, same CPU chip. Same problem. Same chipset, perchance? Greetings, Rafael - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: Problems with SMP ACPI powering off
Rafael J. Wysocki wrote: On Thursday, 27 September 2007 23:29, Mark Lord wrote: Question: do we disable all CPUs except 0 when doing ACPI power off? No, but we should. Background: I have a machine here dedicated to running MythTV. It powers up to record, and then sets the RTC alarm for next time and powers down again in between recordings. It has an Intel Core2duo E6300 CPU, currently on an ICH8 motherboard. Previously it was on a completely different (vendor,bios,...) ICH7 motherboard. In both cases, halt -p sometimes fails to actually turn off the power, which means that it later then fails to turn on to record again. Annoying. This is a 32-bit kernel/runtime, with full ACPI (not APM) kernel support enabled. So I'm wondering if it may be due to the old SMP-poweroff bogeyman ? May be. Which kernel? Latest 2.6.23-rc-git. Same problem from time to time on 2.6.17, as well. Dunno about in between those Revs., but it's much more common on the latest than it was on the old kernel. For now, I've hardcoded a cpu_down(1) into the poweroff code, and we'll see if that helps or is merely redundant. But I do wonder where else to look for a cause? Two different boards, vendors, BIOSs, same CPU chip. Same problem. Same chipset, perchance? Mmmm I originally didn't think so. But actually one board is ICH8, the other ICH8R, so yes, they use the same chipset. Cheers - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: Problems with SMP ACPI powering off
On Thursday 27 September 2007 18:00, Rafael J. Wysocki wrote: On Thursday, 27 September 2007 23:29, Mark Lord wrote: Question: do we disable all CPUs except 0 when doing ACPI power off? No, but we should. We used to. It is absolutely mandatory -- else it confuses the BIOS on some boards b/c it isn't expecting SMM to get entered from other than cpu0. -Len - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
