Re: Question on ARC's thread_info
On Sunday 29 March 2015 04:48 AM, Richard Weinberger wrote: > Vineet, > > I'm working on a patch series which touches sturct thread_info. > ARC's thread_info has the following comment: > * - if the contents of this structure are changed, the assembly constants > * must also be changed > > Is this still true? Unless I'm reading the code wrong that case should be > handled automatically by the asm-offsets mechanism. > So no manual fixup of magic constants should be needed. Yep, I think that is the case too - perhaps the comment is dated when we still had magic constants in code :-) If not I need to fix it anyways so feel free to change it. -Vineet -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: Question on ARC's thread_info
On Sunday 29 March 2015 04:48 AM, Richard Weinberger wrote: Vineet, I'm working on a patch series which touches sturct thread_info. ARC's thread_info has the following comment: * - if the contents of this structure are changed, the assembly constants * must also be changed Is this still true? Unless I'm reading the code wrong that case should be handled automatically by the asm-offsets mechanism. So no manual fixup of magic constants should be needed. Yep, I think that is the case too - perhaps the comment is dated when we still had magic constants in code :-) If not I need to fix it anyways so feel free to change it. -Vineet -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Question on ARC's thread_info
Vineet, I'm working on a patch series which touches sturct thread_info. ARC's thread_info has the following comment: * - if the contents of this structure are changed, the assembly constants * must also be changed Is this still true? Unless I'm reading the code wrong that case should be handled automatically by the asm-offsets mechanism. So no manual fixup of magic constants should be needed. Thanks, //richard -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Question on ARC's thread_info
Vineet, I'm working on a patch series which touches sturct thread_info. ARC's thread_info has the following comment: * - if the contents of this structure are changed, the assembly constants * must also be changed Is this still true? Unless I'm reading the code wrong that case should be handled automatically by the asm-offsets mechanism. So no manual fixup of magic constants should be needed. Thanks, //richard -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/