RE: [ACPI] [PATCH, new ACPI driver] new sony_acpi driver
Basically, this driver just call some specific AML method for hotkey function,
that can be
achieved through generic hotkey driver filed at
http://bugzilla.kernel.org/show_bug.cgi?id=3887.
So I don't think this driver is needed.
>-Original Message-
>From: [EMAIL PROTECTED]
>[mailto:[EMAIL PROTECTED] On Behalf Of
>Stelian Pop
>Sent: 2005年2月11日 0:18
>To: Linux Kernel Mailing List
>Cc: Andrew Morton; [EMAIL PROTECTED]
>Subject: [ACPI] [PATCH, new ACPI driver] new sony_acpi driver
>
>Hi,
>
>This driver has been submitted (almost unchanged) on lkml and
>on acpi-devel twice, first on July 21, 2004, then again on
>September 17, 2004. It has been quietly ignored.
>
>Privately I've had many positive feedbacks from users of this driver
>(and no negative feedback), including Linux distributions who wish
>to include it into their kernels. The reports are increasing in number,
>it would seem that newer Sony Vaios are more and more incompatible
>with sonypi and require sony_acpi to control the screen brightness.
>
>Please integrate this patch in -mm for wider testing and into
>the ACPI tree.
>
>Original announcement follows below.
>
>Thanks,
>
>Stelian.
>
>PS: I am also going to submit a bugzilla RFE for the acpi people,
>I have been told they are more receptive to that.
>
>--
>Most of the Sony Vaio owners are happy with the current sonypi
>driver, which makes them able to get/set the screen brightness,
>capture the jogdial and/or special key events etc.
>
>However, some newer Vaio series (FX series, and not only those) lack
>a SPIC device in their ACPI BIOS making the sonypi driver unusable
>for them.
>
>Fortunately, there is another ACPI device, called SNC (for Sony
>Notebook Control) which seems to be present in all Vaios, which
>can be used to access some low-level laptop functions. From what
>I understood, the SPIC device itself is built on top of SNC.
>
>The SNC device is able to drive the screen brightness, and probably
>more (what is does more is yet unknown). The attached driver is a
>first shot of using the SNC directly.
>
>In the default mode, the sony_acpi driver let's the user get/set the
>screen brightness, and only that.
>
>The screen is one of the most important power consumers in a laptop,
>so being able to set its brightness is very important for many users,
>making this driver useful even if it does only that.
>
>In the debug/developer mode (which can be activated with a module
>option), the driver let's the user see a few other knobs, whose
>effects is however unknown. Using the debug mode we may hopefully
>find what those knobs do and propose that extra functionalities in
>the future versions of the driver (if someone at Sony is listening,
>you know what we need from you...)
>
>This driver does not interact with the current sonypi driver, both
>drivers can be used at the same time.
>
>Signed-of-by: Stelian Pop <[EMAIL PROTECTED]>
>
>--- /dev/null 2005-02-10 10:35:32.824183288 +0100
>+++ linux-2.6-stelian/drivers/acpi/sony_acpi.c 2005-01-31
>17:05:53.0 +0100
>@@ -0,0 +1,442 @@
>+/*
>+ * ACPI Sony Notebook Control Driver (SNC)
>+ *
>+ * Copyright (C) 2004 Stelian Pop <[EMAIL PROTECTED]>
>+ *
>+ * Parts of this driver inspired from asus_acpi.c, which is
>+ * Copyright (C) 2002, 2003, 2004 Julien Lerouge, Karol Kozimor
>+ *
>+ * This program is free software; you can redistribute it
>and/or modify
>+ * it under the terms of the GNU General Public License as
>published by
>+ * the Free Software Foundation; either version 2 of the License, or
>+ * (at your option) any later version.
>+ *
>+ * This program is distributed in the hope that it will be useful,
>+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
>+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
>+ * GNU General Public License for more details.
>+ *
>+ * You should have received a copy of the GNU General Public License
>+ * along with this program; if not, write to the Free Software
>+ * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
>+ *
>+ */
>+
>+#include
>+#include
>+#include
>+#include
>+#include
>+#include
>+#include
>+#include
>+
>+#define ACPI_SNC_CLASS"sony"
>+#define ACPI_SNC_HID "SNY5001"
>+#define ACPI_SNC_DRIVER_NAME "ACPI Sony Notebook Control Driver v0.1"
>+
>+MODULE_AUTHOR("Stelian Pop");
>+MODULE_DESCRIPTION(ACPI_SNC_DRIVER_NAME);
>+MODULE_LICENSE("GPL");
>+
>+static int debug = 0;
>+module_param(debug, int, 0);
>+MODULE_PARM_DESC(debug,"set this to 1 (and RTFM) if you want
>to help the development of this driver");
>+
>+static int sony_acpi_add (struct acpi_device *device);
>+static int sony_acpi_remove (struct acpi_device *device, int type);
>+
>+static struct acpi_driver sony_acpi_driver = {
>+ name: ACPI_SNC_DRIVER_NAME,
>+ class: ACPI_SNC_CLASS,
>+ ids:ACPI_SNC_HID,
>+ ops:{
>+ add:sony_acpi_add,
RE: [ACPI] [PATCH, new ACPI driver] new sony_acpi driver
Basically, this driver just call some specific AML method for hotkey function,
that can be
achieved through generic hotkey driver filed at
http://bugzilla.kernel.org/show_bug.cgi?id=3887.
So I don't think this driver is needed.
-Original Message-
From: [EMAIL PROTECTED]
[mailto:[EMAIL PROTECTED] On Behalf Of
Stelian Pop
Sent: 2005211 0:18
To: Linux Kernel Mailing List
Cc: Andrew Morton; [EMAIL PROTECTED]
Subject: [ACPI] [PATCH, new ACPI driver] new sony_acpi driver
Hi,
This driver has been submitted (almost unchanged) on lkml and
on acpi-devel twice, first on July 21, 2004, then again on
September 17, 2004. It has been quietly ignored.
Privately I've had many positive feedbacks from users of this driver
(and no negative feedback), including Linux distributions who wish
to include it into their kernels. The reports are increasing in number,
it would seem that newer Sony Vaios are more and more incompatible
with sonypi and require sony_acpi to control the screen brightness.
Please integrate this patch in -mm for wider testing and into
the ACPI tree.
Original announcement follows below.
Thanks,
Stelian.
PS: I am also going to submit a bugzilla RFE for the acpi people,
I have been told they are more receptive to that.
--
Most of the Sony Vaio owners are happy with the current sonypi
driver, which makes them able to get/set the screen brightness,
capture the jogdial and/or special key events etc.
However, some newer Vaio series (FX series, and not only those) lack
a SPIC device in their ACPI BIOS making the sonypi driver unusable
for them.
Fortunately, there is another ACPI device, called SNC (for Sony
Notebook Control) which seems to be present in all Vaios, which
can be used to access some low-level laptop functions. From what
I understood, the SPIC device itself is built on top of SNC.
The SNC device is able to drive the screen brightness, and probably
more (what is does more is yet unknown). The attached driver is a
first shot of using the SNC directly.
In the default mode, the sony_acpi driver let's the user get/set the
screen brightness, and only that.
The screen is one of the most important power consumers in a laptop,
so being able to set its brightness is very important for many users,
making this driver useful even if it does only that.
In the debug/developer mode (which can be activated with a module
option), the driver let's the user see a few other knobs, whose
effects is however unknown. Using the debug mode we may hopefully
find what those knobs do and propose that extra functionalities in
the future versions of the driver (if someone at Sony is listening,
you know what we need from you...)
This driver does not interact with the current sonypi driver, both
drivers can be used at the same time.
Signed-of-by: Stelian Pop [EMAIL PROTECTED]
--- /dev/null 2005-02-10 10:35:32.824183288 +0100
+++ linux-2.6-stelian/drivers/acpi/sony_acpi.c 2005-01-31
17:05:53.0 +0100
@@ -0,0 +1,442 @@
+/*
+ * ACPI Sony Notebook Control Driver (SNC)
+ *
+ * Copyright (C) 2004 Stelian Pop [EMAIL PROTECTED]
+ *
+ * Parts of this driver inspired from asus_acpi.c, which is
+ * Copyright (C) 2002, 2003, 2004 Julien Lerouge, Karol Kozimor
+ *
+ * This program is free software; you can redistribute it
and/or modify
+ * it under the terms of the GNU General Public License as
published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
+ *
+ */
+
+#include linux/kernel.h
+#include linux/module.h
+#include linux/moduleparam.h
+#include linux/init.h
+#include linux/types.h
+#include acpi/acpi_drivers.h
+#include acpi/acpi_bus.h
+#include asm/uaccess.h
+
+#define ACPI_SNC_CLASSsony
+#define ACPI_SNC_HID SNY5001
+#define ACPI_SNC_DRIVER_NAME ACPI Sony Notebook Control Driver v0.1
+
+MODULE_AUTHOR(Stelian Pop);
+MODULE_DESCRIPTION(ACPI_SNC_DRIVER_NAME);
+MODULE_LICENSE(GPL);
+
+static int debug = 0;
+module_param(debug, int, 0);
+MODULE_PARM_DESC(debug,set this to 1 (and RTFM) if you want
to help the development of this driver);
+
+static int sony_acpi_add (struct acpi_device *device);
+static int sony_acpi_remove (struct acpi_device *device, int type);
+
+static struct acpi_driver sony_acpi_driver = {
+ name: ACPI_SNC_DRIVER_NAME,
+ class: ACPI_SNC_CLASS,
+ ids:ACPI_SNC_HID,
+ ops:{
+ add:sony_acpi_add,
+ remove:
Re: [ACPI] [PATCH, new ACPI driver] new sony_acpi driver
> > platform specific wart is the only way to go. But > > it would be best if we can make the exotic Sony/SNC > > look more generic to the user so that the user > > (and the distro supporting them) don't need to learn > > special things to handle this system. > > I agree, but unfortunately I don't think it's possible to handle > them in a generic way. However, my understanding of the ACPI layer > is limited, so I very well be wrong. > > I attached two DSDT in bugzilla, I have a few more if you want them. > I will (re)work some part of the acpi_video stuff in order to make it more generic (its design is to separate a kind of 'video bus', then 'video devices' can attach. For now, its support only one kind of device, the acpi one. See acpi_viedo.c). The original goal was to atleast attach others acpi specific drivers (the toshiba at that time). Problem though is my time which unfortunately is missing currently (professional stuff, other free projects and even real life) and I must admit I don't intend to work on acpi_video right now. Cheers, -- Bruno Ducrot -- Which is worse: ignorance or apathy? -- Don't know. Don't care. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [ACPI] [PATCH, new ACPI driver] new sony_acpi driver
platform specific wart is the only way to go. But it would be best if we can make the exotic Sony/SNC look more generic to the user so that the user (and the distro supporting them) don't need to learn special things to handle this system. I agree, but unfortunately I don't think it's possible to handle them in a generic way. However, my understanding of the ACPI layer is limited, so I very well be wrong. I attached two DSDT in bugzilla, I have a few more if you want them. I will (re)work some part of the acpi_video stuff in order to make it more generic (its design is to separate a kind of 'video bus', then 'video devices' can attach. For now, its support only one kind of device, the acpi one. See acpi_viedo.c). The original goal was to atleast attach others acpi specific drivers (the toshiba at that time). Problem though is my time which unfortunately is missing currently (professional stuff, other free projects and even real life) and I must admit I don't intend to work on acpi_video right now. Cheers, -- Bruno Ducrot -- Which is worse: ignorance or apathy? -- Don't know. Don't care. - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [ACPI] [PATCH, new ACPI driver] new sony_acpi driver
On Tue, Feb 15, 2005 at 10:30:49AM -0500, Len Brown wrote: > On Thu, 2005-02-10 at 11:18, Stelian Pop wrote:, > > > > > PS: I am also going to submit a bugzilla RFE for the acpi people, > > I have been told they are more receptive to that. > > I guess that refers to me:-) Hey, you *are* more receptive to bugzilla then ! > E-mail is fine, but the unfortunate reality is that due to simple > volume, it is lossy. The reason we like bugzilla is that it never > forgets:-) > > So thanks for taking the extra time to file a bug report > http://bugzilla.kernel.org/show_bug.cgi?id=4193 > > If it turns out that there is no way a generic solution > can handle the SNC Sony laptops, then I agree that a Note: this is not a subset of the Sony laptops, we are talking about all the Sony laptops here. > platform specific wart is the only way to go. But > it would be best if we can make the exotic Sony/SNC > look more generic to the user so that the user > (and the distro supporting them) don't need to learn > special things to handle this system. I agree, but unfortunately I don't think it's possible to handle them in a generic way. However, my understanding of the ACPI layer is limited, so I very well be wrong. I attached two DSDT in bugzilla, I have a few more if you want them. Stelian. -- Stelian Pop <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [ACPI] [PATCH, new ACPI driver] new sony_acpi driver
On Thu, 2005-02-10 at 11:18, Stelian Pop wrote:, > > PS: I am also going to submit a bugzilla RFE for the acpi people, > I have been told they are more receptive to that. I guess that refers to me:-) E-mail is fine, but the unfortunate reality is that due to simple volume, it is lossy. The reason we like bugzilla is that it never forgets:-) So thanks for taking the extra time to file a bug report http://bugzilla.kernel.org/show_bug.cgi?id=4193 If it turns out that there is no way a generic solution can handle the SNC Sony laptops, then I agree that a platform specific wart is the only way to go. But it would be best if we can make the exotic Sony/SNC look more generic to the user so that the user (and the distro supporting them) don't need to learn special things to handle this system. thanks, -Len - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [ACPI] [PATCH, new ACPI driver] new sony_acpi driver
On Thu, 2005-02-10 at 11:18, Stelian Pop wrote:, PS: I am also going to submit a bugzilla RFE for the acpi people, I have been told they are more receptive to that. I guess that refers to me:-) E-mail is fine, but the unfortunate reality is that due to simple volume, it is lossy. The reason we like bugzilla is that it never forgets:-) So thanks for taking the extra time to file a bug report http://bugzilla.kernel.org/show_bug.cgi?id=4193 If it turns out that there is no way a generic solution can handle the SNC Sony laptops, then I agree that a platform specific wart is the only way to go. But it would be best if we can make the exotic Sony/SNC look more generic to the user so that the user (and the distro supporting them) don't need to learn special things to handle this system. thanks, -Len - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [ACPI] [PATCH, new ACPI driver] new sony_acpi driver
On Tue, Feb 15, 2005 at 10:30:49AM -0500, Len Brown wrote: On Thu, 2005-02-10 at 11:18, Stelian Pop wrote:, PS: I am also going to submit a bugzilla RFE for the acpi people, I have been told they are more receptive to that. I guess that refers to me:-) Hey, you *are* more receptive to bugzilla then ! E-mail is fine, but the unfortunate reality is that due to simple volume, it is lossy. The reason we like bugzilla is that it never forgets:-) So thanks for taking the extra time to file a bug report http://bugzilla.kernel.org/show_bug.cgi?id=4193 If it turns out that there is no way a generic solution can handle the SNC Sony laptops, then I agree that a Note: this is not a subset of the Sony laptops, we are talking about all the Sony laptops here. platform specific wart is the only way to go. But it would be best if we can make the exotic Sony/SNC look more generic to the user so that the user (and the distro supporting them) don't need to learn special things to handle this system. I agree, but unfortunately I don't think it's possible to handle them in a generic way. However, my understanding of the ACPI layer is limited, so I very well be wrong. I attached two DSDT in bugzilla, I have a few more if you want them. Stelian. -- Stelian Pop [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [ACPI] [PATCH, new ACPI driver] new sony_acpi driver
On Thu, Feb 10, 2005 at 08:39:37PM +0100, Bruno Ducrot wrote: > On Thu, Feb 10, 2005 at 05:18:10PM +0100, Stelian Pop wrote: > > Hi, > > > > +ACPI Sony Notebook Control Driver (SNC) Readme > > +-- > > + Copyright (C) 2004 Stelian Pop <[EMAIL PROTECTED]> > > + > > +This mini-driver drives the ACPI SNC device present in the > > +ACPI BIOS of the Sony Vaio laptops. > > + > > +It gives access to some extra laptop functionalities. In > > +its current form, the only thing this driver does is letting > > +the user set or query the screen brightness. > > Does those laptops support acpi_video? No. I double checked for a few AML dumps I have here, and except for _DOS/_DOD present in some of them no other acpi_video method is supported. Newer Vaio laptops may eventualy support acpi_video, but all current (to the best of my knowledge) Vaios do support the SNC device. Stelian. -- Stelian Pop <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [ACPI] [PATCH, new ACPI driver] new sony_acpi driver
On Thu, Feb 10, 2005 at 08:39:37PM +0100, Bruno Ducrot wrote: On Thu, Feb 10, 2005 at 05:18:10PM +0100, Stelian Pop wrote: Hi, +ACPI Sony Notebook Control Driver (SNC) Readme +-- + Copyright (C) 2004 Stelian Pop [EMAIL PROTECTED] + +This mini-driver drives the ACPI SNC device present in the +ACPI BIOS of the Sony Vaio laptops. + +It gives access to some extra laptop functionalities. In +its current form, the only thing this driver does is letting +the user set or query the screen brightness. Does those laptops support acpi_video? No. I double checked for a few AML dumps I have here, and except for _DOS/_DOD present in some of them no other acpi_video method is supported. Newer Vaio laptops may eventualy support acpi_video, but all current (to the best of my knowledge) Vaios do support the SNC device. Stelian. -- Stelian Pop [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [ACPI] [PATCH, new ACPI driver] new sony_acpi driver
On Thu, Feb 10, 2005 at 05:18:10PM +0100, Stelian Pop wrote: > Hi, > > +ACPI Sony Notebook Control Driver (SNC) Readme > +-- > + Copyright (C) 2004 Stelian Pop <[EMAIL PROTECTED]> > + > +This mini-driver drives the ACPI SNC device present in the > +ACPI BIOS of the Sony Vaio laptops. > + > +It gives access to some extra laptop functionalities. In > +its current form, the only thing this driver does is letting > +the user set or query the screen brightness. Does those laptops support acpi_video? -- Bruno Ducrot -- Which is worse: ignorance or apathy? -- Don't know. Don't care. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [ACPI] [PATCH, new ACPI driver] new sony_acpi driver
On Thu, Feb 10, 2005 at 05:18:10PM +0100, Stelian Pop wrote: Hi, +ACPI Sony Notebook Control Driver (SNC) Readme +-- + Copyright (C) 2004 Stelian Pop [EMAIL PROTECTED] + +This mini-driver drives the ACPI SNC device present in the +ACPI BIOS of the Sony Vaio laptops. + +It gives access to some extra laptop functionalities. In +its current form, the only thing this driver does is letting +the user set or query the screen brightness. Does those laptops support acpi_video? -- Bruno Ducrot -- Which is worse: ignorance or apathy? -- Don't know. Don't care. - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
