RE: [CHECKER] 120 potential dereference to invalid pointers errors for linux 2.4.1
Well the ACPI bugs look legitimate. We'll work on getting those fixed. Thanks for your efforts! Regards -- Andy - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
RE: [CHECKER] 120 potential dereference to invalid pointers errors for linux 2.4.1
Well the ACPI bugs look legitimate. We'll work on getting those fixed. Thanks for your efforts! Regards -- Andy - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [CHECKER] 120 potential dereference to invalid pointers errors for linux 2.4.1
On Sat, Mar 17, 2001 at 01:30:54AM -0800, Junfeng Yang wrote: > - > [BUG] dereference to invalid pointer "bluetooth" in error message > /u2/acc/oses/linux/2.4.1/drivers/usb/bluetooth.c:924:bluetooth_read_bulk_callback: >ERROR:NULL:828:924: Using NULL ptr "bluetooth" illegally! set by >'get_usb_bluetooth':828 > > Start ---> > struct usb_bluetooth *bluetooth = get_usb_bluetooth ((struct usb_bluetooth >*)urb->context, __FUNCTION__); > unsigned char *data = urb->transfer_buffer; > unsigned int count = urb->actual_length; > unsigned int i; > unsigned int packet_size; > > ... DELETED 88 lines ... > > bluetooth->bulk_packet_pos = 0; > } > > exit: > Error ---> > FILL_BULK_URB(bluetooth->read_urb, bluetooth->dev, > usb_rcvbulkpipe(bluetooth->dev, >bluetooth->bulk_in_endpointAddress), This has already been fixed in a patch that was sent to the linux-usb-devel and bluetooth mailing lists, but hasn't made it into the kernel tree yet. But good catch! thanks, greg k-h -- greg@(kroah|wirex).com http://immunix.org/~greg - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [CHECKER] 120 potential dereference to invalid pointers errors for linux 2.4.1
> > [BUG] fore200e_kmalloc can return NULL > > /u2/acc/oses/linux/2.4.1/drivers/atm/fore200e.c:2032:fore200e_get_esi: >ERROR:NULL:2020:2032: Using unknown ptr "prom" illegally! set by >'fore200e_kmalloc':2020 > > I don't see the bug - there is an explicit "if(!prom) return -ENOMEM;" after > the allocation. It looks fine to me. We checked 2.4.1; it appears that by 2.4.2 someone had already fixed it :) -Andy - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [CHECKER] 120 potential dereference to invalid pointers errors for linux 2.4.1
Junfeng Yang wrote: > [BUG] fore200e_kmalloc can return NULL > /u2/acc/oses/linux/2.4.1/drivers/atm/fore200e.c:2032:fore200e_get_esi: >ERROR:NULL:2020:2032: Using unknown ptr "prom" illegally! set by >'fore200e_kmalloc':2020 I don't see the bug - there is an explicit "if(!prom) return -ENOMEM;" after the allocation. It looks fine to me. > [BUG] break the while loop, but not the for loop > /u2/acc/oses/linux/2.4.1/drivers/atm/zatm.c:1817:zatm_detect: ERROR:NULL:1804:1817: >Using NULL ptr "zatm_dev" illegally! set by 'kmalloc':1804 Ah, good catch. It'd be almost impossible to actually trigger this since you'd need multiple cards of different types (all of which are rare) and end up with really bad allocation luck, but it is technically a bug. Really line 1829 should be "if(!zatm_dev) return devs;" > [BUG] at line 1796 > /u2/acc/oses/linux/2.4.1/net/atm/lec.c:1799:lec_arp_update: ERROR:NULL:1798:1799: >Using unknown ptr "entry" illegally! set by 'make_entry':1798 Yep, all three of the catches in lec.c are real bugs - great work as always. -Mitch - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [CHECKER] 120 potential dereference to invalid pointers errors for linux 2.4.1
Junfeng Yang wrote: [BUG] fore200e_kmalloc can return NULL /u2/acc/oses/linux/2.4.1/drivers/atm/fore200e.c:2032:fore200e_get_esi: ERROR:NULL:2020:2032: Using unknown ptr "prom" illegally! set by 'fore200e_kmalloc':2020 I don't see the bug - there is an explicit "if(!prom) return -ENOMEM;" after the allocation. It looks fine to me. [BUG] break the while loop, but not the for loop /u2/acc/oses/linux/2.4.1/drivers/atm/zatm.c:1817:zatm_detect: ERROR:NULL:1804:1817: Using NULL ptr "zatm_dev" illegally! set by 'kmalloc':1804 Ah, good catch. It'd be almost impossible to actually trigger this since you'd need multiple cards of different types (all of which are rare) and end up with really bad allocation luck, but it is technically a bug. Really line 1829 should be "if(!zatm_dev) return devs;" [BUG] at line 1796 /u2/acc/oses/linux/2.4.1/net/atm/lec.c:1799:lec_arp_update: ERROR:NULL:1798:1799: Using unknown ptr "entry" illegally! set by 'make_entry':1798 Yep, all three of the catches in lec.c are real bugs - great work as always. -Mitch - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [CHECKER] 120 potential dereference to invalid pointers errors for linux 2.4.1
[BUG] fore200e_kmalloc can return NULL /u2/acc/oses/linux/2.4.1/drivers/atm/fore200e.c:2032:fore200e_get_esi: ERROR:NULL:2020:2032: Using unknown ptr "prom" illegally! set by 'fore200e_kmalloc':2020 I don't see the bug - there is an explicit "if(!prom) return -ENOMEM;" after the allocation. It looks fine to me. We checked 2.4.1; it appears that by 2.4.2 someone had already fixed it :) -Andy - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [CHECKER] 120 potential dereference to invalid pointers errors for linux 2.4.1
On Sat, Mar 17, 2001 at 01:30:54AM -0800, Junfeng Yang wrote: - [BUG] dereference to invalid pointer "bluetooth" in error message /u2/acc/oses/linux/2.4.1/drivers/usb/bluetooth.c:924:bluetooth_read_bulk_callback: ERROR:NULL:828:924: Using NULL ptr "bluetooth" illegally! set by 'get_usb_bluetooth':828 Start --- struct usb_bluetooth *bluetooth = get_usb_bluetooth ((struct usb_bluetooth *)urb-context, __FUNCTION__); unsigned char *data = urb-transfer_buffer; unsigned int count = urb-actual_length; unsigned int i; unsigned int packet_size; ... DELETED 88 lines ... bluetooth-bulk_packet_pos = 0; } exit: Error --- FILL_BULK_URB(bluetooth-read_urb, bluetooth-dev, usb_rcvbulkpipe(bluetooth-dev, bluetooth-bulk_in_endpointAddress), This has already been fixed in a patch that was sent to the linux-usb-devel and bluetooth mailing lists, but hasn't made it into the kernel tree yet. But good catch! thanks, greg k-h -- greg@(kroah|wirex).com http://immunix.org/~greg - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
