Re: [EXT] Re: [PATCH RFC net-next 00/19] net: mvpp2: Add TX Flow Control support
On Sun, Jan 10, 2021 at 07:11:53PM +, Stefan Chulski wrote: > > > > On Sun, Jan 10, 2021 at 06:55:11PM +, Stefan Chulski wrote: > > > > > not connected to the GOP flow control generation mechanism. > > > > > To solve this issue Armada has firmware running on CM3 CPU > > > > > dedectated for Flow Control support. Firmware monitors Packet > > > > > Processor resources and asserts XON/XOFF by writing to Ports Control 0 > > Register. > > > > > > > > What is the minimum firmware version that supports this? > > > > > > > > > > Support were added to firmware about two years ago. > > > All releases from 18.09 should has it. > > > > Can you query the firmware and ask its version? We should keep all this code > > disabled if the firmware it too old. > > > > Andrew > > This is exactly what " net: mvpp2: add TX FC firmware check " patch > do. If handshake of flow control support fail, FC won't be > supported. Ah, O.K. Please extend the kernel log message to include the minimum firmware version. Andrew
RE: [EXT] Re: [PATCH RFC net-next 00/19] net: mvpp2: Add TX Flow Control support
> > On Sun, Jan 10, 2021 at 06:55:11PM +, Stefan Chulski wrote: > > > > not connected to the GOP flow control generation mechanism. > > > > To solve this issue Armada has firmware running on CM3 CPU > > > > dedectated for Flow Control support. Firmware monitors Packet > > > > Processor resources and asserts XON/XOFF by writing to Ports Control 0 > Register. > > > > > > What is the minimum firmware version that supports this? > > > > > > > Support were added to firmware about two years ago. > > All releases from 18.09 should has it. > > Can you query the firmware and ask its version? We should keep all this code > disabled if the firmware it too old. > > Andrew This is exactly what " net: mvpp2: add TX FC firmware check " patch do. If handshake of flow control support fail, FC won't be supported. Stefan.
Re: [EXT] Re: [PATCH RFC net-next 00/19] net: mvpp2: Add TX Flow Control support
On Sun, Jan 10, 2021 at 06:55:11PM +, Stefan Chulski wrote: > > > not connected to the GOP flow control generation mechanism. > > > To solve this issue Armada has firmware running on CM3 CPU dedectated > > > for Flow Control support. Firmware monitors Packet Processor resources > > > and asserts XON/XOFF by writing to Ports Control 0 Register. > > > > What is the minimum firmware version that supports this? > > > > Support were added to firmware about two years ago. > All releases from 18.09 should has it. Can you query the firmware and ask its version? We should keep all this code disabled if the firmware it too old. Andrew
Re: [EXT] Re: [PATCH RFC net-next 00/19] net: mvpp2: Add TX Flow Control support
On Sun, Jan 10, 2021 at 06:55:11PM +, Stefan Chulski wrote: > > > not connected to the GOP flow control generation mechanism. > > > To solve this issue Armada has firmware running on CM3 CPU dedectated > > > for Flow Control support. Firmware monitors Packet Processor resources > > > and asserts XON/XOFF by writing to Ports Control 0 Register. > > > > What is the minimum firmware version that supports this? > > > > Support were added to firmware about two years ago. > All releases from 18.09 should has it. Please add that vital bit of information somewhere appropriate. I would not be surprised if people are still running e.g. 17.10 on some of their Armada 8040 boards. My Macchiatobin which is acting as a server currently has 17.10, although I plan to upgrade it to 18.12 in about three to six months time, once I've well and truely proven that my ext4 problems are resolved. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
RE: [EXT] Re: [PATCH RFC net-next 00/19] net: mvpp2: Add TX Flow Control support
> > not connected to the GOP flow control generation mechanism. > > To solve this issue Armada has firmware running on CM3 CPU dedectated > > for Flow Control support. Firmware monitors Packet Processor resources > > and asserts XON/XOFF by writing to Ports Control 0 Register. > > What is the minimum firmware version that supports this? > Support were added to firmware about two years ago. All releases from 18.09 should has it. Stefan, Regards.
