Re: [NEW DRIVER V4 3/7] DA9058 ONKEY driver
On 04/16/13 03:33, Opensource [Anthony Olech] wrote:
>> -Original Message-
>> From: Randy Dunlap [mailto:rdun...@infradead.org]
>> Sent: 12 April 2013 21:02
>> To: Opensource [Anthony Olech]
>> Cc: Dmitry Torokhov; Mark Brown; Samuel Ortiz; Ashish Jangam; Eric
>> Andersson; Andrew Jones; linux-in...@vger.kernel.org; LKML; David Dajun Chen
>> Subject: Re: [NEW DRIVER V4 3/7] DA9058 ONKEY driver
>>
>> On 04/12/13 06:05, Anthony Olech wrote:
>>> This is the ONKEY component driver of the Dialog DA9058 PMIC.
>>> This driver is just one component of the whole DA9058 PMIC driver.
>>> It depends on the CORE component driver of the DA9058 MFD.
>>>
>>> Signed-off-by: Anthony Olech
>>> Signed-off-by: David Dajun Chen
>>> ---
>>> drivers/input/misc/Kconfig| 10 +++
>>> drivers/input/misc/Makefile |1 +
>>> drivers/input/misc/da9058_onkey.c | 177
>>> +
>>> 3 files changed, 188 insertions(+)
>>> create mode 100644 drivers/input/misc/da9058_onkey.c
>>>
>>> diff --git a/drivers/input/misc/Kconfig b/drivers/input/misc/Kconfig
>>> index 259ef31..bd07b38 100644
>>> --- a/drivers/input/misc/Kconfig
>>> +++ b/drivers/input/misc/Kconfig
>>> @@ -93,6 +93,16 @@ config INPUT_BMA150
>>> To compile this driver as a module, choose M here: the
>>> module will be called bma150.
>>>
>>> +config INPUT_DA9058_ONKEY
>>> + tristate "DA9058 ONKEY support"
>>> + depends on MFD_DA9058
>>> + help
>>> + Support the ONKEY of DA9058 PMICs as an input device
>>> + reporting power button status.
>>
>> What possible values can a power button status have?
>> Must be more than my KISS guess:
>> this software is running => ON
>> software not running => OFF
>> eh?
>
> Pressing the button briefly and pressing and holding the button will have
> different effects in a mobile device. The press and hold on phones normally
> switches them into a sleep state. So the "power button status" is the fact
> that the ONKEY is still being held down.
>
> Does that answer your question? or have I missed your point??
Yes, that answers my question. I get it.
>
> [...]
>>> + onkey->irq = platform_get_irq(pdev, 0);
>>> + if (onkey->irq < 0) {
>>> + dev_err(&pdev->dev, "can not get ONKEY IRQ error=%d\n",
>>
>> cannot
>
> The Washington State University language site says:
>
> "These two spellings [cannot/can not] are largely interchangeable, but by far
> the most common is 'cannot' and you should probably use it except when you
> want to be emphatic: 'No, you can not wash the dog in the Maytag.'"
>
> Since I was not trying to be particularly emphatic, I will change to using
> 'cannot'
> as per your suggestion.
thanks.
--
~Randy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
RE: [NEW DRIVER V4 3/7] DA9058 ONKEY driver
> -Original Message-
> From: Randy Dunlap [mailto:rdun...@infradead.org]
> Sent: 12 April 2013 21:02
> To: Opensource [Anthony Olech]
> Cc: Dmitry Torokhov; Mark Brown; Samuel Ortiz; Ashish Jangam; Eric
> Andersson; Andrew Jones; linux-in...@vger.kernel.org; LKML; David Dajun Chen
> Subject: Re: [NEW DRIVER V4 3/7] DA9058 ONKEY driver
>
> On 04/12/13 06:05, Anthony Olech wrote:
> > This is the ONKEY component driver of the Dialog DA9058 PMIC.
> > This driver is just one component of the whole DA9058 PMIC driver.
> > It depends on the CORE component driver of the DA9058 MFD.
> >
> > Signed-off-by: Anthony Olech
> > Signed-off-by: David Dajun Chen
> > ---
> > drivers/input/misc/Kconfig| 10 +++
> > drivers/input/misc/Makefile |1 +
> > drivers/input/misc/da9058_onkey.c | 177
> > +
> > 3 files changed, 188 insertions(+)
> > create mode 100644 drivers/input/misc/da9058_onkey.c
> >
> > diff --git a/drivers/input/misc/Kconfig b/drivers/input/misc/Kconfig
> > index 259ef31..bd07b38 100644
> > --- a/drivers/input/misc/Kconfig
> > +++ b/drivers/input/misc/Kconfig
> > @@ -93,6 +93,16 @@ config INPUT_BMA150
> > To compile this driver as a module, choose M here: the
> > module will be called bma150.
> >
> > +config INPUT_DA9058_ONKEY
> > + tristate "DA9058 ONKEY support"
> > + depends on MFD_DA9058
> > + help
> > + Support the ONKEY of DA9058 PMICs as an input device
> > + reporting power button status.
>
> What possible values can a power button status have?
> Must be more than my KISS guess:
> this software is running => ON
> software not running => OFF
> eh?
Pressing the button briefly and pressing and holding the button will have
different effects in a mobile device. The press and hold on phones normally
switches them into a sleep state. So the "power button status" is the fact
that the ONKEY is still being held down.
Does that answer your question? or have I missed your point??
[...]
> > + onkey->irq = platform_get_irq(pdev, 0);
> > + if (onkey->irq < 0) {
> > + dev_err(&pdev->dev, "can not get ONKEY IRQ error=%d\n",
>
>cannot
The Washington State University language site says:
"These two spellings [cannot/can not] are largely interchangeable, but by far
the most common is 'cannot' and you should probably use it except when you
want to be emphatic: 'No, you can not wash the dog in the Maytag.'"
Since I was not trying to be particularly emphatic, I will change to using
'cannot'
as per your suggestion.
Tony Olech
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [NEW DRIVER V4 3/7] DA9058 ONKEY driver
On 04/12/13 06:05, Anthony Olech wrote:
> This is the ONKEY component driver of the Dialog DA9058 PMIC.
> This driver is just one component of the whole DA9058 PMIC driver.
> It depends on the CORE component driver of the DA9058 MFD.
>
> Signed-off-by: Anthony Olech
> Signed-off-by: David Dajun Chen
> ---
> drivers/input/misc/Kconfig| 10 +++
> drivers/input/misc/Makefile |1 +
> drivers/input/misc/da9058_onkey.c | 177
> +
> 3 files changed, 188 insertions(+)
> create mode 100644 drivers/input/misc/da9058_onkey.c
>
> diff --git a/drivers/input/misc/Kconfig b/drivers/input/misc/Kconfig
> index 259ef31..bd07b38 100644
> --- a/drivers/input/misc/Kconfig
> +++ b/drivers/input/misc/Kconfig
> @@ -93,6 +93,16 @@ config INPUT_BMA150
> To compile this driver as a module, choose M here: the
> module will be called bma150.
>
> +config INPUT_DA9058_ONKEY
> + tristate "DA9058 ONKEY support"
> + depends on MFD_DA9058
> + help
> + Support the ONKEY of DA9058 PMICs as an input device
> + reporting power button status.
What possible values can a power button status have?
Must be more than my KISS guess:
this software is running => ON
software not running => OFF
eh?
> +
> + To compile this driver as a module, choose M here: the module
> + will be called da9058_onkey.
> +
> config INPUT_PCSPKR
> tristate "PC Speaker support"
> depends on PCSPKR_PLATFORM
> diff --git a/drivers/input/misc/da9058_onkey.c
> b/drivers/input/misc/da9058_onkey.c
> new file mode 100644
> index 000..969ad70
> --- /dev/null
> +++ b/drivers/input/misc/da9058_onkey.c
> @@ -0,0 +1,177 @@
> +/*
> + * Copyright (C) 2012 Dialog Semiconductor Ltd.
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License as published by
> + * the Free Software Foundation; either version 2 of the License, or
> + * (at your option) any later version.
> + *
> + */
> +
> +
> +static int da9058_onkey_probe(struct platform_device *pdev)
> +{
> + struct da9058 *da9058 = dev_get_drvdata(pdev->dev.parent);
> + const struct mfd_cell *cell = mfd_get_cell(pdev);
> + struct da9058_onkey_pdata *onkey_pdata;
> + struct da9058_onkey *onkey;
> + int ret;
> +
> + if (cell == NULL) {
> + ret = -ENODEV;
> + goto exit;
> + }
> +
> + onkey_pdata = cell->platform_data;
> +
> + if (onkey_pdata == NULL) {
> + ret = -EINVAL;
> + goto exit;
> + }
> +
> + dev_info(&pdev->dev, "Starting ONKEY\n");
> +
> + onkey = devm_kzalloc(&pdev->dev, sizeof(struct da9058_onkey),
> + GFP_KERNEL);
> + if (!onkey) {
> + ret = -ENOMEM;
> + goto exit;
> + }
> +
> + platform_set_drvdata(pdev, onkey);
> +
> + onkey->da9058 = da9058;
> + onkey->pdev = pdev;
> +
> + onkey->irq = platform_get_irq(pdev, 0);
> + if (onkey->irq < 0) {
> + dev_err(&pdev->dev, "can not get ONKEY IRQ error=%d\n",
cannot
> + onkey->irq);
--
~Randy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
