RE: [PATCH] ARM: at91: sama5/dts: move hsmc_clk out of nfc node

[Yang, Wenyou]

> -Original Message-
> From: Ferre, Nicolas
> Sent: 2016年2月22日 20:58
> To: Yang, Wenyou <wenyou.y...@atmel.com>; Rob Herring
> <robh...@kernel.org>; Pawel Moll <pawel.m...@arm.com>; Mark Brown
> <broo...@kernel.org>; Ian Campbell <ijc+devicet...@hellion.org.uk>; Kumar
> Gala <ga...@codeaurora.org>; Alexandre Belloni <alexandre.belloni@free-
> electrons.com>; Jean-Christophe Plagniol-Villard <plagn...@jcrosoft.com>;
> Russell King <li...@arm.linux.org.uk>
> Cc: linux-arm-ker...@lists.infradead.org; linux-kernel@vger.kernel.org;
> devicet...@vger.kernel.org; Wu, Josh <josh...@atmel.com>; Josh Wu
> <rainyfeel...@outlook.com>; Alexandre Belloni <alexandre.belloni@free-
> electrons.com>
> Subject: Re: [PATCH] ARM: at91: sama5/dts: move hsmc_clk out of nfc node
> 
> Le 17/02/2016 06:42, Wenyou Yang a écrit :
> > From: Josh Wu <josh...@atmel.com>
> >
> > In sama5d3, sama5d4 chips, pmecc will use the hsmc clock. As pmecc is
> > part of HSMC. So move out hsmc_clk from nfc node to nand node.
> >
> > Signed-off-by: Josh Wu <rainyfeel...@outlook.com>
> > Signed-off-by: Wenyou Yang <wenyou.y...@atmel.com>
> 
> I'm not against this change, but beware, it must be applied in 
> synchronization with
> the patch just posted "[PATCH] mtd: atmel_nand:
> move the hsmc_clk from nfc node to nand node"

Okay, revert the mail address to the original one, keep it consistent.

And add this address to CC. 

> 
> Bye,
> 
> 
> > ---
> >
> >  arch/arm/boot/dts/sama5d3.dtsi |2 +-
> >  arch/arm/boot/dts/sama5d4.dtsi |2 +-
> >  2 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/sama5d3.dtsi
> > b/arch/arm/boot/dts/sama5d3.dtsi index a532791..a242d27 100644
> > --- a/arch/arm/boot/dts/sama5d3.dtsi
> > +++ b/arch/arm/boot/dts/sama5d3.dtsi
> > @@ -1474,6 +1474,7 @@
> > atmel,nand-has-dma;
> > pinctrl-names = "default";
> > pinctrl-0 = <_nand0_ale_cle>;
> > +   clocks = <_clk>;
> > atmel,pmecc-lookup-table-offset = <0x0 0x8000>;
> > status = "disabled";
> >
> > @@ -1486,7 +1487,6 @@
> > 0xc000 0x0070   /* NFC HSMC
> regs */
> > 0x0020 0x0010   /* NFC
> SRAM banks */
> > >;
> > -   clocks = <_clk>;
> > };
> > };
> > };
> > diff --git a/arch/arm/boot/dts/sama5d4.dtsi
> > b/arch/arm/boot/dts/sama5d4.dtsi index b8032bc..1499b33 100644
> > --- a/arch/arm/boot/dts/sama5d4.dtsi
> > +++ b/arch/arm/boot/dts/sama5d4.dtsi
> > @@ -295,6 +295,7 @@
> > atmel,nand-has-dma;
> > pinctrl-names = "default";
> > pinctrl-0 = <_nand>;
> > +   clocks = <_clk>;
> > status = "disabled";
> >
> > nfc@9000 {
> > @@ -306,7 +307,6 @@
> > 0xfc05c000 0x0070   /* NFC
> HSMC regs */
> > 0x0010 0x0010   /* NFC
> SRAM banks */
> >   >;
> > -   clocks = <_clk>;
> > atmel,write-by-sram;
> > };
> > };
> >
> 
> 
> --
> Nicolas Ferre


Best Regards,
Wenyou Yang

RE: [PATCH] ARM: at91: sama5/dts: move hsmc_clk out of nfc node

[Yang, Wenyou]

> -Original Message-
> From: Ferre, Nicolas
> Sent: 2016年2月22日 20:58
> To: Yang, Wenyou ; Rob Herring
> ; Pawel Moll ; Mark Brown
> ; Ian Campbell ; Kumar
> Gala ; Alexandre Belloni  electrons.com>; Jean-Christophe Plagniol-Villard ;
> Russell King 
> Cc: linux-arm-ker...@lists.infradead.org; linux-kernel@vger.kernel.org;
> devicet...@vger.kernel.org; Wu, Josh ; Josh Wu
> ; Alexandre Belloni  electrons.com>
> Subject: Re: [PATCH] ARM: at91: sama5/dts: move hsmc_clk out of nfc node
> 
> Le 17/02/2016 06:42, Wenyou Yang a écrit :
> > From: Josh Wu 
> >
> > In sama5d3, sama5d4 chips, pmecc will use the hsmc clock. As pmecc is
> > part of HSMC. So move out hsmc_clk from nfc node to nand node.
> >
> > Signed-off-by: Josh Wu 
> > Signed-off-by: Wenyou Yang 
> 
> I'm not against this change, but beware, it must be applied in 
> synchronization with
> the patch just posted "[PATCH] mtd: atmel_nand:
> move the hsmc_clk from nfc node to nand node"

Okay, revert the mail address to the original one, keep it consistent.

And add this address to CC. 

> 
> Bye,
> 
> 
> > ---
> >
> >  arch/arm/boot/dts/sama5d3.dtsi |2 +-
> >  arch/arm/boot/dts/sama5d4.dtsi |2 +-
> >  2 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/sama5d3.dtsi
> > b/arch/arm/boot/dts/sama5d3.dtsi index a532791..a242d27 100644
> > --- a/arch/arm/boot/dts/sama5d3.dtsi
> > +++ b/arch/arm/boot/dts/sama5d3.dtsi
> > @@ -1474,6 +1474,7 @@
> > atmel,nand-has-dma;
> > pinctrl-names = "default";
> > pinctrl-0 = <_nand0_ale_cle>;
> > +   clocks = <_clk>;
> > atmel,pmecc-lookup-table-offset = <0x0 0x8000>;
> > status = "disabled";
> >
> > @@ -1486,7 +1487,6 @@
> > 0xc000 0x0070   /* NFC HSMC
> regs */
> > 0x0020 0x0010   /* NFC
> SRAM banks */
> > >;
> > -   clocks = <_clk>;
> > };
> > };
> > };
> > diff --git a/arch/arm/boot/dts/sama5d4.dtsi
> > b/arch/arm/boot/dts/sama5d4.dtsi index b8032bc..1499b33 100644
> > --- a/arch/arm/boot/dts/sama5d4.dtsi
> > +++ b/arch/arm/boot/dts/sama5d4.dtsi
> > @@ -295,6 +295,7 @@
> > atmel,nand-has-dma;
> > pinctrl-names = "default";
> > pinctrl-0 = <_nand>;
> > +   clocks = <_clk>;
> > status = "disabled";
> >
> > nfc@9000 {
> > @@ -306,7 +307,6 @@
> > 0xfc05c000 0x0070   /* NFC
> HSMC regs */
> > 0x0010 0x0010   /* NFC
> SRAM banks */
> >   >;
> > -   clocks = <_clk>;
> > atmel,write-by-sram;
> > };
> > };
> >
> 
> 
> --
> Nicolas Ferre


Best Regards,
Wenyou Yang

Re: [PATCH] ARM: at91: sama5/dts: move hsmc_clk out of nfc node

[Nicolas Ferre]

Le 17/02/2016 06:42, Wenyou Yang a écrit :
> From: Josh Wu 
> 
> In sama5d3, sama5d4 chips, pmecc will use the hsmc clock. As pmecc is
> part of HSMC. So move out hsmc_clk from nfc node to nand node.
> 
> Signed-off-by: Josh Wu 
> Signed-off-by: Wenyou Yang 

I'm not against this change, but beware, it must be applied in
synchronization with the patch just posted "[PATCH] mtd: atmel_nand:
move the hsmc_clk from nfc node to nand node"

Bye,


> ---
> 
>  arch/arm/boot/dts/sama5d3.dtsi |2 +-
>  arch/arm/boot/dts/sama5d4.dtsi |2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/sama5d3.dtsi b/arch/arm/boot/dts/sama5d3.dtsi
> index a532791..a242d27 100644
> --- a/arch/arm/boot/dts/sama5d3.dtsi
> +++ b/arch/arm/boot/dts/sama5d3.dtsi
> @@ -1474,6 +1474,7 @@
>   atmel,nand-has-dma;
>   pinctrl-names = "default";
>   pinctrl-0 = <_nand0_ale_cle>;
> + clocks = <_clk>;
>   atmel,pmecc-lookup-table-offset = <0x0 0x8000>;
>   status = "disabled";
>  
> @@ -1486,7 +1487,6 @@
>   0xc000 0x0070   /* NFC HSMC 
> regs */
>   0x0020 0x0010   /* NFC SRAM 
> banks */
>   >;
> - clocks = <_clk>;
>   };
>   };
>   };
> diff --git a/arch/arm/boot/dts/sama5d4.dtsi b/arch/arm/boot/dts/sama5d4.dtsi
> index b8032bc..1499b33 100644
> --- a/arch/arm/boot/dts/sama5d4.dtsi
> +++ b/arch/arm/boot/dts/sama5d4.dtsi
> @@ -295,6 +295,7 @@
>   atmel,nand-has-dma;
>   pinctrl-names = "default";
>   pinctrl-0 = <_nand>;
> + clocks = <_clk>;
>   status = "disabled";
>  
>   nfc@9000 {
> @@ -306,7 +307,6 @@
>   0xfc05c000 0x0070   /* NFC HSMC 
> regs */
>   0x0010 0x0010   /* NFC SRAM 
> banks */
>   >;
> - clocks = <_clk>;
>   atmel,write-by-sram;
>   };
>   };
> 


-- 
Nicolas Ferre

Re: [PATCH] ARM: at91: sama5/dts: move hsmc_clk out of nfc node

[Nicolas Ferre]

Le 17/02/2016 06:42, Wenyou Yang a écrit :
> From: Josh Wu 
> 
> In sama5d3, sama5d4 chips, pmecc will use the hsmc clock. As pmecc is
> part of HSMC. So move out hsmc_clk from nfc node to nand node.
> 
> Signed-off-by: Josh Wu 
> Signed-off-by: Wenyou Yang 

I'm not against this change, but beware, it must be applied in
synchronization with the patch just posted "[PATCH] mtd: atmel_nand:
move the hsmc_clk from nfc node to nand node"

Bye,


> ---
> 
>  arch/arm/boot/dts/sama5d3.dtsi |2 +-
>  arch/arm/boot/dts/sama5d4.dtsi |2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/sama5d3.dtsi b/arch/arm/boot/dts/sama5d3.dtsi
> index a532791..a242d27 100644
> --- a/arch/arm/boot/dts/sama5d3.dtsi
> +++ b/arch/arm/boot/dts/sama5d3.dtsi
> @@ -1474,6 +1474,7 @@
>   atmel,nand-has-dma;
>   pinctrl-names = "default";
>   pinctrl-0 = <_nand0_ale_cle>;
> + clocks = <_clk>;
>   atmel,pmecc-lookup-table-offset = <0x0 0x8000>;
>   status = "disabled";
>  
> @@ -1486,7 +1487,6 @@
>   0xc000 0x0070   /* NFC HSMC 
> regs */
>   0x0020 0x0010   /* NFC SRAM 
> banks */
>   >;
> - clocks = <_clk>;
>   };
>   };
>   };
> diff --git a/arch/arm/boot/dts/sama5d4.dtsi b/arch/arm/boot/dts/sama5d4.dtsi
> index b8032bc..1499b33 100644
> --- a/arch/arm/boot/dts/sama5d4.dtsi
> +++ b/arch/arm/boot/dts/sama5d4.dtsi
> @@ -295,6 +295,7 @@
>   atmel,nand-has-dma;
>   pinctrl-names = "default";
>   pinctrl-0 = <_nand>;
> + clocks = <_clk>;
>   status = "disabled";
>  
>   nfc@9000 {
> @@ -306,7 +307,6 @@
>   0xfc05c000 0x0070   /* NFC HSMC 
> regs */
>   0x0010 0x0010   /* NFC SRAM 
> banks */
>   >;
> - clocks = <_clk>;
>   atmel,write-by-sram;
>   };
>   };
> 


-- 
Nicolas Ferre