RE: [PATCH] blkcg: add plugging support for punt bio

2020-09-08 Thread Tianxianting 
Thanks TJ and your previous guide to me.
I will summarize and resubmit the patch.

-Original Message-
From: Tejun Heo [mailto:hte...@gmail.com] On Behalf Of Tejun Heo
Sent: Wednesday, September 09, 2020 2:03 AM
To: tianxianting (RD) 
Cc: ax...@kernel.dk; cgro...@vger.kernel.org; linux-bl...@vger.kernel.org; 
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] blkcg: add plugging support for punt bio

On Sat, Sep 05, 2020 at 11:25:03AM +, Tianxianting wrote:
> Hi jens,tj
> Could you share a couple of  minutes to comment it?
> I really appreciate it

The result looks fine to me but can you please summarize that in the commit 
message of the patch?

Thanks.

--
tejun

Re: [PATCH] blkcg: add plugging support for punt bio

2020-09-08 Thread Tejun Heo 
On Sat, Sep 05, 2020 at 11:25:03AM +, Tianxianting wrote:
> Hi jens,tj
> Could you share a couple of  minutes to comment it?
> I really appreciate it

The result looks fine to me but can you please summarize that in the commit
message of the patch?

Thanks.

-- 
tejun

Re: [PATCH] blkcg: add plugging support for punt bio

2020-08-06 Thread Jens Axboe 
On 8/6/20 7:54 AM, Xianting Tian wrote:
> Try to merge continuous bio to current task's plug fisrt.

The patch looks fine to me, but I'd really like to see a bit more
changelog here. The commit message should explain why the change
is made, rather it's a very brief explanation of what it does.

If the bio list is contiguous, then we do the plugging to improve
merging at the lower level. You probably ran into a case where
you saw sub-optimal merging? And now the performance is better
with the patch? How much?


-- 
Jens Axboe

Re: [PATCH] blkcg: add plugging support for punt bio

2020-08-06 Thread Tejun Heo 
On Thu, Aug 06, 2020 at 09:54:42AM -0400, Xianting Tian wrote:
> Try to merge continuous bio to current task's plug fisrt.
> 
> Signed-off-by: Xianting Tian 

Acked-by: Tejun Heo 

Thanks!

-- 
tejun