Re: [EXT] Re: [PATCH] dt-bindings: spi: Convert NXP flexspi to json schema
On Wed, Mar 10, 2021 at 10:24:21AM +, Kuldeep Singh wrote: > > Like I said in the mail you're replying to please send me a copy of the > > patch. > I hope this will suffice. Please let me know in case of any other requirement. Please submit the patch following the process documented in submitting-patches.rst. signature.asc Description: PGP signature
RE: [EXT] Re: [PATCH] dt-bindings: spi: Convert NXP flexspi to json schema
> -Original Message-
> From: Mark Brown
> Sent: Tuesday, March 9, 2021 11:02 PM
> To: Kuldeep Singh
> Cc: Rob Herring ; linux-...@vger.kernel.org;
> devicet...@vger.kernel.org; linux-kernel@vger.kernel.org; Ashish Kumar
>
> Subject: Re: [EXT] Re: [PATCH] dt-bindings: spi: Convert NXP flexspi to json
> schema
>
> On Tue, Mar 09, 2021 at 05:30:00PM +, Kuldeep Singh wrote:
>
> > > Binding patches generally go through the subsystem tree so please
> > > send the patch to me.
>
> > Thanks for letting me know.
> > I have developed the patch on top of your tree and also sent to spi-devel
> mailing list.
> > Please see [1] for more details. Kindly let me know if I need to resubmit
> > the
> patch.
>
> Like I said in the mail you're replying to please send me a copy of the patch.
I hope this will suffice. Please let me know in case of any other requirement.
Regards
Kuldeep
[1]
Convert the NXP FlexSPI binding to DT schema format using json-schema.
Signed-off-by: Kuldeep Singh
---
.../bindings/spi/nxp,spi-nxp-fspi.yaml| 85 +++
.../devicetree/bindings/spi/spi-nxp-fspi.txt | 43 --
MAINTAINERS | 2 +-
3 files changed, 86 insertions(+), 44 deletions(-) create mode 100644
Documentation/devicetree/bindings/spi/nxp,spi-nxp-fspi.yaml
delete mode 100644 Documentation/devicetree/bindings/spi/spi-nxp-fspi.txt
diff --git a/Documentation/devicetree/bindings/spi/nxp,spi-nxp-fspi.yaml
b/Documentation/devicetree/bindings/spi/nxp,spi-nxp-fspi.yaml
new file mode 100644
index ..e3f2c5aae847
--- /dev/null
+++ b/Documentation/devicetree/bindings/spi/nxp,spi-nxp-fspi.yaml
@@ -0,0 +1,85 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) %YAML 1.2
+---
+$id: http://devicetree.org/schemas/spi/nxp,spi-nxp-fspi.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: NXP Flex Serial Peripheral Interface (FSPI)
+
+maintainers:
+ - Ashish Kumar
+
+allOf:
+ - $ref: "spi-controller.yaml#"
+
+properties:
+ compatible:
+enum:
+ - nxp,lx2160a-fspi
+ - nxp,imx8qxp-fspi
+ - nxp,imx8mm-fspi
+ - nxp,imx8dxl-fspi
+
+ reg:
+items:
+ - description: registers
+ - description: memory mapping
+
+ reg-names:
+items:
+ - const: fspi_base
+ - const: fspi_mmap
+
+ interrupts:
+maxItems: 1
+
+ clocks:
+items:
+ - description: SoC SPI fspi_en clock
+ - description: SoC SPI fspi clock
+
+ clock-names:
+items:
+ - const: fspi_en
+ - const: fspi
+
+required:
+ - compatible
+ - reg
+ - reg-names
+ - interrupts
+ - clocks
+ - clock-names
+
+unevaluatedProperties: false
+
+examples:
+ - |
+#include
+#include
+
+soc {
+#address-cells = <2>;
+#size-cells = <2>;
+
+spi@20c {
+compatible = "nxp,lx2160a-fspi";
+reg = <0x0 0x20c 0x0 0x10>,
+ <0x0 0x2000 0x0 0x1000>;
+reg-names = "fspi_base", "fspi_mmap";
+interrupts = ;
+clocks = < QORIQ_CLK_PLATFORM_PLL QORIQ_CLK_PLL_DIV(4)>,
+ < QORIQ_CLK_PLATFORM_PLL QORIQ_CLK_PLL_DIV(4)>;
+clock-names = "fspi_en", "fspi";
+#address-cells = <1>;
+#size-cells = <0>;
+
+flash@0 {
+compatible = "jedec,spi-nor";
+spi-max-frequency = <5000>;
+reg = <0>;
+spi-rx-bus-width = <8>;
+spi-tx-bus-width = <8>;
+};
+};
+};
diff --git a/Documentation/devicetree/bindings/spi/spi-nxp-fspi.txt
b/Documentation/devicetree/bindings/spi/spi-nxp-fspi.txt
deleted file mode 100644
index df178d1b62e6..
--- a/Documentation/devicetree/bindings/spi/spi-nxp-fspi.txt
+++ /dev/null
@@ -1,43 +0,0 @@
-* NXP Flex Serial Peripheral Interface (FSPI)
-
-Required properties:
- - compatible : Should be "nxp,lx2160a-fspi"
- "nxp,imx8qxp-fspi"
- "nxp,imx8mm-fspi"
- "nxp,imx8dxl-fspi"
-
- - reg :First contains the register location and length,
- Second contains the memory mapping address and length
- - reg-names : Should contain the resource reg names:
-- fspi_base: configuration register address space
- - fspi_mmap: memory mapped address space
- - interrupts : Should contain the interrupt for the device
-
-Required SPI slave node properties:
- - reg :There are two buses (A and B) with two chip selects each.
- This encodes to which bus and CS the flash is connected:
- - <
Re: [EXT] Re: [PATCH] dt-bindings: spi: Convert NXP flexspi to json schema
On Tue, Mar 09, 2021 at 05:30:00PM +, Kuldeep Singh wrote: > > Binding patches generally go through the subsystem tree so please send the > > patch > > to me. > Thanks for letting me know. > I have developed the patch on top of your tree and also sent to spi-devel > mailing list. > Please see [1] for more details. Kindly let me know if I need to resubmit the > patch. Like I said in the mail you're replying to please send me a copy of the patch. signature.asc Description: PGP signature
RE: [EXT] Re: [PATCH] dt-bindings: spi: Convert NXP flexspi to json schema
Hi Mark, > -Original Message- > From: Mark Brown > Sent: Tuesday, March 9, 2021 6:06 PM > To: Kuldeep Singh > Cc: Rob Herring ; linux-...@vger.kernel.org; > devicet...@vger.kernel.org; linux-kernel@vger.kernel.org; Ashish Kumar > > Subject: [EXT] Re: [PATCH] dt-bindings: spi: Convert NXP flexspi to json > schema > > On Tue, Mar 09, 2021 at 11:41:50AM +, Kuldeep Singh wrote: > > + Mark (Forgot to add him previously) > > ... > > > I was not sure with which tree this patch will go through. > > Currently, I have rebased this on top of > > tree(git://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git, > > branch: for-next) > > Binding patches generally go through the subsystem tree so please send the > patch > to me. Thanks for letting me know. I have developed the patch on top of your tree and also sent to spi-devel mailing list. Please see [1] for more details. Kindly let me know if I need to resubmit the patch. Regards Kuldeep [1] https://patchwork.kernel.org/project/spi-devel-general/patch/20210309103528.3538910-1-kuldeep.si...@nxp.com/
Re: [PATCH] dt-bindings: spi: Convert NXP flexspi to json schema
On Tue, Mar 09, 2021 at 11:41:50AM +, Kuldeep Singh wrote: > + Mark (Forgot to add him previously) ... > I was not sure with which tree this patch will go through. > Currently, I have rebased this on top of > tree(git://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git, branch: > for-next) Binding patches generally go through the subsystem tree so please send the patch to me. signature.asc Description: PGP signature
RE: [PATCH] dt-bindings: spi: Convert NXP flexspi to json schema
+ Mark (Forgot to add him previously) > -Original Message- > From: Kuldeep Singh > Sent: Tuesday, March 9, 2021 4:05 PM > To: Rob Herring ; linux-...@vger.kernel.org; > devicet...@vger.kernel.org; linux-kernel@vger.kernel.org > Cc: Ashish Kumar ; Kuldeep Singh > > Subject: [PATCH] dt-bindings: spi: Convert NXP flexspi to json schema > > Convert the NXP FlexSPI binding to DT schema format using json-schema. > > Signed-off-by: Kuldeep Singh > Hi Rob and Mark, I was not sure with which tree this patch will go through. Currently, I have rebased this on top of tree(git://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git, branch: for-next) Regards Kuldeep
RE: [EXT] Re: [PATCH] dt-bindings: spi: Convert NXP flexspi to json schema
> -Original Message- > From: Rob Herring > Sent: Monday, March 1, 2021 8:14 PM > To: Kuldeep Singh > Cc: devicet...@vger.kernel.org; Rob Herring ; Mark Brown > ; Ashish Kumar ; linux- > ker...@vger.kernel.org; linux-...@vger.kernel.org > Subject: [EXT] Re: [PATCH] dt-bindings: spi: Convert NXP flexspi to json > schema > > Caution: EXT Email > > On Mon, 01 Mar 2021 15:34:06 +0530, Kuldeep Singh wrote: > > Convert the NXP FlexSPI binding to DT schema format using json-schema. > > Also, update MAINTAINERS to reflect the change. > > > > Signed-off-by: Kuldeep Singh > > --- > > .../bindings/spi/nxp,spi-nxp-fspi.yaml| 101 ++ > > .../devicetree/bindings/spi/spi-nxp-fspi.txt | 42 > > MAINTAINERS | 2 +- > > 3 files changed, 102 insertions(+), 43 deletions(-) create mode > > 100644 Documentation/devicetree/bindings/spi/nxp,spi-nxp-fspi.yaml > > delete mode 100644 > > Documentation/devicetree/bindings/spi/spi-nxp-fspi.txt > > > > My bot found errors running 'make dt_binding_check' on your patch: > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > /builds/robherring/linux-dt- > review/Documentation/devicetree/bindings/spi/nxp,spi-nxp-fspi.yaml: > properties:clocks:maxItems: False schema does not allow 2 > /builds/robherring/linux-dt- > review/Documentation/devicetree/bindings/spi/nxp,spi-nxp-fspi.yaml: ignoring, > error in schema: properties: clocks: maxItems > warning: no schema found in > file: ./Documentation/devicetree/bindings/spi/nxp,spi-nxp-fspi.yaml > Error: Documentation/devicetree/bindings/spi/nxp,spi-nxp- > fspi.example.dts:26.31-32 syntax error FATAL ERROR: Unable to parse input tree > make[1]: *** [scripts/Makefile.lib:349: > Documentation/devicetree/bindings/spi/nxp,spi-nxp-fspi.example.dt.yaml] Error > 1 > make: *** [Makefile:1380: dt_binding_check] Error 2 > > See > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatchwork > .ozlabs.org%2Fpatch%2F1445509data=04%7C01%7Ckuldeep.singh%40nxp. > com%7Cb964d840a95e45dbf3cc08d8dcc08376%7C686ea1d3bc2b4c6fa92cd99c5c > 301635%7C0%7C0%7C637502066681922692%7CUnknown%7CTWFpbGZsb3d8eyJ > WIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1 > 000sdata=Ga5fpQ7oBEz8sQaA%2BtBZh75gPELe%2FDg6R5qJ2tZ2pB4%3D& > amp;reserved=0 > > This check can fail if there are any dependencies. The base for a patch > series is > generally the most recent rc1. > > If you already ran 'make dt_binding_check' and didn't see the above error(s), > then > make sure 'yamllint' is installed and dt-schema is up to > date: > > pip3 install dtschema --upgrade > > Please check and re-submit. Thanks Rob for mentioning. I will make sure to run 'make dt_binding_check' before submitting next version. Regards Kuldeep
Re: [PATCH] dt-bindings: spi: Convert NXP flexspi to json schema
On Mon, 01 Mar 2021 15:34:06 +0530, Kuldeep Singh wrote: > Convert the NXP FlexSPI binding to DT schema format using json-schema. > Also, update MAINTAINERS to reflect the change. > > Signed-off-by: Kuldeep Singh > --- > .../bindings/spi/nxp,spi-nxp-fspi.yaml| 101 ++ > .../devicetree/bindings/spi/spi-nxp-fspi.txt | 42 > MAINTAINERS | 2 +- > 3 files changed, 102 insertions(+), 43 deletions(-) > create mode 100644 > Documentation/devicetree/bindings/spi/nxp,spi-nxp-fspi.yaml > delete mode 100644 Documentation/devicetree/bindings/spi/spi-nxp-fspi.txt > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/spi/nxp,spi-nxp-fspi.yaml: properties:clocks:maxItems: False schema does not allow 2 /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/spi/nxp,spi-nxp-fspi.yaml: ignoring, error in schema: properties: clocks: maxItems warning: no schema found in file: ./Documentation/devicetree/bindings/spi/nxp,spi-nxp-fspi.yaml Error: Documentation/devicetree/bindings/spi/nxp,spi-nxp-fspi.example.dts:26.31-32 syntax error FATAL ERROR: Unable to parse input tree make[1]: *** [scripts/Makefile.lib:349: Documentation/devicetree/bindings/spi/nxp,spi-nxp-fspi.example.dt.yaml] Error 1 make: *** [Makefile:1380: dt_binding_check] Error 2 See https://patchwork.ozlabs.org/patch/1445509 This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit.
