RE: [PATCH] staging: fpgaboot: clean up Makefile
On Thursday, April 03, 2014 10:56 AM, Dan Carpenter wrote: > > Signed-off-by is like signing a legal document, to show you haven't violated > copyright law or anything while the patch was in your hands. > You should use Acked-by or Reviewed-by depending on what you mean. > Dan, Thank you for pointing that out. This was for reviewing, so I would put this instead, then. Reviewed-by: Insop Song Regards, ISS -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] staging: fpgaboot: clean up Makefile
On Thu, Apr 03, 2014 at 05:14:44PM +, Insop Song wrote: > Added signed-off-by below: > Signed-off-by is like signing a legal document, to show you haven't violated copyright law or anything while the patch was in your hands. You should use Acked-by or Reviewed-by depending on what you mean. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
RE: [PATCH] staging: fpgaboot: clean up Makefile
Added signed-off-by below:
On Thursday, April 03, 2014 1:32 AM, Paul Bolle wrote:
>
> This Makefile tries to set the DEBUG macro but it uses an unknown Kconfig
> macro to do so. Since no code appears to even care about the DEBUG macro
> this line can safely be removed.
>
> Signed-off-by: Paul Bolle
Signed-off-by: Insop Song
> ---
> Completely untested.
>
> By the way, do de...@driverdev.osuosl.org and
> de...@linuxdriverproject.org deliver to the same list?
>
> drivers/staging/gs_fpgaboot/Makefile | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/staging/gs_fpgaboot/Makefile
> b/drivers/staging/gs_fpgaboot/Makefile
> index 34cb606..d2f0211 100644
> --- a/drivers/staging/gs_fpgaboot/Makefile
> +++ b/drivers/staging/gs_fpgaboot/Makefile
> @@ -1,4 +1,2 @@
> gs_fpga-y+= gs_fpgaboot.o io.o
> obj-$(CONFIG_GS_FPGABOOT)+= gs_fpga.o
> -
> -ccflags-$(CONFIG_GS_FPGA_DEBUG) := -DDEBUG
> --
> 1.9.0
N�r��yb�X��ǧv�^�){.n�+{zX����ܨ}���Ơz�:+v���zZ+��+zf���h���~i���z� �w���?�&�)ߢf��^jǫy�m��@A�a���
0��h���i
RE: [PATCH] staging: fpgaboot: clean up Makefile
Added signed-off-by below:
On Thursday, April 03, 2014 1:32 AM, Paul Bolle wrote:
This Makefile tries to set the DEBUG macro but it uses an unknown Kconfig
macro to do so. Since no code appears to even care about the DEBUG macro
this line can safely be removed.
Signed-off-by: Paul Bolle pebo...@tiscali.nl
Signed-off-by: Insop Song insop.s...@gainspeed.com
---
Completely untested.
By the way, do de...@driverdev.osuosl.org and
de...@linuxdriverproject.org deliver to the same list?
drivers/staging/gs_fpgaboot/Makefile | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/gs_fpgaboot/Makefile
b/drivers/staging/gs_fpgaboot/Makefile
index 34cb606..d2f0211 100644
--- a/drivers/staging/gs_fpgaboot/Makefile
+++ b/drivers/staging/gs_fpgaboot/Makefile
@@ -1,4 +1,2 @@
gs_fpga-y+= gs_fpgaboot.o io.o
obj-$(CONFIG_GS_FPGABOOT)+= gs_fpga.o
-
-ccflags-$(CONFIG_GS_FPGA_DEBUG) := -DDEBUG
--
1.9.0
N�r��yb�X��ǧv�^�){.n�+{zX����ܨ}���Ơz�j:+v���zZ+��+zf���h���~i���z� �w���?��)ߢf��^jǫy�m��@A�a���
0��h���i
Re: [PATCH] staging: fpgaboot: clean up Makefile
On Thu, Apr 03, 2014 at 05:14:44PM +, Insop Song wrote: Added signed-off-by below: Signed-off-by is like signing a legal document, to show you haven't violated copyright law or anything while the patch was in your hands. You should use Acked-by or Reviewed-by depending on what you mean. regards, dan carpenter -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
RE: [PATCH] staging: fpgaboot: clean up Makefile
On Thursday, April 03, 2014 10:56 AM, Dan Carpenter wrote: Signed-off-by is like signing a legal document, to show you haven't violated copyright law or anything while the patch was in your hands. You should use Acked-by or Reviewed-by depending on what you mean. Dan, Thank you for pointing that out. This was for reviewing, so I would put this instead, then. Reviewed-by: Insop Song insop.s...@gainspeed.com Regards, ISS -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
