Re: [PATCH] vfio: mdev: make a couple of functions and structure vfio_mdev_driver static
On Fri, 22 Dec 2017 07:12:26 +0800 Xiongwei Song wrote: > The functions vfio_mdev_probe, vfio_mdev_remove and the structure > vfio_mdev_driver are only used in this file, so make them static. > > Clean up sparse warnings: > drivers/vfio/mdev/vfio_mdev.c:114:5: warning: no previous prototype > for 'vfio_mdev_probe' [-Wmissing-prototypes] > drivers/vfio/mdev/vfio_mdev.c:121:6: warning: no previous prototype > for 'vfio_mdev_remove' [-Wmissing-prototypes] > > Signed-off-by: Xiongwei Song > --- > drivers/vfio/mdev/vfio_mdev.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) Applied to next branch with reviewed-bys for v4.16. Thanks, Alex
Re: [PATCH] vfio: mdev: make a couple of functions and structure vfio_mdev_driver static
On 12/22/2017 4:42 AM, Xiongwei Song wrote: > The functions vfio_mdev_probe, vfio_mdev_remove and the structure > vfio_mdev_driver are only used in this file, so make them static. > > Clean up sparse warnings: > drivers/vfio/mdev/vfio_mdev.c:114:5: warning: no previous prototype > for 'vfio_mdev_probe' [-Wmissing-prototypes] > drivers/vfio/mdev/vfio_mdev.c:121:6: warning: no previous prototype > for 'vfio_mdev_remove' [-Wmissing-prototypes] > > Signed-off-by: Xiongwei Song > --- > drivers/vfio/mdev/vfio_mdev.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/vfio/mdev/vfio_mdev.c b/drivers/vfio/mdev/vfio_mdev.c > index fa848a701b8b..d230620fe02d 100644 > --- a/drivers/vfio/mdev/vfio_mdev.c > +++ b/drivers/vfio/mdev/vfio_mdev.c > @@ -111,19 +111,19 @@ static const struct vfio_device_ops vfio_mdev_dev_ops = > { > .mmap = vfio_mdev_mmap, > }; > > -int vfio_mdev_probe(struct device *dev) > +static int vfio_mdev_probe(struct device *dev) > { > struct mdev_device *mdev = to_mdev_device(dev); > > return vfio_add_group_dev(dev, &vfio_mdev_dev_ops, mdev); > } > > -void vfio_mdev_remove(struct device *dev) > +static void vfio_mdev_remove(struct device *dev) > { > vfio_del_group_dev(dev); > } > > -struct mdev_driver vfio_mdev_driver = { > +static struct mdev_driver vfio_mdev_driver = { > .name = "vfio_mdev", > .probe = vfio_mdev_probe, > .remove = vfio_mdev_remove, > Reviewed by: Kirti Wankhede
RE: [PATCH] vfio: mdev: make a couple of functions and structure vfio_mdev_driver static
> Sent: Friday, December 22, 2017 7:12 AM > To: kwankh...@nvidia.com; alex.william...@redhat.com > Cc: k...@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: [PATCH] vfio: mdev: make a couple of functions and structure > vfio_mdev_driver static > > The functions vfio_mdev_probe, vfio_mdev_remove and the structure > vfio_mdev_driver are only used in this file, so make them static. > > Clean up sparse warnings: > drivers/vfio/mdev/vfio_mdev.c:114:5: warning: no previous prototype for > 'vfio_mdev_probe' [-Wmissing-prototypes] > drivers/vfio/mdev/vfio_mdev.c:121:6: warning: no previous prototype for > 'vfio_mdev_remove' [-Wmissing-prototypes] > > Signed-off-by: Xiongwei Song > --- > drivers/vfio/mdev/vfio_mdev.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/vfio/mdev/vfio_mdev.c b/drivers/vfio/mdev/vfio_mdev.c > index > fa848a701b8b..d230620fe02d 100644 > --- a/drivers/vfio/mdev/vfio_mdev.c > +++ b/drivers/vfio/mdev/vfio_mdev.c > @@ -111,19 +111,19 @@ static const struct vfio_device_ops vfio_mdev_dev_ops = > { > .mmap = vfio_mdev_mmap, > }; > > -int vfio_mdev_probe(struct device *dev) > +static int vfio_mdev_probe(struct device *dev) > { > struct mdev_device *mdev = to_mdev_device(dev); > > return vfio_add_group_dev(dev, &vfio_mdev_dev_ops, mdev); } > > -void vfio_mdev_remove(struct device *dev) > +static void vfio_mdev_remove(struct device *dev) > { > vfio_del_group_dev(dev); > } > > -struct mdev_driver vfio_mdev_driver = { > +static struct mdev_driver vfio_mdev_driver = { > .name = "vfio_mdev", > .probe = vfio_mdev_probe, > .remove = vfio_mdev_remove, > -- > 2.15.1 Reviewed-by: Liu, Yi L
Re: [PATCH] vfio: mdev: make a couple of functions and structure vfio_mdev_driver static
On 2017/12/22 07:12, Xiongwei Song wrote: The functions vfio_mdev_probe, vfio_mdev_remove and the structure vfio_mdev_driver are only used in this file, so make them static. Clean up sparse warnings: drivers/vfio/mdev/vfio_mdev.c:114:5: warning: no previous prototype for 'vfio_mdev_probe' [-Wmissing-prototypes] drivers/vfio/mdev/vfio_mdev.c:121:6: warning: no previous prototype for 'vfio_mdev_remove' [-Wmissing-prototypes] Signed-off-by: Xiongwei Song --- drivers/vfio/mdev/vfio_mdev.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/vfio/mdev/vfio_mdev.c b/drivers/vfio/mdev/vfio_mdev.c index fa848a701b8b..d230620fe02d 100644 --- a/drivers/vfio/mdev/vfio_mdev.c +++ b/drivers/vfio/mdev/vfio_mdev.c @@ -111,19 +111,19 @@ static const struct vfio_device_ops vfio_mdev_dev_ops = { .mmap = vfio_mdev_mmap, }; -int vfio_mdev_probe(struct device *dev) +static int vfio_mdev_probe(struct device *dev) { struct mdev_device *mdev = to_mdev_device(dev); return vfio_add_group_dev(dev, &vfio_mdev_dev_ops, mdev); } -void vfio_mdev_remove(struct device *dev) +static void vfio_mdev_remove(struct device *dev) { vfio_del_group_dev(dev); } -struct mdev_driver vfio_mdev_driver = { +static struct mdev_driver vfio_mdev_driver = { .name = "vfio_mdev", .probe = vfio_mdev_probe, .remove = vfio_mdev_remove, Reviewed-by: Quan Xu