Re: [PATCH 1/1] gpio: sch: Consolidate similar algorithms
On Wed, Jan 21, 2015 at 11:32 AM, Chang Rebecca Swee Fun wrote: > Consolidating similar algorithms into common functions to make > GPIO SCH simpler and manageable. > > Signed-off-by: Chang Rebecca Swee Fun Applied again, with the review-tags. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 1/1] gpio: sch: Consolidate similar algorithms
On Wed, Jan 21, 2015 at 11:32 AM, Chang Rebecca Swee Fun rebecca.swee.fun.ch...@intel.com wrote: Consolidating similar algorithms into common functions to make GPIO SCH simpler and manageable. Signed-off-by: Chang Rebecca Swee Fun rebecca.swee.fun.ch...@intel.com Applied again, with the review-tags. Yours, Linus Walleij -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
RE: [PATCH 1/1] gpio: sch: Consolidate similar algorithms
Hi both, Noted with thanks! Rebecca > -Original Message- > From: Westerberg, Mika > Sent: 22 January, 2015 5:46 PM > To: Chang, Rebecca Swee Fun > Cc: Linus Walleij; Alexandre Courbot; GPIO Subsystem Mailing List; Linux > Kernel > Mailing List > Subject: Re: [PATCH 1/1] gpio: sch: Consolidate similar algorithms > > On Wed, Jan 21, 2015 at 06:32:21PM +0800, Chang Rebecca Swee Fun wrote: > > Consolidating similar algorithms into common functions to make GPIO > > SCH simpler and manageable. > > > > Signed-off-by: Chang Rebecca Swee Fun > > > > Like Alexandre said, you can carry the Reviewed-by: tags with the patch if you > only fixed build warning. > > In future please make sure that patches compile without warnings and that > they have proper testing done beforehand. Thanks. > > Reviewed-by: Mika Westerberg -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 1/1] gpio: sch: Consolidate similar algorithms
On Wed, Jan 21, 2015 at 06:32:21PM +0800, Chang Rebecca Swee Fun wrote: > Consolidating similar algorithms into common functions to make > GPIO SCH simpler and manageable. > > Signed-off-by: Chang Rebecca Swee Fun Like Alexandre said, you can carry the Reviewed-by: tags with the patch if you only fixed build warning. In future please make sure that patches compile without warnings and that they have proper testing done beforehand. Thanks. Reviewed-by: Mika Westerberg -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
RE: [PATCH 1/1] gpio: sch: Consolidate similar algorithms
Hi both, Noted with thanks! Rebecca -Original Message- From: Westerberg, Mika Sent: 22 January, 2015 5:46 PM To: Chang, Rebecca Swee Fun Cc: Linus Walleij; Alexandre Courbot; GPIO Subsystem Mailing List; Linux Kernel Mailing List Subject: Re: [PATCH 1/1] gpio: sch: Consolidate similar algorithms On Wed, Jan 21, 2015 at 06:32:21PM +0800, Chang Rebecca Swee Fun wrote: Consolidating similar algorithms into common functions to make GPIO SCH simpler and manageable. Signed-off-by: Chang Rebecca Swee Fun rebecca.swee.fun.ch...@intel.com Like Alexandre said, you can carry the Reviewed-by: tags with the patch if you only fixed build warning. In future please make sure that patches compile without warnings and that they have proper testing done beforehand. Thanks. Reviewed-by: Mika Westerberg mika.westerb...@linux.intel.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 1/1] gpio: sch: Consolidate similar algorithms
On Wed, Jan 21, 2015 at 06:32:21PM +0800, Chang Rebecca Swee Fun wrote: Consolidating similar algorithms into common functions to make GPIO SCH simpler and manageable. Signed-off-by: Chang Rebecca Swee Fun rebecca.swee.fun.ch...@intel.com Like Alexandre said, you can carry the Reviewed-by: tags with the patch if you only fixed build warning. In future please make sure that patches compile without warnings and that they have proper testing done beforehand. Thanks. Reviewed-by: Mika Westerberg mika.westerb...@linux.intel.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 1/1] gpio: sch: Consolidate similar algorithms
On Wed, Jan 21, 2015 at 7:32 PM, Chang Rebecca Swee Fun wrote: > Consolidating similar algorithms into common functions to make > GPIO SCH simpler and manageable. > > Signed-off-by: Chang Rebecca Swee Fun Looks like there has been some confusion due to the adding/removal of patches on Linus' branch. I (as well as Mika IIRC) gave my Reviewed-by on an earlier version of this patch. Has it changed that much that it needs to be reviewed from start again? If you just fixed it to compile on Linus' latest devel branch, you can (and should) carry tags over. Anyway: Reviewed-by: Alexandre Courbot -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 1/1] gpio: sch: Consolidate similar algorithms
On Wed, Jan 21, 2015 at 7:32 PM, Chang Rebecca Swee Fun rebecca.swee.fun.ch...@intel.com wrote: Consolidating similar algorithms into common functions to make GPIO SCH simpler and manageable. Signed-off-by: Chang Rebecca Swee Fun rebecca.swee.fun.ch...@intel.com Looks like there has been some confusion due to the adding/removal of patches on Linus' branch. I (as well as Mika IIRC) gave my Reviewed-by on an earlier version of this patch. Has it changed that much that it needs to be reviewed from start again? If you just fixed it to compile on Linus' latest devel branch, you can (and should) carry tags over. Anyway: Reviewed-by: Alexandre Courbot acour...@nvidia.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
