RE: [PATCH 1/2] rtc: omap: add option to indicate wakeup support through DT
On Fri, May 31, 2013 at 23:18:03, Kevin Hilman wrote: > Hebbar Gururaja writes: > > > Even though RTC-IP is wakeup capable, Not all Boards support it. > > > > For example > > The rtc alarm wakeup is available in rtc-ip since omap1 days but alarm > > was not wired properly in previous ompa1 boards. > > > > commit fa5b07820fe3a0fc06ac368516e71f10a59b9539 > > Author: Sekhar Nori > > Date: Wed Oct 27 15:33:05 2010 -0700 > > > > rtc: omap: let device wakeup capability be configured from chip > > init logic > > > > The rtc-omap driver currently hardcodes the RTC wakeup > > capability to be "not capable". While this seems to be true for > > existing OMAP1 boards which are not wired for this, the > > DA850/OMAP-L138 SoC, the RTC can always be wake up source from > > its "deep sleep" mode. > > > > Current rtc-omap driver expects the rtc module wake-up capabilities to > > be set up by board specific code. However, in case of DT, this is not > > possible. > > > > So, add a DT property "ti,wakeup_capable" to indicate that the module is > > wake-up capable. > > Why is this a TI-specific property? May be I am wrong but isn't this driver used only be TI SoC (Davinci, OMAP ...) > > Also, I think we can do this without a new DT property.Did you see this > patch from Tony which is already queued for v3.11: > > http://marc.info/?l=linux-omap&m=136917244530612&w=2 AFAIK, all boards that use twl rtc IP by default support rtc wakeup. However, as mentioned in the commit message not all boards that uses OMAP rtc IP supports rtc wake up (due to somoe wiring issue). Hence I am adding a new DT property for this. > > I think this is the right way to go. Platforms that don't want/need > wakeup support can disable it from userspace via: > > echo disabled > /sys/devices/.../power/wakeup Hmmm. Debatable. Let me get some more info about this and come back > > Kevin > > Regards, Gururaja -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 1/2] rtc: omap: add option to indicate wakeup support through DT
Hebbar Gururaja writes: > Even though RTC-IP is wakeup capable, Not all Boards support it. > > For example > The rtc alarm wakeup is available in rtc-ip since omap1 days but alarm > was not wired properly in previous ompa1 boards. > > commit fa5b07820fe3a0fc06ac368516e71f10a59b9539 > Author: Sekhar Nori > Date: Wed Oct 27 15:33:05 2010 -0700 > > rtc: omap: let device wakeup capability be configured from chip > init logic > > The rtc-omap driver currently hardcodes the RTC wakeup > capability to be "not capable". While this seems to be true for > existing OMAP1 boards which are not wired for this, the > DA850/OMAP-L138 SoC, the RTC can always be wake up source from > its "deep sleep" mode. > > Current rtc-omap driver expects the rtc module wake-up capabilities to > be set up by board specific code. However, in case of DT, this is not > possible. > > So, add a DT property "ti,wakeup_capable" to indicate that the module is > wake-up capable. Why is this a TI-specific property? Also, I think we can do this without a new DT property.Did you see this patch from Tony which is already queued for v3.11: http://marc.info/?l=linux-omap&m=136917244530612&w=2 I think this is the right way to go. Platforms that don't want/need wakeup support can disable it from userspace via: echo disabled > /sys/devices/.../power/wakeup Kevin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
RE: [PATCH 1/2] rtc: omap: add option to indicate wakeup support through DT
On Fri, May 31, 2013 at 12:14:44, Prabhakar Lad wrote: > Hi Gururaja, > > Thanks for the patch. > > On Fri, May 31, 2013 at 12:03 PM, Hebbar Gururaja > wrote: > > Even though RTC-IP is wakeup capable, Not all Boards support it. > > > > For example > > The rtc alarm wakeup is available in rtc-ip since omap1 days but alarm > > was not wired properly in previous ompa1 boards. > > > [snip] > > > > +Optional properties: > > +- ti,wakeup_capable: Inform the rtc driver that this module is wake-up > For devicetree properties '-' is preferred over '_'. Thanks for the review. I will make the correction. But will wait for some more time (so others can review) and then send V2 > > Regards, > --Prabhakar Lad > Regards, Gururaja -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 1/2] rtc: omap: add option to indicate wakeup support through DT
Hi Gururaja, Thanks for the patch. On Fri, May 31, 2013 at 12:03 PM, Hebbar Gururaja wrote: > Even though RTC-IP is wakeup capable, Not all Boards support it. > > For example > The rtc alarm wakeup is available in rtc-ip since omap1 days but alarm > was not wired properly in previous ompa1 boards. > [snip] > > +Optional properties: > +- ti,wakeup_capable: Inform the rtc driver that this module is wake-up For devicetree properties '-' is preferred over '_'. Regards, --Prabhakar Lad -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
