RE: [PATCH 1/3] opp: of: Support multiple suspend OPPs defined in DT
Hi, Viresh > On 09-07-19, 15:10, anson.hu...@nxp.com wrote: > > From: Anson Huang > > > > With property "opp-supported-hw" introduced, the OPP table in DT could > > be a large OPP table and ONLY a subset of OPPs are available, based on > > the version of the hardware running on. That introduces restriction of > > using "opp-suspend" > > property to define the suspend OPP, as we are NOT sure if the OPP > > containing "opp-suspend" property is available for the hardware > > running on, and the of opp core does NOT allow multiple suspend OPPs > > defined in DT OPP table. > > > > To eliminate this restrition, make of opp core allow multiple suspend > > OPPs defined in DT, and pick the OPP with highest rate and with > > "opp-suspend" property present to be suspend OPP, it can speed up the > > suspend/resume process. > > > > Signed-off-by: Anson Huang > > --- > > drivers/opp/of.c | 9 ++--- > > 1 file changed, 6 insertions(+), 3 deletions(-) > > Please update the DT bindings first. OK, will send a V2 containing DT binding changes. > > FWIW, all three patches look fine otherwise. Thank you! Anson.
Re: [PATCH 1/3] opp: of: Support multiple suspend OPPs defined in DT
On 09-07-19, 15:10, anson.hu...@nxp.com wrote: > From: Anson Huang > > With property "opp-supported-hw" introduced, the OPP table > in DT could be a large OPP table and ONLY a subset of OPPs > are available, based on the version of the hardware running > on. That introduces restriction of using "opp-suspend" > property to define the suspend OPP, as we are NOT sure if the > OPP containing "opp-suspend" property is available for the > hardware running on, and the of opp core does NOT allow multiple > suspend OPPs defined in DT OPP table. > > To eliminate this restrition, make of opp core allow multiple > suspend OPPs defined in DT, and pick the OPP with highest rate > and with "opp-suspend" property present to be suspend OPP, it > can speed up the suspend/resume process. > > Signed-off-by: Anson Huang > --- > drivers/opp/of.c | 9 ++--- > 1 file changed, 6 insertions(+), 3 deletions(-) Please update the DT bindings first. FWIW, all three patches look fine otherwise. -- viresh
