Re: [PATCH 1/4] arm64: Enable TIMER_IMX_SYS_CTR for ARCH_MXC platforms
On Mon, Jul 22, 2019 at 02:15:10AM +, Anson Huang wrote: > Hi, Shawn > > > On Mon, Jun 24, 2019 at 02:35:10AM +, Anson Huang wrote: > > > Hi, Shawn > > > > > > > -Original Message- > > > > From: Shawn Guo > > > > Sent: Monday, June 24, 2019 10:27 AM > > > > To: Anson Huang > > > > Cc: mark.rutl...@arm.com; Aisheng Dong ; > > Peng > > > > Fan ; feste...@gmail.com; Jacky Bai > > > > ; devicet...@vger.kernel.org; sb...@kernel.org; > > > > catalin.mari...@arm.com; s.ha...@pengutronix.de; linux- > > > > ker...@vger.kernel.org; Daniel Baluta ; > > > > linux- c...@vger.kernel.org; robh...@kernel.org; dl-linux-imx > > > i...@nxp.com>; ker...@pengutronix.de; Leonard Crestez > > > > ; w...@kernel.org; mturque...@baylibre.com; > > > > linux-arm-ker...@lists.infradead.org; Abel Vesa > > > > Subject: Re: [PATCH 1/4] arm64: Enable TIMER_IMX_SYS_CTR for > > > > ARCH_MXC platforms > > > > > > > > On Mon, Jun 24, 2019 at 10:22:01AM +0800, Shawn Guo wrote: > > > > > On Fri, Jun 21, 2019 at 03:07:17PM +0800, anson.hu...@nxp.com > > wrote: > > > > > > From: Anson Huang > > > > > > > > > > > > ARCH_MXC platforms needs system counter as broadcast timer to > > > > > > support cpuidle, enable it by default. > > > > > > > > > > > > Signed-off-by: Anson Huang > > > > > > --- > > > > > > arch/arm64/Kconfig.platforms | 1 + > > > > > > 1 file changed, 1 insertion(+) > > > > > > > > > > > > diff --git a/arch/arm64/Kconfig.platforms > > > > > > b/arch/arm64/Kconfig.platforms index 4778c77..f5e623f 100644 > > > > > > --- a/arch/arm64/Kconfig.platforms > > > > > > +++ b/arch/arm64/Kconfig.platforms > > > > > > @@ -173,6 +173,7 @@ config ARCH_MXC > > > > > > select PM > > > > > > select PM_GENERIC_DOMAINS > > > > > > select SOC_BUS > > > > > > + select TIMER_IMX_SYS_CTR > > > > > > > > > > Where is that driver? > > > > > > > > Okay, just found it in the mailbox. They seem to be sent in the wrong > > order. > > > > Really, you should send this series only after the driver lands on > > > > mainline. > > > > > > OK, just noticed that mainline does NOT have it, since I did it based on > > > next > > tree. > > > I will resend the patch series after the system counter driver landing on > > mainline. > > > > I just picked the series up, so no need to resend. > > Something changed for this series, the system counter clock related > implementation > are changed after some comments from maintainer, so I think you should picked > up > below patch series instead, and drop this series, > > https://patchwork.kernel.org/patch/11037953/ Okay, dropped clk and dts patches. arch/arm64/Kconfig.platforms one is kept. Shawn
RE: [PATCH 1/4] arm64: Enable TIMER_IMX_SYS_CTR for ARCH_MXC platforms
Hi, Shawn > On Mon, Jun 24, 2019 at 02:35:10AM +, Anson Huang wrote: > > Hi, Shawn > > > > > -Original Message- > > > From: Shawn Guo > > > Sent: Monday, June 24, 2019 10:27 AM > > > To: Anson Huang > > > Cc: mark.rutl...@arm.com; Aisheng Dong ; > Peng > > > Fan ; feste...@gmail.com; Jacky Bai > > > ; devicet...@vger.kernel.org; sb...@kernel.org; > > > catalin.mari...@arm.com; s.ha...@pengutronix.de; linux- > > > ker...@vger.kernel.org; Daniel Baluta ; > > > linux- c...@vger.kernel.org; robh...@kernel.org; dl-linux-imx > > i...@nxp.com>; ker...@pengutronix.de; Leonard Crestez > > > ; w...@kernel.org; mturque...@baylibre.com; > > > linux-arm-ker...@lists.infradead.org; Abel Vesa > > > Subject: Re: [PATCH 1/4] arm64: Enable TIMER_IMX_SYS_CTR for > > > ARCH_MXC platforms > > > > > > On Mon, Jun 24, 2019 at 10:22:01AM +0800, Shawn Guo wrote: > > > > On Fri, Jun 21, 2019 at 03:07:17PM +0800, anson.hu...@nxp.com > wrote: > > > > > From: Anson Huang > > > > > > > > > > ARCH_MXC platforms needs system counter as broadcast timer to > > > > > support cpuidle, enable it by default. > > > > > > > > > > Signed-off-by: Anson Huang > > > > > --- > > > > > arch/arm64/Kconfig.platforms | 1 + > > > > > 1 file changed, 1 insertion(+) > > > > > > > > > > diff --git a/arch/arm64/Kconfig.platforms > > > > > b/arch/arm64/Kconfig.platforms index 4778c77..f5e623f 100644 > > > > > --- a/arch/arm64/Kconfig.platforms > > > > > +++ b/arch/arm64/Kconfig.platforms > > > > > @@ -173,6 +173,7 @@ config ARCH_MXC > > > > > select PM > > > > > select PM_GENERIC_DOMAINS > > > > > select SOC_BUS > > > > > + select TIMER_IMX_SYS_CTR > > > > > > > > Where is that driver? > > > > > > Okay, just found it in the mailbox. They seem to be sent in the wrong > order. > > > Really, you should send this series only after the driver lands on > > > mainline. > > > > OK, just noticed that mainline does NOT have it, since I did it based on > > next > tree. > > I will resend the patch series after the system counter driver landing on > mainline. > > I just picked the series up, so no need to resend. Something changed for this series, the system counter clock related implementation are changed after some comments from maintainer, so I think you should picked up below patch series instead, and drop this series, https://patchwork.kernel.org/patch/11037953/ thanks, Anson
Re: [PATCH 1/4] arm64: Enable TIMER_IMX_SYS_CTR for ARCH_MXC platforms
On Mon, Jun 24, 2019 at 02:35:10AM +, Anson Huang wrote: > Hi, Shawn > > > -Original Message- > > From: Shawn Guo > > Sent: Monday, June 24, 2019 10:27 AM > > To: Anson Huang > > Cc: mark.rutl...@arm.com; Aisheng Dong ; Peng > > Fan ; feste...@gmail.com; Jacky Bai > > ; devicet...@vger.kernel.org; sb...@kernel.org; > > catalin.mari...@arm.com; s.ha...@pengutronix.de; linux- > > ker...@vger.kernel.org; Daniel Baluta ; linux- > > c...@vger.kernel.org; robh...@kernel.org; dl-linux-imx > i...@nxp.com>; ker...@pengutronix.de; Leonard Crestez > > ; w...@kernel.org; mturque...@baylibre.com; > > linux-arm-ker...@lists.infradead.org; Abel Vesa > > Subject: Re: [PATCH 1/4] arm64: Enable TIMER_IMX_SYS_CTR for ARCH_MXC > > platforms > > > > On Mon, Jun 24, 2019 at 10:22:01AM +0800, Shawn Guo wrote: > > > On Fri, Jun 21, 2019 at 03:07:17PM +0800, anson.hu...@nxp.com wrote: > > > > From: Anson Huang > > > > > > > > ARCH_MXC platforms needs system counter as broadcast timer to > > > > support cpuidle, enable it by default. > > > > > > > > Signed-off-by: Anson Huang > > > > --- > > > > arch/arm64/Kconfig.platforms | 1 + > > > > 1 file changed, 1 insertion(+) > > > > > > > > diff --git a/arch/arm64/Kconfig.platforms > > > > b/arch/arm64/Kconfig.platforms index 4778c77..f5e623f 100644 > > > > --- a/arch/arm64/Kconfig.platforms > > > > +++ b/arch/arm64/Kconfig.platforms > > > > @@ -173,6 +173,7 @@ config ARCH_MXC > > > > select PM > > > > select PM_GENERIC_DOMAINS > > > > select SOC_BUS > > > > + select TIMER_IMX_SYS_CTR > > > > > > Where is that driver? > > > > Okay, just found it in the mailbox. They seem to be sent in the wrong > > order. > > Really, you should send this series only after the driver lands on mainline. > > OK, just noticed that mainline does NOT have it, since I did it based on next > tree. > I will resend the patch series after the system counter driver landing on > mainline. I just picked the series up, so no need to resend. Shawn
RE: [PATCH 1/4] arm64: Enable TIMER_IMX_SYS_CTR for ARCH_MXC platforms
Hi, Shawn > -Original Message- > From: Shawn Guo > Sent: Monday, June 24, 2019 10:27 AM > To: Anson Huang > Cc: mark.rutl...@arm.com; Aisheng Dong ; Peng > Fan ; feste...@gmail.com; Jacky Bai > ; devicet...@vger.kernel.org; sb...@kernel.org; > catalin.mari...@arm.com; s.ha...@pengutronix.de; linux- > ker...@vger.kernel.org; Daniel Baluta ; linux- > c...@vger.kernel.org; robh...@kernel.org; dl-linux-imx i...@nxp.com>; ker...@pengutronix.de; Leonard Crestez > ; w...@kernel.org; mturque...@baylibre.com; > linux-arm-ker...@lists.infradead.org; Abel Vesa > Subject: Re: [PATCH 1/4] arm64: Enable TIMER_IMX_SYS_CTR for ARCH_MXC > platforms > > On Mon, Jun 24, 2019 at 10:22:01AM +0800, Shawn Guo wrote: > > On Fri, Jun 21, 2019 at 03:07:17PM +0800, anson.hu...@nxp.com wrote: > > > From: Anson Huang > > > > > > ARCH_MXC platforms needs system counter as broadcast timer to > > > support cpuidle, enable it by default. > > > > > > Signed-off-by: Anson Huang > > > --- > > > arch/arm64/Kconfig.platforms | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/arch/arm64/Kconfig.platforms > > > b/arch/arm64/Kconfig.platforms index 4778c77..f5e623f 100644 > > > --- a/arch/arm64/Kconfig.platforms > > > +++ b/arch/arm64/Kconfig.platforms > > > @@ -173,6 +173,7 @@ config ARCH_MXC > > > select PM > > > select PM_GENERIC_DOMAINS > > > select SOC_BUS > > > + select TIMER_IMX_SYS_CTR > > > > Where is that driver? > > Okay, just found it in the mailbox. They seem to be sent in the wrong order. > Really, you should send this series only after the driver lands on mainline. OK, just noticed that mainline does NOT have it, since I did it based on next tree. I will resend the patch series after the system counter driver landing on mainline. Thanks, Anson. > > Shawn
Re: [PATCH 1/4] arm64: Enable TIMER_IMX_SYS_CTR for ARCH_MXC platforms
On Mon, Jun 24, 2019 at 10:22:01AM +0800, Shawn Guo wrote: > On Fri, Jun 21, 2019 at 03:07:17PM +0800, anson.hu...@nxp.com wrote: > > From: Anson Huang > > > > ARCH_MXC platforms needs system counter as broadcast timer > > to support cpuidle, enable it by default. > > > > Signed-off-by: Anson Huang > > --- > > arch/arm64/Kconfig.platforms | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms > > index 4778c77..f5e623f 100644 > > --- a/arch/arm64/Kconfig.platforms > > +++ b/arch/arm64/Kconfig.platforms > > @@ -173,6 +173,7 @@ config ARCH_MXC > > select PM > > select PM_GENERIC_DOMAINS > > select SOC_BUS > > + select TIMER_IMX_SYS_CTR > > Where is that driver? Okay, just found it in the mailbox. They seem to be sent in the wrong order. Really, you should send this series only after the driver lands on mainline. Shawn
RE: [PATCH 1/4] arm64: Enable TIMER_IMX_SYS_CTR for ARCH_MXC platforms
Hi, Shawn > -Original Message- > From: Shawn Guo > Sent: Monday, June 24, 2019 10:22 AM > To: Anson Huang > Cc: catalin.mari...@arm.com; w...@kernel.org; robh...@kernel.org; > mark.rutl...@arm.com; s.ha...@pengutronix.de; ker...@pengutronix.de; > feste...@gmail.com; mturque...@baylibre.com; sb...@kernel.org; > Leonard Crestez ; Aisheng Dong > ; Jacky Bai ; Daniel Baluta > ; Peng Fan ; Abel Vesa > ; linux-arm-ker...@lists.infradead.org; linux- > ker...@vger.kernel.org; devicet...@vger.kernel.org; linux- > c...@vger.kernel.org; dl-linux-imx > Subject: Re: [PATCH 1/4] arm64: Enable TIMER_IMX_SYS_CTR for ARCH_MXC > platforms > > On Fri, Jun 21, 2019 at 03:07:17PM +0800, anson.hu...@nxp.com wrote: > > From: Anson Huang > > > > ARCH_MXC platforms needs system counter as broadcast timer to support > > cpuidle, enable it by default. > > > > Signed-off-by: Anson Huang > > --- > > arch/arm64/Kconfig.platforms | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/arch/arm64/Kconfig.platforms > > b/arch/arm64/Kconfig.platforms index 4778c77..f5e623f 100644 > > --- a/arch/arm64/Kconfig.platforms > > +++ b/arch/arm64/Kconfig.platforms > > @@ -173,6 +173,7 @@ config ARCH_MXC > > select PM > > select PM_GENERIC_DOMAINS > > select SOC_BUS > > + select TIMER_IMX_SYS_CTR > > Where is that driver? The driver is drivers/clocksource/timer-imx-sysctr.c, similar function as GPT. Thanks, Anson > > Shawn > > > help > > This enables support for the ARMv8 based SoCs in the > > NXP i.MX family. > > -- > > 2.7.4 > >
Re: [PATCH 1/4] arm64: Enable TIMER_IMX_SYS_CTR for ARCH_MXC platforms
On Fri, Jun 21, 2019 at 03:07:17PM +0800, anson.hu...@nxp.com wrote: > From: Anson Huang > > ARCH_MXC platforms needs system counter as broadcast timer > to support cpuidle, enable it by default. > > Signed-off-by: Anson Huang > --- > arch/arm64/Kconfig.platforms | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms > index 4778c77..f5e623f 100644 > --- a/arch/arm64/Kconfig.platforms > +++ b/arch/arm64/Kconfig.platforms > @@ -173,6 +173,7 @@ config ARCH_MXC > select PM > select PM_GENERIC_DOMAINS > select SOC_BUS > + select TIMER_IMX_SYS_CTR Where is that driver? Shawn > help > This enables support for the ARMv8 based SoCs in the > NXP i.MX family. > -- > 2.7.4 >
