RE: [PATCH 3/3] ARM: dts: am335x: add support for Moxa UC-2102 open platform
Hi,
> The 2102 is a superset of the 2101? If so, the 2102 should come first.
> If not, this should probably be 2 separate entries.
>
Nope, they use different SoC models and PMICs. I'll resend them separately in
next version.
Thanks for guidance.
> > + {
> > + vcc1-supply = <>;
> > + vcc2-supply = <>;
> > + vcc3-supply = <>;
> > + vcc4-supply = <>;
> > + vcc5-supply = <>;
> > + vcc6-supply = <>;
> > + vcc7-supply = <>;
> > + vccio-supply = <>;
> > +
> > + regulators {
> > + vrtc_reg: regulator@0 {
>
> Without a reg property, you shouldn't have unit addresses.
I would like to ask why shouldn't we keep unit address with
"regulator-always-on;" reg property?
SZ
>
>
> > + regulator-always-on;
> > + };
> > +
> > + vio_reg: regulator@1 {
> > + regulator-always-on;
> > + };
> > +
> > + vdd1_reg: regulator@2 {
> > + /* VDD_MPU voltage limits 0.95V - 1.26V with +/-4%
> > tolerance */
> > + regulator-name = "vdd_mpu";
> > + regulator-min-microvolt = <912500>;
> > + regulator-max-microvolt = <1378000>;
> > + regulator-boot-on;
> > + regulator-always-on;
> > + };
> > +
> > + vdd2_reg: regulator@3 {
> > + /* VDD_CORE voltage limits 0.95V - 1.1V with +/-4%
> > tolerance */
> > + regulator-name = "vdd_core";
> > + regulator-min-microvolt = <912500>;
> > + regulator-max-microvolt = <115>;
> > + regulator-boot-on;
> > + regulator-always-on;
> > + };
> > +
> > + vdd3_reg: regulator@4 {
> > + regulator-always-on;
> > + };
> > +
> > + vdig1_reg: regulator@5 {
> > + regulator-always-on;
> > + };
> > +
> > + vdig2_reg: regulator@6 {
> > + regulator-always-on;
> > + };
> > +
> > + vpll_reg: regulator@7 {
> > + regulator-always-on;
> > + };
> > +
> > + vdac_reg: regulator@8 {
> > + regulator-always-on;
> > + };
> > +
> > + vaux1_reg: regulator@9 {
> > + regulator-always-on;
> > + };
> > +
> > + vaux2_reg: regulator@10 {
> > + regulator-always-on;
> > + };
> > +
> > + vaux33_reg: regulator@11 {
> > + regulator-always-on;
> > + };
> > +
> > + vmmc_reg: regulator@12 {
> > + compatible = "regulator-fixed";
> > + regulator-name = "vmmc_reg";
> > + regulator-min-microvolt = <330>;
> > + regulator-max-microvolt = <330>;
> > + regulator-always-on;
> > + };
> > + };
> > +};
> > +
> > + {
> > + pinctrl-names = "default";
> > + pinctrl-0 = <_default>;
> > + dual_emac = <1>;
> > + status = "okay";
> > +};
> > +
> > +_emac0 {
> > + status = "okay";
> > + phy_id = <_mdio>, <0x4>;
> > + phy-mode = "rmii";
> > + dual_emac_res_vlan = <1>;
> > +};
> > +
> > +_emac1 {
> > + status = "okay";
> > + phy_id = <_mdio>, <0x5>;
> > + phy-mode = "rmii";
> > + dual_emac_res_vlan = <2>;
> > +};
> > +
> > + {
> > + pinctrl-names = "default";
> > + vmmc-supply = <_fixed>;
> > + bus-width = <4>;
> > + pinctrl-0 = <_pins_default>;
> > + cd-gpios = < 14 GPIO_ACTIVE_HIGH>;
> > + wp-gpios = < 18 GPIO_ACTIVE_HIGH>;
> > + status = "okay";
> > +};
> > --
> > 2.19.0.rc1
> >
RE: [PATCH 3/3] ARM: dts: am335x: add support for Moxa UC-2102 open platform
Hi,
> The 2102 is a superset of the 2101? If so, the 2102 should come first.
> If not, this should probably be 2 separate entries.
>
Nope, they use different SoC models and PMICs. I'll resend them separately in
next version.
Thanks for guidance.
> > + {
> > + vcc1-supply = <>;
> > + vcc2-supply = <>;
> > + vcc3-supply = <>;
> > + vcc4-supply = <>;
> > + vcc5-supply = <>;
> > + vcc6-supply = <>;
> > + vcc7-supply = <>;
> > + vccio-supply = <>;
> > +
> > + regulators {
> > + vrtc_reg: regulator@0 {
>
> Without a reg property, you shouldn't have unit addresses.
I would like to ask why shouldn't we keep unit address with
"regulator-always-on;" reg property?
SZ
>
>
> > + regulator-always-on;
> > + };
> > +
> > + vio_reg: regulator@1 {
> > + regulator-always-on;
> > + };
> > +
> > + vdd1_reg: regulator@2 {
> > + /* VDD_MPU voltage limits 0.95V - 1.26V with +/-4%
> > tolerance */
> > + regulator-name = "vdd_mpu";
> > + regulator-min-microvolt = <912500>;
> > + regulator-max-microvolt = <1378000>;
> > + regulator-boot-on;
> > + regulator-always-on;
> > + };
> > +
> > + vdd2_reg: regulator@3 {
> > + /* VDD_CORE voltage limits 0.95V - 1.1V with +/-4%
> > tolerance */
> > + regulator-name = "vdd_core";
> > + regulator-min-microvolt = <912500>;
> > + regulator-max-microvolt = <115>;
> > + regulator-boot-on;
> > + regulator-always-on;
> > + };
> > +
> > + vdd3_reg: regulator@4 {
> > + regulator-always-on;
> > + };
> > +
> > + vdig1_reg: regulator@5 {
> > + regulator-always-on;
> > + };
> > +
> > + vdig2_reg: regulator@6 {
> > + regulator-always-on;
> > + };
> > +
> > + vpll_reg: regulator@7 {
> > + regulator-always-on;
> > + };
> > +
> > + vdac_reg: regulator@8 {
> > + regulator-always-on;
> > + };
> > +
> > + vaux1_reg: regulator@9 {
> > + regulator-always-on;
> > + };
> > +
> > + vaux2_reg: regulator@10 {
> > + regulator-always-on;
> > + };
> > +
> > + vaux33_reg: regulator@11 {
> > + regulator-always-on;
> > + };
> > +
> > + vmmc_reg: regulator@12 {
> > + compatible = "regulator-fixed";
> > + regulator-name = "vmmc_reg";
> > + regulator-min-microvolt = <330>;
> > + regulator-max-microvolt = <330>;
> > + regulator-always-on;
> > + };
> > + };
> > +};
> > +
> > + {
> > + pinctrl-names = "default";
> > + pinctrl-0 = <_default>;
> > + dual_emac = <1>;
> > + status = "okay";
> > +};
> > +
> > +_emac0 {
> > + status = "okay";
> > + phy_id = <_mdio>, <0x4>;
> > + phy-mode = "rmii";
> > + dual_emac_res_vlan = <1>;
> > +};
> > +
> > +_emac1 {
> > + status = "okay";
> > + phy_id = <_mdio>, <0x5>;
> > + phy-mode = "rmii";
> > + dual_emac_res_vlan = <2>;
> > +};
> > +
> > + {
> > + pinctrl-names = "default";
> > + vmmc-supply = <_fixed>;
> > + bus-width = <4>;
> > + pinctrl-0 = <_pins_default>;
> > + cd-gpios = < 14 GPIO_ACTIVE_HIGH>;
> > + wp-gpios = < 18 GPIO_ACTIVE_HIGH>;
> > + status = "okay";
> > +};
> > --
> > 2.19.0.rc1
> >
